1
0
mirror of https://github.com/golang/go synced 2024-11-18 02:34:46 -07:00

[dev.link] ensure package path is set when TEXT symbols are created

We're reworking pclntab generation in the linker, and with that we're
moving FuncID generation in to the compiler. Determining the FuncID is
done by a lookup on the package.function name; therefore, we need the
package whenever we make the TEXT symbols.

Change-Id: I805445ffbf2f895f06ce3a91fb09126d012bf86e
Reviewed-on: https://go-review.googlesource.com/c/go/+/245318
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Jeremy Faller 2020-07-28 13:49:13 -04:00
parent 6ac9914383
commit 128f4e51f2
2 changed files with 3 additions and 1 deletions

View File

@ -285,6 +285,8 @@ func Main(archInit func(*Arch)) {
objabi.Flagparse(usage)
Ctxt.Pkgpath = myimportpath
for _, f := range strings.Split(spectre, ",") {
f = strings.TrimSpace(f)
switch f {
@ -789,7 +791,6 @@ func Main(archInit func(*Arch)) {
// Write object data to disk.
timings.Start("be", "dumpobj")
dumpdata()
Ctxt.Pkgpath = myimportpath
Ctxt.NumberSyms()
dumpobj()
if asmhdr != "" {

View File

@ -824,6 +824,7 @@ func runInstall(pkg string, ch chan struct{}) {
"-D", "GOOS_" + goos,
"-D", "GOARCH_" + goarch,
"-D", "GOOS_GOARCH_" + goos + "_" + goarch,
"-p", pkg,
}
if goarch == "mips" || goarch == "mipsle" {
// Define GOMIPS_value from gomips.