qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 13:47:57 -07:00
Code Releases Activity

goinstall: check for error from exec.*Cmd.Wait() before using its result

Browse Source 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/1923043
This commit is contained in:
Alex Brainman 2010-08-04 17:18:57 -07:00 committed by Russ Cox
parent 6b8ec5c572
commit 12576f9e70
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/goinstall/main.go
View File

@ -207,6 +207,9 @@ func genRun(dir string, stdin []byte, cmd []string, quiet bool) os.Error {
io.Copy(&buf, p.Stdout) io.Copy(&buf, p.Stdout)
w, err := p.Wait(0) w, err := p.Wait(0)
p.Close() p.Close()
if err != nil {
return err
}
if !w.Exited() || w.ExitStatus() != 0 { if !w.Exited() || w.ExitStatus() != 0 {
if !quiet || *verbose { if !quiet || *verbose {
if dir != "" { if dir != "" {