1
0
mirror of https://github.com/golang/go synced 2024-11-26 15:56:57 -07:00

[dev.typeparams] cmd/compile: explain why expandInline needed

Change-Id: Ica9817675b4eb929a000640f9ae873b75fc5a2e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/330290
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Cuong Manh Le 2021-06-23 14:39:44 +07:00
parent 99732b9070
commit 107b1fce64

View File

@ -1956,8 +1956,9 @@ func (r *reader) inlReturn(ret *ir.ReturnStmt) *ir.BlockStmt {
// expandInline reads in an extra copy of IR to populate // expandInline reads in an extra copy of IR to populate
// fn.Inl.{Dcl,Body}. // fn.Inl.{Dcl,Body}.
func expandInline(fn *ir.Func, pri pkgReaderIndex) { func expandInline(fn *ir.Func, pri pkgReaderIndex) {
// TODO(mdempsky): Remove this function. It's currently needed for // TODO(mdempsky): Remove this function. It's currently needed by
// dwarfgen for some reason, but we should be able to provide it // dwarfgen/dwarf.go:preInliningDcls, which requires fn.Inl.Dcl to
// create abstract function DIEs. But we should be able to provide it
// with the same information some other way. // with the same information some other way.
fndcls := len(fn.Dcl) fndcls := len(fn.Dcl)