qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 04:24:36 -06:00
Code Releases Activity

os: fix handling of ErrShortWrite in (*File).Write

Browse Source 
Restore the handling of io.ErrShortWrite in (*File).Write:
if we write less than the requested amount, and there is no error from
the syscall, then return io.ErrShortWrite.

I can't figure out how to write a test for this. It would require a
non-pollable file (not a pipe) on a device that is almost but not
quite entirely full. The original code (https://golang.org/cl/36800043,
committed as part of https://golang.org/cl/36930044) does not have a test.

Fixes #20386.

Change-Id: Ied7b411e621e1eaf49f864f8db90069f276256f5
Reviewed-on: https://go-review.googlesource.com/43558
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Ian Lance Taylor 2017-05-16 17:41:42 -07:00
parent 13cdd814ea
commit 0fd7de4971
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/os/file.go
View File

@ -147,7 +147,11 @@ func (f *File) Write(b []byte) (n int, err error) {
epipecheck(f, e)
return n, f.wrapErr("write", e)
if e != nil {
err = f.wrapErr("write", e)
}
return n, err
}
// WriteAt writes len(b) bytes to the File starting at byte offset off.