From 0f4bb9627ebc27d4e669e41d7f58396e063abb70 Mon Sep 17 00:00:00 2001 From: Ethan Hur Date: Sun, 14 Mar 2021 13:43:26 +0000 Subject: [PATCH] cmd/compile: fix outdated comment variable xtop has removed and refactored after go 1.16, but there are comments referring xtop. It may mislead new contributors to be confused. Change-Id: Id79c747d8daef14049b29e70a4ecd34054a28a5e GitHub-Last-Rev: 94b55208862fdc9fa0de39aacf2c9ef9987cef56 GitHub-Pull-Request: golang/go#44995 Reviewed-on: https://go-review.googlesource.com/c/go/+/301629 Reviewed-by: Matthew Dempsky Trust: Keith Randall --- src/cmd/compile/internal/typecheck/func.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/typecheck/func.go b/src/cmd/compile/internal/typecheck/func.go index 367df8e9f40..86058a0c730 100644 --- a/src/cmd/compile/internal/typecheck/func.go +++ b/src/cmd/compile/internal/typecheck/func.go @@ -308,7 +308,7 @@ func tcClosure(clo *ir.ClosureExpr, top int) { return } - // Don't give a name and add to xtop if we are typechecking an inlined + // Don't give a name and add to Target.Decls if we are typechecking an inlined // body in ImportedBody(), since we only want to create the named function // when the closure is actually inlined (and then we force a typecheck // explicitly in (*inlsubst).node()). @@ -354,7 +354,7 @@ func tcClosure(clo *ir.ClosureExpr, top int) { ir.Dump(s, fn) } if !inTypeCheckInl { - // Add function to xtop once only when we give it a name + // Add function to Target.Decls once only when we give it a name Target.Decls = append(Target.Decls, fn) } }