1
0
mirror of https://github.com/golang/go synced 2024-11-24 23:57:57 -07:00

codereview: fix 'hg sync' and 'hg download' in Python 2.7

Fixes #1218.

R=rsc
CC=golang-dev
https://golang.org/cl/2664041
This commit is contained in:
Fazlul Shahriar 2010-11-01 16:37:17 -04:00 committed by Russ Cox
parent 270bad3939
commit 0e816f5972

View File

@ -1508,7 +1508,7 @@ def IsRietveldSubmitted(ui, clname, hex):
if feed is None: if feed is None:
return False return False
for sum in feed.findall("{http://www.w3.org/2005/Atom}entry/{http://www.w3.org/2005/Atom}summary"): for sum in feed.findall("{http://www.w3.org/2005/Atom}entry/{http://www.w3.org/2005/Atom}summary"):
text = sum.findtext("", None).strip() text = sum.text.strip()
m = re.match('\*\*\* Submitted as [^*]*?([0-9a-f]+) \*\*\*', text) m = re.match('\*\*\* Submitted as [^*]*?([0-9a-f]+) \*\*\*', text)
if m is not None and len(m.group(1)) >= 8 and hex.startswith(m.group(1)): if m is not None and len(m.group(1)) >= 8 and hex.startswith(m.group(1)):
return True return True
@ -1542,7 +1542,7 @@ def DownloadCL(ui, repo, clname):
# Find author - first entry will be author who created CL. # Find author - first entry will be author who created CL.
nick = None nick = None
for author in feed.findall("{http://www.w3.org/2005/Atom}entry/{http://www.w3.org/2005/Atom}author/{http://www.w3.org/2005/Atom}name"): for author in feed.findall("{http://www.w3.org/2005/Atom}entry/{http://www.w3.org/2005/Atom}author/{http://www.w3.org/2005/Atom}name"):
nick = author.findtext("", None).strip() nick = author.text.strip()
break break
if not nick: if not nick:
return None, None, "CL has no author" return None, None, "CL has no author"