qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 14:14:29 -06:00
Code Releases Activity

net/netip: skip some TestAddrStringAllocs tests on noopt builders

Browse Source 
CL 403914 introduced TestAddrStringAllocs which checks that there is
only 1 alloc in Addr.String for v4-in-v6 addresses. This requires
optimizations to be enabled, otherwise there are 2 allocs. Skip the
ipv4-in-ipv6 sub-tests on noopt builders to fix failing
TestAddrStringAllocs on the noopt builders.

Change-Id: I0285264260b264b53cf822dc7cec4829e9854531
Reviewed-on: https://go-review.googlesource.com/c/go/+/405834
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
This commit is contained in:
Tobias Klauser 2022-05-12 09:30:54 +02:00 committed by Gopher Robot
parent 2bea43b0e7
commit 0d8345df66
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/net/netip/netip_test.go
View File

@ -10,6 +10,7 @@ import (
"flag"
"fmt"
"internal/intern"
"internal/testenv"
"net"
. "net/netip"
"reflect"
@ -1907,8 +1908,13 @@ func TestAddrStringAllocs(t *testing.T) {
{"ipv4-in-ipv6", MustParseAddr("::ffff:192.168.1.1"), 1},
{"ipv4-in-ipv6+zone", MustParseAddr("::ffff:192.168.1.1%eth0"), 1},
}
isNooptBuilder := strings.HasSuffix(testenv.Builder(), "-noopt")
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
if isNooptBuilder && strings.HasPrefix(tc.name, "ipv4-in-ipv6") {
// Optimizations are required to remove some allocs.
t.Skipf("skipping on %v", testenv.Builder())
}
allocs := int(testing.AllocsPerRun(1000, func() {
sinkString = tc.ip.String()
}))