qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 22:47:58 -07:00
Code Releases Activity

http/cgi: correctly set request Content-Type

Browse Source 
R=bradfitz
CC=golang-dev
https://golang.org/cl/4433087
This commit is contained in:
Evan Shaw 2011-04-29 07:04:28 -07:00 committed by Brad Fitzpatrick
parent da9b8b8352
commit 0add1c3ed8
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkg/http/cgi/child.go
View File

@ -84,6 +84,10 @@ func RequestFromMap(params map[string]string) (*http.Request, os.Error) {
r.ContentLength = clen r.ContentLength = clen
} }
if ct := params["CONTENT_TYPE"]; ct != "" {
r.Header.Set("Content-Type", ct)
}
// Copy "HTTP_FOO_BAR" variables to "Foo-Bar" Headers // Copy "HTTP_FOO_BAR" variables to "Foo-Bar" Headers
for k, v := range params { for k, v := range params {
if !strings.HasPrefix(k, "HTTP_") || skipHeader[k] { if !strings.HasPrefix(k, "HTTP_") || skipHeader[k] {

4
src/pkg/http/cgi/child_test.go
View File

@ -20,6 +20,7 @@ func TestRequest(t *testing.T) {
"HTTP_FOO_BAR": "baz", "HTTP_FOO_BAR": "baz",
"REQUEST_URI": "/path?a=b", "REQUEST_URI": "/path?a=b",
"CONTENT_LENGTH": "123", "CONTENT_LENGTH": "123",
"CONTENT_TYPE": "text/xml",
"HTTPS": "1", "HTTPS": "1",
"REMOTE_ADDR": "5.6.7.8", "REMOTE_ADDR": "5.6.7.8",
} }
@ -37,6 +38,9 @@ func TestRequest(t *testing.T) {
// Tests that we don't put recognized headers in the map // Tests that we don't put recognized headers in the map
t.Errorf("expected User-Agent %q; got %q", e, g) t.Errorf("expected User-Agent %q; got %q", e, g)
} }
if g, e := req.Header.Get("Content-Type"), "text/xml"; e != g {
t.Errorf("expected Content-Type %q; got %q", e, g)
}
if g, e := req.ContentLength, int64(123); e != g { if g, e := req.ContentLength, int64(123); e != g {
t.Errorf("expected ContentLength %d; got %d", e, g) t.Errorf("expected ContentLength %d; got %d", e, g)
} }