From 0aa9f2fd802dde3c409bdebe577e7acc61bba962 Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Fri, 15 May 2020 15:02:58 -0400 Subject: [PATCH] internal/lsp/cmd: clean up remote flag descriptions The format of descriptions for the `-remote.*` flags were inconsistent. Clean them up. Also remove a TODO in lsprpc.go about adding a test for telemetry. That is enough of a separate concern (and one that is rapidly changing) that I no longer think this TODO makes sense. Change-Id: Id14796000634ae4be4b480d0386b1da9069737c4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/234113 Run-TryBot: Robert Findley TryBot-Result: Gobot Gobot Reviewed-by: Rebecca Stambler --- internal/lsp/cmd/serve.go | 6 +++--- internal/lsp/lsprpc/lsprpc_test.go | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/internal/lsp/cmd/serve.go b/internal/lsp/cmd/serve.go index 86cac2cfa3..6474a60c84 100644 --- a/internal/lsp/cmd/serve.go +++ b/internal/lsp/cmd/serve.go @@ -31,9 +31,9 @@ type Serve struct { Trace bool `flag:"rpc.trace" help:"print the full rpc trace in lsp inspector format"` Debug string `flag:"debug" help:"serve debug information on the supplied address"` - RemoteListenTimeout time.Duration `flag:"remote.listen.timeout" help:"when used with -remote=auto, the listen.timeout used when auto-starting the remote"` - RemoteDebug string `flag:"remote.debug" help:"when used with -remote=auto, the debug address used when auto-starting the remote"` - RemoteLogfile string `flag:"remote.logfile" help:"when used with -remote=auto, the filename for the remote daemon to log to"` + RemoteListenTimeout time.Duration `flag:"remote.listen.timeout" help:"when used with -remote=auto, the -listen.timeout value used to start the daemon"` + RemoteDebug string `flag:"remote.debug" help:"when used with -remote=auto, the -debug value used to start the daemon"` + RemoteLogfile string `flag:"remote.logfile" help:"when used with -remote=auto, the -logfile value used to start the daemon"` app *Application } diff --git a/internal/lsp/lsprpc/lsprpc_test.go b/internal/lsp/lsprpc/lsprpc_test.go index c89e54cb02..231e6befe6 100644 --- a/internal/lsp/lsprpc/lsprpc_test.go +++ b/internal/lsp/lsprpc/lsprpc_test.go @@ -252,5 +252,3 @@ func TestDebugInfoLifecycle(t *testing.T) { // TODO(rfindley): once disconnection works, assert that len(Clients) == 1 // (as of writing, it is still 2) } - -// TODO: add a test for telemetry.