qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 04:04:46 -07:00
Code Releases Activity

Revert "cmd/cgo: use --no-gc-sections if available"

Browse Source 
This reverts CL 405414.

Reason for revert: Breaks on AIX and iOS.

Change-Id: I4681c6f2fd69616691660916ebf0853e3a6a67ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/407634
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Ian Lance Taylor 2022-05-20 22:50:17 +00:00 committed by Gopher Robot
parent c3470ca83c
commit 0a1a092c4b
1 changed files with 7 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/cmd/go/internal/work/exec.go
View File

@ -2528,13 +2528,6 @@ func (b *Builder) compilerCmd(compiler []string, incdir, workdir string) []strin
a = append(a, "-Qunused-arguments") a = append(a, "-Qunused-arguments")
} }
// zig cc passes --gc-sections to the underlying linker, which then causes
// undefined symbol errors when compiling with cgo but without C code.
// https://github.com/golang/go/issues/52690
if b.gccSupportsFlag(compiler, "-Wl,--no-gc-sections") {
a = append(a, "-Wl,--no-gc-sections")
}
// disable word wrapping in error messages // disable word wrapping in error messages
a = append(a, "-fmessage-length=0") a = append(a, "-fmessage-length=0")
@ -2601,21 +2594,13 @@ func (b *Builder) gccSupportsFlag(compiler []string, flag string) bool {
defer os.Remove(tmp) defer os.Remove(tmp)
} }
// We used to write an empty C file, but that gets complicated with go // We used to write an empty C file, but that gets complicated with
// build -n. We tried using a file that does not exist, but that fails on // go build -n. We tried using a file that does not exist, but that
// systems with GCC version 4.2.1; that is the last GPLv2 version of GCC, // fails on systems with GCC version 4.2.1; that is the last GPLv2
// so some systems have frozen on it. Now we pass an empty file on stdin, // version of GCC, so some systems have frozen on it.
// which should work at least for GCC and clang. // Now we pass an empty file on stdin, which should work at least for
// // GCC and clang.
// If the argument is "-Wl,", then it's testing the linker. In that case, cmdArgs := str.StringList(compiler, flag, "-c", "-x", "c", "-", "-o", tmp)
// skip "-c". If it's not "-Wl,", then we are testing the compiler and
// can emit the linking step with "-c".
cmdArgs := str.StringList(compiler, flag)
if !strings.HasPrefix(flag, "-Wl,") /* linker flag */ {
cmdArgs = append(cmdArgs, "-c")
}
cmdArgs = append(cmdArgs, "-x", "c", "-", "-o", tmp)
if cfg.BuildN || cfg.BuildX { if cfg.BuildN || cfg.BuildX {
b.Showcmd(b.WorkDir, "%s || true", joinUnambiguously(cmdArgs)) b.Showcmd(b.WorkDir, "%s || true", joinUnambiguously(cmdArgs))
if cfg.BuildN { if cfg.BuildN {