qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 06:40:05 -07:00
Code Releases Activity

cmd/api: make api/next/* entries required, not optional

Browse Source 
We want the API check to catch if some API present in api/next/*
files is no longer implemented in the tree, and report it in the
same CL that is making the change (by failing loudly). Arguably
this should've been the case since CL 315350, but I didn't notice
it at the time. Do it now.

For #43956.

Change-Id: I73330dd5fd3f5706a1fdf13b2bf8e0f24c6b48e5
Reviewed-on: https://go-review.googlesource.com/c/go/+/488135
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Dmitri Shuralyov 2023-04-24 11:26:23 -04:00 committed by Gopher Robot
parent b4eed1c341
commit 0972096c5c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmd/api/api.go
View File

@ -193,13 +193,12 @@ func Check(t *testing.T) {
bw := bufio.NewWriter(os.Stdout) bw := bufio.NewWriter(os.Stdout)
defer bw.Flush() defer bw.Flush()
var required []string var required, optional []string
for _, file := range checkFiles { for _, file := range checkFiles {
required = append(required, fileFeatures(file, needApproval(file))...) required = append(required, fileFeatures(file, needApproval(file))...)
} }
var optional []string
for _, file := range nextFiles { for _, file := range nextFiles {
optional = append(optional, fileFeatures(file, true)...) required = append(required, fileFeatures(file, true)...)
} }
exception := fileFeatures(filepath.Join(testenv.GOROOT(t), "api/except.txt"), false) exception := fileFeatures(filepath.Join(testenv.GOROOT(t), "api/except.txt"), false)