qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 14:24:45 -07:00
Code Releases Activity

hash/crc32: fix code generator to use the Go standard

Browse Source 
Apply the Go standard for code generation (https://go.dev/s/generatedcode)
to generated crc32_table_ppc64le.s despites this is not
generated Go but Assembly.  This is to help prevent changes like CL 478976
that changed the generated output without fixing the generator.

Add gen.go to allow to launch code generation with "go generate".

Change-Id: I8671284265425826c8620dbec055519b992fa04e
Reviewed-on: https://go-review.googlesource.com/c/go/+/556335
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Olivier Mengué 2024-01-16 23:30:12 +01:00 committed by Gopher Robot
parent 7ecef2e344
commit 0882ca7a73
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/hash/crc32/crc32_table_ppc64le.s
View File

@ -1,5 +1,4 @@
// autogenerated: do not edit!
// generated from crc32/gen_const_ppc64le.go
// Code generated by "go run gen_const_ppc64le.go"; DO NOT EDIT.
#include "textflag.h"

7
src/hash/crc32/gen.go Normal file
View File

@ -0,0 +1,7 @@
// Copyright 2023 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:generate go run gen_const_ppc64le.go
package crc32

8
src/hash/crc32/gen_const_ppc64le.go
View File

@ -89,10 +89,10 @@ func xnmodp(n uint, poly uint64, deg uint) (uint64, uint64) {
func main() {
w := new(bytes.Buffer)
fmt.Fprintf(w, "// autogenerated: do not edit!\n")
fmt.Fprintf(w, "// generated from crc32/gen_const_ppc64le.go\n")
// Standard: https://go.dev/s/generatedcode
fmt.Fprintln(w, `// Code generated by "go run gen_const_ppc64le.go"; DO NOT EDIT.`)
fmt.Fprintln(w)
fmt.Fprintf(w, "#include \"textflag.h\"\n")
fmt.Fprintln(w, `#include "textflag.h"`)
// These are the polynomials supported in vector now.
// If adding others, include the polynomial and a name
@ -105,7 +105,7 @@ func main() {
err := os.WriteFile("crc32_table_ppc64le.s", b, 0666)
if err != nil {
fmt.Printf("can't write output: %s\n", err)
fmt.Fprintf(os.Stderr, "can't write output: %s\n", err)
}
}