qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 17:30:02 -07:00
Code Releases Activity

cmd/go/internal/modfetch/codehost: don't try to execute a nonexistent fetch function

Browse Source 
This fixes a panic observed in
https://build.golang.org/log/1242a032cac29fd3dffb24055fdeff0202b546be.

Change-Id: I029b9d69cabb87091734bd33d7fd39d30b12f9c5
Reviewed-on: https://go-review.googlesource.com/c/go/+/183917
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Bryan C. Mills 2019-06-26 09:22:08 -04:00
parent 4047f01d31
commit 070e2dda02
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/cmd/go/internal/modfetch/codehost/vcs.go
View File

@ -341,7 +341,9 @@ func (r *vcsRepo) Stat(rev string) (*RevInfo, error) {
} }
func (r *vcsRepo) fetch() { func (r *vcsRepo) fetch() {
_, r.fetchErr = Run(r.dir, r.cmd.fetch) if len(r.cmd.fetch) > 0 {
_, r.fetchErr = Run(r.dir, r.cmd.fetch)
}
} }
func (r *vcsRepo) statLocal(rev string) (*RevInfo, error) { func (r *vcsRepo) statLocal(rev string) (*RevInfo, error) {

6
src/cmd/go/testdata/script/mod_get_svn.txt vendored
View File

@ -13,6 +13,12 @@ stderr 'ReadZip not implemented for svn'
! go install . ! go install .
stderr 'ReadZip not implemented for svn' stderr 'ReadZip not implemented for svn'
# Attempting to get a nonexistent module using svn should fail with a
# reasonable message instead of a panic.
! go get -d vcs-test.golang.org/svn/nonexistent.svn
! stderr panic
stderr 'go get vcs-test.golang.org/svn/nonexistent.svn: no matching versions for query "latest"'
-- go.mod -- -- go.mod --
module golang/go/issues/28943/main module golang/go/issues/28943/main
-- main.go -- -- main.go --