qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
Code Releases Activity

go.tools/playground/socket: log connections and code snippet run requests

Browse Source 
This logs all successful handshakes and all requests to run code snippets;
it is not immediately obvious how to limit this to non-localhost hosts, or
to instances where publicly available playgrounds are allowed without resorting
to addition of a new global. The level of noise on the log should not be too
great.

LGTM=adg
R=adg
CC=golang-codereviews
https://golang.org/cl/112850043
This commit is contained in:
Robert Daniel Kortschak 2014-07-09 12:14:27 +10:00 committed by Andrew Gerrand
parent 32c9809768
commit 063db5971c
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playground/socket/socket.go
View File

@ -95,6 +95,7 @@ func handshake(c *websocket.Config, req *http.Request) error {
log.Println("bad websocket origin:", o) log.Println("bad websocket origin:", o)
return websocket.ErrBadWebSocketOrigin return websocket.ErrBadWebSocketOrigin
} }
log.Println("accepting connection from:", req.RemoteAddr)
return nil return nil
} }
@ -136,6 +137,7 @@ func socketHandler(c *websocket.Conn) {
case m := <-in: case m := <-in:
switch m.Kind { switch m.Kind {
case "run": case "run":
log.Println("running snippet from:", c.Request().RemoteAddr)
proc[m.Id].Kill() proc[m.Id].Kill()
lOut := limiter(in, out) lOut := limiter(in, out)
proc[m.Id] = startProcess(m.Id, m.Body, lOut, m.Options) proc[m.Id] = startProcess(m.Id, m.Body, lOut, m.Options)