diff --git a/src/runtime/mgcmark.go b/src/runtime/mgcmark.go index 00787ade04..cfd24e06fb 100644 --- a/src/runtime/mgcmark.go +++ b/src/runtime/mgcmark.go @@ -126,26 +126,32 @@ func gcMarkRootCheck() { lock(&allglock) // Check that stacks have been scanned. + var gp *g if gcphase == _GCmarktermination && debug.gcrescanstacks > 0 { for i := 0; i < len(allgs); i++ { - gp := allgs[i] + gp = allgs[i] if !(gp.gcscandone && gp.gcscanvalid) && readgstatus(gp) != _Gdead { - println("gp", gp, "goid", gp.goid, - "status", readgstatus(gp), - "gcscandone", gp.gcscandone, - "gcscanvalid", gp.gcscanvalid) - throw("scan missed a g") + goto fail } } } else { for i := 0; i < work.nStackRoots; i++ { - gp := allgs[i] + gp = allgs[i] if !gp.gcscandone { - throw("scan missed a g") + goto fail } } } unlock(&allglock) + return + +fail: + println("gp", gp, "goid", gp.goid, + "status", readgstatus(gp), + "gcscandone", gp.gcscandone, + "gcscanvalid", gp.gcscanvalid) + unlock(&allglock) // Avoid self-deadlock with traceback. + throw("scan missed a g") } // ptrmask for an allocation containing a single pointer.