qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 15:24:28 -06:00
Code Releases Activity

cmd/link: suppress -bind_at_load deprecation warning for ld-prime

Browse Source 
ld-prime emits a deprecation warning for -bind_at_load. The flag
is needed for plugins to not deadlock (#38824) when linking with
older darwin linker. It is supposedly not needed with newer linker
when chained fixups are used. For now, we always pass it, and
suppress the warning.

For #61229.

Change-Id: I4b8a6f864a460c40dc38adbb533f664f7fd5343c
Reviewed-on: https://go-review.googlesource.com/c/go/+/508696
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
This commit is contained in:
Cherry Mui 2023-07-10 18:50:06 -04:00
parent 91bea5a21d
commit 040dbf9c18
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cmd/link/internal/ld/lib.go
View File

@ -1903,6 +1903,16 @@ func (ctxt *Link) hostlink() {
out = append(out[:i], out[i+len(noPieWarning):]...)
}
}
if ctxt.IsDarwin() {
const bindAtLoadWarning = "ld: warning: -bind_at_load is deprecated on macOS\n"
if i := bytes.Index(out, []byte(bindAtLoadWarning)); i >= 0 {
// -bind_at_load is deprecated with ld-prime, but needed for
// correctness with older versions of ld64. Swallow the warning.
// TODO: maybe pass -bind_at_load conditionally based on C
// linker version.
out = append(out[:i], out[i+len(bindAtLoadWarning):]...)
}
}
ctxt.Logf("%s", out)
}