qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 20:04:47 -07:00
Code Releases Activity

[dev.typeparams] cmd/compile: allow nil Syms in Sym.Less

Browse Source 
Allows sorting interfaces that contain embedded anonymous types.

Fixes #46556.

Change-Id: If19afa1d62432323b2e98957087867afbf3f9097
Reviewed-on: https://go-review.googlesource.com/c/go/+/324812
Trust: Matthew Dempsky <mdempsky@google.com>
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
This commit is contained in:
Matthew Dempsky 2021-06-03 13:05:22 -07:00
parent a2d6a2caeb
commit 026480d06b
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cmd/compile/internal/types/sym.go
View File

@ -110,6 +110,14 @@ func (a *Sym) Less(b *Sym) bool {
return false
}
// Nil before non-nil.
if a == nil {
return true
}
if b == nil {
return false
}
// Exported symbols before non-exported.
ea := IsExported(a.Name)
eb := IsExported(b.Name)

16
test/fixedbugs/issue46556.go Normal file
View File

@ -0,0 +1,16 @@
// compile
// Copyright 2021 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package p
type A = interface{}
type B interface{}
// Test that embedding both anonymous and defined types is supported.
type C interface {
A
B
}