2019-05-10 14:35:43 -06:00
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2019-04-22 14:04:44 -06:00
|
|
|
package cache
|
|
|
|
|
|
|
|
import (
|
2019-07-09 15:52:23 -06:00
|
|
|
"bytes"
|
2019-04-22 14:04:44 -06:00
|
|
|
"context"
|
|
|
|
"go/ast"
|
|
|
|
"go/parser"
|
|
|
|
"go/scanner"
|
|
|
|
"go/token"
|
2019-09-06 15:22:54 -06:00
|
|
|
"reflect"
|
2019-04-22 14:04:44 -06:00
|
|
|
|
2020-04-17 07:32:56 -06:00
|
|
|
"golang.org/x/tools/internal/event"
|
2020-03-10 21:09:39 -06:00
|
|
|
"golang.org/x/tools/internal/lsp/debug/tag"
|
2019-09-09 22:36:39 -06:00
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
2019-06-04 20:14:37 -06:00
|
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
|
|
"golang.org/x/tools/internal/memoize"
|
2019-09-09 22:36:39 -06:00
|
|
|
"golang.org/x/tools/internal/span"
|
2019-08-06 13:13:11 -06:00
|
|
|
errors "golang.org/x/xerrors"
|
2019-04-22 14:04:44 -06:00
|
|
|
)
|
|
|
|
|
2019-06-13 13:55:53 -06:00
|
|
|
// parseKey uniquely identifies a parsed Go file.
|
2019-06-04 20:14:37 -06:00
|
|
|
type parseKey struct {
|
|
|
|
file source.FileIdentity
|
|
|
|
mode source.ParseMode
|
|
|
|
}
|
|
|
|
|
|
|
|
type parseGoHandle struct {
|
|
|
|
handle *memoize.Handle
|
|
|
|
file source.FileHandle
|
|
|
|
mode source.ParseMode
|
|
|
|
}
|
|
|
|
|
|
|
|
type parseGoData struct {
|
|
|
|
memoize.NoCopy
|
2019-06-13 13:55:53 -06:00
|
|
|
|
2020-04-07 20:54:42 -06:00
|
|
|
ast *ast.File
|
|
|
|
mapper *protocol.ColumnMapper
|
|
|
|
|
|
|
|
// Source code used to build the AST. It may be different from the
|
|
|
|
// actual content of the file if we have fixed the AST, in which case,
|
|
|
|
// fixed will be true.
|
|
|
|
src []byte
|
|
|
|
fixed bool
|
|
|
|
|
2019-09-17 09:19:11 -06:00
|
|
|
parseError error // errors associated with parsing the file
|
2020-04-07 20:54:42 -06:00
|
|
|
err error // any other errors
|
2019-05-17 08:51:19 -06:00
|
|
|
}
|
|
|
|
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
func (c *Cache) ParseGoHandle(ctx context.Context, fh source.FileHandle, mode source.ParseMode) source.ParseGoHandle {
|
|
|
|
return c.parseGoHandle(ctx, fh, mode)
|
2020-04-07 20:54:42 -06:00
|
|
|
}
|
|
|
|
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
func (c *Cache) parseGoHandle(ctx context.Context, fh source.FileHandle, mode source.ParseMode) *parseGoHandle {
|
2019-06-04 20:14:37 -06:00
|
|
|
key := parseKey{
|
|
|
|
file: fh.Identity(),
|
|
|
|
mode: mode,
|
|
|
|
}
|
2019-11-19 14:59:25 -07:00
|
|
|
fset := c.fset
|
2019-06-04 20:14:37 -06:00
|
|
|
h := c.store.Bind(key, func(ctx context.Context) interface{} {
|
2020-02-10 21:10:59 -07:00
|
|
|
return parseGo(ctx, fset, fh, mode)
|
2019-06-04 20:14:37 -06:00
|
|
|
})
|
|
|
|
return &parseGoHandle{
|
|
|
|
handle: h,
|
2019-06-21 15:00:02 -06:00
|
|
|
file: fh,
|
|
|
|
mode: mode,
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-12-11 11:44:39 -07:00
|
|
|
func (pgh *parseGoHandle) String() string {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
return pgh.File().URI().Filename()
|
2019-12-11 11:44:39 -07:00
|
|
|
}
|
|
|
|
|
2019-11-30 00:01:00 -07:00
|
|
|
func (pgh *parseGoHandle) File() source.FileHandle {
|
|
|
|
return pgh.file
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
|
|
|
|
2019-11-30 00:01:00 -07:00
|
|
|
func (pgh *parseGoHandle) Mode() source.ParseMode {
|
|
|
|
return pgh.mode
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
|
|
|
|
2020-02-10 21:10:59 -07:00
|
|
|
func (pgh *parseGoHandle) Parse(ctx context.Context) (*ast.File, []byte, *protocol.ColumnMapper, error, error) {
|
2020-04-07 20:54:42 -06:00
|
|
|
data, err := pgh.parse(ctx)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, nil, nil, err
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
2020-02-10 21:10:59 -07:00
|
|
|
return data.ast, data.src, data.mapper, data.parseError, data.err
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
|
|
|
|
2020-04-07 20:54:42 -06:00
|
|
|
func (pgh *parseGoHandle) parse(ctx context.Context) (*parseGoData, error) {
|
|
|
|
v := pgh.handle.Get(ctx)
|
|
|
|
data, ok := v.(*parseGoData)
|
|
|
|
if !ok {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
return nil, errors.Errorf("no parsed file for %s", pgh.File().URI())
|
2020-04-07 20:54:42 -06:00
|
|
|
}
|
|
|
|
return data, nil
|
|
|
|
}
|
|
|
|
|
2020-02-10 21:10:59 -07:00
|
|
|
func (pgh *parseGoHandle) Cached() (*ast.File, []byte, *protocol.ColumnMapper, error, error) {
|
2019-11-30 00:01:00 -07:00
|
|
|
v := pgh.handle.Cached()
|
2019-08-06 16:51:17 -06:00
|
|
|
if v == nil {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
return nil, nil, nil, nil, errors.Errorf("no cached AST for %s", pgh.file.URI())
|
2019-08-06 16:51:17 -06:00
|
|
|
}
|
|
|
|
data := v.(*parseGoData)
|
2020-02-10 21:10:59 -07:00
|
|
|
return data.ast, data.src, data.mapper, data.parseError, data.err
|
2019-08-06 16:51:17 -06:00
|
|
|
}
|
|
|
|
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
func hashParseKeys(pghs []*parseGoHandle) string {
|
2019-07-09 15:52:23 -06:00
|
|
|
b := bytes.NewBuffer(nil)
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
for _, pgh := range pghs {
|
|
|
|
b.WriteString(pgh.file.Identity().String())
|
|
|
|
b.WriteByte(byte(pgh.Mode()))
|
2019-07-09 15:52:23 -06:00
|
|
|
}
|
|
|
|
return hashContents(b.Bytes())
|
|
|
|
}
|
|
|
|
|
2020-02-10 21:10:59 -07:00
|
|
|
func parseGo(ctx context.Context, fset *token.FileSet, fh source.FileHandle, mode source.ParseMode) *parseGoData {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
ctx, done := event.Start(ctx, "cache.parseGo", tag.File.Of(fh.URI().Filename()))
|
2019-06-26 20:46:12 -06:00
|
|
|
defer done()
|
2019-08-08 10:18:43 -06:00
|
|
|
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
if fh.Kind() != source.Go {
|
|
|
|
return &parseGoData{err: errors.Errorf("cannot parse non-Go file %s", fh.URI())}
|
2020-01-09 17:22:08 -07:00
|
|
|
}
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
buf, err := fh.Read()
|
2019-06-04 20:14:37 -06:00
|
|
|
if err != nil {
|
2020-02-10 21:10:59 -07:00
|
|
|
return &parseGoData{err: err}
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
2020-03-11 20:22:13 -06:00
|
|
|
|
2019-06-04 20:14:37 -06:00
|
|
|
parserMode := parser.AllErrors | parser.ParseComments
|
|
|
|
if mode == source.ParseHeader {
|
2019-08-02 17:45:56 -06:00
|
|
|
parserMode = parser.ImportsOnly | parser.ParseComments
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
file, parseError := parser.ParseFile(fset, fh.URI().Filename(), buf, parserMode)
|
2019-11-19 14:59:25 -07:00
|
|
|
var tok *token.File
|
2020-04-07 20:54:42 -06:00
|
|
|
var fixed bool
|
2019-09-17 09:19:11 -06:00
|
|
|
if file != nil {
|
2019-11-19 14:59:25 -07:00
|
|
|
tok = fset.File(file.Pos())
|
|
|
|
if tok == nil {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
return &parseGoData{err: errors.Errorf("successfully parsed but no token.File for %s (%v)", fh.URI(), parseError)}
|
2019-11-19 14:59:25 -07:00
|
|
|
}
|
2020-01-26 15:55:07 -07:00
|
|
|
|
2020-01-26 20:00:02 -07:00
|
|
|
// Fix any badly parsed parts of the AST.
|
2020-04-07 20:54:42 -06:00
|
|
|
fixed = fixAST(ctx, file, tok, buf)
|
2020-01-26 20:00:02 -07:00
|
|
|
|
2020-01-26 15:55:07 -07:00
|
|
|
// Fix certain syntax errors that render the file unparseable.
|
|
|
|
newSrc := fixSrc(file, tok, buf)
|
|
|
|
if newSrc != nil {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
newFile, _ := parser.ParseFile(fset, fh.URI().Filename(), newSrc, parserMode)
|
2020-01-26 15:55:07 -07:00
|
|
|
if newFile != nil {
|
|
|
|
// Maintain the original parseError so we don't try formatting the doctored file.
|
|
|
|
file = newFile
|
|
|
|
buf = newSrc
|
|
|
|
tok = fset.File(file.Pos())
|
2020-01-26 20:00:02 -07:00
|
|
|
|
2020-04-07 20:54:42 -06:00
|
|
|
fixed = fixAST(ctx, file, tok, buf)
|
2020-01-26 15:55:07 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-06-10 06:58:14 -06:00
|
|
|
if mode == source.ParseExported {
|
2019-09-17 09:19:11 -06:00
|
|
|
trimAST(file)
|
2019-06-10 06:58:14 -06:00
|
|
|
}
|
2019-06-04 20:14:37 -06:00
|
|
|
}
|
2019-09-17 09:19:11 -06:00
|
|
|
if file == nil {
|
2019-09-18 10:48:40 -06:00
|
|
|
// If the file is nil only due to parse errors,
|
|
|
|
// the parse errors are the actual errors.
|
|
|
|
err := parseError
|
|
|
|
if err == nil {
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
err = errors.Errorf("no AST for %s", fh.URI())
|
2019-09-18 10:48:40 -06:00
|
|
|
}
|
2020-02-10 21:10:59 -07:00
|
|
|
return &parseGoData{parseError: parseError, err: err}
|
2019-09-17 09:19:11 -06:00
|
|
|
}
|
|
|
|
m := &protocol.ColumnMapper{
|
internal/lsp: read files eagerly
We use file identities pervasively throughout gopls. Prior to this
change, the identity is the modification date of an unopened file, or
the hash of an opened file. That means that opening a file changes its
identity, which causes unnecessary churn in the cache.
Unfortunately, there isn't an easy way to fix this. Changing the
cache key to something else, such as the modification time, means that
we won't unify cache entries if a change is made and then undone. The
approach here is to read files eagerly in GetFile, so that we know their
hashes immediately. That resolves the churn, but means that we do a ton
of file IO at startup.
Incidental changes:
Remove the FileSystem interface; there was only one implementation and
it added a fair amount of cruft. We have many other places that assume
os.Stat and such work.
Add direct accessors to FileHandle for URI, Kind, and Version. Most uses
of (FileHandle).Identity were for stuff that we derive solely from the
URI, and this helped me disentangle them. It is a *ton* of churn,
though. I can revert it if you want.
Change-Id: Ia2133bc527f71daf81c9d674951726a232ca5bc9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/237037
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-08 13:21:24 -06:00
|
|
|
URI: fh.URI(),
|
2019-11-19 14:59:25 -07:00
|
|
|
Converter: span.NewTokenConverter(fset, tok),
|
2020-01-26 14:49:43 -07:00
|
|
|
Content: buf,
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
2020-02-10 21:10:59 -07:00
|
|
|
return &parseGoData{
|
|
|
|
src: buf,
|
|
|
|
ast: file,
|
|
|
|
mapper: m,
|
|
|
|
parseError: parseError,
|
2020-04-07 20:54:42 -06:00
|
|
|
fixed: fixed,
|
2020-02-10 21:10:59 -07:00
|
|
|
}
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
|
2019-05-23 11:51:56 -06:00
|
|
|
// trimAST clears any part of the AST not relevant to type checking
|
|
|
|
// expressions at pos.
|
|
|
|
func trimAST(file *ast.File) {
|
|
|
|
ast.Inspect(file, func(n ast.Node) bool {
|
|
|
|
if n == nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
switch n := n.(type) {
|
|
|
|
case *ast.FuncDecl:
|
|
|
|
n.Body = nil
|
|
|
|
case *ast.BlockStmt:
|
|
|
|
n.List = nil
|
|
|
|
case *ast.CaseClause:
|
|
|
|
n.Body = nil
|
|
|
|
case *ast.CommClause:
|
|
|
|
n.Body = nil
|
|
|
|
case *ast.CompositeLit:
|
|
|
|
// Leave elts in place for [...]T
|
|
|
|
// array literals, because they can
|
|
|
|
// affect the expression's type.
|
|
|
|
if !isEllipsisArray(n.Type) {
|
|
|
|
n.Elts = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true
|
|
|
|
})
|
|
|
|
}
|
2019-04-22 14:04:44 -06:00
|
|
|
|
2019-05-23 11:51:56 -06:00
|
|
|
func isEllipsisArray(n ast.Expr) bool {
|
|
|
|
at, ok := n.(*ast.ArrayType)
|
|
|
|
if !ok {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
_, ok = at.Len.(*ast.Ellipsis)
|
|
|
|
return ok
|
|
|
|
}
|
|
|
|
|
2020-01-26 14:49:43 -07:00
|
|
|
// fixAST inspects the AST and potentially modifies any *ast.BadStmts so that it can be
|
2019-07-27 18:52:02 -06:00
|
|
|
// type-checked more effectively.
|
2020-04-07 20:54:42 -06:00
|
|
|
func fixAST(ctx context.Context, n ast.Node, tok *token.File, src []byte) (fixed bool) {
|
2020-01-26 14:49:43 -07:00
|
|
|
var err error
|
|
|
|
walkASTWithParent(n, func(n, parent ast.Node) bool {
|
2019-04-22 14:04:44 -06:00
|
|
|
switch n := n.(type) {
|
|
|
|
case *ast.BadStmt:
|
2020-04-07 20:54:42 -06:00
|
|
|
if fixed = fixDeferOrGoStmt(n, parent, tok, src); fixed {
|
2019-09-13 11:31:28 -06:00
|
|
|
// Recursively fix in our fixed node.
|
2020-04-07 20:54:42 -06:00
|
|
|
_ = fixAST(ctx, parent, tok, src)
|
2019-09-09 10:25:22 -06:00
|
|
|
} else {
|
2019-08-06 13:13:11 -06:00
|
|
|
err = errors.Errorf("unable to parse defer or go from *ast.BadStmt: %v", err)
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
case *ast.BadExpr:
|
2020-04-07 20:54:42 -06:00
|
|
|
if fixed = fixArrayType(n, parent, tok, src); fixed {
|
2019-09-13 11:31:28 -06:00
|
|
|
// Recursively fix in our fixed node.
|
2020-04-07 20:54:42 -06:00
|
|
|
_ = fixAST(ctx, parent, tok, src)
|
2019-11-20 12:15:53 -07:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
2020-01-26 17:34:04 -07:00
|
|
|
|
|
|
|
// Fix cases where parser interprets if/for/switch "init"
|
|
|
|
// statement as "cond" expression, e.g.:
|
|
|
|
//
|
|
|
|
// // "i := foo" is init statement, not condition.
|
|
|
|
// for i := foo
|
|
|
|
//
|
|
|
|
fixInitStmt(n, parent, tok, src)
|
|
|
|
|
2019-09-13 11:31:28 -06:00
|
|
|
return false
|
2019-11-20 12:15:53 -07:00
|
|
|
case *ast.SelectorExpr:
|
|
|
|
// Fix cases where a keyword prefix results in a phantom "_" selector, e.g.:
|
|
|
|
//
|
|
|
|
// foo.var<> // want to complete to "foo.variance"
|
|
|
|
//
|
|
|
|
fixPhantomSelector(n, tok, src)
|
|
|
|
return true
|
2020-02-22 19:56:15 -07:00
|
|
|
|
|
|
|
case *ast.BlockStmt:
|
|
|
|
switch parent.(type) {
|
|
|
|
case *ast.SwitchStmt, *ast.TypeSwitchStmt, *ast.SelectStmt:
|
|
|
|
// Adjust closing curly brace of empty switch/select
|
|
|
|
// statements so we can complete inside them.
|
|
|
|
fixEmptySwitch(n, tok, src)
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
2019-04-22 14:04:44 -06:00
|
|
|
default:
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
})
|
2020-04-07 20:54:42 -06:00
|
|
|
return fixed
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
|
2020-01-26 14:49:43 -07:00
|
|
|
// walkASTWithParent walks the AST rooted at n. The semantics are
|
|
|
|
// similar to ast.Inspect except it does not call f(nil).
|
|
|
|
func walkASTWithParent(n ast.Node, f func(n ast.Node, parent ast.Node) bool) {
|
|
|
|
var ancestors []ast.Node
|
|
|
|
ast.Inspect(n, func(n ast.Node) (recurse bool) {
|
|
|
|
defer func() {
|
|
|
|
if recurse {
|
|
|
|
ancestors = append(ancestors, n)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
if n == nil {
|
|
|
|
ancestors = ancestors[:len(ancestors)-1]
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
var parent ast.Node
|
|
|
|
if len(ancestors) > 0 {
|
|
|
|
parent = ancestors[len(ancestors)-1]
|
|
|
|
}
|
|
|
|
|
|
|
|
return f(n, parent)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2020-01-26 15:55:07 -07:00
|
|
|
// fixSrc attempts to modify the file's source code to fix certain
|
|
|
|
// syntax errors that leave the rest of the file unparsed.
|
|
|
|
func fixSrc(f *ast.File, tok *token.File, src []byte) (newSrc []byte) {
|
|
|
|
walkASTWithParent(f, func(n, parent ast.Node) bool {
|
|
|
|
if newSrc != nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
switch n := n.(type) {
|
|
|
|
case *ast.BlockStmt:
|
|
|
|
newSrc = fixMissingCurlies(f, n, parent, tok, src)
|
2020-01-26 20:00:02 -07:00
|
|
|
case *ast.SelectorExpr:
|
2020-03-27 10:52:40 -06:00
|
|
|
newSrc = fixDanglingSelector(n, tok, src)
|
2020-01-26 15:55:07 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
return newSrc == nil
|
|
|
|
})
|
|
|
|
|
|
|
|
return newSrc
|
|
|
|
}
|
|
|
|
|
|
|
|
// fixMissingCurlies adds in curly braces for block statements that
|
|
|
|
// are missing curly braces. For example:
|
|
|
|
//
|
|
|
|
// if foo
|
|
|
|
//
|
|
|
|
// becomes
|
|
|
|
//
|
|
|
|
// if foo {}
|
|
|
|
func fixMissingCurlies(f *ast.File, b *ast.BlockStmt, parent ast.Node, tok *token.File, src []byte) []byte {
|
|
|
|
// If the "{" is already in the source code, there isn't anything to
|
2020-03-15 12:45:57 -06:00
|
|
|
// fix since we aren't missing curlies.
|
2020-01-26 15:55:07 -07:00
|
|
|
if b.Lbrace.IsValid() {
|
|
|
|
braceOffset := tok.Offset(b.Lbrace)
|
|
|
|
if braceOffset < len(src) && src[braceOffset] == '{' {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-02-14 10:02:32 -07:00
|
|
|
parentLine := tok.Line(parent.Pos())
|
|
|
|
|
|
|
|
if parentLine >= tok.LineCount() {
|
|
|
|
// If we are the last line in the file, no need to fix anything.
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2020-01-26 15:55:07 -07:00
|
|
|
// Insert curlies at the end of parent's starting line. The parent
|
|
|
|
// is the statement that contains the block, e.g. *ast.IfStmt. The
|
|
|
|
// block's Pos()/End() can't be relied upon because they are based
|
|
|
|
// on the (missing) curly braces. We assume the statement is a
|
|
|
|
// single line for now and try sticking the curly braces at the end.
|
2020-02-14 10:02:32 -07:00
|
|
|
insertPos := tok.LineStart(parentLine+1) - 1
|
2020-01-26 15:55:07 -07:00
|
|
|
|
|
|
|
// Scootch position backwards until it's not in a comment. For example:
|
|
|
|
//
|
|
|
|
// if foo<> // some amazing comment |
|
|
|
|
// someOtherCode()
|
|
|
|
//
|
|
|
|
// insertPos will be located at "|", so we back it out of the comment.
|
|
|
|
didSomething := true
|
|
|
|
for didSomething {
|
|
|
|
didSomething = false
|
|
|
|
for _, c := range f.Comments {
|
|
|
|
if c.Pos() < insertPos && insertPos <= c.End() {
|
|
|
|
insertPos = c.Pos()
|
|
|
|
didSomething = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Bail out if line doesn't end in an ident or ".". This is to avoid
|
|
|
|
// cases like below where we end up making things worse by adding
|
|
|
|
// curlies:
|
|
|
|
//
|
|
|
|
// if foo &&
|
|
|
|
// bar<>
|
|
|
|
switch precedingToken(insertPos, tok, src) {
|
|
|
|
case token.IDENT, token.PERIOD:
|
|
|
|
// ok
|
|
|
|
default:
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var buf bytes.Buffer
|
2020-01-26 17:34:04 -07:00
|
|
|
buf.Grow(len(src) + 3)
|
2020-01-26 15:55:07 -07:00
|
|
|
buf.Write(src[:tok.Offset(insertPos)])
|
2020-01-26 17:34:04 -07:00
|
|
|
|
|
|
|
// Detect if we need to insert a semicolon to fix "for" loop situations like:
|
|
|
|
//
|
|
|
|
// for i := foo(); foo<>
|
|
|
|
//
|
|
|
|
// Just adding curlies is not sufficient to make things parse well.
|
|
|
|
if fs, ok := parent.(*ast.ForStmt); ok {
|
|
|
|
if _, ok := fs.Cond.(*ast.BadExpr); !ok {
|
|
|
|
if xs, ok := fs.Post.(*ast.ExprStmt); ok {
|
|
|
|
if _, ok := xs.X.(*ast.BadExpr); ok {
|
|
|
|
buf.WriteByte(';')
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Insert "{}" at insertPos.
|
2020-01-26 15:55:07 -07:00
|
|
|
buf.WriteByte('{')
|
|
|
|
buf.WriteByte('}')
|
|
|
|
buf.Write(src[tok.Offset(insertPos):])
|
|
|
|
return buf.Bytes()
|
|
|
|
}
|
|
|
|
|
2020-02-22 19:56:15 -07:00
|
|
|
// fixEmptySwitch moves empty switch/select statements' closing curly
|
|
|
|
// brace down one line. This allows us to properly detect incomplete
|
|
|
|
// "case" and "default" keywords as inside the switch statement. For
|
|
|
|
// example:
|
|
|
|
//
|
|
|
|
// switch {
|
|
|
|
// def<>
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// gets parsed like:
|
|
|
|
//
|
|
|
|
// switch {
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// Later we manually pull out the "def" token, but we need to detect
|
|
|
|
// that our "<>" position is inside the switch block. To do that we
|
|
|
|
// move the curly brace so it looks like:
|
|
|
|
//
|
|
|
|
// switch {
|
|
|
|
//
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
func fixEmptySwitch(body *ast.BlockStmt, tok *token.File, src []byte) {
|
|
|
|
// We only care about empty switch statements.
|
|
|
|
if len(body.List) > 0 || !body.Rbrace.IsValid() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the right brace is actually in the source code at the
|
|
|
|
// specified position, don't mess with it.
|
|
|
|
braceOffset := tok.Offset(body.Rbrace)
|
|
|
|
if braceOffset < len(src) && src[braceOffset] == '}' {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
braceLine := tok.Line(body.Rbrace)
|
|
|
|
if braceLine >= tok.LineCount() {
|
|
|
|
// If we are the last line in the file, no need to fix anything.
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Move the right brace down one line.
|
|
|
|
body.Rbrace = tok.LineStart(braceLine + 1)
|
|
|
|
}
|
|
|
|
|
2020-01-26 20:00:02 -07:00
|
|
|
// fixDanglingSelector inserts real "_" selector expressions in place
|
|
|
|
// of phantom "_" selectors. For example:
|
|
|
|
//
|
|
|
|
// func _() {
|
|
|
|
// x.<>
|
|
|
|
// }
|
|
|
|
// var x struct { i int }
|
|
|
|
//
|
|
|
|
// To fix completion at "<>", we insert a real "_" after the "." so the
|
|
|
|
// following declaration of "x" can be parsed and type checked
|
|
|
|
// normally.
|
2020-03-27 10:52:40 -06:00
|
|
|
func fixDanglingSelector(s *ast.SelectorExpr, tok *token.File, src []byte) []byte {
|
2020-01-26 20:00:02 -07:00
|
|
|
if !isPhantomUnderscore(s.Sel, tok, src) {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if !s.X.End().IsValid() {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Insert directly after the selector's ".".
|
|
|
|
insertOffset := tok.Offset(s.X.End()) + 1
|
|
|
|
if src[insertOffset-1] != '.' {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var buf bytes.Buffer
|
|
|
|
buf.Grow(len(src) + 1)
|
|
|
|
buf.Write(src[:insertOffset])
|
|
|
|
buf.WriteByte('_')
|
|
|
|
buf.Write(src[insertOffset:])
|
|
|
|
return buf.Bytes()
|
|
|
|
}
|
|
|
|
|
2019-11-20 12:15:53 -07:00
|
|
|
// fixPhantomSelector tries to fix selector expressions with phantom
|
|
|
|
// "_" selectors. In particular, we check if the selector is a
|
|
|
|
// keyword, and if so we swap in an *ast.Ident with the keyword text. For example:
|
|
|
|
//
|
|
|
|
// foo.var
|
|
|
|
//
|
|
|
|
// yields a "_" selector instead of "var" since "var" is a keyword.
|
|
|
|
func fixPhantomSelector(sel *ast.SelectorExpr, tok *token.File, src []byte) {
|
|
|
|
if !isPhantomUnderscore(sel.Sel, tok, src) {
|
|
|
|
return
|
|
|
|
}
|
2020-01-26 20:00:02 -07:00
|
|
|
|
|
|
|
// Only consider selectors directly abutting the selector ".". This
|
|
|
|
// avoids false positives in cases like:
|
|
|
|
//
|
|
|
|
// foo. // don't think "var" is our selector
|
|
|
|
// var bar = 123
|
|
|
|
//
|
|
|
|
if sel.Sel.Pos() != sel.X.End()+1 {
|
|
|
|
return
|
|
|
|
}
|
2019-11-20 12:15:53 -07:00
|
|
|
|
|
|
|
maybeKeyword := readKeyword(sel.Sel.Pos(), tok, src)
|
|
|
|
if maybeKeyword == "" {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
replaceNode(sel, sel.Sel, &ast.Ident{
|
|
|
|
Name: maybeKeyword,
|
|
|
|
NamePos: sel.Sel.Pos(),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// isPhantomUnderscore reports whether the given ident is a phantom
|
|
|
|
// underscore. The parser sometimes inserts phantom underscores when
|
|
|
|
// it encounters otherwise unparseable situations.
|
|
|
|
func isPhantomUnderscore(id *ast.Ident, tok *token.File, src []byte) bool {
|
|
|
|
if id == nil || id.Name != "_" {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// Phantom underscore means the underscore is not actually in the
|
|
|
|
// program text.
|
|
|
|
offset := tok.Offset(id.Pos())
|
|
|
|
return len(src) <= offset || src[offset] != '_'
|
|
|
|
}
|
|
|
|
|
2020-01-26 17:34:04 -07:00
|
|
|
// fixInitStmt fixes cases where the parser misinterprets an
|
|
|
|
// if/for/switch "init" statement as the "cond" conditional. In cases
|
|
|
|
// like "if i := 0" the user hasn't typed the semicolon yet so the
|
|
|
|
// parser is looking for the conditional expression. However, "i := 0"
|
|
|
|
// are not valid expressions, so we get a BadExpr.
|
|
|
|
func fixInitStmt(bad *ast.BadExpr, parent ast.Node, tok *token.File, src []byte) {
|
|
|
|
if !bad.Pos().IsValid() || !bad.End().IsValid() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Try to extract a statement from the BadExpr.
|
|
|
|
stmtBytes := src[tok.Offset(bad.Pos()) : tok.Offset(bad.End()-1)+1]
|
|
|
|
stmt, err := parseStmt(bad.Pos(), stmtBytes)
|
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the parent statement doesn't already have an "init" statement,
|
|
|
|
// move the extracted statement into the "init" field and insert a
|
|
|
|
// dummy expression into the required "cond" field.
|
|
|
|
switch p := parent.(type) {
|
|
|
|
case *ast.IfStmt:
|
|
|
|
if p.Init != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
p.Init = stmt
|
2020-04-07 20:54:42 -06:00
|
|
|
p.Cond = &ast.Ident{
|
|
|
|
Name: "_",
|
|
|
|
NamePos: stmt.End(),
|
|
|
|
}
|
2020-01-26 17:34:04 -07:00
|
|
|
case *ast.ForStmt:
|
|
|
|
if p.Init != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
p.Init = stmt
|
2020-04-07 20:54:42 -06:00
|
|
|
p.Cond = &ast.Ident{
|
|
|
|
Name: "_",
|
|
|
|
NamePos: stmt.End(),
|
|
|
|
}
|
2020-01-26 17:34:04 -07:00
|
|
|
case *ast.SwitchStmt:
|
|
|
|
if p.Init != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
p.Init = stmt
|
|
|
|
p.Tag = nil
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-11-20 12:15:53 -07:00
|
|
|
// readKeyword reads the keyword starting at pos, if any.
|
|
|
|
func readKeyword(pos token.Pos, tok *token.File, src []byte) string {
|
|
|
|
var kwBytes []byte
|
|
|
|
for i := tok.Offset(pos); i < len(src); i++ {
|
|
|
|
// Use a simplified identifier check since keywords are always lowercase ASCII.
|
|
|
|
if src[i] < 'a' || src[i] > 'z' {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
kwBytes = append(kwBytes, src[i])
|
|
|
|
|
|
|
|
// Stop search at arbitrarily chosen too-long-for-a-keyword length.
|
|
|
|
if len(kwBytes) > 15 {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if kw := string(kwBytes); token.Lookup(kw).IsKeyword() {
|
|
|
|
return kw
|
|
|
|
}
|
|
|
|
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
2019-09-13 11:31:28 -06:00
|
|
|
// fixArrayType tries to parse an *ast.BadExpr into an *ast.ArrayType.
|
|
|
|
// go/parser often turns lone array types like "[]int" into BadExprs
|
|
|
|
// if it isn't expecting a type.
|
2020-04-07 20:54:42 -06:00
|
|
|
func fixArrayType(bad *ast.BadExpr, parent ast.Node, tok *token.File, src []byte) bool {
|
2019-09-13 11:31:28 -06:00
|
|
|
// Our expected input is a bad expression that looks like "[]someExpr".
|
|
|
|
|
|
|
|
from := bad.Pos()
|
|
|
|
to := bad.End()
|
|
|
|
|
|
|
|
if !from.IsValid() || !to.IsValid() {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
2019-09-13 13:15:53 -06:00
|
|
|
exprBytes := make([]byte, 0, int(to-from)+3)
|
2019-09-13 11:31:28 -06:00
|
|
|
// Avoid doing tok.Offset(to) since that panics if badExpr ends at EOF.
|
|
|
|
exprBytes = append(exprBytes, src[tok.Offset(from):tok.Offset(to-1)+1]...)
|
2019-09-13 13:15:53 -06:00
|
|
|
exprBytes = bytes.TrimSpace(exprBytes)
|
|
|
|
|
|
|
|
// If our expression ends in "]" (e.g. "[]"), add a phantom selector
|
|
|
|
// so we can complete directly after the "[]".
|
|
|
|
if len(exprBytes) > 0 && exprBytes[len(exprBytes)-1] == ']' {
|
|
|
|
exprBytes = append(exprBytes, '_')
|
|
|
|
}
|
2019-09-13 11:31:28 -06:00
|
|
|
|
|
|
|
// Add "{}" to turn our ArrayType into a CompositeLit. This is to
|
|
|
|
// handle the case of "[...]int" where we must make it a composite
|
|
|
|
// literal to be parseable.
|
|
|
|
exprBytes = append(exprBytes, '{', '}')
|
|
|
|
|
|
|
|
expr, err := parseExpr(from, exprBytes)
|
|
|
|
if err != nil {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
cl, _ := expr.(*ast.CompositeLit)
|
|
|
|
if cl == nil {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
at, _ := cl.Type.(*ast.ArrayType)
|
|
|
|
if at == nil {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
2020-04-07 20:54:42 -06:00
|
|
|
return replaceNode(parent, bad, at)
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
2020-01-26 15:55:07 -07:00
|
|
|
// precedingToken scans src to find the token preceding pos.
|
|
|
|
func precedingToken(pos token.Pos, tok *token.File, src []byte) token.Token {
|
|
|
|
s := &scanner.Scanner{}
|
|
|
|
s.Init(tok, src, nil, 0)
|
|
|
|
|
|
|
|
var lastTok token.Token
|
|
|
|
for {
|
|
|
|
p, t, _ := s.Scan()
|
|
|
|
if t == token.EOF || p >= pos {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
|
|
|
|
lastTok = t
|
|
|
|
}
|
|
|
|
return lastTok
|
|
|
|
}
|
|
|
|
|
2019-09-13 11:31:28 -06:00
|
|
|
// fixDeferOrGoStmt tries to parse an *ast.BadStmt into a defer or a go statement.
|
2019-04-22 14:04:44 -06:00
|
|
|
//
|
|
|
|
// go/parser packages a statement of the form "defer x." as an *ast.BadStmt because
|
|
|
|
// it does not include a call expression. This means that go/types skips type-checking
|
|
|
|
// this statement entirely, and we can't use the type information when completing.
|
|
|
|
// Here, we try to generate a fake *ast.DeferStmt or *ast.GoStmt to put into the AST,
|
|
|
|
// instead of the *ast.BadStmt.
|
2020-04-07 20:54:42 -06:00
|
|
|
func fixDeferOrGoStmt(bad *ast.BadStmt, parent ast.Node, tok *token.File, src []byte) bool {
|
2019-04-22 14:04:44 -06:00
|
|
|
// Check if we have a bad statement containing either a "go" or "defer".
|
|
|
|
s := &scanner.Scanner{}
|
|
|
|
s.Init(tok, src, nil, 0)
|
|
|
|
|
2019-09-06 15:22:54 -06:00
|
|
|
var (
|
|
|
|
pos token.Pos
|
|
|
|
tkn token.Token
|
|
|
|
)
|
2019-04-22 14:04:44 -06:00
|
|
|
for {
|
|
|
|
if tkn == token.EOF {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
if pos >= bad.From {
|
|
|
|
break
|
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
pos, tkn, _ = s.Scan()
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
|
2019-04-22 14:04:44 -06:00
|
|
|
var stmt ast.Stmt
|
2019-09-06 15:22:54 -06:00
|
|
|
switch tkn {
|
|
|
|
case token.DEFER:
|
2019-04-22 14:04:44 -06:00
|
|
|
stmt = &ast.DeferStmt{
|
|
|
|
Defer: pos,
|
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
case token.GO:
|
2019-04-22 14:04:44 -06:00
|
|
|
stmt = &ast.GoStmt{
|
|
|
|
Go: pos,
|
|
|
|
}
|
|
|
|
default:
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
|
2019-09-06 15:22:54 -06:00
|
|
|
var (
|
|
|
|
from, to, last token.Pos
|
|
|
|
lastToken token.Token
|
|
|
|
braceDepth int
|
|
|
|
phantomSelectors []token.Pos
|
|
|
|
)
|
2019-04-22 14:04:44 -06:00
|
|
|
FindTo:
|
|
|
|
for {
|
2019-09-06 15:22:54 -06:00
|
|
|
to, tkn, _ = s.Scan()
|
|
|
|
|
|
|
|
if from == token.NoPos {
|
|
|
|
from = to
|
|
|
|
}
|
|
|
|
|
|
|
|
switch tkn {
|
|
|
|
case token.EOF:
|
|
|
|
break FindTo
|
|
|
|
case token.SEMICOLON:
|
|
|
|
// If we aren't in nested braces, end of statement means
|
|
|
|
// end of expression.
|
|
|
|
if braceDepth == 0 {
|
|
|
|
break FindTo
|
|
|
|
}
|
|
|
|
case token.LBRACE:
|
|
|
|
braceDepth++
|
|
|
|
}
|
|
|
|
|
|
|
|
// This handles the common dangling selector case. For example in
|
2019-04-22 14:04:44 -06:00
|
|
|
//
|
2019-09-06 15:22:54 -06:00
|
|
|
// defer fmt.
|
|
|
|
// y := 1
|
2019-04-22 14:04:44 -06:00
|
|
|
//
|
2019-09-06 15:22:54 -06:00
|
|
|
// we notice the dangling period and end our expression.
|
|
|
|
//
|
|
|
|
// If the previous token was a "." and we are looking at a "}",
|
|
|
|
// the period is likely a dangling selector and needs a phantom
|
2019-09-11 00:14:36 -06:00
|
|
|
// "_". Likewise if the current token is on a different line than
|
2019-09-06 15:22:54 -06:00
|
|
|
// the period, the period is likely a dangling selector.
|
|
|
|
if lastToken == token.PERIOD && (tkn == token.RBRACE || tok.Line(to) > tok.Line(last)) {
|
|
|
|
// Insert phantom "_" selector after the dangling ".".
|
|
|
|
phantomSelectors = append(phantomSelectors, last+1)
|
|
|
|
// If we aren't in a block then end the expression after the ".".
|
|
|
|
if braceDepth == 0 {
|
|
|
|
to = last + 1
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
lastToken = tkn
|
|
|
|
last = to
|
|
|
|
|
2019-04-22 14:04:44 -06:00
|
|
|
switch tkn {
|
2019-09-06 15:22:54 -06:00
|
|
|
case token.RBRACE:
|
|
|
|
braceDepth--
|
|
|
|
if braceDepth <= 0 {
|
|
|
|
if braceDepth == 0 {
|
|
|
|
// +1 to include the "}" itself.
|
|
|
|
to += 1
|
|
|
|
}
|
|
|
|
break FindTo
|
|
|
|
}
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
|
2019-04-22 14:04:44 -06:00
|
|
|
if !from.IsValid() || tok.Offset(from) >= len(src) {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
|
|
|
|
if !to.IsValid() || tok.Offset(to) >= len(src) {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
|
|
|
|
// Insert any phantom selectors needed to prevent dangling "." from messing
|
|
|
|
// up the AST.
|
|
|
|
exprBytes := make([]byte, 0, int(to-from)+len(phantomSelectors))
|
|
|
|
for i, b := range src[tok.Offset(from):tok.Offset(to)] {
|
|
|
|
if len(phantomSelectors) > 0 && from+token.Pos(i) == phantomSelectors[0] {
|
|
|
|
exprBytes = append(exprBytes, '_')
|
|
|
|
phantomSelectors = phantomSelectors[1:]
|
|
|
|
}
|
|
|
|
exprBytes = append(exprBytes, b)
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(phantomSelectors) > 0 {
|
|
|
|
exprBytes = append(exprBytes, '_')
|
|
|
|
}
|
|
|
|
|
2019-09-13 11:31:28 -06:00
|
|
|
expr, err := parseExpr(from, exprBytes)
|
|
|
|
if err != nil {
|
2020-04-07 20:54:42 -06:00
|
|
|
return false
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// Package the expression into a fake *ast.CallExpr and re-insert
|
|
|
|
// into the function.
|
|
|
|
call := &ast.CallExpr{
|
|
|
|
Fun: expr,
|
|
|
|
Lparen: to,
|
|
|
|
Rparen: to,
|
|
|
|
}
|
|
|
|
|
|
|
|
switch stmt := stmt.(type) {
|
|
|
|
case *ast.DeferStmt:
|
|
|
|
stmt.Call = call
|
|
|
|
case *ast.GoStmt:
|
|
|
|
stmt.Call = call
|
|
|
|
}
|
|
|
|
|
2020-04-07 20:54:42 -06:00
|
|
|
return replaceNode(parent, bad, stmt)
|
2019-09-13 11:31:28 -06:00
|
|
|
}
|
|
|
|
|
2020-01-26 14:49:43 -07:00
|
|
|
// parseStmt parses the statement in src and updates its position to
|
2019-09-13 11:31:28 -06:00
|
|
|
// start at pos.
|
2020-01-26 14:49:43 -07:00
|
|
|
func parseStmt(pos token.Pos, src []byte) (ast.Stmt, error) {
|
2019-09-09 10:25:22 -06:00
|
|
|
// Wrap our expression to make it a valid Go file we can pass to ParseFile.
|
|
|
|
fileSrc := bytes.Join([][]byte{
|
|
|
|
[]byte("package fake;func _(){"),
|
2019-09-13 11:31:28 -06:00
|
|
|
src,
|
2019-09-09 10:25:22 -06:00
|
|
|
[]byte("}"),
|
|
|
|
}, nil)
|
|
|
|
|
|
|
|
// Use ParseFile instead of ParseExpr because ParseFile has
|
|
|
|
// best-effort behavior, whereas ParseExpr fails hard on any error.
|
|
|
|
fakeFile, err := parser.ParseFile(token.NewFileSet(), "", fileSrc, 0)
|
|
|
|
if fakeFile == nil {
|
2019-09-13 11:31:28 -06:00
|
|
|
return nil, errors.Errorf("error reading fake file source: %v", err)
|
2019-09-09 10:25:22 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// Extract our expression node from inside the fake file.
|
|
|
|
if len(fakeFile.Decls) == 0 {
|
2019-09-13 11:31:28 -06:00
|
|
|
return nil, errors.Errorf("error parsing fake file: %v", err)
|
2019-09-09 10:25:22 -06:00
|
|
|
}
|
2019-09-13 11:31:28 -06:00
|
|
|
|
2019-09-09 10:25:22 -06:00
|
|
|
fakeDecl, _ := fakeFile.Decls[0].(*ast.FuncDecl)
|
|
|
|
if fakeDecl == nil || len(fakeDecl.Body.List) == 0 {
|
2019-09-13 11:31:28 -06:00
|
|
|
return nil, errors.Errorf("no statement in %s: %v", src, err)
|
2019-09-09 10:25:22 -06:00
|
|
|
}
|
2019-09-13 11:31:28 -06:00
|
|
|
|
2020-01-26 14:49:43 -07:00
|
|
|
stmt := fakeDecl.Body.List[0]
|
|
|
|
|
|
|
|
// parser.ParseFile returns undefined positions.
|
|
|
|
// Adjust them for the current file.
|
|
|
|
offsetPositions(stmt, pos-1-(stmt.Pos()-1))
|
|
|
|
|
|
|
|
return stmt, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// parseExpr parses the expression in src and updates its position to
|
|
|
|
// start at pos.
|
|
|
|
func parseExpr(pos token.Pos, src []byte) (ast.Expr, error) {
|
|
|
|
stmt, err := parseStmt(pos, src)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
exprStmt, ok := stmt.(*ast.ExprStmt)
|
2019-09-09 10:25:22 -06:00
|
|
|
if !ok {
|
2019-09-13 11:31:28 -06:00
|
|
|
return nil, errors.Errorf("no expr in %s: %v", src, err)
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
2019-09-13 11:31:28 -06:00
|
|
|
|
2020-01-26 14:49:43 -07:00
|
|
|
return exprStmt.X, nil
|
2019-04-22 14:04:44 -06:00
|
|
|
}
|
|
|
|
|
2019-09-06 15:22:54 -06:00
|
|
|
var tokenPosType = reflect.TypeOf(token.NoPos)
|
|
|
|
|
2019-04-22 14:04:44 -06:00
|
|
|
// offsetPositions applies an offset to the positions in an ast.Node.
|
2020-01-26 14:49:43 -07:00
|
|
|
func offsetPositions(n ast.Node, offset token.Pos) {
|
|
|
|
ast.Inspect(n, func(n ast.Node) bool {
|
2019-09-06 15:22:54 -06:00
|
|
|
if n == nil {
|
2019-04-22 14:04:44 -06:00
|
|
|
return false
|
|
|
|
}
|
2019-09-06 15:22:54 -06:00
|
|
|
|
|
|
|
v := reflect.ValueOf(n).Elem()
|
|
|
|
|
|
|
|
switch v.Kind() {
|
|
|
|
case reflect.Struct:
|
|
|
|
for i := 0; i < v.NumField(); i++ {
|
|
|
|
f := v.Field(i)
|
|
|
|
if f.Type() != tokenPosType {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if !f.CanSet() {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2019-09-13 11:31:28 -06:00
|
|
|
f.SetInt(f.Int() + int64(offset))
|
2019-09-06 15:22:54 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true
|
2019-04-22 14:04:44 -06:00
|
|
|
})
|
|
|
|
}
|
2019-09-17 22:20:55 -06:00
|
|
|
|
|
|
|
// replaceNode updates parent's child oldChild to be newChild. It
|
2020-02-18 21:58:26 -07:00
|
|
|
// returns whether it replaced successfully.
|
2019-09-17 22:20:55 -06:00
|
|
|
func replaceNode(parent, oldChild, newChild ast.Node) bool {
|
|
|
|
if parent == nil || oldChild == nil || newChild == nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
parentVal := reflect.ValueOf(parent).Elem()
|
|
|
|
if parentVal.Kind() != reflect.Struct {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
newChildVal := reflect.ValueOf(newChild)
|
|
|
|
|
|
|
|
tryReplace := func(v reflect.Value) bool {
|
|
|
|
if !v.CanSet() || !v.CanInterface() {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the existing value is oldChild, we found our child. Make
|
|
|
|
// sure our newChild is assignable and then make the swap.
|
|
|
|
if v.Interface() == oldChild && newChildVal.Type().AssignableTo(v.Type()) {
|
|
|
|
v.Set(newChildVal)
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// Loop over parent's struct fields.
|
|
|
|
for i := 0; i < parentVal.NumField(); i++ {
|
|
|
|
f := parentVal.Field(i)
|
|
|
|
|
|
|
|
switch f.Kind() {
|
|
|
|
// Check interface and pointer fields.
|
|
|
|
case reflect.Interface, reflect.Ptr:
|
|
|
|
if tryReplace(f) {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
// Search through any slice fields.
|
|
|
|
case reflect.Slice:
|
|
|
|
for i := 0; i < f.Len(); i++ {
|
|
|
|
if tryReplace(f.Index(i)) {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false
|
|
|
|
}
|