1
0
mirror of https://github.com/golang/go synced 2024-11-06 01:56:12 -07:00
go/internal/telemetry/event/key.go

500 lines
14 KiB
Go
Raw Normal View History

// Copyright 2019 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package event
import (
"math"
)
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
var (
// Msg is a key used to add message strings to tag lists.
Msg = NewStringKey("message", "a readable message")
// Name is used for things like traces that have a name.
Name = NewStringKey("name", "an entity name")
// Err is a key used to add error values to tag lists.
Err = NewErrorKey("error", "an error that occurred")
)
// Key is the interface shared by all key implementations.
type Key interface {
// Name returns the key name.
Name() string
// Description returns a string that can be used to describe the value.
Description() string
}
// key is used as the identity of a Tag.
// Keys are intended to be compared by pointer only, the name should be unique
// for communicating with external systems, but it is not required or enforced.
type key struct {
name string
description string
}
// ValueKey represents a key for untyped values.
type ValueKey struct {
name string
description string
}
// NewKey creates a new Key for untyped values.
func NewKey(name, description string) *ValueKey {
return &ValueKey{name: name, description: description}
}
func (k *ValueKey) Name() string { return k.name }
func (k *ValueKey) Description() string { return k.description }
// Get can be used to get a tag for the key from a TagMap.
func (k *ValueKey) Get(tags TagMap) interface{} {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return nil
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *ValueKey) From(t Tag) interface{} { return t.untyped }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *ValueKey) Of(value interface{}) Tag { return Tag{Key: k, untyped: value} }
// IntKey represents a key
type IntKey struct {
name string
description string
}
// NewIntKey creates a new Key for int values.
func NewIntKey(name, description string) *IntKey {
return &IntKey{name: name, description: description}
}
func (k *IntKey) Name() string { return k.name }
func (k *IntKey) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *IntKey) Of(v int) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *IntKey) Get(tags TagMap) int {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *IntKey) From(t Tag) int { return int(t.packed) }
// Int8Key represents a key
type Int8Key struct {
name string
description string
}
// NewInt8Key creates a new Key for int8 values.
func NewInt8Key(name, description string) *Int8Key {
return &Int8Key{name: name, description: description}
}
func (k *Int8Key) Name() string { return k.name }
func (k *Int8Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int8Key) Of(v int8) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *Int8Key) Get(tags TagMap) int8 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int8Key) From(t Tag) int8 { return int8(t.packed) }
// Int16Key represents a key
type Int16Key struct {
name string
description string
}
// NewInt16Key creates a new Key for int16 values.
func NewInt16Key(name, description string) *Int16Key {
return &Int16Key{name: name, description: description}
}
func (k *Int16Key) Name() string { return k.name }
func (k *Int16Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int16Key) Of(v int16) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *Int16Key) Get(tags TagMap) int16 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int16Key) From(t Tag) int16 { return int16(t.packed) }
// Int32Key represents a key
type Int32Key struct {
name string
description string
}
// NewInt32Key creates a new Key for int32 values.
func NewInt32Key(name, description string) *Int32Key {
return &Int32Key{name: name, description: description}
}
func (k *Int32Key) Name() string { return k.name }
func (k *Int32Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int32Key) Of(v int32) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *Int32Key) Get(tags TagMap) int32 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int32Key) From(t Tag) int32 { return int32(t.packed) }
// Int64Key represents a key
type Int64Key struct {
name string
description string
}
// NewInt64Key creates a new Key for int64 values.
func NewInt64Key(name, description string) *Int64Key {
return &Int64Key{name: name, description: description}
}
func (k *Int64Key) Name() string { return k.name }
func (k *Int64Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int64Key) Of(v int64) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *Int64Key) Get(tags TagMap) int64 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Int64Key) From(t Tag) int64 { return int64(t.packed) }
// UIntKey represents a key
type UIntKey struct {
name string
description string
}
// NewUIntKey creates a new Key for uint values.
func NewUIntKey(name, description string) *UIntKey {
return &UIntKey{name: name, description: description}
}
func (k *UIntKey) Name() string { return k.name }
func (k *UIntKey) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UIntKey) Of(v uint) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *UIntKey) Get(tags TagMap) uint {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UIntKey) From(t Tag) uint { return uint(t.packed) }
// UInt8Key represents a key
type UInt8Key struct {
name string
description string
}
// NewUInt8Key creates a new Key for uint8 values.
func NewUInt8Key(name, description string) *UInt8Key {
return &UInt8Key{name: name, description: description}
}
func (k *UInt8Key) Name() string { return k.name }
func (k *UInt8Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt8Key) Of(v uint8) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *UInt8Key) Get(tags TagMap) uint8 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt8Key) From(t Tag) uint8 { return uint8(t.packed) }
// UInt16Key represents a key
type UInt16Key struct {
name string
description string
}
// NewUInt16Key creates a new Key for uint16 values.
func NewUInt16Key(name, description string) *UInt16Key {
return &UInt16Key{name: name, description: description}
}
func (k *UInt16Key) Name() string { return k.name }
func (k *UInt16Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt16Key) Of(v uint16) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *UInt16Key) Get(tags TagMap) uint16 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt16Key) From(t Tag) uint16 { return uint16(t.packed) }
// UInt32Key represents a key
type UInt32Key struct {
name string
description string
}
// NewUInt32Key creates a new Key for uint32 values.
func NewUInt32Key(name, description string) *UInt32Key {
return &UInt32Key{name: name, description: description}
}
func (k *UInt32Key) Name() string { return k.name }
func (k *UInt32Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt32Key) Of(v uint32) Tag { return Tag{Key: k, packed: uint64(v)} }
// Get can be used to get a tag for the key from a TagMap.
func (k *UInt32Key) Get(tags TagMap) uint32 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt32Key) From(t Tag) uint32 { return uint32(t.packed) }
// UInt64Key represents a key
type UInt64Key struct {
name string
description string
}
// NewUInt64Key creates a new Key for uint64 values.
func NewUInt64Key(name, description string) *UInt64Key {
return &UInt64Key{name: name, description: description}
}
func (k *UInt64Key) Name() string { return k.name }
func (k *UInt64Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt64Key) Of(v uint64) Tag { return Tag{Key: k, packed: v} }
// Get can be used to get a tag for the key from a TagMap.
func (k *UInt64Key) Get(tags TagMap) uint64 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *UInt64Key) From(t Tag) uint64 { return t.packed }
// Float32Key represents a key
type Float32Key struct {
name string
description string
}
// NewFloat32Key creates a new Key for float32 values.
func NewFloat32Key(name, description string) *Float32Key {
return &Float32Key{name: name, description: description}
}
func (k *Float32Key) Name() string { return k.name }
func (k *Float32Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Float32Key) Of(v float32) Tag {
return Tag{Key: k, packed: uint64(math.Float32bits(v))}
}
// Get can be used to get a tag for the key from a TagMap.
func (k *Float32Key) Get(tags TagMap) float32 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Float32Key) From(t Tag) float32 {
return math.Float32frombits(uint32(t.packed))
}
// Float64Key represents a key
type Float64Key struct {
name string
description string
}
// NewFloat64Key creates a new Key for int64 values.
func NewFloat64Key(name, description string) *Float64Key {
return &Float64Key{name: name, description: description}
}
func (k *Float64Key) Name() string { return k.name }
func (k *Float64Key) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Float64Key) Of(v float64) Tag {
return Tag{Key: k, packed: math.Float64bits(v)}
}
// Get can be used to get a tag for the key from a TagMap.
func (k *Float64Key) Get(tags TagMap) float64 {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return 0
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *Float64Key) From(t Tag) float64 {
return math.Float64frombits(t.packed)
}
// StringKey represents a key
type StringKey struct {
name string
description string
}
// NewStringKey creates a new Key for int64 values.
func NewStringKey(name, description string) *StringKey {
return &StringKey{name: name, description: description}
}
func (k *StringKey) Name() string { return k.name }
func (k *StringKey) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *StringKey) Of(v string) Tag { return Tag{Key: k, str: v} }
// Get can be used to get a tag for the key from a TagMap.
func (k *StringKey) Get(tags TagMap) string {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return ""
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *StringKey) From(t Tag) string { return t.str }
// BooleanKey represents a key
type BooleanKey struct {
name string
description string
}
// NewBooleanKey creates a new Key for bool values.
func NewBooleanKey(name, description string) *BooleanKey {
return &BooleanKey{name: name, description: description}
}
func (k *BooleanKey) Name() string { return k.name }
func (k *BooleanKey) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *BooleanKey) Of(v bool) Tag {
t := Tag{Key: k}
if v {
t.packed = 1
}
return t
}
// Get can be used to get a tag for the key from a TagMap.
func (k *BooleanKey) Get(tags TagMap) bool {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return false
}
// From can be used to get a value from a Tag.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *BooleanKey) From(t Tag) bool { return t.packed > 0 }
// ErrorKey represents a key
type ErrorKey struct {
name string
description string
}
// NewErrorKey creates a new Key for int64 values.
func NewErrorKey(name, description string) *ErrorKey {
return &ErrorKey{name: name, description: description}
}
func (k *ErrorKey) Name() string { return k.name }
func (k *ErrorKey) Description() string { return k.description }
// Of creates a new Tag with this key and the supplied value.
internal/telemetry: change tag to use type specific storage Because packing values into interface{} causes allocations this gives us a major improvement on allocation count, but tag is bigger so a significant loss on bytes allocated. It is a minor performance win overall, especially in the null exporter case when it really matters the most. name old time/op new time/op delta /Baseline-8 147ns ± 3% 146ns ± 3% ~ (p=0.349 n=5+5) /StdLog-8 6.83µs ± 1% 6.78µs ± 2% ~ (p=0.548 n=5+5) /LogNoExporter-8 1.15µs ± 1% 1.05µs ± 1% -8.63% (p=0.008 n=5+5) /TraceNoExporter-8 1.01µs ± 4% 0.99µs ± 1% ~ (p=0.087 n=5+5) /StatsNoExporter-8 1.89µs ± 0% 1.95µs ± 3% +3.27% (p=0.016 n=4+5) /Log-8 23.7µs ± 1% 24.4µs ± 6% +3.14% (p=0.032 n=5+5) /Trace-8 42.2µs ± 1% 42.2µs ± 1% ~ (p=0.841 n=5+5) /Stats-8 7.37µs ± 3% 7.10µs ± 1% -3.74% (p=0.008 n=5+5) name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ (all equal) /StdLog-8 552B ± 0% 552B ± 0% ~ (all equal) /LogNoExporter-8 680B ± 0% 1024B ± 0% +50.59% (p=0.008 n=5+5) /TraceNoExporter-8 512B ± 0% 512B ± 0% ~ (all equal) /StatsNoExporter-8 1.26kB ± 0% 2.05kB ± 0% +62.03% (p=0.008 n=5+5) /Log-8 5.20kB ± 0% 6.06kB ± 0% +16.46% (p=0.008 n=5+5) /Trace-8 11.8kB ± 0% 11.8kB ± 0% ~ (p=0.167 n=5+5) /Stats-8 2.29kB ± 0% 3.07kB ± 0% +34.27% (p=0.008 n=5+5) name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ (all equal) /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ (all equal) /LogNoExporter-8 30.0 ± 0% 16.0 ± 0% -46.67% (p=0.008 n=5+5) /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ (all equal) /StatsNoExporter-8 62.0 ± 0% 32.0 ± 0% -48.39% (p=0.008 n=5+5) /Log-8 172 ± 0% 158 ± 0% -8.14% (p=0.008 n=5+5) /Trace-8 336 ± 0% 336 ± 0% ~ (all equal) /Stats-8 94.0 ± 0% 64.0 ± 0% -31.91% (p=0.008 n=5+5) Change-Id: I81d2443c9a32d25a5b60fffa60759caa33566da2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/225381 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Reviewed-by: Robert Findley <rfindley@google.com>
2020-03-24 19:32:44 -06:00
func (k *ErrorKey) Of(v error) Tag { return Tag{Key: k, untyped: v} }
// Get can be used to get a tag for the key from a TagMap.
func (k *ErrorKey) Get(tags TagMap) error {
if t := tags.Find(k); t.Valid() {
return k.From(t)
}
return nil
}
// From can be used to get a value from a Tag.
func (k *ErrorKey) From(t Tag) error {
err, _ := t.untyped.(error)
return err
}