qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-01 13:18:33 -06:00
Code Releases Activity
ec2e11d257
go/internal/lsp/testdata/unimported/unimported.go.in

20 lines
1.0 KiB
Go
Raw Normal View History

internal/lsp: add completions of unimported std lib pkgs Unimported packages may be suggested as completion items. Since these are not yet imported, they should be ranked lower than other candidates. They also require an additional import statement to be valid, which is provided as an AdditionalTextEdit. Adding this import does not use astutil.AddNamedImport, to avoid editing the current ast and work even if there are errors. Additionally, it can be hard to determine what changes need to be made to the source document from the ast, as astutil.AddNamedImport includes a merging pass. Instead, the completion item simply adds another import declaration. Change-Id: Icbde226d843bd49ee3713cafcbd5299d51530695 Reviewed-on: https://go-review.googlesource.com/c/tools/+/190338 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-08-14 15:25:47 -06:00
package unimported
func _() {
internal/lsp/source: cap number of unimported completions Building unimported completions requires re-parsing and formatting at least some of the file for each one, which adds up. Limit it to 20; I expect people will just type more rather than scroll through a giant list. Updates golang/go#36001. Change-Id: Ib41232b91c327d4b824e6176e30306abf356f5b4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210198 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 16:08:19 -07:00
//@unimported("", hashslashadler32, goslashast, encodingslashbase64, bytes)
pkg //@unimported("g", externalpackage)
internal/lsp: use available type info for unimported completions Packages that aren't imported in the current file will often have been used elsewhere, which means that gopls will have their type information available. Expose loaded packages in the Snapshot, and try to use that information when possible for unimported packages. Change-Id: Icb672618a9f9ec31b9796f0c5da56ed3d2b38aa7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204824 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-01 15:59:28 -06:00
// container/ring is extremely unlikely to be imported by anything, so shouldn't have type information.
ring.Ring //@unimported("Ring", ringring)
signature.Foo //@unimported("Foo", signaturefoo)
internal/lsp: add completions of unimported std lib pkgs Unimported packages may be suggested as completion items. Since these are not yet imported, they should be ranked lower than other candidates. They also require an additional import statement to be valid, which is provided as an AdditionalTextEdit. Adding this import does not use astutil.AddNamedImport, to avoid editing the current ast and work even if there are errors. Additionally, it can be hard to determine what changes need to be made to the source document from the ast, as astutil.AddNamedImport includes a merging pass. Instead, the completion item simply adds another import declaration. Change-Id: Icbde226d843bd49ee3713cafcbd5299d51530695 Reviewed-on: https://go-review.googlesource.com/c/tools/+/190338 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-08-14 15:25:47 -06:00
}
// Create markers for unimported std lib packages. Only for use by this test.
internal/lsp/source: cap number of unimported completions Building unimported completions requires re-parsing and formatting at least some of the file for each one, which adds up. Limit it to 20; I expect people will just type more rather than scroll through a giant list. Updates golang/go#36001. Change-Id: Ib41232b91c327d4b824e6176e30306abf356f5b4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210198 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 16:08:19 -07:00
/* adler32 */ //@item(hashslashadler32, "adler32", "\"hash/adler32\"", "package")
/* ast */ //@item(goslashast, "ast", "\"go/ast\"", "package")
/* base64 */ //@item(encodingslashbase64, "base64", "\"encoding/base64\"", "package")
internal/lsp: add completions of unimported std lib pkgs Unimported packages may be suggested as completion items. Since these are not yet imported, they should be ranked lower than other candidates. They also require an additional import statement to be valid, which is provided as an AdditionalTextEdit. Adding this import does not use astutil.AddNamedImport, to avoid editing the current ast and work even if there are errors. Additionally, it can be hard to determine what changes need to be made to the source document from the ast, as astutil.AddNamedImport includes a merging pass. Instead, the completion item simply adds another import declaration. Change-Id: Icbde226d843bd49ee3713cafcbd5299d51530695 Reviewed-on: https://go-review.googlesource.com/c/tools/+/190338 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-08-14 15:25:47 -06:00
/* bytes */ //@item(bytes, "bytes", "\"bytes\"", "package")
internal/lsp: use available type info for unimported completions Packages that aren't imported in the current file will often have been used elsewhere, which means that gopls will have their type information available. Expose loaded packages in the Snapshot, and try to use that information when possible for unimported packages. Change-Id: Icb672618a9f9ec31b9796f0c5da56ed3d2b38aa7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204824 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-01 15:59:28 -06:00
/* pkg */ //@item(externalpackage, "pkg", "\"example.com/extramodule/pkg\"", "package")
internal/lsp/source: propose exports for unimported packages When a user completes rand.<>, propose rand.Seed (from math/rand) and rand.Prime (from crypto/rand), etc. Because we don't necessarily have type checking information for unimported packages, I had to add shortcut cases to a number of functions around the completion code. Better suggestions welcome. Change-Id: I7822dc75c86b24156963e7bdd959443f4f2748b1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204819 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Muir Manders <muir@mnd.rs>
2019-11-01 11:50:21 -06:00
internal/lsp: use available type info for unimported completions Packages that aren't imported in the current file will often have been used elsewhere, which means that gopls will have their type information available. Expose loaded packages in the Snapshot, and try to use that information when possible for unimported packages. Change-Id: Icb672618a9f9ec31b9796f0c5da56ed3d2b38aa7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204824 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-01 15:59:28 -06:00
/* ring.Ring */ //@item(ringring, "Ring", "(from \"container/ring\")", "var")
/* signature.Foo */ //@item(signaturefoo, "Foo", "func(a string, b int) (c bool) (from \"golang.org/x/tools/internal/lsp/signature\")", "func")
Copy Permalink