qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 10:04:56 -07:00
Code Releases Activity
e461004dd0
go/internal/lsp/testdata/godef/b/b.go

38 lines
848 B
Go
Raw Normal View History

internal/lsp: add definition tests from godef This makes our internal version of go to definition be tested with the same test data that godef now uses Change-Id: I04e488b6b9b2d891181f202ea1125b823a079c50 Reviewed-on: https://go-review.googlesource.com/c/150045 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2018-11-14 19:11:16 -07:00
package b
internal/lsp: add definition support for packages Now the "type" of a *ast.PkgName is the package it points to. Of course, a package is not a real types.Type, but we can still jump you there. We have to pick one of the package's files, so we choose the longest one, hoping it is the most interesting. Similarly, the "definition" of an *ast.ImportSpec is the package being imported. I also added a nil check for the package in SignatureHelp. This panics for me occasionally. Change-Id: Ide4640530a28bcec9da6de36723eb7f0e4cc941c GitHub-Last-Rev: 8190baa0b908065db5b53f236de03d2f3bff39b5 GitHub-Pull-Request: golang/tools#92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174081 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 08:32:25 -06:00
import (
internal/lsp: use the explicit import spec name as ident When there is an explicit name for an import spec, treat it as its own identifier, separate from the import path. Example: import h "hello" The name h is defined in that import spec, not in the package hello it contains its own references. If asked about a position within the import path, continue treating that as referencing the imported package. If the position is within the name, use the identifier there that is local to that file. This change allows for go to definition of the explicit name to point to itself, find all references from the import spec, and rename the explicit name from the import spec. Change-Id: Ia1d927a26e73f2dc450d256d71909c006bdf4c37 Reviewed-on: https://go-review.googlesource.com/c/tools/+/191164 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-08-21 17:36:09 -06:00
myFoo "golang.org/x/tools/internal/lsp/foo" //@mark(myFoo, "myFoo"),godef("foo", PackageFoo),godef("myFoo", myFoo)
internal/lsp: add definition support for packages Now the "type" of a *ast.PkgName is the package it points to. Of course, a package is not a real types.Type, but we can still jump you there. We have to pick one of the package's files, so we choose the longest one, hoping it is the most interesting. Similarly, the "definition" of an *ast.ImportSpec is the package being imported. I also added a nil check for the package in SignatureHelp. This panics for me occasionally. Change-Id: Ide4640530a28bcec9da6de36723eb7f0e4cc941c GitHub-Last-Rev: 8190baa0b908065db5b53f236de03d2f3bff39b5 GitHub-Pull-Request: golang/tools#92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174081 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 08:32:25 -06:00
"golang.org/x/tools/internal/lsp/godef/a" //@mark(AImport, "\"")
)
internal/lsp: add definition tests from godef This makes our internal version of go to definition be tested with the same test data that godef now uses Change-Id: I04e488b6b9b2d891181f202ea1125b823a079c50 Reviewed-on: https://go-review.googlesource.com/c/150045 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2018-11-14 19:11:16 -07:00
type S1 struct { //@S1
F1 int //@mark(S1F1, "F1")
S2 //@godef("S2", S2), mark(S1S2, "S2")
a.A //@godef("A", A)
}
type S2 struct { //@S2
internal/lsp: handle embedded struct pointer definitions When jumping to definition of an embedded struct pointer, be sure to unwrap the pointer type so you properly jump to the pointee type. Also, fix jumping to definition of an embedded struct inside an anonymous struct inside a struct. The embedded struct detection was continuing too far and thinking it wasn't an embedded struct when it saw the anonymous struct. Fixes golang/go#31451 Change-Id: I96017764270712a2ae02a85306605495075d12e7 GitHub-Last-Rev: 9997f60855ebe37bcca2fecc1ba2a7b871f393d4 GitHub-Pull-Request: golang/tools#83 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172583 Run-TryBot: Paul Jolly <paul@myitcv.org.uk> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-04-19 09:10:38 -06:00
F1 string //@mark(S2F1, "F1")
F2 int //@mark(S2F2, "F2")
internal/lsp: add definition support for packages Now the "type" of a *ast.PkgName is the package it points to. Of course, a package is not a real types.Type, but we can still jump you there. We have to pick one of the package's files, so we choose the longest one, hoping it is the most interesting. Similarly, the "definition" of an *ast.ImportSpec is the package being imported. I also added a nil check for the package in SignatureHelp. This panics for me occasionally. Change-Id: Ide4640530a28bcec9da6de36723eb7f0e4cc941c GitHub-Last-Rev: 8190baa0b908065db5b53f236de03d2f3bff39b5 GitHub-Pull-Request: golang/tools#92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174081 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 08:32:25 -06:00
*a.A //@godef("A", A),godef("a",AImport)
internal/lsp: handle embedded struct pointer definitions When jumping to definition of an embedded struct pointer, be sure to unwrap the pointer type so you properly jump to the pointee type. Also, fix jumping to definition of an embedded struct inside an anonymous struct inside a struct. The embedded struct detection was continuing too far and thinking it wasn't an embedded struct when it saw the anonymous struct. Fixes golang/go#31451 Change-Id: I96017764270712a2ae02a85306605495075d12e7 GitHub-Last-Rev: 9997f60855ebe37bcca2fecc1ba2a7b871f393d4 GitHub-Pull-Request: golang/tools#83 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172583 Run-TryBot: Paul Jolly <paul@myitcv.org.uk> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-04-19 09:10:38 -06:00
}
type S3 struct {
F1 struct {
a.A //@godef("A", A)
}
internal/lsp: add definition tests from godef This makes our internal version of go to definition be tested with the same test data that godef now uses Change-Id: I04e488b6b9b2d891181f202ea1125b823a079c50 Reviewed-on: https://go-review.googlesource.com/c/150045 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2018-11-14 19:11:16 -07:00
}
func Bar() {
a.Stuff() //@godef("Stuff", Stuff)
var x S1 //@godef("S1", S1)
_ = x.S2 //@godef("S2", S1S2)
_ = x.F1 //@godef("F1", S1F1)
_ = x.F2 //@godef("F2", S2F2)
_ = x.S2.F1 //@godef("F1", S2F1)
internal/lsp: add definition support for packages Now the "type" of a *ast.PkgName is the package it points to. Of course, a package is not a real types.Type, but we can still jump you there. We have to pick one of the package's files, so we choose the longest one, hoping it is the most interesting. Similarly, the "definition" of an *ast.ImportSpec is the package being imported. I also added a nil check for the package in SignatureHelp. This panics for me occasionally. Change-Id: Ide4640530a28bcec9da6de36723eb7f0e4cc941c GitHub-Last-Rev: 8190baa0b908065db5b53f236de03d2f3bff39b5 GitHub-Pull-Request: golang/tools#92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174081 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 08:32:25 -06:00
internal/lsp: use the explicit import spec name as ident When there is an explicit name for an import spec, treat it as its own identifier, separate from the import path. Example: import h "hello" The name h is defined in that import spec, not in the package hello it contains its own references. If asked about a position within the import path, continue treating that as referencing the imported package. If the position is within the name, use the identifier there that is local to that file. This change allows for go to definition of the explicit name to point to itself, find all references from the import spec, and rename the explicit name from the import spec. Change-Id: Ia1d927a26e73f2dc450d256d71909c006bdf4c37 Reviewed-on: https://go-review.googlesource.com/c/tools/+/191164 Run-TryBot: Suzy Mueller <suzmue@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-08-21 17:36:09 -06:00
var _ *myFoo.StructFoo //@godef("myFoo", myFoo)
internal/lsp: add definition tests from godef This makes our internal version of go to definition be tested with the same test data that godef now uses Change-Id: I04e488b6b9b2d891181f202ea1125b823a079c50 Reviewed-on: https://go-review.googlesource.com/c/150045 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2018-11-14 19:11:16 -07:00
}
internal/lsp: add constant values to hovers Change-Id: Ic0c497f4b1644f915db850be3fbacda8e2f85e9a Reviewed-on: https://go-review.googlesource.com/c/tools/+/197818 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-27 19:10:58 -06:00
const X = 0 //@mark(X, "X"),godef("X", X)
Copy Permalink