2012-09-23 11:16:14 -06:00
|
|
|
// errorcheck -0 -m -l
|
2011-08-24 11:07:08 -06:00
|
|
|
|
|
|
|
// Copyright 2010 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2012-02-18 20:28:53 -07:00
|
|
|
// Test, using compiler diagnostic flags, that the escape analysis is working.
|
2012-02-23 21:09:53 -07:00
|
|
|
// Compiles but does not run. Inlining is disabled.
|
2012-02-18 20:28:53 -07:00
|
|
|
|
2011-08-24 11:07:08 -06:00
|
|
|
package foo
|
|
|
|
|
2011-11-01 09:02:43 -06:00
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"unsafe"
|
|
|
|
)
|
2011-08-24 11:07:08 -06:00
|
|
|
|
|
|
|
var gxx *int
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo1(x int) { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
gxx = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo2(yy *int) { // ERROR "leaking param: yy"
|
2011-08-24 11:07:08 -06:00
|
|
|
gxx = yy
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo3(x int) *int { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
type T *T
|
2011-08-28 10:05:00 -06:00
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo3b(t T) { // ERROR "leaking param: t"
|
2011-08-24 11:07:08 -06:00
|
|
|
*t = t
|
|
|
|
}
|
|
|
|
|
|
|
|
// xx isn't going anywhere, so use of yy is ok
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo4(xx, yy *int) { // ERROR "xx does not escape" "yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
xx = yy
|
|
|
|
}
|
|
|
|
|
|
|
|
// xx isn't going anywhere, so taking address of yy is ok
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo5(xx **int, yy *int) { // ERROR "xx does not escape" "yy does not escape"
|
2011-11-01 09:02:43 -06:00
|
|
|
xx = &yy // ERROR "&yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo6(xx **int, yy *int) { // ERROR "xx does not escape" "leaking param: yy"
|
2011-08-24 11:07:08 -06:00
|
|
|
*xx = yy
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo7(xx **int, yy *int) { // ERROR "xx does not escape" "yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
**xx = *yy
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo8(xx, yy *int) int { // ERROR "xx does not escape" "yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
xx = yy
|
|
|
|
return *xx
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo9(xx, yy *int) *int { // ERROR "leaking param: xx" "leaking param: yy"
|
2011-08-24 11:07:08 -06:00
|
|
|
xx = yy
|
|
|
|
return xx
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo10(xx, yy *int) { // ERROR "xx does not escape" "yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
*xx = *yy
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo11() int {
|
|
|
|
x, y := 0, 42
|
2011-11-01 09:02:43 -06:00
|
|
|
xx := &x // ERROR "&x does not escape"
|
|
|
|
yy := &y // ERROR "&y does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
*xx = *yy
|
|
|
|
return x
|
|
|
|
}
|
|
|
|
|
|
|
|
var xxx **int
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo12(yyy **int) { // ERROR "leaking param: yyy"
|
2011-08-24 11:07:08 -06:00
|
|
|
xxx = yyy
|
|
|
|
}
|
|
|
|
|
2014-05-09 13:40:45 -06:00
|
|
|
// Must treat yyy as leaking because *yyy leaks, and the escape analysis
|
2013-03-15 02:03:45 -06:00
|
|
|
// summaries in exported metadata do not distinguish these two cases.
|
|
|
|
func foo13(yyy **int) { // ERROR "leaking param: yyy"
|
2011-08-24 11:07:08 -06:00
|
|
|
*xxx = *yyy
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo14(yyy **int) { // ERROR "yyy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
**xxx = **yyy
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo15(yy *int) { // ERROR "moved to heap: yy"
|
2011-11-01 09:02:43 -06:00
|
|
|
xxx = &yy // ERROR "&yy escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo16(yy *int) { // ERROR "leaking param: yy"
|
2011-08-24 11:07:08 -06:00
|
|
|
*xxx = yy
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo17(yy *int) { // ERROR "yy does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
**xxx = *yy
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo18(y int) { // ERROR "moved to heap: "y"
|
2011-11-01 09:02:43 -06:00
|
|
|
*xxx = &y // ERROR "&y escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo19(y int) {
|
|
|
|
**xxx = y
|
|
|
|
}
|
|
|
|
|
|
|
|
type Bar struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
i int
|
2011-08-24 11:07:08 -06:00
|
|
|
ii *int
|
|
|
|
}
|
|
|
|
|
|
|
|
func NewBar() *Bar {
|
2011-10-08 11:37:06 -06:00
|
|
|
return &Bar{42, nil} // ERROR "&Bar literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func NewBarp(x *int) *Bar { // ERROR "leaking param: x"
|
|
|
|
return &Bar{42, x} // ERROR "&Bar literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func NewBarp2(x *int) *Bar { // ERROR "x does not escape"
|
2011-10-08 11:37:06 -06:00
|
|
|
return &Bar{*x, nil} // ERROR "&Bar literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func (b *Bar) NoLeak() int { // ERROR "b does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
return *(b.ii)
|
|
|
|
}
|
|
|
|
|
2012-01-12 04:08:40 -07:00
|
|
|
func (b *Bar) Leak() *int { // ERROR "leaking param: b"
|
|
|
|
return &b.i // ERROR "&b.i escapes to heap"
|
|
|
|
}
|
|
|
|
|
cmd/gc: fix escape analysis of func returning indirect of parameter
I introduced this bug when I changed the escape
analysis to run in phases based on call graph
dependency order, in order to be more precise about
inputs escaping back to outputs (functions returning
their arguments).
Given
func f(z **int) *int { return *z }
we were tagging the function as 'z does not escape
and is not returned', which is all true, but not
enough information.
If used as:
var x int
p := &x
q := &p
leak(f(q))
then the compiler might try to keep x, p, and q all
on the stack, since (according to the recorded
information) nothing interesting ends up being
passed to leak.
In fact since f returns *q = p, &x is passed to leak
and x needs to be heap allocated.
To trigger the bug, you need a chain that the
compiler wants to keep on the stack (like x, p, q
above), and you need a function that returns an
indirect of its argument, and you need to pass the
head of the chain to that function. This doesn't
come up very often: this bug has been present since
June 2012 (between Go 1 and Go 1.1) and we haven't
seen it until now. It helps that most functions that
return indirects are getters that are simple enough
to be inlined, avoiding the bug.
Earlier versions of Go also had the benefit that if
&x really wasn't used beyond x's lifetime, nothing
broke if you put &x in a heap-allocated structure
accidentally. With the new stack copying, though,
heap-allocated structures containing &x are not
updated when the stack is copied and x moves,
leading to crashes in Go 1.3 that were not crashes
in Go 1.2 or Go 1.1.
The fix is in two parts.
First, in the analysis of a function, recognize when
a value obtained via indirect of a parameter ends up
being returned. Mark those parameters as having
content escape back to the return results (but we
don't bother to write down which result).
Second, when using the analysis to analyze, say,
f(q), mark parameters with content escaping as
having any indirections escape to the heap. (We
don't bother trying to match the content to the
return value.)
The fix could be less precise (simpler).
In the first part we might mark all content-escaping
parameters as plain escaping, and then the second
part could be dropped. Or we might assume that when
calling f(q) all the things pointed at by q escape
always (for any f and q).
The fix could also be more precise (more complex).
We might record the specific mapping from parameter
to result along with the number of indirects from the
parameter to the thing being returned as the result,
and then at the call sites we could set up exactly the
right graph for the called function. That would make
notleaks(f(q)) be able to keep x on the stack, because
the reuslt of f(q) isn't passed to anything that leaks it.
The less precise the fix, the more stack allocations
become heap allocations.
This fix is exactly as precise as it needs to be so that
none of the current stack allocations in the standard
library turn into heap allocations.
Fixes #8120.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, khr, r
https://golang.org/cl/102040046
2014-06-03 09:35:59 -06:00
|
|
|
func (b *Bar) AlsoNoLeak() *int { // ERROR "leaking param b content to result ~r0"
|
2011-08-24 11:07:08 -06:00
|
|
|
return b.ii
|
|
|
|
}
|
|
|
|
|
2012-01-12 04:08:40 -07:00
|
|
|
func (b Bar) AlsoLeak() *int { // ERROR "leaking param: b"
|
|
|
|
return b.ii
|
|
|
|
}
|
|
|
|
|
|
|
|
func (b Bar) LeaksToo() *int { // ERROR "leaking param: b"
|
2012-12-20 15:27:28 -07:00
|
|
|
v := 0 // ERROR "moved to heap: v"
|
2012-01-12 04:08:40 -07:00
|
|
|
b.ii = &v // ERROR "&v escapes"
|
|
|
|
return b.ii
|
|
|
|
}
|
|
|
|
|
cmd/gc: fix escape analysis of func returning indirect of parameter
I introduced this bug when I changed the escape
analysis to run in phases based on call graph
dependency order, in order to be more precise about
inputs escaping back to outputs (functions returning
their arguments).
Given
func f(z **int) *int { return *z }
we were tagging the function as 'z does not escape
and is not returned', which is all true, but not
enough information.
If used as:
var x int
p := &x
q := &p
leak(f(q))
then the compiler might try to keep x, p, and q all
on the stack, since (according to the recorded
information) nothing interesting ends up being
passed to leak.
In fact since f returns *q = p, &x is passed to leak
and x needs to be heap allocated.
To trigger the bug, you need a chain that the
compiler wants to keep on the stack (like x, p, q
above), and you need a function that returns an
indirect of its argument, and you need to pass the
head of the chain to that function. This doesn't
come up very often: this bug has been present since
June 2012 (between Go 1 and Go 1.1) and we haven't
seen it until now. It helps that most functions that
return indirects are getters that are simple enough
to be inlined, avoiding the bug.
Earlier versions of Go also had the benefit that if
&x really wasn't used beyond x's lifetime, nothing
broke if you put &x in a heap-allocated structure
accidentally. With the new stack copying, though,
heap-allocated structures containing &x are not
updated when the stack is copied and x moves,
leading to crashes in Go 1.3 that were not crashes
in Go 1.2 or Go 1.1.
The fix is in two parts.
First, in the analysis of a function, recognize when
a value obtained via indirect of a parameter ends up
being returned. Mark those parameters as having
content escape back to the return results (but we
don't bother to write down which result).
Second, when using the analysis to analyze, say,
f(q), mark parameters with content escaping as
having any indirections escape to the heap. (We
don't bother trying to match the content to the
return value.)
The fix could be less precise (simpler).
In the first part we might mark all content-escaping
parameters as plain escaping, and then the second
part could be dropped. Or we might assume that when
calling f(q) all the things pointed at by q escape
always (for any f and q).
The fix could also be more precise (more complex).
We might record the specific mapping from parameter
to result along with the number of indirects from the
parameter to the thing being returned as the result,
and then at the call sites we could set up exactly the
right graph for the called function. That would make
notleaks(f(q)) be able to keep x on the stack, because
the reuslt of f(q) isn't passed to anything that leaks it.
The less precise the fix, the more stack allocations
become heap allocations.
This fix is exactly as precise as it needs to be so that
none of the current stack allocations in the standard
library turn into heap allocations.
Fixes #8120.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, khr, r
https://golang.org/cl/102040046
2014-06-03 09:35:59 -06:00
|
|
|
func (b *Bar) LeaksABit() *int { // ERROR "leaking param b content to result ~r0"
|
2012-12-20 15:27:28 -07:00
|
|
|
v := 0 // ERROR "moved to heap: v"
|
2012-01-12 04:08:40 -07:00
|
|
|
b.ii = &v // ERROR "&v escapes"
|
|
|
|
return b.ii
|
|
|
|
}
|
|
|
|
|
|
|
|
func (b Bar) StillNoLeak() int { // ERROR "b does not escape"
|
|
|
|
v := 0
|
|
|
|
b.ii = &v // ERROR "&v does not escape"
|
|
|
|
return b.i
|
|
|
|
}
|
|
|
|
|
2011-11-01 09:02:43 -06:00
|
|
|
func goLeak(b *Bar) { // ERROR "leaking param: b"
|
2011-09-07 11:03:11 -06:00
|
|
|
go b.NoLeak()
|
|
|
|
}
|
|
|
|
|
2011-08-24 11:07:08 -06:00
|
|
|
type Bar2 struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
i [12]int
|
2011-08-24 11:07:08 -06:00
|
|
|
ii []int
|
|
|
|
}
|
|
|
|
|
|
|
|
func NewBar2() *Bar2 {
|
2011-10-08 11:37:06 -06:00
|
|
|
return &Bar2{[12]int{42}, nil} // ERROR "&Bar2 literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func (b *Bar2) NoLeak() int { // ERROR "b does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
return b.i[0]
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (b *Bar2) Leak() []int { // ERROR "leaking param: b"
|
2012-01-12 04:08:40 -07:00
|
|
|
return b.i[:] // ERROR "b.i escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
cmd/gc: fix escape analysis of func returning indirect of parameter
I introduced this bug when I changed the escape
analysis to run in phases based on call graph
dependency order, in order to be more precise about
inputs escaping back to outputs (functions returning
their arguments).
Given
func f(z **int) *int { return *z }
we were tagging the function as 'z does not escape
and is not returned', which is all true, but not
enough information.
If used as:
var x int
p := &x
q := &p
leak(f(q))
then the compiler might try to keep x, p, and q all
on the stack, since (according to the recorded
information) nothing interesting ends up being
passed to leak.
In fact since f returns *q = p, &x is passed to leak
and x needs to be heap allocated.
To trigger the bug, you need a chain that the
compiler wants to keep on the stack (like x, p, q
above), and you need a function that returns an
indirect of its argument, and you need to pass the
head of the chain to that function. This doesn't
come up very often: this bug has been present since
June 2012 (between Go 1 and Go 1.1) and we haven't
seen it until now. It helps that most functions that
return indirects are getters that are simple enough
to be inlined, avoiding the bug.
Earlier versions of Go also had the benefit that if
&x really wasn't used beyond x's lifetime, nothing
broke if you put &x in a heap-allocated structure
accidentally. With the new stack copying, though,
heap-allocated structures containing &x are not
updated when the stack is copied and x moves,
leading to crashes in Go 1.3 that were not crashes
in Go 1.2 or Go 1.1.
The fix is in two parts.
First, in the analysis of a function, recognize when
a value obtained via indirect of a parameter ends up
being returned. Mark those parameters as having
content escape back to the return results (but we
don't bother to write down which result).
Second, when using the analysis to analyze, say,
f(q), mark parameters with content escaping as
having any indirections escape to the heap. (We
don't bother trying to match the content to the
return value.)
The fix could be less precise (simpler).
In the first part we might mark all content-escaping
parameters as plain escaping, and then the second
part could be dropped. Or we might assume that when
calling f(q) all the things pointed at by q escape
always (for any f and q).
The fix could also be more precise (more complex).
We might record the specific mapping from parameter
to result along with the number of indirects from the
parameter to the thing being returned as the result,
and then at the call sites we could set up exactly the
right graph for the called function. That would make
notleaks(f(q)) be able to keep x on the stack, because
the reuslt of f(q) isn't passed to anything that leaks it.
The less precise the fix, the more stack allocations
become heap allocations.
This fix is exactly as precise as it needs to be so that
none of the current stack allocations in the standard
library turn into heap allocations.
Fixes #8120.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, khr, r
https://golang.org/cl/102040046
2014-06-03 09:35:59 -06:00
|
|
|
func (b *Bar2) AlsoNoLeak() []int { // ERROR "leaking param b content to result ~r0"
|
2011-08-24 11:07:08 -06:00
|
|
|
return b.ii[0:1]
|
|
|
|
}
|
|
|
|
|
2012-01-12 04:08:40 -07:00
|
|
|
func (b Bar2) AgainNoLeak() [12]int { // ERROR "b does not escape"
|
|
|
|
return b.i
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (b *Bar2) LeakSelf() { // ERROR "leaking param: b"
|
2012-01-12 04:08:40 -07:00
|
|
|
b.ii = b.i[0:4] // ERROR "b.i escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (b *Bar2) LeakSelf2() { // ERROR "leaking param: b"
|
2011-08-24 11:07:08 -06:00
|
|
|
var buf []int
|
2012-01-12 04:08:40 -07:00
|
|
|
buf = b.i[0:] // ERROR "b.i escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
b.ii = buf
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo21() func() int {
|
2011-11-01 09:02:43 -06:00
|
|
|
x := 42 // ERROR "moved to heap: x"
|
|
|
|
return func() int { // ERROR "func literal escapes to heap"
|
|
|
|
return x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo22() int {
|
|
|
|
x := 42
|
2011-11-01 09:02:43 -06:00
|
|
|
return func() int { // ERROR "func literal does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
return x
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo23(x int) func() int { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return func() int { // ERROR "func literal escapes to heap"
|
|
|
|
return x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo23a(x int) func() int { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
f := func() int { // ERROR "func literal escapes to heap"
|
|
|
|
return x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
return f
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo23b(x int) *(func() int) { // ERROR "moved to heap: x"
|
|
|
|
f := func() int { return x } // ERROR "moved to heap: f" "func literal escapes to heap" "&x escapes to heap"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &f // ERROR "&f escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo24(x int) int {
|
2011-11-01 09:02:43 -06:00
|
|
|
return func() int { // ERROR "func literal does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
return x
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
var x *int
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func fooleak(xx *int) int { // ERROR "leaking param: xx"
|
2011-08-24 11:07:08 -06:00
|
|
|
x = xx
|
|
|
|
return *x
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foonoleak(xx *int) int { // ERROR "xx does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
return *x + *xx
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo31(x int) int { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return fooleak(&x) // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo32(x int) int {
|
2011-11-01 09:02:43 -06:00
|
|
|
return foonoleak(&x) // ERROR "&x does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
type Foo struct {
|
|
|
|
xx *int
|
2011-08-28 10:05:00 -06:00
|
|
|
x int
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
var F Foo
|
|
|
|
var pf *Foo
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (f *Foo) fooleak() { // ERROR "leaking param: f"
|
2011-08-24 11:07:08 -06:00
|
|
|
pf = f
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func (f *Foo) foonoleak() { // ERROR "f does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
F.x = f.x
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (f *Foo) Leak() { // ERROR "leaking param: f"
|
2011-08-24 11:07:08 -06:00
|
|
|
f.fooleak()
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func (f *Foo) NoLeak() { // ERROR "f does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
f.foonoleak()
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo41(x int) { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
F.xx = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (f *Foo) foo42(x int) { // ERROR "f does not escape" "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
f.xx = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo43(f *Foo, x int) { // ERROR "f does not escape" "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
f.xx = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo44(yy *int) { // ERROR "leaking param: yy"
|
2011-08-24 11:07:08 -06:00
|
|
|
F.xx = yy
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func (f *Foo) foo45() { // ERROR "f does not escape"
|
|
|
|
F.x = f.x
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2013-03-15 02:03:45 -06:00
|
|
|
// See foo13 above for explanation of why f leaks.
|
|
|
|
func (f *Foo) foo46() { // ERROR "leaking param: f"
|
2011-08-28 10:05:00 -06:00
|
|
|
F.xx = f.xx
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func (f *Foo) foo47() { // ERROR "leaking param: f"
|
2011-11-01 09:02:43 -06:00
|
|
|
f.xx = &f.x // ERROR "&f.x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
var ptrSlice []*int
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo50(i *int) { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
ptrSlice[0] = i
|
|
|
|
}
|
|
|
|
|
|
|
|
var ptrMap map[*int]*int
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo51(i *int) { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
ptrMap[i] = i
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func indaddr1(x int) *int { // ERROR "moved to heap: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func indaddr2(x *int) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return *&x // ERROR "&x does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func indaddr3(x *int32) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return *(**int)(unsafe.Pointer(&x)) // ERROR "&x does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// From package math:
|
|
|
|
|
|
|
|
func Float32bits(f float32) uint32 {
|
2011-11-01 09:02:43 -06:00
|
|
|
return *(*uint32)(unsafe.Pointer(&f)) // ERROR "&f does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func Float32frombits(b uint32) float32 {
|
2011-11-01 09:02:43 -06:00
|
|
|
return *(*float32)(unsafe.Pointer(&b)) // ERROR "&b does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func Float64bits(f float64) uint64 {
|
2011-11-01 09:02:43 -06:00
|
|
|
return *(*uint64)(unsafe.Pointer(&f)) // ERROR "&f does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func Float64frombits(b uint64) float64 {
|
2011-11-01 09:02:43 -06:00
|
|
|
return *(*float64)(unsafe.Pointer(&b)) // ERROR "&b does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// contrast with
|
2011-10-08 11:37:06 -06:00
|
|
|
func float64bitsptr(f float64) *uint64 { // ERROR "moved to heap: f"
|
2011-11-01 09:02:43 -06:00
|
|
|
return (*uint64)(unsafe.Pointer(&f)) // ERROR "&f escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func float64ptrbitsptr(f *float64) *uint64 { // ERROR "leaking param: f"
|
2011-08-24 11:07:08 -06:00
|
|
|
return (*uint64)(unsafe.Pointer(f))
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func typesw(i interface{}) *int { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
switch val := i.(type) {
|
|
|
|
case *int:
|
|
|
|
return val
|
|
|
|
case *int8:
|
2011-10-08 11:37:06 -06:00
|
|
|
v := int(*val) // ERROR "moved to heap: v"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &v // ERROR "&v escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func exprsw(i *int) *int { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
switch j := i; *j + 110 {
|
|
|
|
case 12:
|
|
|
|
return j
|
|
|
|
case 42:
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
// assigning to an array element is like assigning to the array
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo60(i *int) *int { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
var a [12]*int
|
|
|
|
a[0] = i
|
|
|
|
return a[1]
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo60a(i *int) *int { // ERROR "i does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
var a [12]*int
|
|
|
|
a[0] = i
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// assigning to a struct field is like assigning to the struct
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo61(i *int) *int { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
type S struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
a, b *int
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
var s S
|
|
|
|
s.a = i
|
|
|
|
return s.b
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo61a(i *int) *int { // ERROR "i does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
type S struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
a, b *int
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
var s S
|
|
|
|
s.a = i
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// assigning to a struct field is like assigning to the struct but
|
|
|
|
// here this subtlety is lost, since s.a counts as an assignment to a
|
|
|
|
// track-losing dereference.
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo62(i *int) *int { // ERROR "leaking param: i"
|
2011-08-24 11:07:08 -06:00
|
|
|
type S struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
a, b *int
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
2011-08-28 10:05:00 -06:00
|
|
|
s := new(S) // ERROR "new[(]S[)] does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
s.a = i
|
2011-08-28 10:05:00 -06:00
|
|
|
return nil // s.b
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
type M interface {
|
|
|
|
M()
|
|
|
|
}
|
2011-08-24 11:07:08 -06:00
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo63(m M) { // ERROR "m does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo64(m M) { // ERROR "leaking param: m"
|
2011-08-24 11:07:08 -06:00
|
|
|
m.M()
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo64b(m M) { // ERROR "leaking param: m"
|
2011-09-07 11:03:11 -06:00
|
|
|
defer m.M()
|
|
|
|
}
|
|
|
|
|
2011-08-24 11:07:08 -06:00
|
|
|
type MV int
|
2011-08-28 10:05:00 -06:00
|
|
|
|
2011-08-24 11:07:08 -06:00
|
|
|
func (MV) M() {}
|
|
|
|
|
|
|
|
func foo65() {
|
|
|
|
var mv MV
|
2011-11-01 09:02:43 -06:00
|
|
|
foo63(&mv) // ERROR "&mv does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo66() {
|
2011-11-01 09:02:43 -06:00
|
|
|
var mv MV // ERROR "moved to heap: mv"
|
|
|
|
foo64(&mv) // ERROR "&mv escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo67() {
|
|
|
|
var mv MV
|
|
|
|
foo63(mv)
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo68() {
|
|
|
|
var mv MV
|
2011-08-28 10:05:00 -06:00
|
|
|
foo64(mv) // escapes but it's an int so irrelevant
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo69(m M) { // ERROR "leaking param: m"
|
2011-08-24 11:07:08 -06:00
|
|
|
foo64(m)
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo70(mv1 *MV, m M) { // ERROR "leaking param: mv1" "leaking param: m"
|
2011-08-24 11:07:08 -06:00
|
|
|
m = mv1
|
|
|
|
foo64(m)
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo71(x *int) []*int { // ERROR "leaking param: x"
|
2011-08-24 11:07:08 -06:00
|
|
|
var y []*int
|
|
|
|
y = append(y, x)
|
|
|
|
return y
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo71a(x int) []*int { // ERROR "moved to heap: x"
|
2011-08-24 11:07:08 -06:00
|
|
|
var y []*int
|
2011-11-01 09:02:43 -06:00
|
|
|
y = append(y, &x) // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
return y
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo72() {
|
|
|
|
var x int
|
|
|
|
var y [1]*int
|
2011-11-01 09:02:43 -06:00
|
|
|
y[0] = &x // ERROR "&x does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo72aa() [10]*int {
|
2011-10-08 11:37:06 -06:00
|
|
|
var x int // ERROR "moved to heap: x"
|
2011-08-24 11:07:08 -06:00
|
|
|
var y [10]*int
|
2011-11-01 09:02:43 -06:00
|
|
|
y[0] = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
return y
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo72a() {
|
|
|
|
var y [10]*int
|
|
|
|
for i := 0; i < 10; i++ {
|
2011-08-28 10:05:00 -06:00
|
|
|
// escapes its scope
|
2011-11-01 09:02:43 -06:00
|
|
|
x := i // ERROR "moved to heap: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
y[i] = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo72b() [10]*int {
|
|
|
|
var y [10]*int
|
|
|
|
for i := 0; i < 10; i++ {
|
2011-11-01 09:02:43 -06:00
|
|
|
x := i // ERROR "moved to heap: x"
|
|
|
|
y[i] = &x // ERROR "&x escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
return y
|
|
|
|
}
|
|
|
|
|
|
|
|
// issue 2145
|
|
|
|
func foo73() {
|
2011-10-08 11:37:06 -06:00
|
|
|
s := []int{3, 2, 1} // ERROR "\[\]int literal does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
for _, v := range s {
|
2011-11-01 09:02:43 -06:00
|
|
|
vv := v // ERROR "moved to heap: vv"
|
2011-08-28 10:05:00 -06:00
|
|
|
// actually just escapes its scope
|
|
|
|
defer func() { // ERROR "func literal escapes to heap"
|
2011-11-01 09:02:43 -06:00
|
|
|
println(vv) // ERROR "&vv escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo74() {
|
2011-10-08 11:37:06 -06:00
|
|
|
s := []int{3, 2, 1} // ERROR "\[\]int literal does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
for _, v := range s {
|
2011-11-01 09:02:43 -06:00
|
|
|
vv := v // ERROR "moved to heap: vv"
|
2011-08-28 10:05:00 -06:00
|
|
|
// actually just escapes its scope
|
|
|
|
fn := func() { // ERROR "func literal escapes to heap"
|
2011-11-01 09:02:43 -06:00
|
|
|
println(vv) // ERROR "&vv escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
defer fn()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-08-31 14:23:37 -06:00
|
|
|
// issue 3975
|
|
|
|
func foo74b() {
|
|
|
|
var array [3]func()
|
|
|
|
s := []int{3, 2, 1} // ERROR "\[\]int literal does not escape"
|
|
|
|
for i, v := range s {
|
|
|
|
vv := v // ERROR "moved to heap: vv"
|
|
|
|
// actually just escapes its scope
|
|
|
|
array[i] = func() { // ERROR "func literal escapes to heap"
|
|
|
|
println(vv) // ERROR "&vv escapes to heap"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func myprint(y *int, x ...interface{}) *int { // ERROR "x does not escape" "leaking param: y"
|
2011-08-24 11:07:08 -06:00
|
|
|
return y
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func myprint1(y *int, x ...interface{}) *interface{} { // ERROR "y does not escape" "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &x[0] // ERROR "&x.0. escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
func foo75(z *int) { // ERROR "z does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
myprint(z, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo75a(z *int) { // ERROR "z does not escape"
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
myprint1(z, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo75esc(z *int) { // ERROR "leaking param: z"
|
|
|
|
gxx = myprint(z, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo75aesc(z *int) { // ERROR "z does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
var ppi **interface{} // assignments to pointer dereferences lose track
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
*ppi = myprint1(z, 1, 2, 3) // ERROR "[.][.][.] argument escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo76(z *int) { // ERROR "leaking param: z"
|
2011-08-28 10:05:00 -06:00
|
|
|
myprint(nil, z) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo76a(z *int) { // ERROR "leaking param: z"
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
myprint1(nil, z) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo76b() {
|
2011-08-28 10:05:00 -06:00
|
|
|
myprint(nil, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo76c() {
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
myprint1(nil, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo76d() {
|
2011-08-28 10:05:00 -06:00
|
|
|
defer myprint(nil, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo76e() {
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
defer myprint1(nil, 1, 2, 3) // ERROR "[.][.][.] argument does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo76f() {
|
|
|
|
for {
|
2011-08-28 10:05:00 -06:00
|
|
|
// TODO: This one really only escapes its scope, but we don't distinguish yet.
|
|
|
|
defer myprint(nil, 1, 2, 3) // ERROR "[.][.][.] argument escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo76g() {
|
|
|
|
for {
|
2011-08-28 10:05:00 -06:00
|
|
|
defer myprint1(nil, 1, 2, 3) // ERROR "[.][.][.] argument escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo77(z []interface{}) { // ERROR "z does not escape"
|
|
|
|
myprint(nil, z...) // z does not escape
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
func foo77a(z []interface{}) { // ERROR "z does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
myprint1(nil, z...)
|
|
|
|
}
|
|
|
|
|
cmd/gc: escape analysis to track flow of in to out parameters.
includes step 0: synthesize outparams, from 6600044
includes step 1,2: give outparams loopdepth 0 and verify unchanged results
generate esc:$mask tags, but still tie to sink if a param has mask != 0
from 6610054
adds final steps:
- have esccall generate n->escretval, a list of nodes the function results flow to
- use these in esccall and ORETURN/OAS2FUNC/and f(g())
- only tie parameters to sink if tag is absent, otherwise according to mask, tie them to escretval
R=rsc, bradfitz
CC=dave, gobot, golang-dev, iant, rsc
https://golang.org/cl/6741044
2012-10-29 06:38:21 -06:00
|
|
|
func foo77b(z []interface{}) { // ERROR "leaking param: z"
|
|
|
|
var ppi **interface{}
|
|
|
|
*ppi = myprint1(nil, z...)
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo78(z int) *int { // ERROR "moved to heap: z"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &z // ERROR "&z escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo78a(z int) *int { // ERROR "moved to heap: z"
|
2011-11-01 09:02:43 -06:00
|
|
|
y := &z // ERROR "&z escapes to heap"
|
|
|
|
x := &y // ERROR "&y does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
return *x // really return y
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo79() *int {
|
2011-08-28 10:05:00 -06:00
|
|
|
return new(int) // ERROR "new[(]int[)] escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func foo80() *int {
|
|
|
|
var z *int
|
|
|
|
for {
|
2011-08-28 10:05:00 -06:00
|
|
|
// Really just escapes its scope but we don't distinguish
|
|
|
|
z = new(int) // ERROR "new[(]int[)] escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
_ = z
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo81() *int {
|
|
|
|
for {
|
2011-08-28 10:05:00 -06:00
|
|
|
z := new(int) // ERROR "new[(]int[)] does not escape"
|
2011-08-24 11:07:08 -06:00
|
|
|
_ = z
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2012-12-20 15:27:28 -07:00
|
|
|
func tee(p *int) (x, y *int) { return p, p } // ERROR "leaking param"
|
|
|
|
|
|
|
|
func noop(x, y *int) {} // ERROR "does not escape"
|
|
|
|
|
|
|
|
func foo82() {
|
|
|
|
var x, y, z int // ERROR "moved to heap"
|
|
|
|
go noop(tee(&z)) // ERROR "&z escapes to heap"
|
|
|
|
go noop(&x, &y) // ERROR "escapes to heap"
|
|
|
|
for {
|
|
|
|
var u, v, w int // ERROR "moved to heap"
|
|
|
|
defer noop(tee(&u)) // ERROR "&u escapes to heap"
|
|
|
|
defer noop(&v, &w) // ERROR "escapes to heap"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-08-24 11:07:08 -06:00
|
|
|
type Fooer interface {
|
|
|
|
Foo()
|
|
|
|
}
|
|
|
|
|
|
|
|
type LimitedFooer struct {
|
2011-08-28 10:05:00 -06:00
|
|
|
Fooer
|
|
|
|
N int64
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func LimitFooer(r Fooer, n int64) Fooer { // ERROR "leaking param: r"
|
|
|
|
return &LimitedFooer{r, n} // ERROR "&LimitedFooer literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo90(x *int) map[*int]*int { // ERROR "leaking param: x"
|
2011-12-02 12:45:07 -07:00
|
|
|
return map[*int]*int{nil: x} // ERROR "map\[\*int\]\*int literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo91(x *int) map[*int]*int { // ERROR "leaking param: x"
|
2011-12-02 12:45:07 -07:00
|
|
|
return map[*int]*int{x: nil} // ERROR "map\[\*int\]\*int literal escapes to heap"
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo92(x *int) [2]*int { // ERROR "leaking param: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
return [2]*int{x, nil}
|
2011-08-24 11:07:08 -06:00
|
|
|
}
|
|
|
|
|
2011-08-25 07:26:13 -06:00
|
|
|
// does not leak c
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo93(c chan *int) *int { // ERROR "c does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
for v := range c {
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak m
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo94(m map[*int]*int, b bool) *int { // ERROR "m does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
for k, v := range m {
|
|
|
|
if b {
|
|
|
|
return k
|
|
|
|
}
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// does leak x
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo95(m map[*int]*int, x *int) { // ERROR "m does not escape" "leaking param: x"
|
2011-08-25 07:26:13 -06:00
|
|
|
m[x] = x
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak m
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo96(m []*int) *int { // ERROR "m does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
return m[0]
|
|
|
|
}
|
|
|
|
|
|
|
|
// does leak m
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo97(m [1]*int) *int { // ERROR "leaking param: m"
|
2011-08-25 07:26:13 -06:00
|
|
|
return m[0]
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak m
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo98(m map[int]*int) *int { // ERROR "m does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
return m[0]
|
|
|
|
}
|
|
|
|
|
|
|
|
// does leak m
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo99(m *[1]*int) []*int { // ERROR "leaking param: m"
|
2011-08-25 07:26:13 -06:00
|
|
|
return m[:]
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak m
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo100(m []*int) *int { // ERROR "m does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
for _, v := range m {
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// does leak m
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo101(m [1]*int) *int { // ERROR "leaking param: m"
|
2011-08-25 07:26:13 -06:00
|
|
|
for _, v := range m {
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2011-08-28 10:05:00 -06:00
|
|
|
// does not leak m
|
|
|
|
func foo101a(m [1]*int) *int { // ERROR "m does not escape"
|
2011-10-08 11:37:06 -06:00
|
|
|
for i := range m { // ERROR "moved to heap: i"
|
2011-11-01 09:02:43 -06:00
|
|
|
return &i // ERROR "&i escapes to heap"
|
2011-08-28 10:05:00 -06:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2011-08-25 07:26:13 -06:00
|
|
|
// does leak x
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo102(m []*int, x *int) { // ERROR "m does not escape" "leaking param: x"
|
2011-08-25 07:26:13 -06:00
|
|
|
m[0] = x
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak x
|
2011-08-28 10:05:00 -06:00
|
|
|
func foo103(m [1]*int, x *int) { // ERROR "m does not escape" "x does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
m[0] = x
|
|
|
|
}
|
|
|
|
|
|
|
|
var y []*int
|
|
|
|
|
|
|
|
// does not leak x
|
2011-11-01 09:02:43 -06:00
|
|
|
func foo104(x []*int) { // ERROR "x does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
copy(y, x)
|
|
|
|
}
|
|
|
|
|
|
|
|
// does not leak x
|
2011-11-01 09:02:43 -06:00
|
|
|
func foo105(x []*int) { // ERROR "x does not escape"
|
2011-08-25 07:26:13 -06:00
|
|
|
_ = append(y, x...)
|
|
|
|
}
|
|
|
|
|
|
|
|
// does leak x
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo106(x *int) { // ERROR "leaking param: x"
|
2011-08-25 07:26:13 -06:00
|
|
|
_ = append(y, x)
|
|
|
|
}
|
2011-08-28 10:05:00 -06:00
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo107(x *int) map[*int]*int { // ERROR "leaking param: x"
|
|
|
|
return map[*int]*int{x: nil} // ERROR "map.* literal escapes to heap"
|
2011-08-28 10:05:00 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo108(x *int) map[*int]*int { // ERROR "leaking param: x"
|
|
|
|
return map[*int]*int{nil: x} // ERROR "map.* literal escapes to heap"
|
2011-08-28 10:05:00 -06:00
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo109(x *int) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
m := map[*int]*int{x: nil} // ERROR "map.* literal does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
for k, _ := range m {
|
|
|
|
return k
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo110(x *int) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
m := map[*int]*int{nil: x} // ERROR "map.* literal does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
return m[nil]
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo111(x *int) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
m := []*int{x} // ERROR "\[\]\*int literal does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
return m[0]
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo112(x *int) *int { // ERROR "leaking param: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
m := [1]*int{x}
|
|
|
|
return m[0]
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo113(x *int) *int { // ERROR "leaking param: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
m := Bar{ii: x}
|
|
|
|
return m.ii
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo114(x *int) *int { // ERROR "leaking param: x"
|
2011-11-01 09:02:43 -06:00
|
|
|
m := &Bar{ii: x} // ERROR "&Bar literal does not escape"
|
2011-08-28 10:05:00 -06:00
|
|
|
return m.ii
|
|
|
|
}
|
|
|
|
|
2011-10-08 11:37:06 -06:00
|
|
|
func foo115(x *int) *int { // ERROR "leaking param: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
return (*int)(unsafe.Pointer(uintptr(unsafe.Pointer(x)) + 1))
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo116(b bool) *int {
|
|
|
|
if b {
|
2011-11-01 09:02:43 -06:00
|
|
|
x := 1 // ERROR "moved to heap: x"
|
|
|
|
return &x // ERROR "&x escapes to heap"
|
2011-08-28 10:05:00 -06:00
|
|
|
} else {
|
2011-11-01 09:02:43 -06:00
|
|
|
y := 1 // ERROR "moved to heap: y"
|
|
|
|
return &y // ERROR "&y escapes to heap"
|
2011-08-28 10:05:00 -06:00
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2011-11-01 09:02:43 -06:00
|
|
|
func foo117(unknown func(interface{})) { // ERROR "unknown does not escape"
|
|
|
|
x := 1 // ERROR "moved to heap: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
unknown(&x) // ERROR "&x escapes to heap"
|
|
|
|
}
|
|
|
|
|
2011-11-01 09:02:43 -06:00
|
|
|
func foo118(unknown func(*int)) { // ERROR "unknown does not escape"
|
|
|
|
x := 1 // ERROR "moved to heap: x"
|
2011-08-28 10:05:00 -06:00
|
|
|
unknown(&x) // ERROR "&x escapes to heap"
|
|
|
|
}
|
2011-08-28 21:29:34 -06:00
|
|
|
|
|
|
|
func external(*int)
|
|
|
|
|
2011-11-01 09:02:43 -06:00
|
|
|
func foo119(x *int) { // ERROR "leaking param: x"
|
2011-08-28 21:29:34 -06:00
|
|
|
external(x)
|
|
|
|
}
|
2011-09-01 11:44:46 -06:00
|
|
|
|
|
|
|
func foo120() {
|
|
|
|
// formerly exponential time analysis
|
|
|
|
L1:
|
|
|
|
L2:
|
|
|
|
L3:
|
|
|
|
L4:
|
|
|
|
L5:
|
|
|
|
L6:
|
|
|
|
L7:
|
|
|
|
L8:
|
|
|
|
L9:
|
|
|
|
L10:
|
|
|
|
L11:
|
|
|
|
L12:
|
|
|
|
L13:
|
|
|
|
L14:
|
|
|
|
L15:
|
|
|
|
L16:
|
|
|
|
L17:
|
|
|
|
L18:
|
|
|
|
L19:
|
|
|
|
L20:
|
|
|
|
L21:
|
|
|
|
L22:
|
|
|
|
L23:
|
|
|
|
L24:
|
|
|
|
L25:
|
|
|
|
L26:
|
|
|
|
L27:
|
|
|
|
L28:
|
|
|
|
L29:
|
|
|
|
L30:
|
|
|
|
L31:
|
|
|
|
L32:
|
|
|
|
L33:
|
|
|
|
L34:
|
|
|
|
L35:
|
|
|
|
L36:
|
|
|
|
L37:
|
|
|
|
L38:
|
|
|
|
L39:
|
|
|
|
L40:
|
|
|
|
L41:
|
|
|
|
L42:
|
|
|
|
L43:
|
|
|
|
L44:
|
|
|
|
L45:
|
|
|
|
L46:
|
|
|
|
L47:
|
|
|
|
L48:
|
|
|
|
L49:
|
|
|
|
L50:
|
|
|
|
L51:
|
|
|
|
L52:
|
|
|
|
L53:
|
|
|
|
L54:
|
|
|
|
L55:
|
|
|
|
L56:
|
|
|
|
L57:
|
|
|
|
L58:
|
|
|
|
L59:
|
|
|
|
L60:
|
|
|
|
L61:
|
|
|
|
L62:
|
|
|
|
L63:
|
|
|
|
L64:
|
|
|
|
L65:
|
|
|
|
L66:
|
|
|
|
L67:
|
|
|
|
L68:
|
|
|
|
L69:
|
|
|
|
L70:
|
|
|
|
L71:
|
|
|
|
L72:
|
|
|
|
L73:
|
|
|
|
L74:
|
|
|
|
L75:
|
|
|
|
L76:
|
|
|
|
L77:
|
|
|
|
L78:
|
|
|
|
L79:
|
|
|
|
L80:
|
|
|
|
L81:
|
|
|
|
L82:
|
|
|
|
L83:
|
|
|
|
L84:
|
|
|
|
L85:
|
|
|
|
L86:
|
|
|
|
L87:
|
|
|
|
L88:
|
|
|
|
L89:
|
|
|
|
L90:
|
|
|
|
L91:
|
|
|
|
L92:
|
|
|
|
L93:
|
|
|
|
L94:
|
|
|
|
L95:
|
|
|
|
L96:
|
|
|
|
L97:
|
|
|
|
L98:
|
|
|
|
L99:
|
|
|
|
L100:
|
|
|
|
// use the labels to silence compiler errors
|
|
|
|
goto L1
|
|
|
|
goto L2
|
|
|
|
goto L3
|
|
|
|
goto L4
|
|
|
|
goto L5
|
|
|
|
goto L6
|
|
|
|
goto L7
|
|
|
|
goto L8
|
|
|
|
goto L9
|
|
|
|
goto L10
|
|
|
|
goto L11
|
|
|
|
goto L12
|
|
|
|
goto L13
|
|
|
|
goto L14
|
|
|
|
goto L15
|
|
|
|
goto L16
|
|
|
|
goto L17
|
|
|
|
goto L18
|
|
|
|
goto L19
|
|
|
|
goto L20
|
|
|
|
goto L21
|
|
|
|
goto L22
|
|
|
|
goto L23
|
|
|
|
goto L24
|
|
|
|
goto L25
|
|
|
|
goto L26
|
|
|
|
goto L27
|
|
|
|
goto L28
|
|
|
|
goto L29
|
|
|
|
goto L30
|
|
|
|
goto L31
|
|
|
|
goto L32
|
|
|
|
goto L33
|
|
|
|
goto L34
|
|
|
|
goto L35
|
|
|
|
goto L36
|
|
|
|
goto L37
|
|
|
|
goto L38
|
|
|
|
goto L39
|
|
|
|
goto L40
|
|
|
|
goto L41
|
|
|
|
goto L42
|
|
|
|
goto L43
|
|
|
|
goto L44
|
|
|
|
goto L45
|
|
|
|
goto L46
|
|
|
|
goto L47
|
|
|
|
goto L48
|
|
|
|
goto L49
|
|
|
|
goto L50
|
|
|
|
goto L51
|
|
|
|
goto L52
|
|
|
|
goto L53
|
|
|
|
goto L54
|
|
|
|
goto L55
|
|
|
|
goto L56
|
|
|
|
goto L57
|
|
|
|
goto L58
|
|
|
|
goto L59
|
|
|
|
goto L60
|
|
|
|
goto L61
|
|
|
|
goto L62
|
|
|
|
goto L63
|
|
|
|
goto L64
|
|
|
|
goto L65
|
|
|
|
goto L66
|
|
|
|
goto L67
|
|
|
|
goto L68
|
|
|
|
goto L69
|
|
|
|
goto L70
|
|
|
|
goto L71
|
|
|
|
goto L72
|
|
|
|
goto L73
|
|
|
|
goto L74
|
|
|
|
goto L75
|
|
|
|
goto L76
|
|
|
|
goto L77
|
|
|
|
goto L78
|
|
|
|
goto L79
|
|
|
|
goto L80
|
|
|
|
goto L81
|
|
|
|
goto L82
|
|
|
|
goto L83
|
|
|
|
goto L84
|
|
|
|
goto L85
|
|
|
|
goto L86
|
|
|
|
goto L87
|
|
|
|
goto L88
|
|
|
|
goto L89
|
|
|
|
goto L90
|
|
|
|
goto L91
|
|
|
|
goto L92
|
|
|
|
goto L93
|
|
|
|
goto L94
|
|
|
|
goto L95
|
|
|
|
goto L96
|
|
|
|
goto L97
|
|
|
|
goto L98
|
|
|
|
goto L99
|
|
|
|
goto L100
|
|
|
|
}
|
2011-11-01 09:02:43 -06:00
|
|
|
|
|
|
|
func foo121() {
|
|
|
|
for i := 0; i < 10; i++ {
|
|
|
|
defer myprint(nil, i) // ERROR "[.][.][.] argument escapes to heap"
|
|
|
|
go myprint(nil, i) // ERROR "[.][.][.] argument escapes to heap"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// same as foo121 but check across import
|
|
|
|
func foo121b() {
|
|
|
|
for i := 0; i < 10; i++ {
|
|
|
|
defer fmt.Printf("%d", i) // ERROR "[.][.][.] argument escapes to heap"
|
|
|
|
go fmt.Printf("%d", i) // ERROR "[.][.][.] argument escapes to heap"
|
|
|
|
}
|
|
|
|
}
|
2011-12-15 09:35:59 -07:00
|
|
|
|
|
|
|
// a harmless forward jump
|
|
|
|
func foo122() {
|
|
|
|
var i *int
|
|
|
|
|
|
|
|
goto L1
|
|
|
|
L1:
|
2012-04-23 13:39:01 -06:00
|
|
|
i = new(int) // ERROR "new.int. does not escape"
|
2011-12-15 09:35:59 -07:00
|
|
|
_ = i
|
|
|
|
}
|
|
|
|
|
|
|
|
// a backward jump, increases loopdepth
|
|
|
|
func foo123() {
|
|
|
|
var i *int
|
|
|
|
|
|
|
|
L1:
|
2012-04-23 13:39:01 -06:00
|
|
|
i = new(int) // ERROR "new.int. escapes to heap"
|
2011-12-15 09:35:59 -07:00
|
|
|
|
|
|
|
goto L1
|
|
|
|
_ = i
|
2012-01-12 04:08:40 -07:00
|
|
|
}
|
2012-04-23 13:39:01 -06:00
|
|
|
|
2012-12-20 15:27:28 -07:00
|
|
|
func foo124(x **int) { // ERROR "x does not escape"
|
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes"
|
|
|
|
func() { // ERROR "func literal does not escape"
|
|
|
|
*x = p // ERROR "leaking closure reference p"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
2012-12-20 15:27:28 -07:00
|
|
|
func foo125(ch chan *int) { // ERROR "does not escape"
|
|
|
|
var i int // ERROR "moved to heap"
|
|
|
|
p := &i // ERROR "&i escapes to heap"
|
|
|
|
func() { // ERROR "func literal does not escape"
|
|
|
|
ch <- p // ERROR "leaking closure reference p"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo126() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var px *int // loopdepth 0
|
2012-04-23 13:39:01 -06:00
|
|
|
for {
|
|
|
|
// loopdepth 1
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
px = &i // ERROR "&i escapes"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
2013-09-17 16:24:54 -06:00
|
|
|
_ = px
|
2012-04-23 13:39:01 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
var px *int
|
|
|
|
|
|
|
|
func foo127() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
q := p
|
|
|
|
px = q
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo128() {
|
|
|
|
var i int
|
|
|
|
p := &i // ERROR "&i does not escape"
|
|
|
|
q := p
|
|
|
|
_ = q
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo129() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
q := p // ERROR "leaking closure reference p"
|
|
|
|
func() { // ERROR "func literal does not escape"
|
|
|
|
r := q // ERROR "leaking closure reference q"
|
2012-04-23 13:39:01 -06:00
|
|
|
px = r
|
|
|
|
}()
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo130() {
|
|
|
|
for {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
px = &i // ERROR "&i escapes" "leaking closure reference i"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo131() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
px = &i // ERROR "&i escapes" "leaking closure reference i"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo132() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap"
|
|
|
|
go func() { // ERROR "func literal escapes to heap"
|
|
|
|
px = &i // ERROR "&i escapes" "leaking closure reference i"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo133() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap"
|
|
|
|
defer func() { // ERROR "func literal does not escape"
|
|
|
|
px = &i // ERROR "&i escapes" "leaking closure reference i"
|
2012-04-23 13:39:01 -06:00
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo134() {
|
|
|
|
var i int
|
|
|
|
p := &i // ERROR "&i does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-04-23 13:39:01 -06:00
|
|
|
q := p
|
2012-12-20 15:27:28 -07:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-04-23 13:39:01 -06:00
|
|
|
r := q
|
|
|
|
_ = r
|
|
|
|
}()
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo135() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes to heap" "moved to heap: p"
|
|
|
|
go func() { // ERROR "func literal escapes to heap"
|
|
|
|
q := p // ERROR "&p escapes to heap"
|
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-04-23 13:39:01 -06:00
|
|
|
r := q
|
|
|
|
_ = r
|
|
|
|
}()
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo136() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes to heap" "moved to heap: p"
|
|
|
|
go func() { // ERROR "func literal escapes to heap"
|
|
|
|
q := p // ERROR "&p escapes to heap" "leaking closure reference p"
|
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-04-23 13:39:01 -06:00
|
|
|
r := q // ERROR "leaking closure reference q"
|
|
|
|
px = r
|
|
|
|
}()
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo137() {
|
2012-12-20 15:27:28 -07:00
|
|
|
var i int // ERROR "moved to heap: i"
|
|
|
|
p := &i // ERROR "&i escapes to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
func() { // ERROR "func literal does not escape"
|
2012-12-20 15:27:28 -07:00
|
|
|
q := p // ERROR "leaking closure reference p" "moved to heap: q"
|
2012-04-23 13:39:01 -06:00
|
|
|
go func() { // ERROR "func literal escapes to heap"
|
2012-12-20 15:27:28 -07:00
|
|
|
r := q // ERROR "&q escapes to heap"
|
2012-04-23 13:39:01 -06:00
|
|
|
_ = r
|
|
|
|
}()
|
|
|
|
}()
|
|
|
|
}
|
2012-09-24 13:53:12 -06:00
|
|
|
|
|
|
|
func foo138() *byte {
|
|
|
|
type T struct {
|
|
|
|
x [1]byte
|
|
|
|
}
|
2012-12-20 15:27:28 -07:00
|
|
|
t := new(T) // ERROR "new.T. escapes to heap"
|
2012-09-24 13:53:12 -06:00
|
|
|
return &t.x[0] // ERROR "&t.x.0. escapes to heap"
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo139() *byte {
|
|
|
|
type T struct {
|
|
|
|
x struct {
|
|
|
|
y byte
|
|
|
|
}
|
|
|
|
}
|
2012-12-20 15:27:28 -07:00
|
|
|
t := new(T) // ERROR "new.T. escapes to heap"
|
2012-09-24 13:53:12 -06:00
|
|
|
return &t.x.y // ERROR "&t.x.y escapes to heap"
|
|
|
|
}
|
2013-02-04 20:48:31 -07:00
|
|
|
|
|
|
|
// issue 4751
|
|
|
|
func foo140() interface{} {
|
|
|
|
type T struct {
|
|
|
|
X string
|
|
|
|
}
|
|
|
|
type U struct {
|
|
|
|
X string
|
|
|
|
T *T
|
|
|
|
}
|
|
|
|
t := &T{} // ERROR "&T literal escapes to heap"
|
|
|
|
return U{
|
|
|
|
X: t.X,
|
|
|
|
T: t,
|
|
|
|
}
|
|
|
|
}
|
2013-02-05 05:00:38 -07:00
|
|
|
|
|
|
|
//go:noescape
|
|
|
|
|
|
|
|
func F1([]byte)
|
|
|
|
|
|
|
|
func F2([]byte)
|
|
|
|
|
|
|
|
//go:noescape
|
|
|
|
|
|
|
|
func F3(x []byte) // ERROR "F3 x does not escape"
|
|
|
|
|
|
|
|
func F4(x []byte)
|
|
|
|
|
|
|
|
func G() {
|
|
|
|
var buf1 [10]byte
|
|
|
|
F1(buf1[:]) // ERROR "buf1 does not escape"
|
2014-05-09 13:40:45 -06:00
|
|
|
|
2013-02-05 05:00:38 -07:00
|
|
|
var buf2 [10]byte // ERROR "moved to heap: buf2"
|
2014-05-09 13:40:45 -06:00
|
|
|
F2(buf2[:]) // ERROR "buf2 escapes to heap"
|
2013-02-05 05:00:38 -07:00
|
|
|
|
|
|
|
var buf3 [10]byte
|
|
|
|
F3(buf3[:]) // ERROR "buf3 does not escape"
|
2014-05-09 13:40:45 -06:00
|
|
|
|
2013-02-05 05:00:38 -07:00
|
|
|
var buf4 [10]byte // ERROR "moved to heap: buf4"
|
2014-05-09 13:40:45 -06:00
|
|
|
F4(buf4[:]) // ERROR "buf4 escapes to heap"
|
2013-02-05 05:00:38 -07:00
|
|
|
}
|
2013-03-20 21:53:27 -06:00
|
|
|
|
|
|
|
type Tm struct {
|
|
|
|
x int
|
|
|
|
}
|
|
|
|
|
|
|
|
func (t *Tm) M() { // ERROR "t does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo141() {
|
|
|
|
var f func()
|
2014-05-09 13:40:45 -06:00
|
|
|
|
2013-03-20 21:53:27 -06:00
|
|
|
t := new(Tm) // ERROR "escapes to heap"
|
2014-05-09 13:40:45 -06:00
|
|
|
f = t.M // ERROR "t.M does not escape"
|
2013-03-20 21:53:27 -06:00
|
|
|
_ = f
|
|
|
|
}
|
|
|
|
|
|
|
|
var gf func()
|
|
|
|
|
|
|
|
func foo142() {
|
|
|
|
t := new(Tm) // ERROR "escapes to heap"
|
2014-05-09 13:40:45 -06:00
|
|
|
gf = t.M // ERROR "t.M escapes to heap"
|
2013-03-20 21:53:27 -06:00
|
|
|
}
|
2013-05-22 14:45:38 -06:00
|
|
|
|
|
|
|
// issue 3888.
|
|
|
|
func foo143() {
|
|
|
|
for i := 0; i < 1000; i++ {
|
|
|
|
func() { // ERROR "func literal does not escape"
|
|
|
|
for i := 0; i < 1; i++ {
|
|
|
|
var t Tm
|
|
|
|
t.M() // ERROR "t does not escape"
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
}
|
2013-06-25 15:28:49 -06:00
|
|
|
|
|
|
|
// issue 5773
|
|
|
|
// Check that annotations take effect regardless of whether they
|
|
|
|
// are before or after the use in the source code.
|
|
|
|
|
|
|
|
//go:noescape
|
|
|
|
|
|
|
|
func foo144a(*int)
|
|
|
|
|
|
|
|
func foo144() {
|
|
|
|
var x int
|
|
|
|
foo144a(&x) // ERROR "&x does not escape"
|
|
|
|
var y int
|
|
|
|
foo144b(&y) // ERROR "&y does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
//go:noescape
|
|
|
|
|
|
|
|
func foo144b(*int)
|
2014-02-13 12:04:43 -07:00
|
|
|
|
|
|
|
// issue 7313: for loop init should not be treated as "in loop"
|
|
|
|
|
|
|
|
type List struct {
|
|
|
|
Next *List
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo145(l List) { // ERROR "l does not escape"
|
|
|
|
var p *List
|
|
|
|
for p = &l; p.Next != nil; p = p.Next { // ERROR "&l does not escape"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo146(l List) { // ERROR "l does not escape"
|
|
|
|
var p *List
|
|
|
|
p = &l // ERROR "&l does not escape"
|
|
|
|
for ; p.Next != nil; p = p.Next {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo147(l List) { // ERROR "l does not escape"
|
|
|
|
var p *List
|
|
|
|
p = &l // ERROR "&l does not escape"
|
|
|
|
for p.Next != nil {
|
|
|
|
p = p.Next
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo148(l List) { // ERROR " l does not escape"
|
|
|
|
for p := &l; p.Next != nil; p = p.Next { // ERROR "&l does not escape"
|
|
|
|
}
|
|
|
|
}
|
2014-02-13 17:59:09 -07:00
|
|
|
|
|
|
|
// related: address of variable should have depth of variable, not of loop
|
|
|
|
|
|
|
|
func foo149(l List) { // ERROR " l does not escape"
|
|
|
|
var p *List
|
|
|
|
for {
|
|
|
|
for p = &l; p.Next != nil; p = p.Next { // ERROR "&l does not escape"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2014-05-09 13:40:45 -06:00
|
|
|
|
|
|
|
// issue 7934: missed ... if element type had no pointers
|
|
|
|
|
|
|
|
var save150 []byte
|
|
|
|
|
|
|
|
func foo150(x ...byte) { // ERROR "leaking param: x"
|
|
|
|
save150 = x
|
|
|
|
}
|
|
|
|
|
|
|
|
func bar150() {
|
|
|
|
foo150(1, 2, 3) // ERROR "[.][.][.] argument escapes to heap"
|
|
|
|
}
|
2014-05-12 12:45:05 -06:00
|
|
|
|
|
|
|
// issue 7931: bad handling of slice of array
|
|
|
|
|
|
|
|
var save151 *int
|
|
|
|
|
|
|
|
func foo151(x *int) { // ERROR "leaking param: x"
|
|
|
|
save151 = x
|
|
|
|
}
|
|
|
|
|
|
|
|
func bar151() {
|
|
|
|
var a [64]int // ERROR "moved to heap: a"
|
|
|
|
a[4] = 101
|
|
|
|
foo151(&(&a)[4:8][0]) // ERROR "&\(&a\)\[4:8\]\[0\] escapes to heap" "&a escapes to heap"
|
|
|
|
}
|
|
|
|
|
|
|
|
func bar151b() {
|
|
|
|
var a [10]int // ERROR "moved to heap: a"
|
|
|
|
b := a[:] // ERROR "a escapes to heap"
|
|
|
|
foo151(&b[4:8][0]) // ERROR "&b\[4:8\]\[0\] escapes to heap"
|
|
|
|
}
|
|
|
|
|
|
|
|
func bar151c() {
|
|
|
|
var a [64]int // ERROR "moved to heap: a"
|
|
|
|
a[4] = 101
|
|
|
|
foo151(&(&a)[4:8:8][0]) // ERROR "&\(&a\)\[4:8:8\]\[0\] escapes to heap" "&a escapes to heap"
|
|
|
|
}
|
|
|
|
|
|
|
|
func bar151d() {
|
|
|
|
var a [10]int // ERROR "moved to heap: a"
|
|
|
|
b := a[:] // ERROR "a escapes to heap"
|
|
|
|
foo151(&b[4:8:8][0]) // ERROR "&b\[4:8:8\]\[0\] escapes to heap"
|
|
|
|
}
|
cmd/gc: fix escape analysis of func returning indirect of parameter
I introduced this bug when I changed the escape
analysis to run in phases based on call graph
dependency order, in order to be more precise about
inputs escaping back to outputs (functions returning
their arguments).
Given
func f(z **int) *int { return *z }
we were tagging the function as 'z does not escape
and is not returned', which is all true, but not
enough information.
If used as:
var x int
p := &x
q := &p
leak(f(q))
then the compiler might try to keep x, p, and q all
on the stack, since (according to the recorded
information) nothing interesting ends up being
passed to leak.
In fact since f returns *q = p, &x is passed to leak
and x needs to be heap allocated.
To trigger the bug, you need a chain that the
compiler wants to keep on the stack (like x, p, q
above), and you need a function that returns an
indirect of its argument, and you need to pass the
head of the chain to that function. This doesn't
come up very often: this bug has been present since
June 2012 (between Go 1 and Go 1.1) and we haven't
seen it until now. It helps that most functions that
return indirects are getters that are simple enough
to be inlined, avoiding the bug.
Earlier versions of Go also had the benefit that if
&x really wasn't used beyond x's lifetime, nothing
broke if you put &x in a heap-allocated structure
accidentally. With the new stack copying, though,
heap-allocated structures containing &x are not
updated when the stack is copied and x moves,
leading to crashes in Go 1.3 that were not crashes
in Go 1.2 or Go 1.1.
The fix is in two parts.
First, in the analysis of a function, recognize when
a value obtained via indirect of a parameter ends up
being returned. Mark those parameters as having
content escape back to the return results (but we
don't bother to write down which result).
Second, when using the analysis to analyze, say,
f(q), mark parameters with content escaping as
having any indirections escape to the heap. (We
don't bother trying to match the content to the
return value.)
The fix could be less precise (simpler).
In the first part we might mark all content-escaping
parameters as plain escaping, and then the second
part could be dropped. Or we might assume that when
calling f(q) all the things pointed at by q escape
always (for any f and q).
The fix could also be more precise (more complex).
We might record the specific mapping from parameter
to result along with the number of indirects from the
parameter to the thing being returned as the result,
and then at the call sites we could set up exactly the
right graph for the called function. That would make
notleaks(f(q)) be able to keep x on the stack, because
the reuslt of f(q) isn't passed to anything that leaks it.
The less precise the fix, the more stack allocations
become heap allocations.
This fix is exactly as precise as it needs to be so that
none of the current stack allocations in the standard
library turn into heap allocations.
Fixes #8120.
LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews, khr, r
https://golang.org/cl/102040046
2014-06-03 09:35:59 -06:00
|
|
|
|
|
|
|
// issue 8120
|
|
|
|
|
|
|
|
type U struct {
|
|
|
|
s *string
|
|
|
|
}
|
|
|
|
|
|
|
|
func (u *U) String() *string { // ERROR "leaking param u content to result ~r0"
|
|
|
|
return u.s
|
|
|
|
}
|
|
|
|
|
|
|
|
type V struct {
|
|
|
|
s *string
|
|
|
|
}
|
|
|
|
|
|
|
|
func NewV(u U) *V { // ERROR "leaking param: u"
|
|
|
|
return &V{u.String()} // ERROR "&V literal escapes to heap" "u does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
func foo152() {
|
|
|
|
a := "a" // ERROR "moved to heap: a"
|
|
|
|
u := U{&a} // ERROR "&a escapes to heap"
|
|
|
|
v := NewV(u)
|
|
|
|
println(v)
|
|
|
|
}
|
2014-06-11 09:48:47 -06:00
|
|
|
|
|
|
|
// issue 8176 - &x in type switch body not marked as escaping
|
|
|
|
|
|
|
|
func foo153(v interface{}) *int { // ERROR "leaking param: v"
|
|
|
|
switch x := v.(type) {
|
|
|
|
case int: // ERROR "moved to heap: x"
|
|
|
|
return &x // ERROR "&x escapes to heap"
|
|
|
|
}
|
|
|
|
panic(0)
|
|
|
|
}
|
2014-06-11 12:21:06 -06:00
|
|
|
|
|
|
|
// issue 8185 - &result escaping into result
|
|
|
|
|
|
|
|
func f() (x int, y *int) { // ERROR "moved to heap: x"
|
|
|
|
y = &x // ERROR "&x escapes to heap"
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
func g() (x interface{}) { // ERROR "moved to heap: x"
|
|
|
|
x = &x // ERROR "&x escapes to heap"
|
|
|
|
return
|
|
|
|
}
|