qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 10:44:47 -07:00
Code Releases Activity
dbc83e6dc0
go/internal/lsp/testdata/bad/bad1.go

34 lines
2.2 KiB
Go
Raw Normal View History

internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
// +build go1.11
internal/lsp: use packagestest markers to test diagnostics Add some basic tests for diagnostics using the new go/packages/packagestest framework. Change-Id: I6a7bfba6c392928a9eb123ab71ceb73785c12600 Reviewed-on: https://go-review.googlesource.com/c/145697 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-10-29 16:12:41 -06:00
package bad
internal/lsp/source: fix typeIsValid() inf recursion typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-19 07:18:24 -07:00
// See #36637
type stateFunc func() stateFunc //@item(stateFunc, "stateFunc", "func() stateFunc", "type")
internal/lsp: refactor error handling code in type-checking This change adds a source.Error type which is used to collect the error information that comes out of the loading, parsing, and type checking stages. We also add specific sources per-error, rather than having them all be labeled as "LSP". This change will enable follow-ups that do a better job of extracting error ranges. Change-Id: I3fbb5e42d66aa2c5bb1b2f41d1eadfc45f3a749b Reviewed-on: https://go-review.googlesource.com/c/tools/+/202298 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-10-20 17:57:03 -06:00
var a unknown //@item(global_a, "a", "unknown", "var"),diag("unknown", "compiler", "undeclared name: unknown")
internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
internal/lsp: move function signature into detail instead of label Fixes golang/go#32414 Change-Id: If08e655d7a0e29b0865c13d8377e98be01cf24c5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/184777 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-07-02 16:10:05 -06:00
func random() int { //@item(random, "random", "func() int", "func")
internal/lsp/source: fix typeIsValid() inf recursion typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-19 07:18:24 -07:00
//@complete("", global_a, bob, random, random2, random3, stateFunc, stuff)
internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
return 0
}
internal/lsp: remove duplicated enums source.DiagnosticSeverity and source.CompletionItemKind are duplicated and not worth maintaining. Change-Id: I8d6c8621a227855309c0977da59d8c9fa53617bf Reviewed-on: https://go-review.googlesource.com/c/tools/+/197177 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-24 22:46:57 -06:00
func random2(y int) int { //@item(random2, "random2", "func(y int) int", "func"),item(bad_y_param, "y", "int", "var")
internal/lsp/source: fix all types in resolveInvalid This CL teaches lsp to report `**T` instead of `**invalid type`, `func (badParam) badResult` instead of `func (invalid type) invalid type`, etc. To do that, we need to detect "invalid type" inside any part of a type. I've added typeIsValid() function for that. To simplify type formating code in resolveInvalid(), formatNode function is added that can also format *ast.StarExpr (of any depth). Since we already used AST printer in the same file, I added formatNode function that is now used in both places. While at it, replaced bytes.Buffer to strings.Builder there. Change-Id: I3bb84c58c417b175cceefb410e238c48425f7cee Reviewed-on: https://go-review.googlesource.com/c/tools/+/210357 Run-TryBot: Iskander Sharipov <quasilyte@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-06 10:59:56 -07:00
x := 6 //@item(x, "x", "int", "var"),diag("x", "compiler", "x declared but not used")
var q blah //@item(q, "q", "blah", "var"),diag("q", "compiler", "q declared but not used"),diag("blah", "compiler", "undeclared name: blah")
var t **blob //@item(t, "t", "**blob", "var"),diag("t", "compiler", "t declared but not used"),diag("blob", "compiler", "undeclared name: blob")
internal/lsp/source: fix typeIsValid() inf recursion typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-19 07:18:24 -07:00
//@complete("", q, t, x, bad_y_param, global_a, bob, random, random2, random3, stateFunc, stuff)
internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
internal/lsp: use packagestest markers to test diagnostics Add some basic tests for diagnostics using the new go/packages/packagestest framework. Change-Id: I6a7bfba6c392928a9eb123ab71ceb73785c12600 Reviewed-on: https://go-review.googlesource.com/c/145697 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-10-29 16:12:41 -06:00
return y
}
internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
internal/lsp: remove duplicated enums source.DiagnosticSeverity and source.CompletionItemKind are duplicated and not worth maintaining. Change-Id: I8d6c8621a227855309c0977da59d8c9fa53617bf Reviewed-on: https://go-review.googlesource.com/c/tools/+/197177 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-24 22:46:57 -06:00
func random3(y ...int) { //@item(random3, "random3", "func(y ...int)", "func"),item(y_variadic_param, "y", "[]int", "var")
internal/lsp/source: fix typeIsValid() inf recursion typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-19 07:18:24 -07:00
//@complete("", y_variadic_param, global_a, bob, random, random2, random3, stateFunc, stuff)
internal/lsp/source: fix all types in resolveInvalid This CL teaches lsp to report `**T` instead of `**invalid type`, `func (badParam) badResult` instead of `func (invalid type) invalid type`, etc. To do that, we need to detect "invalid type" inside any part of a type. I've added typeIsValid() function for that. To simplify type formating code in resolveInvalid(), formatNode function is added that can also format *ast.StarExpr (of any depth). Since we already used AST printer in the same file, I added formatNode function that is now used in both places. While at it, replaced bytes.Buffer to strings.Builder there. Change-Id: I3bb84c58c417b175cceefb410e238c48425f7cee Reviewed-on: https://go-review.googlesource.com/c/tools/+/210357 Run-TryBot: Iskander Sharipov <quasilyte@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-06 10:59:56 -07:00
var ch chan (favType1) //@item(ch, "ch", "chan (favType1)", "var"),diag("ch", "compiler", "ch declared but not used"),diag("favType1", "compiler", "undeclared name: favType1")
var m map[keyType]int //@item(m, "m", "map[keyType]int", "var"),diag("m", "compiler", "m declared but not used"),diag("keyType", "compiler", "undeclared name: keyType")
var arr []favType2 //@item(arr, "arr", "[]favType2", "var"),diag("arr", "compiler", "arr declared but not used"),diag("favType2", "compiler", "undeclared name: favType2")
var fn1 func() badResult //@item(fn1, "fn1", "func() badResult", "var"),diag("fn1", "compiler", "fn1 declared but not used"),diag("badResult", "compiler", "undeclared name: badResult")
var fn2 func(badParam) //@item(fn2, "fn2", "func(badParam)", "var"),diag("fn2", "compiler", "fn2 declared but not used"),diag("badParam", "compiler", "undeclared name: badParam")
internal/lsp/source: fix typeIsValid() inf recursion typeIsValid() intended to stop on a named type, but since we called Underlying(), switch case never caught any named type. To avoid that, do an early check. Fixes golang/go#36637 Change-Id: I2700afbb8f9678b4542e2e7dccc3be59b1d9ebdf Reviewed-on: https://go-review.googlesource.com/c/tools/+/215238 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-01-19 07:18:24 -07:00
//@complete("", arr, ch, fn1, fn2, m, y_variadic_param, global_a, bob, random, random2, random3, stateFunc, stuff)
internal/lsp: add more testdata for completion and diagnostics Change-Id: I2a73e51b60f76a2af0f8ff4d34220b551e0cd378 Reviewed-on: https://go-review.googlesource.com/c/150041 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2018-11-13 09:13:53 -07:00
}
Copy Permalink