2012-03-21 12:14:44 -06:00
|
|
|
// skip
|
2012-02-20 20:28:49 -07:00
|
|
|
|
2016-04-10 15:32:26 -06:00
|
|
|
// Copyright 2012 The Go Authors. All rights reserved.
|
2012-02-20 20:28:49 -07:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
// Run runs tests in the test directory.
|
|
|
|
package main
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"errors"
|
|
|
|
"flag"
|
|
|
|
"fmt"
|
2015-06-04 00:21:30 -06:00
|
|
|
"hash/fnv"
|
|
|
|
"io"
|
2020-11-04 16:20:17 -07:00
|
|
|
"io/fs"
|
2012-02-20 20:28:49 -07:00
|
|
|
"io/ioutil"
|
|
|
|
"log"
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
2012-09-23 11:16:14 -06:00
|
|
|
"path"
|
2012-02-20 20:28:49 -07:00
|
|
|
"path/filepath"
|
|
|
|
"regexp"
|
|
|
|
"runtime"
|
|
|
|
"sort"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
2013-12-10 12:02:42 -07:00
|
|
|
"time"
|
2013-08-13 10:25:41 -06:00
|
|
|
"unicode"
|
2012-02-20 20:28:49 -07:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
2013-01-11 23:52:52 -07:00
|
|
|
verbose = flag.Bool("v", false, "verbose. if set, parallelism is set to 1.")
|
2016-03-10 22:10:52 -07:00
|
|
|
keep = flag.Bool("k", false, "keep. keep temporary directory.")
|
2013-01-11 23:52:52 -07:00
|
|
|
numParallel = flag.Int("n", runtime.NumCPU(), "number of parallel tests to run")
|
|
|
|
summary = flag.Bool("summary", false, "show summary of results")
|
2019-09-26 11:25:04 -06:00
|
|
|
allCodegen = flag.Bool("all_codegen", defaultAllCodeGen(), "run all goos/goarch for codegen")
|
2013-01-11 23:52:52 -07:00
|
|
|
showSkips = flag.Bool("show_skips", false, "show skipped tests")
|
2015-10-26 15:34:06 -06:00
|
|
|
runSkips = flag.Bool("run_skips", false, "run skipped tests (ignore skip and build tags)")
|
2015-10-26 19:54:19 -06:00
|
|
|
linkshared = flag.Bool("linkshared", false, "")
|
2015-02-19 12:00:11 -07:00
|
|
|
updateErrors = flag.Bool("update_errors", false, "update error messages in test file based on compiler output")
|
2013-01-11 23:52:52 -07:00
|
|
|
runoutputLimit = flag.Int("l", defaultRunOutputLimit(), "number of parallel runoutput tests to run")
|
2015-06-04 00:21:30 -06:00
|
|
|
|
|
|
|
shard = flag.Int("shard", 0, "shard index to run. Only applicable if -shards is non-zero.")
|
|
|
|
shards = flag.Int("shards", 0, "number of shards. If 0, all tests are run. This is used by the continuous build.")
|
2012-02-20 20:28:49 -07:00
|
|
|
)
|
|
|
|
|
2019-09-26 11:25:04 -06:00
|
|
|
// defaultAllCodeGen returns the default value of the -all_codegen
|
|
|
|
// flag. By default, we prefer to be fast (returning false), except on
|
|
|
|
// the linux-amd64 builder that's already very fast, so we get more
|
|
|
|
// test coverage on trybots. See https://golang.org/issue/34297.
|
|
|
|
func defaultAllCodeGen() bool {
|
|
|
|
return os.Getenv("GO_BUILDER_NAME") == "linux-amd64"
|
|
|
|
}
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
var (
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
goos, goarch string
|
2021-03-24 14:16:42 -06:00
|
|
|
cgoEnabled bool
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
// dirs are the directories to look for *.go files in.
|
|
|
|
// TODO(bradfitz): just use all directories?
|
[dev.typeparams] all: merge dev.regabi (7e0a81d) into dev.typeparams
As with CL 285875, this required resolving some conflicts around
handling of //go:embed directives. Still further work is needed to
reject uses of //go:embed in files that don't import "embed", so this
is left as a TODO. (When this code was written for dev.typeparams, we
were still leaning towards not requiring the "embed" import.)
Also, the recent support for inlining closures (CL 283112) interacts
poorly with -G=3 mode. There are some known issues with this code
already (#43818), so for now this CL disables inlining of closures
when in -G=3 mode with a TODO to revisit this once closure inlining is
working fully.
Conflicts:
- src/cmd/compile/internal/noder/noder.go
- src/cmd/compile/internal/typecheck/dcl.go
- src/cmd/compile/internal/typecheck/func.go
- test/run.go
Merge List:
+ 2021-01-22 7e0a81d280 [dev.regabi] all: merge master (dab3e5a) into dev.regabi
+ 2021-01-22 dab3e5affe runtime: switch runtime to libc for openbsd/amd64
+ 2021-01-22 a1b53d85da cmd/go: add documentation for test and xtest fields output by go list
+ 2021-01-22 b268b60774 runtime: remove pthread_kill/pthread_self for openbsd
+ 2021-01-22 ec4051763d runtime: fix typo in mgcscavenge.go
+ 2021-01-22 7ece3a7b17 net/http: fix flaky TestDisableKeepAliveUpgrade
+ 2021-01-22 50cba0506f time: clarify Timer.Reset behavior on AfterFunc Timers
+ 2021-01-22 cf10e69f17 doc/go1.16: mention net/http.Transport.GetProxyConnectHeader
+ 2021-01-22 ec1b945265 doc/go1.16: mention path/filepath.WalkDir
+ 2021-01-22 11def3d40b doc/go1.16: mention syscall.AllThreadsSyscall
+ 2021-01-21 07b0235609 doc/go1.16: add notes about package-specific fs.FS changes
+ 2021-01-21 e2b4f1fea5 doc/go1.16: minor formatting fix
+ 2021-01-21 9f43a9e07b doc/go1.16: mention new debug/elf constants
+ 2021-01-21 3c2f11ba5b cmd/go: overwrite program name with full path
+ 2021-01-21 953d1feca9 all: introduce and use internal/execabs
+ 2021-01-21 b186e4d70d cmd/go: add test case for cgo CC setting
+ 2021-01-21 5a8a2265fb cmd/cgo: report exec errors a bit more clearly
+ 2021-01-21 46e2e2e9d9 cmd/go: pass resolved CC, GCCGO to cgo
+ 2021-01-21 3d40895e36 runtime: switch openbsd/arm64 to pthreads
+ 2021-01-21 d95ca91380 crypto/elliptic: fix P-224 field reduction
+ 2021-01-21 d7e71c01ad [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for dwarf
+ 2021-01-21 5248f59a22 [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet for SSA
+ 2021-01-21 970d8b6cb2 [dev.regabi] cmd/compile: replace ir.Name map with ir.NameSet in inlining
+ 2021-01-21 68a4664475 [dev.regabi] cmd/compile: remove tempAssigns in walkCall1
+ 2021-01-21 fd9a391cdd [dev.regabi] cmd/compile: remove CallExpr.Rargs
+ 2021-01-21 19a6db6b63 [dev.regabi] cmd/compile: make sure mkcall* passed non-nil init
+ 2021-01-21 9f036844db [dev.regabi] cmd/compile: use ir.DoChildren directly in inlining
+ 2021-01-21 213c3905e9 [dev.regabi] cmd/compile: use node walked flag to prevent double walk for walkSelect
+ 2021-01-20 1760d736f6 [dev.regabi] cmd/compile: exporting, importing, and inlining functions with OCLOSURE
+ 2021-01-20 ecf4ebf100 cmd/internal/moddeps: check content of all modules in GOROOT
+ 2021-01-20 92cb157cf3 [dev.regabi] cmd/compile: late expansion of return values
+ 2021-01-20 d2d155d1ae runtime: don't adjust timer pp field in timerWaiting status
+ 2021-01-20 803d18fc6c cmd/go: set Incomplete field on go list output if no files match embed
+ 2021-01-20 6e243ce71d cmd/go: have go mod vendor copy embedded files in subdirs
+ 2021-01-20 be28e5abc5 cmd/go: fix mod_get_fallback test
+ 2021-01-20 928bda4f4a runtime: convert openbsd/amd64 locking to libc
+ 2021-01-19 824f2d635c cmd/go: allow go fmt to complete when embedded file is missing
+ 2021-01-19 0575e35e50 cmd/compile: require 'go 1.16' go.mod line for //go:embed
+ 2021-01-19 9423d50d53 [dev.regabi] cmd/compile: use '%q' for printing rune values less than 128
+ 2021-01-19 ccb2e90688 cmd/link: exit before Asmb2 if error
+ 2021-01-19 ca5774a5a5 embed: treat uninitialized FS as empty
+ 2021-01-19 d047c91a6c cmd/link,runtime: switch openbsd/amd64 to pthreads
+ 2021-01-19 61debffd97 runtime: factor out usesLibcall
+ 2021-01-19 9fed39d281 runtime: factor out mStackIsSystemAllocated
+ 2021-01-19 a2f825c542 [dev.regabi] cmd/compile: directly create go.map and go.track symbols
+ 2021-01-19 4a4212c0e5 [dev.regabi] cmd/compile: refactor Linksym creation
+ 2021-01-19 4f5c603c0f [dev.regabi] cmd/compile: cleanup callTargetLSym
+ 2021-01-18 dbab079835 runtime: free Windows event handles after last lock is dropped
+ 2021-01-18 5a8fbb0d2d os: do not close syscall.Stdin in TestReadStdin
+ 2021-01-18 422f38fb6c [dev.regabi] cmd/compile: move stack objects to liveness
+ 2021-01-18 6113db0bb4 [dev.regabi] cmd/compile: convert OPANIC argument to interface{} during typecheck
+ 2021-01-18 4c835f9169 [dev.regabi] cmd/compile: use LinksymOffsetExpr in TypePtr/ItabAddr
+ 2021-01-18 0ffa1ead6e [dev.regabi] cmd/compile: use *obj.LSym instead of *ir.Name for staticdata functions
+ 2021-01-17 7e0fa38aad [dev.regabi] cmd/compile: remove unneeded packages from ir.Pkgs
+ 2021-01-17 99a5db11ac [dev.regabi] cmd/compile: use LinksymOffsetExpr in walkConvInterface
+ 2021-01-17 87845d14f9 [dev.regabi] cmd/compile: add ir.TailCallStmt
+ 2021-01-17 e3027c6828 [dev.regabi] cmd/compile: fix linux-amd64-noopt builder
+ 2021-01-17 59ff93fe64 [dev.regabi] cmd/compile: rename NameOffsetExpr to LinksymOffsetExpr
+ 2021-01-17 82b9cae700 [dev.regabi] cmd/compile: change ir.NameOffsetExpr to use *obj.LSym instead of *Name
+ 2021-01-17 88956fc4b1 [dev.regabi] cmd/compile: stop analyze NameOffsetExpr.Name_ in escape analysis
+ 2021-01-17 7ce2a8383d [dev.regabi] cmd/compile: simplify stack temp initialization
+ 2021-01-17 ba0e8a92fa [dev.regabi] cmd/compile: refactor temp construction in walk
+ 2021-01-17 78e5aabcdb [dev.regabi] cmd/compile: replace Node.HasCall with walk.mayCall
+ 2021-01-16 6de9423445 [dev.regabi] cmd/compile: cleanup OAS2FUNC ordering
+ 2021-01-16 a956a0e909 [dev.regabi] cmd/compile, runtime: fix up comments/error messages from recent renames
+ 2021-01-16 ab3b67abfd [dev.regabi] cmd/compile: remove ONEWOBJ
+ 2021-01-16 c9b1445ac8 [dev.regabi] cmd/compile: remove TypeAssertExpr {Src,Dst}Type fields
+ 2021-01-15 682a1d2176 runtime: detect errors in DuplicateHandle
+ 2021-01-15 9f83418b83 cmd/link: remove GOROOT write in TestBuildForTvOS
+ 2021-01-15 ec9470162f cmd/compile: allow embed into any string or byte slice type
+ 2021-01-15 54198b04db cmd/compile: disallow embed of var inside func
+ 2021-01-15 b386c735e7 cmd/go: fix go generate docs
+ 2021-01-15 bb5075a525 syscall: remove RtlGenRandom and move it into internal/syscall
+ 2021-01-15 1deae0b597 os: invoke processKiller synchronously in testKillProcess
+ 2021-01-15 03a875137f [dev.regabi] cmd/compile: unexport reflectdata.WriteType
+ 2021-01-15 14537e6e54 [dev.regabi] cmd/compile: move stkobj symbol generation to SSA
+ 2021-01-15 ab523fc510 [dev.regabi] cmd/compile: don't promote Byval CaptureVars if Addrtaken
+ 2021-01-15 ff196c3e84 crypto/x509: update iOS bundled roots to version 55188.40.9
+ 2021-01-15 b7a698c73f [dev.regabi] test: disable test on windows because expected contains path separators.
+ 2021-01-15 4be7af23f9 [dev.regabi] cmd/compile: fix ICE during ir.Dump
+ 2021-01-14 e125ccd10e cmd/go: in 'go mod edit', validate versions given to -retract and -exclude
+ 2021-01-14 eb330020dc cmd/dist, cmd/go: pass -arch for C compilation on Darwin
+ 2021-01-14 84e8a06f62 cmd/cgo: remove unnecessary space in cgo export header
+ 2021-01-14 0c86b999c3 cmd/test2json: document passing -test.paniconexit0
+ 2021-01-14 9135795891 cmd/go/internal/load: report positions for embed errors
+ 2021-01-14 35b9c66601 [dev.regabi] cmd/compile,cmd/link: additional code review suggestions for CL 270863
+ 2021-01-14 d9b79e53bb cmd/compile: fix wrong complement for arm64 floating-point comparisons
+ 2021-01-14 c73232d08f cmd/go/internal/load: refactor setErrorPos to PackageError.setPos
+ 2021-01-14 6aa28d3e06 go/build: report positions for go:embed directives
+ 2021-01-14 9734fd482d [dev.regabi] cmd/compile: use node walked flag to prevent double walk for walkSwitch
+ 2021-01-14 f97983249a [dev.regabi] cmd/compile: move more PAUTOHEAP to SSA construction
+ 2021-01-14 4476300425 [dev.regabi] cmd/compile: use byte for CallExpr.Use
+ 2021-01-14 5a5ab24689 [dev.regabi] cmd/compile: do not rely on CallExpr.Rargs for detect already walked calls
+ 2021-01-14 983ac4b086 [dev.regabi] cmd/compile: fix ICE when initializing blank vars
+ 2021-01-13 7eb31d999c cmd/go: add hints to more missing sum error messages
+ 2021-01-13 d6d4673728 [dev.regabi] cmd/compile: fix GOEXPERIMENT=regabi builder
+ 2021-01-13 c41b999ad4 [dev.regabi] cmd/compile: refactor abiutils from "gc" into new "abi"
+ 2021-01-13 861707a8c8 [dev.regabi] cmd/compile: added limited //go:registerparams pragma for new ABI dev
+ 2021-01-13 c1370e918f [dev.regabi] cmd/compile: add code to support register ABI spills around morestack calls
+ 2021-01-13 2abd24f3b7 [dev.regabi] test: make run.go error messages slightly more informative
+ 2021-01-13 9a19481acb [dev.regabi] cmd/compile: make ordering for InvertFlags more stable
+ 2021-01-12 ba76567bc2 cmd/go/internal/modload: delete unused *mvsReqs.next method
+ 2021-01-12 665def2c11 encoding/asn1: document unmarshaling behavior for IMPLICIT string fields
+ 2021-01-11 81ea89adf3 cmd/go: fix non-script staleness checks interacting badly with GOFLAGS
+ 2021-01-11 759309029f doc: update editors.html for Go 1.16
+ 2021-01-11 c3b4c7093a cmd/internal/objfile: don't require runtime.symtab symbol for XCOFF
+ 2021-01-08 59bfc18e34 cmd/go: add hint to read 'go help vcs' to GOVCS errors
+ 2021-01-08 cd6f3a54e4 cmd/go: revise 'go help' documentation for modules
+ 2021-01-08 6192b98751 cmd/go: make hints in error messages more consistent
+ 2021-01-08 25886cf4bd cmd/go: preserve sums for indirect deps fetched by 'go mod download'
+ 2021-01-08 6250833911 runtime/metrics: mark histogram metrics as cumulative
+ 2021-01-08 8f6a9acbb3 runtime/metrics: remove unused StopTheWorld Description field
+ 2021-01-08 6598c65646 cmd/compile: fix exponential-time init-cycle reporting
+ 2021-01-08 fefad1dc85 test: fix timeout code for invoking compiler
+ 2021-01-08 6728118e0a cmd/go: pass signals forward during "go tool"
+ 2021-01-08 e65c543f3c go/build/constraint: add parser for build tag constraint expressions
+ 2021-01-08 0c5afc4fb7 testing/fstest,os: clarify racy behavior of TestFS
+ 2021-01-08 32afcc9436 runtime/metrics: change unit on *-by-size metrics to match bucket unit
+ 2021-01-08 c6513bca5a io/fs: minor corrections to Glob doc
+ 2021-01-08 304f769ffc cmd/compile: don't short-circuit copies whose source is volatile
+ 2021-01-08 ae97717133 runtime,runtime/metrics: use explicit histogram boundaries
+ 2021-01-08 a9ccd2d795 go/build: skip string literal while findEmbed
+ 2021-01-08 d92f8add32 archive/tar: fix typo in comment
+ 2021-01-08 cab1202183 cmd/link: accept extra blocks in TestFallocate
+ 2021-01-08 ee4d32249b io/fs: minor corrections to Glob release date
+ 2021-01-08 54bd1ccce2 cmd: update to latest golang.org/x/tools
+ 2021-01-07 9ec21a8f34 Revert "reflect: support multiple keys in struct tags"
+ 2021-01-07 091414b5b7 io/fs: correct WalkDirFunc documentation
+ 2021-01-07 9b55088d6b doc/go1.16: add release note for disallowing non-ASCII import paths
+ 2021-01-07 fa90aaca7d cmd/compile: fix late expand_calls leaf type for OpStructSelect/OpArraySelect
+ 2021-01-07 7cee66d4cb cmd/go: add documentation for Embed fields in go list output
+ 2021-01-07 e60cffa4ca html/template: attach functions to namespace
+ 2021-01-07 6da2d3b7d7 cmd/link: fix typo in asm.go
+ 2021-01-07 df81a15819 runtime: check mips64 VDSO clock_gettime return code
+ 2021-01-06 4787e906cf crypto/x509: rollback new CertificateRequest fields
+ 2021-01-06 c9658bee93 cmd/go: make module suggestion more friendly
+ 2021-01-06 4c668b25c6 runtime/metrics: fix panic message for Float64Histogram
+ 2021-01-06 d2131704a6 net/http/httputil: fix deadlock in DumpRequestOut
+ 2021-01-05 3e1e13ce6d cmd/go: set cfg.BuildMod to "readonly" by default with no module root
+ 2021-01-05 0b0d004983 cmd/go: pass embedcfg to gccgo if supported
+ 2021-01-05 1b85e7c057 cmd/go: don't scan gccgo standard library packages for imports
+ 2021-01-05 6b37b15d95 runtime: don't take allglock in tracebackothers
+ 2021-01-04 9eef49cfa6 math/rand: fix typo in comment
+ 2021-01-04 b01fb2af9e testing/fstest: fix typo in error message
+ 2021-01-01 3dd5867605 doc: 2021 is the Year of the Gopher
+ 2020-12-31 95ce805d14 io/fs: remove darwin/arm64 special condition
+ 2020-12-30 20d0991b86 lib/time, time/tzdata: update tzdata to 2020f
+ 2020-12-30 ed301733bb misc/cgo/testcarchive: remove special flags for Darwin/ARM
+ 2020-12-30 0ae2e032f2 misc/cgo/test: enable TestCrossPackageTests on darwin/arm64
+ 2020-12-29 780b4de16b misc/ios: fix wording for command line instructions
+ 2020-12-29 b4a71c95d2 doc/go1.16: reference misc/ios/README for how to build iOS programs
+ 2020-12-29 f83e0f6616 misc/ios: add to README how to build ios executables
+ 2020-12-28 4fd9455882 io/fs: fix typo in comment
Change-Id: If24bb93f1e1e7deb1d92ba223c85940ab93b2732
2021-01-22 16:35:11 -07:00
|
|
|
dirs = []string{".", "ken", "chan", "interface", "syntax", "dwarf", "fixedbugs", "codegen", "runtime", "abi", "typeparam"}
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
// ratec controls the max number of tests running at a time.
|
|
|
|
ratec chan bool
|
|
|
|
|
|
|
|
// toRun is the channel of tests to run.
|
|
|
|
// It is nil until the first test is started.
|
|
|
|
toRun chan *test
|
2013-01-11 23:52:52 -07:00
|
|
|
|
|
|
|
// rungatec controls the max number of runoutput tests
|
|
|
|
// executed in parallel as they can each consume a lot of memory.
|
|
|
|
rungatec chan bool
|
2012-02-20 20:28:49 -07:00
|
|
|
)
|
|
|
|
|
|
|
|
// maxTests is an upper bound on the total number of tests.
|
|
|
|
// It is used as a channel buffer size to make sure sends don't block.
|
|
|
|
const maxTests = 5000
|
|
|
|
|
|
|
|
func main() {
|
|
|
|
flag.Parse()
|
2012-03-06 21:43:25 -07:00
|
|
|
|
2014-07-24 15:18:54 -06:00
|
|
|
goos = getenv("GOOS", runtime.GOOS)
|
|
|
|
goarch = getenv("GOARCH", runtime.GOARCH)
|
2021-03-24 14:16:42 -06:00
|
|
|
cgoEnv, err := exec.Command(goTool(), "env", "CGO_ENABLED").Output()
|
|
|
|
if err == nil {
|
|
|
|
cgoEnabled, _ = strconv.ParseBool(strings.TrimSpace(string(cgoEnv)))
|
|
|
|
}
|
2014-07-24 15:18:54 -06:00
|
|
|
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
findExecCmd()
|
|
|
|
|
2014-05-27 23:01:08 -06:00
|
|
|
// Disable parallelism if printing or if using a simulator.
|
|
|
|
if *verbose || len(findExecCmd()) > 0 {
|
|
|
|
*numParallel = 1
|
2018-10-16 22:37:44 -06:00
|
|
|
*runoutputLimit = 1
|
2014-05-27 23:01:08 -06:00
|
|
|
}
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
ratec = make(chan bool, *numParallel)
|
2013-01-11 23:52:52 -07:00
|
|
|
rungatec = make(chan bool, *runoutputLimit)
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
var tests []*test
|
|
|
|
if flag.NArg() > 0 {
|
|
|
|
for _, arg := range flag.Args() {
|
|
|
|
if arg == "-" || arg == "--" {
|
2012-08-06 19:38:35 -06:00
|
|
|
// Permit running:
|
2012-02-20 20:28:49 -07:00
|
|
|
// $ go run run.go - env.go
|
|
|
|
// $ go run run.go -- env.go
|
2012-08-06 19:38:35 -06:00
|
|
|
// $ go run run.go - ./fixedbugs
|
|
|
|
// $ go run run.go -- ./fixedbugs
|
2012-02-20 20:28:49 -07:00
|
|
|
continue
|
|
|
|
}
|
2012-08-06 19:38:35 -06:00
|
|
|
if fi, err := os.Stat(arg); err == nil && fi.IsDir() {
|
|
|
|
for _, baseGoFile := range goFiles(arg) {
|
|
|
|
tests = append(tests, startTest(arg, baseGoFile))
|
|
|
|
}
|
|
|
|
} else if strings.HasSuffix(arg, ".go") {
|
|
|
|
dir, file := filepath.Split(arg)
|
|
|
|
tests = append(tests, startTest(dir, file))
|
|
|
|
} else {
|
|
|
|
log.Fatalf("can't yet deal with non-directory and non-go file %q", arg)
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
for _, dir := range dirs {
|
|
|
|
for _, baseGoFile := range goFiles(dir) {
|
|
|
|
tests = append(tests, startTest(dir, baseGoFile))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
failed := false
|
|
|
|
resCount := map[string]int{}
|
|
|
|
for _, test := range tests {
|
2014-08-01 14:34:36 -06:00
|
|
|
<-test.donec
|
2013-12-10 12:02:42 -07:00
|
|
|
status := "ok "
|
|
|
|
errStr := ""
|
2016-03-31 11:57:48 -06:00
|
|
|
if e, isSkip := test.err.(skipError); isSkip {
|
2013-12-10 12:02:42 -07:00
|
|
|
test.err = nil
|
2016-03-31 11:57:48 -06:00
|
|
|
errStr = "unexpected skip for " + path.Join(test.dir, test.gofile) + ": " + string(e)
|
2014-12-18 11:34:12 -07:00
|
|
|
status = "FAIL"
|
2013-12-10 12:02:42 -07:00
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
if test.err != nil {
|
2013-12-10 12:02:42 -07:00
|
|
|
status = "FAIL"
|
2012-02-20 20:28:49 -07:00
|
|
|
errStr = test.err.Error()
|
|
|
|
}
|
2013-12-10 12:02:42 -07:00
|
|
|
if status == "FAIL" {
|
2012-09-23 11:16:14 -06:00
|
|
|
failed = true
|
|
|
|
}
|
2013-12-10 12:02:42 -07:00
|
|
|
resCount[status]++
|
|
|
|
dt := fmt.Sprintf("%.3fs", test.dt.Seconds())
|
|
|
|
if status == "FAIL" {
|
|
|
|
fmt.Printf("# go run run.go -- %s\n%s\nFAIL\t%s\t%s\n",
|
|
|
|
path.Join(test.dir, test.gofile),
|
|
|
|
errStr, test.goFileName(), dt)
|
2012-02-20 20:28:49 -07:00
|
|
|
continue
|
2012-02-23 18:52:15 -07:00
|
|
|
}
|
2013-12-10 12:02:42 -07:00
|
|
|
if !*verbose {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
fmt.Printf("%s\t%s\t%s\n", status, test.goFileName(), dt)
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
if *summary {
|
|
|
|
for k, v := range resCount {
|
|
|
|
fmt.Printf("%5d %s\n", v, k)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if failed {
|
|
|
|
os.Exit(1)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-03 06:47:20 -07:00
|
|
|
// goTool reports the path of the go tool to use to run the tests.
|
|
|
|
// If possible, use the same Go used to run run.go, otherwise
|
|
|
|
// fallback to the go version found in the PATH.
|
|
|
|
func goTool() string {
|
|
|
|
var exeSuffix string
|
|
|
|
if runtime.GOOS == "windows" {
|
|
|
|
exeSuffix = ".exe"
|
|
|
|
}
|
|
|
|
path := filepath.Join(runtime.GOROOT(), "bin", "go"+exeSuffix)
|
|
|
|
if _, err := os.Stat(path); err == nil {
|
|
|
|
return path
|
|
|
|
}
|
|
|
|
// Just run "go" from PATH
|
|
|
|
return "go"
|
|
|
|
}
|
|
|
|
|
2015-06-04 00:21:30 -06:00
|
|
|
func shardMatch(name string) bool {
|
|
|
|
if *shards == 0 {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
h := fnv.New32()
|
|
|
|
io.WriteString(h, name)
|
|
|
|
return int(h.Sum32()%uint32(*shards)) == *shard
|
|
|
|
}
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
func goFiles(dir string) []string {
|
|
|
|
f, err := os.Open(dir)
|
2020-02-08 23:40:45 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
dirnames, err := f.Readdirnames(-1)
|
2020-02-08 17:43:58 -07:00
|
|
|
f.Close()
|
2020-02-08 23:40:45 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
names := []string{}
|
|
|
|
for _, name := range dirnames {
|
2015-06-04 00:21:30 -06:00
|
|
|
if !strings.HasPrefix(name, ".") && strings.HasSuffix(name, ".go") && shardMatch(name) {
|
2012-02-20 20:28:49 -07:00
|
|
|
names = append(names, name)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
sort.Strings(names)
|
|
|
|
return names
|
|
|
|
}
|
|
|
|
|
2012-10-06 01:23:31 -06:00
|
|
|
type runCmd func(...string) ([]byte, error)
|
|
|
|
|
2017-04-28 08:28:49 -06:00
|
|
|
func compileFile(runcmd runCmd, longname string, flags []string) (out []byte, err error) {
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "tool", "compile", "-e"}
|
2017-04-28 08:28:49 -06:00
|
|
|
cmd = append(cmd, flags...)
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-dynlink", "-installsuffix=dynlink")
|
|
|
|
}
|
|
|
|
cmd = append(cmd, longname)
|
|
|
|
return runcmd(cmd...)
|
2012-10-06 01:23:31 -06:00
|
|
|
}
|
|
|
|
|
2018-05-30 10:46:59 -06:00
|
|
|
func compileInDir(runcmd runCmd, dir string, flags []string, localImports bool, names ...string) (out []byte, err error) {
|
|
|
|
cmd := []string{goTool(), "tool", "compile", "-e"}
|
|
|
|
if localImports {
|
|
|
|
// Set relative path for local imports and import search path to current dir.
|
|
|
|
cmd = append(cmd, "-D", ".", "-I", ".")
|
|
|
|
}
|
2016-03-10 22:10:52 -07:00
|
|
|
cmd = append(cmd, flags...)
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-dynlink", "-installsuffix=dynlink")
|
|
|
|
}
|
2013-01-02 13:31:49 -07:00
|
|
|
for _, name := range names {
|
|
|
|
cmd = append(cmd, filepath.Join(dir, name))
|
|
|
|
}
|
|
|
|
return runcmd(cmd...)
|
2012-10-06 01:23:31 -06:00
|
|
|
}
|
|
|
|
|
2019-03-22 13:24:36 -06:00
|
|
|
func linkFile(runcmd runCmd, goname string, ldflags []string) (err error) {
|
2015-05-21 11:28:17 -06:00
|
|
|
pfile := strings.Replace(goname, ".go", ".o", -1)
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "tool", "link", "-w", "-o", "a.exe", "-L", "."}
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared", "-installsuffix=dynlink")
|
|
|
|
}
|
2019-03-22 13:24:36 -06:00
|
|
|
if ldflags != nil {
|
|
|
|
cmd = append(cmd, ldflags...)
|
|
|
|
}
|
2015-10-26 19:54:19 -06:00
|
|
|
cmd = append(cmd, pfile)
|
|
|
|
_, err = runcmd(cmd...)
|
2012-10-06 01:23:31 -06:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
// skipError describes why a test was skipped.
|
|
|
|
type skipError string
|
|
|
|
|
|
|
|
func (s skipError) Error() string { return string(s) }
|
|
|
|
|
|
|
|
// test holds the state of a test.
|
|
|
|
type test struct {
|
|
|
|
dir, gofile string
|
|
|
|
donec chan bool // closed when done
|
2014-08-01 14:34:36 -06:00
|
|
|
dt time.Duration
|
|
|
|
|
2016-09-22 11:50:16 -06:00
|
|
|
src string
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
tempDir string
|
|
|
|
err error
|
|
|
|
}
|
|
|
|
|
2012-12-22 11:16:31 -07:00
|
|
|
// startTest
|
2012-02-20 20:28:49 -07:00
|
|
|
func startTest(dir, gofile string) *test {
|
|
|
|
t := &test{
|
|
|
|
dir: dir,
|
|
|
|
gofile: gofile,
|
|
|
|
donec: make(chan bool, 1),
|
|
|
|
}
|
|
|
|
if toRun == nil {
|
|
|
|
toRun = make(chan *test, maxTests)
|
|
|
|
go runTests()
|
|
|
|
}
|
|
|
|
select {
|
|
|
|
case toRun <- t:
|
|
|
|
default:
|
|
|
|
panic("toRun buffer size (maxTests) is too small")
|
|
|
|
}
|
|
|
|
return t
|
|
|
|
}
|
|
|
|
|
|
|
|
// runTests runs tests in parallel, but respecting the order they
|
|
|
|
// were enqueued on the toRun channel.
|
|
|
|
func runTests() {
|
|
|
|
for {
|
|
|
|
ratec <- true
|
|
|
|
t := <-toRun
|
|
|
|
go func() {
|
|
|
|
t.run()
|
|
|
|
<-ratec
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
var cwd, _ = os.Getwd()
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
func (t *test) goFileName() string {
|
|
|
|
return filepath.Join(t.dir, t.gofile)
|
|
|
|
}
|
|
|
|
|
2012-07-30 13:12:05 -06:00
|
|
|
func (t *test) goDirName() string {
|
|
|
|
return filepath.Join(t.dir, strings.Replace(t.gofile, ".go", ".dir", -1))
|
|
|
|
}
|
|
|
|
|
2012-10-06 01:23:31 -06:00
|
|
|
func goDirFiles(longdir string) (filter []os.FileInfo, err error) {
|
|
|
|
files, dirErr := ioutil.ReadDir(longdir)
|
|
|
|
if dirErr != nil {
|
|
|
|
return nil, dirErr
|
|
|
|
}
|
|
|
|
for _, gofile := range files {
|
|
|
|
if filepath.Ext(gofile.Name()) == ".go" {
|
|
|
|
filter = append(filter, gofile)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2018-09-27 06:46:08 -06:00
|
|
|
var packageRE = regexp.MustCompile(`(?m)^package ([\p{Lu}\p{Ll}\w]+)`)
|
2013-01-02 13:31:49 -07:00
|
|
|
|
2019-03-22 13:24:36 -06:00
|
|
|
func getPackageNameFromSource(fn string) (string, error) {
|
|
|
|
data, err := ioutil.ReadFile(fn)
|
|
|
|
if err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
pkgname := packageRE.FindStringSubmatch(string(data))
|
|
|
|
if pkgname == nil {
|
|
|
|
return "", fmt.Errorf("cannot find package name in %s", fn)
|
|
|
|
}
|
|
|
|
return pkgname[1], nil
|
|
|
|
}
|
|
|
|
|
2016-06-21 16:33:04 -06:00
|
|
|
// If singlefilepkgs is set, each file is considered a separate package
|
|
|
|
// even if the package names are the same.
|
|
|
|
func goDirPackages(longdir string, singlefilepkgs bool) ([][]string, error) {
|
2013-01-02 13:31:49 -07:00
|
|
|
files, err := goDirFiles(longdir)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
var pkgs [][]string
|
|
|
|
m := make(map[string]int)
|
|
|
|
for _, file := range files {
|
|
|
|
name := file.Name()
|
2019-03-22 13:24:36 -06:00
|
|
|
pkgname, err := getPackageNameFromSource(filepath.Join(longdir, name))
|
2020-02-08 23:40:45 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2019-03-22 13:24:36 -06:00
|
|
|
i, ok := m[pkgname]
|
2016-06-21 16:33:04 -06:00
|
|
|
if singlefilepkgs || !ok {
|
2013-01-02 13:31:49 -07:00
|
|
|
i = len(pkgs)
|
|
|
|
pkgs = append(pkgs, nil)
|
2019-03-22 13:24:36 -06:00
|
|
|
m[pkgname] = i
|
2013-01-02 13:31:49 -07:00
|
|
|
}
|
|
|
|
pkgs[i] = append(pkgs[i], name)
|
|
|
|
}
|
|
|
|
return pkgs, nil
|
|
|
|
}
|
2013-01-11 14:00:48 -07:00
|
|
|
|
2013-08-13 10:25:41 -06:00
|
|
|
type context struct {
|
2021-03-24 14:16:42 -06:00
|
|
|
GOOS string
|
|
|
|
GOARCH string
|
|
|
|
cgoEnabled bool
|
|
|
|
noOptEnv bool
|
2013-08-13 10:25:41 -06:00
|
|
|
}
|
|
|
|
|
2013-01-28 13:29:45 -07:00
|
|
|
// shouldTest looks for build tags in a source file and returns
|
|
|
|
// whether the file should be used according to the tags.
|
|
|
|
func shouldTest(src string, goos, goarch string) (ok bool, whyNot string) {
|
2015-10-26 15:34:06 -06:00
|
|
|
if *runSkips {
|
|
|
|
return true, ""
|
|
|
|
}
|
2013-01-28 13:29:45 -07:00
|
|
|
for _, line := range strings.Split(src, "\n") {
|
|
|
|
line = strings.TrimSpace(line)
|
|
|
|
if strings.HasPrefix(line, "//") {
|
|
|
|
line = line[2:]
|
|
|
|
} else {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
line = strings.TrimSpace(line)
|
|
|
|
if len(line) == 0 || line[0] != '+' {
|
|
|
|
continue
|
|
|
|
}
|
2018-09-24 10:48:54 -06:00
|
|
|
gcFlags := os.Getenv("GO_GCFLAGS")
|
2013-08-13 10:25:41 -06:00
|
|
|
ctxt := &context{
|
2021-03-24 14:16:42 -06:00
|
|
|
GOOS: goos,
|
|
|
|
GOARCH: goarch,
|
|
|
|
cgoEnabled: cgoEnabled,
|
|
|
|
noOptEnv: strings.Contains(gcFlags, "-N") || strings.Contains(gcFlags, "-l"),
|
2013-08-13 10:25:41 -06:00
|
|
|
}
|
2018-09-24 10:48:54 -06:00
|
|
|
|
2013-01-28 13:29:45 -07:00
|
|
|
words := strings.Fields(line)
|
|
|
|
if words[0] == "+build" {
|
2013-08-13 10:25:41 -06:00
|
|
|
ok := false
|
|
|
|
for _, word := range words[1:] {
|
|
|
|
if ctxt.match(word) {
|
|
|
|
ok = true
|
|
|
|
break
|
2013-01-28 13:29:45 -07:00
|
|
|
}
|
|
|
|
}
|
2013-08-13 10:25:41 -06:00
|
|
|
if !ok {
|
|
|
|
// no matching tag found.
|
|
|
|
return false, line
|
|
|
|
}
|
2013-01-28 13:29:45 -07:00
|
|
|
}
|
|
|
|
}
|
2013-08-13 10:25:41 -06:00
|
|
|
// no build tags
|
2013-01-28 13:29:45 -07:00
|
|
|
return true, ""
|
|
|
|
}
|
|
|
|
|
2013-08-13 10:25:41 -06:00
|
|
|
func (ctxt *context) match(name string) bool {
|
|
|
|
if name == "" {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
if i := strings.Index(name, ","); i >= 0 {
|
|
|
|
// comma-separated list
|
|
|
|
return ctxt.match(name[:i]) && ctxt.match(name[i+1:])
|
|
|
|
}
|
|
|
|
if strings.HasPrefix(name, "!!") { // bad syntax, reject always
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
if strings.HasPrefix(name, "!") { // negation
|
|
|
|
return len(name) > 1 && !ctxt.match(name[1:])
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tags must be letters, digits, underscores or dots.
|
|
|
|
// Unlike in Go identifiers, all digits are fine (e.g., "386").
|
|
|
|
for _, c := range name {
|
|
|
|
if !unicode.IsLetter(c) && !unicode.IsDigit(c) && c != '_' && c != '.' {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-02-24 10:55:52 -07:00
|
|
|
exp := os.Getenv("GOEXPERIMENT")
|
|
|
|
if exp != "" {
|
|
|
|
experiments := strings.Split(exp, ",")
|
|
|
|
for _, e := range experiments {
|
|
|
|
if name == "goexperiment."+e {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-24 14:16:42 -06:00
|
|
|
if name == "cgo" && ctxt.cgoEnabled {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2020-12-17 15:03:07 -07:00
|
|
|
if name == ctxt.GOOS || name == ctxt.GOARCH || name == "gc" {
|
2013-08-13 10:25:41 -06:00
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2018-09-24 10:48:54 -06:00
|
|
|
if ctxt.noOptEnv && name == "gcflags_noopt" {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2015-12-04 20:51:03 -07:00
|
|
|
if name == "test_run" {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2013-08-13 10:25:41 -06:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2013-01-28 13:29:45 -07:00
|
|
|
func init() { checkShouldTest() }
|
|
|
|
|
2017-10-30 13:28:11 -06:00
|
|
|
// goGcflags returns the -gcflags argument to use with go build / go run.
|
2018-08-22 23:06:47 -06:00
|
|
|
// This must match the flags used for building the standard library,
|
2017-10-30 13:28:11 -06:00
|
|
|
// or else the commands will rebuild any needed packages (like runtime)
|
|
|
|
// over and over.
|
|
|
|
func goGcflags() string {
|
2020-01-08 09:00:44 -07:00
|
|
|
return "-gcflags=all=" + os.Getenv("GO_GCFLAGS")
|
2017-10-30 13:28:11 -06:00
|
|
|
}
|
|
|
|
|
2020-03-11 18:17:14 -06:00
|
|
|
func goGcflagsIsEmpty() bool {
|
2020-03-11 11:36:42 -06:00
|
|
|
return "" == os.Getenv("GO_GCFLAGS")
|
2020-03-11 18:17:14 -06:00
|
|
|
}
|
|
|
|
|
2021-01-07 09:22:42 -07:00
|
|
|
var errTimeout = errors.New("command exceeded time limit")
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
// run runs a test.
|
|
|
|
func (t *test) run() {
|
2013-12-10 12:02:42 -07:00
|
|
|
start := time.Now()
|
|
|
|
defer func() {
|
|
|
|
t.dt = time.Since(start)
|
|
|
|
close(t.donec)
|
|
|
|
}()
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
srcBytes, err := ioutil.ReadFile(t.goFileName())
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
t.src = string(srcBytes)
|
|
|
|
if t.src[0] == '\n' {
|
|
|
|
t.err = skipError("starts with newline")
|
|
|
|
return
|
|
|
|
}
|
2015-07-10 10:32:03 -06:00
|
|
|
|
|
|
|
// Execution recipe stops at first blank line.
|
2012-02-20 20:28:49 -07:00
|
|
|
pos := strings.Index(t.src, "\n\n")
|
|
|
|
if pos == -1 {
|
2021-01-04 12:05:17 -07:00
|
|
|
t.err = fmt.Errorf("double newline ending execution recipe not found in %s", t.goFileName())
|
2012-02-20 20:28:49 -07:00
|
|
|
return
|
|
|
|
}
|
|
|
|
action := t.src[:pos]
|
2013-01-28 13:29:45 -07:00
|
|
|
if nl := strings.Index(action, "\n"); nl >= 0 && strings.Contains(action[:nl], "+build") {
|
|
|
|
// skip first line
|
|
|
|
action = action[nl+1:]
|
|
|
|
}
|
2020-02-08 23:40:45 -07:00
|
|
|
action = strings.TrimPrefix(action, "//")
|
2012-03-08 12:03:40 -07:00
|
|
|
|
2015-07-10 10:32:03 -06:00
|
|
|
// Check for build constraints only up to the actual code.
|
|
|
|
pkgPos := strings.Index(t.src, "\npackage")
|
|
|
|
if pkgPos == -1 {
|
|
|
|
pkgPos = pos // some files are intentionally malformed
|
|
|
|
}
|
|
|
|
if ok, why := shouldTest(t.src[:pkgPos], goos, goarch); !ok {
|
|
|
|
if *showSkips {
|
2016-09-22 11:50:16 -06:00
|
|
|
fmt.Printf("%-20s %-20s: %s\n", "skip", t.goFileName(), why)
|
2015-07-10 10:32:03 -06:00
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-03-18 09:35:45 -06:00
|
|
|
var args, flags, runenv []string
|
2016-11-10 14:03:47 -07:00
|
|
|
var tim int
|
2012-09-23 11:16:14 -06:00
|
|
|
wantError := false
|
2016-09-22 11:50:16 -06:00
|
|
|
wantAuto := false
|
2016-06-21 16:33:04 -06:00
|
|
|
singlefilepkgs := false
|
2019-03-22 13:24:36 -06:00
|
|
|
setpkgpaths := false
|
2018-05-30 10:46:59 -06:00
|
|
|
localImports := true
|
2012-03-06 23:54:39 -07:00
|
|
|
f := strings.Fields(action)
|
|
|
|
if len(f) > 0 {
|
|
|
|
action = f[0]
|
|
|
|
args = f[1:]
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
|
2016-06-21 16:33:04 -06:00
|
|
|
// TODO: Clean up/simplify this switch statement.
|
2012-02-20 20:28:49 -07:00
|
|
|
switch action {
|
2019-05-17 04:25:07 -06:00
|
|
|
case "compile", "compiledir", "build", "builddir", "buildrundir", "run", "buildrun", "runoutput", "rundir", "runindir", "asmcheck":
|
2016-09-22 11:50:16 -06:00
|
|
|
// nothing to do
|
2016-03-10 22:10:52 -07:00
|
|
|
case "errorcheckandrundir":
|
|
|
|
wantError = false // should be no error if also will run
|
2016-09-22 11:50:16 -06:00
|
|
|
case "errorcheckwithauto":
|
|
|
|
action = "errorcheck"
|
|
|
|
wantAuto = true
|
|
|
|
wantError = true
|
2012-11-07 13:33:54 -07:00
|
|
|
case "errorcheck", "errorcheckdir", "errorcheckoutput":
|
2012-09-23 11:16:14 -06:00
|
|
|
wantError = true
|
2012-03-21 12:14:44 -06:00
|
|
|
case "skip":
|
2015-10-26 15:34:06 -06:00
|
|
|
if *runSkips {
|
|
|
|
break
|
|
|
|
}
|
2012-03-21 12:14:44 -06:00
|
|
|
return
|
2012-02-20 20:28:49 -07:00
|
|
|
default:
|
|
|
|
t.err = skipError("skipped; unknown pattern: " + action)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2016-06-21 16:33:04 -06:00
|
|
|
// collect flags
|
|
|
|
for len(args) > 0 && strings.HasPrefix(args[0], "-") {
|
|
|
|
switch args[0] {
|
2018-05-26 03:57:50 -06:00
|
|
|
case "-1":
|
|
|
|
wantError = true
|
2016-06-21 16:33:04 -06:00
|
|
|
case "-0":
|
|
|
|
wantError = false
|
|
|
|
case "-s":
|
|
|
|
singlefilepkgs = true
|
2019-03-22 13:24:36 -06:00
|
|
|
case "-P":
|
|
|
|
setpkgpaths = true
|
2018-05-30 10:46:59 -06:00
|
|
|
case "-n":
|
|
|
|
// Do not set relative path for local imports to current dir,
|
|
|
|
// e.g. do not pass -D . -I . to the compiler.
|
|
|
|
// Used in fixedbugs/bug345.go to allow compilation and import of local pkg.
|
|
|
|
// See golang.org/issue/25635
|
|
|
|
localImports = false
|
2016-11-10 14:03:47 -07:00
|
|
|
case "-t": // timeout in seconds
|
|
|
|
args = args[1:]
|
|
|
|
var err error
|
|
|
|
tim, err = strconv.Atoi(args[0])
|
|
|
|
if err != nil {
|
|
|
|
t.err = fmt.Errorf("need number of seconds for -t timeout, got %s instead", args[0])
|
|
|
|
}
|
2021-03-18 09:35:45 -06:00
|
|
|
case "-goexperiment": // set GOEXPERIMENT environment
|
|
|
|
args = args[1:]
|
|
|
|
runenv = append(runenv, "GOEXPERIMENT="+args[0])
|
2016-11-10 14:03:47 -07:00
|
|
|
|
2016-06-21 16:33:04 -06:00
|
|
|
default:
|
|
|
|
flags = append(flags, args[0])
|
|
|
|
}
|
|
|
|
args = args[1:]
|
|
|
|
}
|
2016-12-05 16:41:04 -07:00
|
|
|
if action == "errorcheck" {
|
|
|
|
found := false
|
|
|
|
for i, f := range flags {
|
|
|
|
if strings.HasPrefix(f, "-d=") {
|
|
|
|
flags[i] = f + ",ssa/check/on"
|
|
|
|
found = true
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if !found {
|
|
|
|
flags = append(flags, "-d=ssa/check/on")
|
|
|
|
}
|
|
|
|
}
|
2016-06-21 16:33:04 -06:00
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
t.makeTempDir()
|
2016-03-10 22:10:52 -07:00
|
|
|
if !*keep {
|
|
|
|
defer os.RemoveAll(t.tempDir)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
|
|
|
|
err = ioutil.WriteFile(filepath.Join(t.tempDir, t.gofile), srcBytes, 0644)
|
2020-02-08 23:40:45 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2012-03-08 12:03:40 -07:00
|
|
|
|
2012-03-07 00:22:08 -07:00
|
|
|
// A few tests (of things like the environment) require these to be set.
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
if os.Getenv("GOOS") == "" {
|
|
|
|
os.Setenv("GOOS", runtime.GOOS)
|
|
|
|
}
|
|
|
|
if os.Getenv("GOARCH") == "" {
|
|
|
|
os.Setenv("GOARCH", runtime.GOARCH)
|
|
|
|
}
|
2012-03-07 00:22:08 -07:00
|
|
|
|
2020-03-24 14:18:02 -06:00
|
|
|
var (
|
|
|
|
runInDir = t.tempDir
|
|
|
|
tempDirIsGOPATH = false
|
|
|
|
)
|
2012-03-06 23:54:39 -07:00
|
|
|
runcmd := func(args ...string) ([]byte, error) {
|
|
|
|
cmd := exec.Command(args[0], args[1:]...)
|
|
|
|
var buf bytes.Buffer
|
|
|
|
cmd.Stdout = &buf
|
|
|
|
cmd.Stderr = &buf
|
2020-03-24 14:18:02 -06:00
|
|
|
cmd.Env = append(os.Environ(), "GOENV=off", "GOFLAGS=")
|
|
|
|
if runInDir != "" {
|
|
|
|
cmd.Dir = runInDir
|
|
|
|
// Set PWD to match Dir to speed up os.Getwd in the child process.
|
|
|
|
cmd.Env = append(cmd.Env, "PWD="+cmd.Dir)
|
2019-05-17 04:25:07 -06:00
|
|
|
}
|
2020-03-24 14:18:02 -06:00
|
|
|
if tempDirIsGOPATH {
|
|
|
|
cmd.Env = append(cmd.Env, "GOPATH="+t.tempDir)
|
2015-09-06 20:39:07 -06:00
|
|
|
}
|
2021-03-18 09:35:45 -06:00
|
|
|
cmd.Env = append(cmd.Env, runenv...)
|
2016-11-10 14:03:47 -07:00
|
|
|
|
|
|
|
var err error
|
|
|
|
|
|
|
|
if tim != 0 {
|
|
|
|
err = cmd.Start()
|
|
|
|
// This command-timeout code adapted from cmd/go/test.go
|
|
|
|
if err == nil {
|
|
|
|
tick := time.NewTimer(time.Duration(tim) * time.Second)
|
|
|
|
done := make(chan error)
|
|
|
|
go func() {
|
|
|
|
done <- cmd.Wait()
|
|
|
|
}()
|
|
|
|
select {
|
|
|
|
case err = <-done:
|
|
|
|
// ok
|
|
|
|
case <-tick.C:
|
2021-01-07 09:22:42 -07:00
|
|
|
cmd.Process.Signal(os.Interrupt)
|
|
|
|
time.Sleep(1 * time.Second)
|
2016-11-10 14:03:47 -07:00
|
|
|
cmd.Process.Kill()
|
2021-01-07 09:22:42 -07:00
|
|
|
<-done
|
|
|
|
err = errTimeout
|
2016-11-10 14:03:47 -07:00
|
|
|
}
|
|
|
|
tick.Stop()
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
err = cmd.Run()
|
|
|
|
}
|
2021-01-07 09:22:42 -07:00
|
|
|
if err != nil && err != errTimeout {
|
2012-10-06 01:23:31 -06:00
|
|
|
err = fmt.Errorf("%s\n%s", err, buf.Bytes())
|
|
|
|
}
|
2012-03-06 23:54:39 -07:00
|
|
|
return buf.Bytes(), err
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
long := filepath.Join(cwd, t.goFileName())
|
2012-03-08 12:03:40 -07:00
|
|
|
switch action {
|
2012-03-06 23:54:39 -07:00
|
|
|
default:
|
|
|
|
t.err = fmt.Errorf("unimplemented action %q", action)
|
2012-02-20 20:28:49 -07:00
|
|
|
|
2018-02-26 17:59:58 -07:00
|
|
|
case "asmcheck":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile Go file and match the generated assembly
|
|
|
|
// against a set of regexps in comments.
|
2018-04-15 11:00:27 -06:00
|
|
|
ops := t.wantedAsmOpcodes(long)
|
2019-05-15 22:12:34 -06:00
|
|
|
self := runtime.GOOS + "/" + runtime.GOARCH
|
2018-04-15 11:00:27 -06:00
|
|
|
for _, env := range ops.Envs() {
|
2019-05-15 22:12:34 -06:00
|
|
|
// Only run checks relevant to the current GOOS/GOARCH,
|
|
|
|
// to avoid triggering a cross-compile of the runtime.
|
|
|
|
if string(env) != self && !strings.HasPrefix(string(env), self+"/") && !*allCodegen {
|
|
|
|
continue
|
|
|
|
}
|
2018-12-07 11:00:36 -07:00
|
|
|
// -S=2 forces outermost line numbers when disassembling inlined code.
|
|
|
|
cmdline := []string{"build", "-gcflags", "-S=2"}
|
2020-03-10 11:45:19 -06:00
|
|
|
|
|
|
|
// Append flags, but don't override -gcflags=-S=2; add to it instead.
|
|
|
|
for i := 0; i < len(flags); i++ {
|
|
|
|
flag := flags[i]
|
|
|
|
switch {
|
|
|
|
case strings.HasPrefix(flag, "-gcflags="):
|
|
|
|
cmdline[2] += " " + strings.TrimPrefix(flag, "-gcflags=")
|
|
|
|
case strings.HasPrefix(flag, "--gcflags="):
|
|
|
|
cmdline[2] += " " + strings.TrimPrefix(flag, "--gcflags=")
|
|
|
|
case flag == "-gcflags", flag == "--gcflags":
|
|
|
|
i++
|
|
|
|
if i < len(flags) {
|
|
|
|
cmdline[2] += " " + flags[i]
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
cmdline = append(cmdline, flag)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-02-26 17:59:58 -07:00
|
|
|
cmdline = append(cmdline, long)
|
2018-03-29 10:52:12 -06:00
|
|
|
cmd := exec.Command(goTool(), cmdline...)
|
2018-04-15 11:00:27 -06:00
|
|
|
cmd.Env = append(os.Environ(), env.Environ()...)
|
2019-04-03 14:16:58 -06:00
|
|
|
if len(flags) > 0 && flags[0] == "-race" {
|
|
|
|
cmd.Env = append(cmd.Env, "CGO_ENABLED=1")
|
|
|
|
}
|
2018-03-29 10:52:12 -06:00
|
|
|
|
|
|
|
var buf bytes.Buffer
|
|
|
|
cmd.Stdout, cmd.Stderr = &buf, &buf
|
|
|
|
if err := cmd.Run(); err != nil {
|
2018-04-25 12:52:06 -06:00
|
|
|
fmt.Println(env, "\n", cmd.Stderr)
|
2018-02-26 17:59:58 -07:00
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2018-03-29 10:52:12 -06:00
|
|
|
|
2018-04-15 11:00:27 -06:00
|
|
|
t.err = t.asmCheck(buf.String(), long, env, ops[env])
|
2018-02-26 17:59:58 -07:00
|
|
|
if t.err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return
|
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
case "errorcheck":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile Go file.
|
|
|
|
// Fail if wantError is true and compilation was successful and vice versa.
|
|
|
|
// Match errors produced by gc against errors in comments.
|
2017-03-08 15:26:23 -07:00
|
|
|
// TODO(gri) remove need for -C (disable printing of columns in error messages)
|
2021-03-04 08:31:43 -07:00
|
|
|
cmdline := []string{goTool(), "tool", "compile", "-d=panic", "-C", "-e", "-o", "a.o"}
|
2015-10-26 19:54:19 -06:00
|
|
|
// No need to add -dynlink even if linkshared if we're just checking for errors...
|
2012-09-23 11:16:14 -06:00
|
|
|
cmdline = append(cmdline, flags...)
|
|
|
|
cmdline = append(cmdline, long)
|
|
|
|
out, err := runcmd(cmdline...)
|
|
|
|
if wantError {
|
|
|
|
if err == nil {
|
|
|
|
t.err = fmt.Errorf("compilation succeeded unexpectedly\n%s", out)
|
|
|
|
return
|
|
|
|
}
|
2021-01-07 09:22:42 -07:00
|
|
|
if err == errTimeout {
|
|
|
|
t.err = fmt.Errorf("compilation timed out")
|
|
|
|
return
|
|
|
|
}
|
2012-09-23 11:16:14 -06:00
|
|
|
} else {
|
|
|
|
if err != nil {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
2012-09-23 11:16:14 -06:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2015-02-19 12:00:11 -07:00
|
|
|
if *updateErrors {
|
|
|
|
t.updateErrors(string(out), long)
|
|
|
|
}
|
2016-09-22 11:50:16 -06:00
|
|
|
t.err = t.errorCheck(string(out), wantAuto, long, t.gofile)
|
2020-12-03 19:15:50 -07:00
|
|
|
if t.err != nil {
|
|
|
|
return // don't hide error if run below succeeds
|
|
|
|
}
|
2020-11-30 22:38:49 -07:00
|
|
|
|
|
|
|
// The following is temporary scaffolding to get types2 typechecker
|
|
|
|
// up and running against the existing test cases. The explicitly
|
|
|
|
// listed files don't pass yet, usually because the error messages
|
|
|
|
// are slightly different (this list is not complete). Any errorcheck
|
2021-03-01 02:47:09 -07:00
|
|
|
// tests that require output from analysis phases past initial type-
|
2020-11-30 22:38:49 -07:00
|
|
|
// checking are also excluded since these phases are not running yet.
|
|
|
|
// We can get rid of this code once types2 is fully plugged in.
|
|
|
|
|
|
|
|
// For now we're done when we can't handle the file or some of the flags.
|
2020-12-03 12:11:05 -07:00
|
|
|
// The first goal is to eliminate the excluded list; the second goal is to
|
2020-11-30 22:38:49 -07:00
|
|
|
// eliminate the flag list.
|
|
|
|
|
|
|
|
// Excluded files.
|
2021-01-23 12:43:46 -07:00
|
|
|
filename := strings.Replace(t.goFileName(), "\\", "/", -1) // goFileName() uses \ on Windows
|
|
|
|
if excluded[filename] {
|
2020-12-03 12:11:05 -07:00
|
|
|
if *verbose {
|
2021-01-23 12:43:46 -07:00
|
|
|
fmt.Printf("excl\t%s\n", filename)
|
2020-11-30 22:38:49 -07:00
|
|
|
}
|
2020-12-03 12:11:05 -07:00
|
|
|
return // cannot handle file yet
|
2020-11-30 22:38:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
// Excluded flags.
|
|
|
|
for _, flag := range flags {
|
|
|
|
for _, pattern := range []string{
|
|
|
|
"-m",
|
|
|
|
} {
|
|
|
|
if strings.Contains(flag, pattern) {
|
2020-12-03 12:11:05 -07:00
|
|
|
if *verbose {
|
2021-01-23 12:43:46 -07:00
|
|
|
fmt.Printf("excl\t%s\t%s\n", filename, flags)
|
2020-12-03 12:11:05 -07:00
|
|
|
}
|
2020-11-30 22:38:49 -07:00
|
|
|
return // cannot handle flag
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Run errorcheck again with -G option (new typechecker).
|
2021-01-22 18:49:57 -07:00
|
|
|
cmdline = []string{goTool(), "tool", "compile", "-G=3", "-C", "-e", "-o", "a.o"}
|
2020-11-30 22:38:49 -07:00
|
|
|
// No need to add -dynlink even if linkshared if we're just checking for errors...
|
|
|
|
cmdline = append(cmdline, flags...)
|
|
|
|
cmdline = append(cmdline, long)
|
|
|
|
out, err = runcmd(cmdline...)
|
|
|
|
if wantError {
|
|
|
|
if err == nil {
|
|
|
|
t.err = fmt.Errorf("compilation succeeded unexpectedly\n%s", out)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if *updateErrors {
|
|
|
|
t.updateErrors(string(out), long)
|
|
|
|
}
|
|
|
|
t.err = t.errorCheck(string(out), wantAuto, long, t.gofile)
|
2012-03-08 12:03:40 -07:00
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
case "compile":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile Go file.
|
2017-04-28 08:28:49 -06:00
|
|
|
_, t.err = compileFile(runcmd, long, flags)
|
2012-03-08 12:03:40 -07:00
|
|
|
|
2012-07-30 13:12:05 -06:00
|
|
|
case "compiledir":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile all files in the directory as packages in lexicographic order.
|
2012-07-30 13:12:05 -06:00
|
|
|
longdir := filepath.Join(cwd, t.goDirName())
|
2016-06-21 16:33:04 -06:00
|
|
|
pkgs, err := goDirPackages(longdir, singlefilepkgs)
|
2012-10-06 01:23:31 -06:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
2012-07-30 13:12:05 -06:00
|
|
|
return
|
|
|
|
}
|
2013-01-02 13:31:49 -07:00
|
|
|
for _, gofiles := range pkgs {
|
2018-05-30 10:46:59 -06:00
|
|
|
_, t.err = compileInDir(runcmd, longdir, flags, localImports, gofiles...)
|
2012-10-06 01:23:31 -06:00
|
|
|
if t.err != nil {
|
|
|
|
return
|
2012-08-05 22:56:39 -06:00
|
|
|
}
|
2012-10-06 01:23:31 -06:00
|
|
|
}
|
|
|
|
|
2016-03-10 22:10:52 -07:00
|
|
|
case "errorcheckdir", "errorcheckandrundir":
|
2021-03-04 08:31:43 -07:00
|
|
|
flags = append(flags, "-d=panic")
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile and errorCheck all files in the directory as packages in lexicographic order.
|
|
|
|
// If errorcheckdir and wantError, compilation of the last package must fail.
|
|
|
|
// If errorcheckandrundir and wantError, compilation of the package prior the last must fail.
|
2012-10-06 01:23:31 -06:00
|
|
|
longdir := filepath.Join(cwd, t.goDirName())
|
2016-06-21 16:33:04 -06:00
|
|
|
pkgs, err := goDirPackages(longdir, singlefilepkgs)
|
2012-10-06 01:23:31 -06:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2018-05-26 03:57:50 -06:00
|
|
|
errPkg := len(pkgs) - 1
|
|
|
|
if wantError && action == "errorcheckandrundir" {
|
|
|
|
// The last pkg should compiled successfully and will be run in next case.
|
|
|
|
// Preceding pkg must return an error from compileInDir.
|
|
|
|
errPkg--
|
|
|
|
}
|
2013-01-02 13:31:49 -07:00
|
|
|
for i, gofiles := range pkgs {
|
2018-05-30 10:46:59 -06:00
|
|
|
out, err := compileInDir(runcmd, longdir, flags, localImports, gofiles...)
|
2018-05-26 03:57:50 -06:00
|
|
|
if i == errPkg {
|
2012-10-06 01:23:31 -06:00
|
|
|
if wantError && err == nil {
|
|
|
|
t.err = fmt.Errorf("compilation succeeded unexpectedly\n%s", out)
|
|
|
|
return
|
|
|
|
} else if !wantError && err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
} else if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2013-01-02 13:31:49 -07:00
|
|
|
var fullshort []string
|
|
|
|
for _, name := range gofiles {
|
|
|
|
fullshort = append(fullshort, filepath.Join(longdir, name), name)
|
|
|
|
}
|
2016-09-22 11:50:16 -06:00
|
|
|
t.err = t.errorCheck(string(out), wantAuto, fullshort...)
|
2012-10-06 01:23:31 -06:00
|
|
|
if t.err != nil {
|
2012-07-30 13:12:05 -06:00
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
2016-03-10 22:10:52 -07:00
|
|
|
if action == "errorcheckdir" {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
fallthrough
|
2012-07-30 13:12:05 -06:00
|
|
|
|
2012-10-06 01:23:31 -06:00
|
|
|
case "rundir":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Compile all files in the directory as packages in lexicographic order.
|
|
|
|
// In case of errorcheckandrundir, ignore failed compilation of the package before the last.
|
|
|
|
// Link as if the last file is the main package, run it.
|
|
|
|
// Verify the expected output.
|
2012-10-06 01:23:31 -06:00
|
|
|
longdir := filepath.Join(cwd, t.goDirName())
|
2016-06-21 16:33:04 -06:00
|
|
|
pkgs, err := goDirPackages(longdir, singlefilepkgs)
|
2012-10-06 01:23:31 -06:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2019-03-22 13:24:36 -06:00
|
|
|
// Split flags into gcflags and ldflags
|
|
|
|
ldflags := []string{}
|
|
|
|
for i, fl := range flags {
|
|
|
|
if fl == "-ldflags" {
|
|
|
|
ldflags = flags[i+1:]
|
|
|
|
flags = flags[0:i]
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-01-11 14:00:48 -07:00
|
|
|
for i, gofiles := range pkgs {
|
2019-03-22 13:24:36 -06:00
|
|
|
pflags := []string{}
|
|
|
|
pflags = append(pflags, flags...)
|
|
|
|
if setpkgpaths {
|
|
|
|
fp := filepath.Join(longdir, gofiles[0])
|
2020-02-08 23:40:45 -07:00
|
|
|
pkgname, err := getPackageNameFromSource(fp)
|
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2019-03-22 13:24:36 -06:00
|
|
|
pflags = append(pflags, "-p", pkgname)
|
|
|
|
}
|
|
|
|
_, err := compileInDir(runcmd, longdir, pflags, localImports, gofiles...)
|
2018-05-26 03:57:50 -06:00
|
|
|
// Allow this package compilation fail based on conditions below;
|
|
|
|
// its errors were checked in previous case.
|
|
|
|
if err != nil && !(wantError && action == "errorcheckandrundir" && i == len(pkgs)-2) {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2013-01-11 14:00:48 -07:00
|
|
|
if i == len(pkgs)-1 {
|
2019-03-22 13:24:36 -06:00
|
|
|
err = linkFile(runcmd, gofiles[0], ldflags)
|
2013-01-11 14:00:48 -07:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
var cmd []string
|
|
|
|
cmd = append(cmd, findExecCmd()...)
|
|
|
|
cmd = append(cmd, filepath.Join(t.tempDir, "a.exe"))
|
|
|
|
cmd = append(cmd, args...)
|
|
|
|
out, err := runcmd(cmd...)
|
2013-01-11 14:00:48 -07:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2013-01-11 14:00:48 -07:00
|
|
|
}
|
2012-10-06 01:23:31 -06:00
|
|
|
}
|
|
|
|
|
2019-05-17 04:25:07 -06:00
|
|
|
case "runindir":
|
2020-03-24 14:18:02 -06:00
|
|
|
// Make a shallow copy of t.goDirName() in its own module and GOPATH, and
|
|
|
|
// run "go run ." in it. The module path (and hence import path prefix) of
|
|
|
|
// the copy is equal to the basename of the source directory.
|
|
|
|
//
|
|
|
|
// It's used when test a requires a full 'go build' in order to compile
|
|
|
|
// the sources, such as when importing multiple packages (issue29612.dir)
|
|
|
|
// or compiling a package containing assembly files (see issue15609.dir),
|
|
|
|
// but still needs to be run to verify the expected output.
|
|
|
|
tempDirIsGOPATH = true
|
|
|
|
srcDir := t.goDirName()
|
|
|
|
modName := filepath.Base(srcDir)
|
|
|
|
gopathSrcDir := filepath.Join(t.tempDir, "src", modName)
|
|
|
|
runInDir = gopathSrcDir
|
|
|
|
|
|
|
|
if err := overlayDir(gopathSrcDir, srcDir); err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
modFile := fmt.Sprintf("module %s\ngo 1.14\n", modName)
|
|
|
|
if err := ioutil.WriteFile(filepath.Join(gopathSrcDir, "go.mod"), []byte(modFile), 0666); err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2019-05-17 04:25:07 -06:00
|
|
|
cmd := []string{goTool(), "run", goGcflags()}
|
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
2021-02-11 17:55:07 -07:00
|
|
|
cmd = append(cmd, flags...)
|
2019-05-17 04:25:07 -06:00
|
|
|
cmd = append(cmd, ".")
|
|
|
|
out, err := runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2019-05-17 04:25:07 -06:00
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
case "build":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Build Go file.
|
2018-03-03 06:47:20 -07:00
|
|
|
_, err := runcmd(goTool(), "build", goGcflags(), "-o", "a.exe", long)
|
2012-03-06 23:54:39 -07:00
|
|
|
if err != nil {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
2012-03-08 12:03:40 -07:00
|
|
|
|
2018-02-14 17:35:03 -07:00
|
|
|
case "builddir", "buildrundir":
|
2017-06-14 12:36:36 -06:00
|
|
|
// Build an executable from all the .go and .s files in a subdirectory.
|
2018-06-01 04:14:48 -06:00
|
|
|
// Run it and verify its output in the buildrundir case.
|
2017-06-14 12:36:36 -06:00
|
|
|
longdir := filepath.Join(cwd, t.goDirName())
|
|
|
|
files, dirErr := ioutil.ReadDir(longdir)
|
|
|
|
if dirErr != nil {
|
|
|
|
t.err = dirErr
|
|
|
|
break
|
|
|
|
}
|
2018-11-01 20:04:02 -06:00
|
|
|
var gos []string
|
|
|
|
var asms []string
|
2017-06-14 12:36:36 -06:00
|
|
|
for _, file := range files {
|
|
|
|
switch filepath.Ext(file.Name()) {
|
|
|
|
case ".go":
|
2018-11-01 20:04:02 -06:00
|
|
|
gos = append(gos, filepath.Join(longdir, file.Name()))
|
2017-06-14 12:36:36 -06:00
|
|
|
case ".s":
|
2018-11-01 20:04:02 -06:00
|
|
|
asms = append(asms, filepath.Join(longdir, file.Name()))
|
2017-06-14 12:36:36 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|
2018-10-22 09:21:56 -06:00
|
|
|
if len(asms) > 0 {
|
2018-11-13 16:13:42 -07:00
|
|
|
emptyHdrFile := filepath.Join(t.tempDir, "go_asm.h")
|
|
|
|
if err := ioutil.WriteFile(emptyHdrFile, nil, 0666); err != nil {
|
2018-10-22 09:21:56 -06:00
|
|
|
t.err = fmt.Errorf("write empty go_asm.h: %s", err)
|
|
|
|
return
|
|
|
|
}
|
2018-11-15 13:23:48 -07:00
|
|
|
cmd := []string{goTool(), "tool", "asm", "-gensymabis", "-o", "symabis"}
|
2018-10-22 09:21:56 -06:00
|
|
|
cmd = append(cmd, asms...)
|
|
|
|
_, err = runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
2017-06-14 12:36:36 -06:00
|
|
|
var objs []string
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "tool", "compile", "-e", "-D", ".", "-I", ".", "-o", "go.o"}
|
2017-11-29 12:58:03 -07:00
|
|
|
if len(asms) > 0 {
|
2018-10-22 09:21:56 -06:00
|
|
|
cmd = append(cmd, "-asmhdr", "go_asm.h", "-symabis", "symabis")
|
2017-11-29 12:58:03 -07:00
|
|
|
}
|
2018-11-01 20:04:02 -06:00
|
|
|
cmd = append(cmd, gos...)
|
2017-06-14 12:36:36 -06:00
|
|
|
_, err := runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
|
|
|
objs = append(objs, "go.o")
|
|
|
|
if len(asms) > 0 {
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd = []string{goTool(), "tool", "asm", "-e", "-I", ".", "-o", "asm.o"}
|
2018-11-01 20:04:02 -06:00
|
|
|
cmd = append(cmd, asms...)
|
2017-06-14 12:36:36 -06:00
|
|
|
_, err = runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
|
|
|
objs = append(objs, "asm.o")
|
|
|
|
}
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd = []string{goTool(), "tool", "pack", "c", "all.a"}
|
2017-06-14 12:36:36 -06:00
|
|
|
cmd = append(cmd, objs...)
|
|
|
|
_, err = runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd = []string{goTool(), "tool", "link", "-o", "a.exe", "all.a"}
|
2017-06-14 12:36:36 -06:00
|
|
|
_, err = runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
2018-02-14 17:35:03 -07:00
|
|
|
if action == "buildrundir" {
|
|
|
|
cmd = append(findExecCmd(), filepath.Join(t.tempDir, "a.exe"))
|
|
|
|
out, err := runcmd(cmd...)
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
break
|
|
|
|
}
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2018-02-14 17:35:03 -07:00
|
|
|
}
|
2017-06-14 12:36:36 -06:00
|
|
|
|
2018-06-01 04:14:48 -06:00
|
|
|
case "buildrun":
|
|
|
|
// Build an executable from Go file, then run it, verify its output.
|
|
|
|
// Useful for timeout tests where failure mode is infinite loop.
|
2016-11-10 14:03:47 -07:00
|
|
|
// TODO: not supported on NaCl
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "build", goGcflags(), "-o", "a.exe"}
|
2016-11-10 14:03:47 -07:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
|
|
|
longdirgofile := filepath.Join(filepath.Join(cwd, t.dir), t.gofile)
|
|
|
|
cmd = append(cmd, flags...)
|
|
|
|
cmd = append(cmd, longdirgofile)
|
2020-02-08 23:40:45 -07:00
|
|
|
_, err := runcmd(cmd...)
|
2016-11-10 14:03:47 -07:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
cmd = []string{"./a.exe"}
|
2020-02-08 23:40:45 -07:00
|
|
|
out, err := runcmd(append(cmd, args...)...)
|
2016-11-10 14:03:47 -07:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2016-11-10 14:03:47 -07:00
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
case "run":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Run Go file if no special go command flags are provided;
|
|
|
|
// otherwise build an executable and run it.
|
|
|
|
// Verify the output.
|
2020-03-24 14:18:02 -06:00
|
|
|
runInDir = ""
|
2017-10-27 12:11:21 -06:00
|
|
|
var out []byte
|
|
|
|
var err error
|
2020-03-11 18:17:14 -06:00
|
|
|
if len(flags)+len(args) == 0 && goGcflagsIsEmpty() && !*linkshared && goarch == runtime.GOARCH && goos == runtime.GOOS {
|
2017-10-27 12:11:21 -06:00
|
|
|
// If we're not using special go command flags,
|
|
|
|
// skip all the go command machinery.
|
|
|
|
// This avoids any time the go command would
|
|
|
|
// spend checking whether, for example, the installed
|
|
|
|
// package runtime is up to date.
|
|
|
|
// Because we run lots of trivial test programs,
|
|
|
|
// the time adds up.
|
|
|
|
pkg := filepath.Join(t.tempDir, "pkg.a")
|
2018-03-03 06:47:20 -07:00
|
|
|
if _, err := runcmd(goTool(), "tool", "compile", "-o", pkg, t.goFileName()); err != nil {
|
2017-10-27 12:11:21 -06:00
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
exe := filepath.Join(t.tempDir, "test.exe")
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "tool", "link", "-s", "-w"}
|
2017-10-27 12:11:21 -06:00
|
|
|
cmd = append(cmd, "-o", exe, pkg)
|
|
|
|
if _, err := runcmd(cmd...); err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
out, err = runcmd(append([]string{exe}, args...)...)
|
|
|
|
} else {
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "run", goGcflags()}
|
2017-10-27 12:11:21 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
|
|
|
cmd = append(cmd, flags...)
|
|
|
|
cmd = append(cmd, t.goFileName())
|
|
|
|
out, err = runcmd(append(cmd, args...)...)
|
2015-10-26 19:54:19 -06:00
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
if err != nil {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
2014-09-11 13:47:17 -06:00
|
|
|
return
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2012-04-20 09:45:43 -06:00
|
|
|
|
|
|
|
case "runoutput":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Run Go file and write its output into temporary Go file.
|
|
|
|
// Run generated Go file and verify its output.
|
2013-01-11 23:52:52 -07:00
|
|
|
rungatec <- true
|
|
|
|
defer func() {
|
|
|
|
<-rungatec
|
|
|
|
}()
|
2020-03-24 14:18:02 -06:00
|
|
|
runInDir = ""
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "run", goGcflags()}
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
|
|
|
cmd = append(cmd, t.goFileName())
|
|
|
|
out, err := runcmd(append(cmd, args...)...)
|
2012-04-20 09:45:43 -06:00
|
|
|
if err != nil {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
2014-09-11 13:47:17 -06:00
|
|
|
return
|
2012-04-20 09:45:43 -06:00
|
|
|
}
|
|
|
|
tfile := filepath.Join(t.tempDir, "tmp__.go")
|
2013-01-11 23:52:52 -07:00
|
|
|
if err := ioutil.WriteFile(tfile, out, 0666); err != nil {
|
2012-04-20 09:45:43 -06:00
|
|
|
t.err = fmt.Errorf("write tempfile:%s", err)
|
|
|
|
return
|
|
|
|
}
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd = []string{goTool(), "run", goGcflags()}
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
|
|
|
cmd = append(cmd, tfile)
|
|
|
|
out, err = runcmd(cmd...)
|
2012-04-20 09:45:43 -06:00
|
|
|
if err != nil {
|
2012-10-06 01:23:31 -06:00
|
|
|
t.err = err
|
2014-09-11 13:47:17 -06:00
|
|
|
return
|
2012-04-20 09:45:43 -06:00
|
|
|
}
|
2021-01-04 12:05:17 -07:00
|
|
|
t.checkExpectedOutput(out)
|
2012-11-07 13:33:54 -07:00
|
|
|
|
|
|
|
case "errorcheckoutput":
|
2018-06-01 04:14:48 -06:00
|
|
|
// Run Go file and write its output into temporary Go file.
|
|
|
|
// Compile and errorCheck generated Go file.
|
2020-03-24 14:18:02 -06:00
|
|
|
runInDir = ""
|
2018-03-03 06:47:20 -07:00
|
|
|
cmd := []string{goTool(), "run", goGcflags()}
|
2015-10-26 19:54:19 -06:00
|
|
|
if *linkshared {
|
|
|
|
cmd = append(cmd, "-linkshared")
|
|
|
|
}
|
|
|
|
cmd = append(cmd, t.goFileName())
|
|
|
|
out, err := runcmd(append(cmd, args...)...)
|
2012-11-07 13:33:54 -07:00
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
2014-09-11 13:47:17 -06:00
|
|
|
return
|
2012-11-07 13:33:54 -07:00
|
|
|
}
|
|
|
|
tfile := filepath.Join(t.tempDir, "tmp__.go")
|
|
|
|
err = ioutil.WriteFile(tfile, out, 0666)
|
|
|
|
if err != nil {
|
|
|
|
t.err = fmt.Errorf("write tempfile:%s", err)
|
|
|
|
return
|
|
|
|
}
|
2021-03-04 08:31:43 -07:00
|
|
|
cmdline := []string{goTool(), "tool", "compile", "-d=panic", "-e", "-o", "a.o"}
|
2012-11-07 13:33:54 -07:00
|
|
|
cmdline = append(cmdline, flags...)
|
|
|
|
cmdline = append(cmdline, tfile)
|
|
|
|
out, err = runcmd(cmdline...)
|
|
|
|
if wantError {
|
|
|
|
if err == nil {
|
|
|
|
t.err = fmt.Errorf("compilation succeeded unexpectedly\n%s", out)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
if err != nil {
|
|
|
|
t.err = err
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2016-09-22 11:50:16 -06:00
|
|
|
t.err = t.errorCheck(string(out), false, tfile, "tmp__.go")
|
2012-11-07 13:33:54 -07:00
|
|
|
return
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
var execCmd []string
|
|
|
|
|
|
|
|
func findExecCmd() []string {
|
|
|
|
if execCmd != nil {
|
|
|
|
return execCmd
|
|
|
|
}
|
|
|
|
execCmd = []string{} // avoid work the second time
|
|
|
|
if goos == runtime.GOOS && goarch == runtime.GOARCH {
|
|
|
|
return execCmd
|
|
|
|
}
|
|
|
|
path, err := exec.LookPath(fmt.Sprintf("go_%s_%s_exec", goos, goarch))
|
|
|
|
if err == nil {
|
|
|
|
execCmd = []string{path}
|
|
|
|
}
|
|
|
|
return execCmd
|
2014-08-01 14:34:36 -06:00
|
|
|
}
|
all: merge NaCl branch (part 1)
See golang.org/s/go13nacl for design overview.
This CL is the mostly mechanical changes from rsc's Go 1.2 based NaCl branch, specifically 39cb35750369 to 500771b477cf from https://code.google.com/r/rsc-go13nacl. This CL does not include working NaCl support, there are probably two or three more large merges to come.
CL 15750044 is not included as it involves more invasive changes to the linker which will need to be merged separately.
The exact change lists included are
15050047: syscall: support for Native Client
15360044: syscall: unzip implementation for Native Client
15370044: syscall: Native Client SRPC implementation
15400047: cmd/dist, cmd/go, go/build, test: support for Native Client
15410048: runtime: support for Native Client
15410049: syscall: file descriptor table for Native Client
15410050: syscall: in-memory file system for Native Client
15440048: all: update +build lines for Native Client port
15540045: cmd/6g, cmd/8g, cmd/gc: support for Native Client
15570045: os: support for Native Client
15680044: crypto/..., hash/crc32, reflect, sync/atomic: support for amd64p32
15690044: net: support for Native Client
15690048: runtime: support for fake time like on Go Playground
15690051: build: disable various tests on Native Client
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68150047
2014-02-25 07:47:42 -07:00
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
func (t *test) String() string {
|
|
|
|
return filepath.Join(t.dir, t.gofile)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (t *test) makeTempDir() {
|
|
|
|
var err error
|
|
|
|
t.tempDir, err = ioutil.TempDir("", "")
|
2020-02-08 23:40:45 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
2016-03-10 22:10:52 -07:00
|
|
|
if *keep {
|
|
|
|
log.Printf("Temporary directory is %s", t.tempDir)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
2021-01-04 12:05:17 -07:00
|
|
|
// checkExpectedOutput compares the output from compiling and/or running with the contents
|
|
|
|
// of the corresponding reference output file, if any (replace ".go" with ".out").
|
|
|
|
// If they don't match, fail with an informative message.
|
|
|
|
func (t *test) checkExpectedOutput(gotBytes []byte) {
|
|
|
|
got := string(gotBytes)
|
2012-02-20 20:28:49 -07:00
|
|
|
filename := filepath.Join(t.dir, t.gofile)
|
|
|
|
filename = filename[:len(filename)-len(".go")]
|
|
|
|
filename += ".out"
|
2021-01-04 12:05:17 -07:00
|
|
|
b, err := ioutil.ReadFile(filename)
|
|
|
|
// File is allowed to be missing (err != nil) in which case output should be empty.
|
|
|
|
got = strings.Replace(got, "\r\n", "\n", -1)
|
|
|
|
if got != string(b) {
|
|
|
|
if err == nil {
|
|
|
|
t.err = fmt.Errorf("output does not match expected in %s. Instead saw\n%s", filename, got)
|
|
|
|
} else {
|
|
|
|
t.err = fmt.Errorf("output should be empty when (optional) expected-output file %s is not present. Instead saw\n%s", filename, got)
|
|
|
|
}
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
2016-09-22 11:50:16 -06:00
|
|
|
func splitOutput(out string, wantAuto bool) []string {
|
2015-06-23 17:50:12 -06:00
|
|
|
// gc error messages continue onto additional lines with leading tabs.
|
2012-02-20 20:28:49 -07:00
|
|
|
// Split the output at the beginning of each line that doesn't begin with a tab.
|
2015-06-16 16:28:01 -06:00
|
|
|
// <autogenerated> lines are impossible to match so those are filtered out.
|
2015-02-19 12:00:11 -07:00
|
|
|
var res []string
|
|
|
|
for _, line := range strings.Split(out, "\n") {
|
2012-09-23 11:16:14 -06:00
|
|
|
if strings.HasSuffix(line, "\r") { // remove '\r', output by compiler on windows
|
2012-08-16 00:46:59 -06:00
|
|
|
line = line[:len(line)-1]
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
if strings.HasPrefix(line, "\t") {
|
2015-02-19 12:00:11 -07:00
|
|
|
res[len(res)-1] += "\n" + line
|
2016-09-22 11:50:16 -06:00
|
|
|
} else if strings.HasPrefix(line, "go tool") || strings.HasPrefix(line, "#") || !wantAuto && strings.HasPrefix(line, "<autogenerated>") {
|
2012-10-08 08:36:45 -06:00
|
|
|
continue
|
|
|
|
} else if strings.TrimSpace(line) != "" {
|
2015-02-19 12:00:11 -07:00
|
|
|
res = append(res, line)
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
}
|
2015-02-19 12:00:11 -07:00
|
|
|
return res
|
|
|
|
}
|
|
|
|
|
2018-06-01 04:14:48 -06:00
|
|
|
// errorCheck matches errors in outStr against comments in source files.
|
|
|
|
// For each line of the source files which should generate an error,
|
|
|
|
// there should be a comment of the form // ERROR "regexp".
|
|
|
|
// If outStr has an error for a line which has no such comment,
|
|
|
|
// this function will report an error.
|
|
|
|
// Likewise if outStr does not have an error for a line which has a comment,
|
|
|
|
// or if the error message does not match the <regexp>.
|
2018-10-07 19:19:51 -06:00
|
|
|
// The <regexp> syntax is Perl but it's best to stick to egrep.
|
2018-06-01 04:14:48 -06:00
|
|
|
//
|
|
|
|
// Sources files are supplied as fullshort slice.
|
2018-10-07 19:19:51 -06:00
|
|
|
// It consists of pairs: full path to source file and its base name.
|
2016-09-22 11:50:16 -06:00
|
|
|
func (t *test) errorCheck(outStr string, wantAuto bool, fullshort ...string) (err error) {
|
2015-02-19 12:00:11 -07:00
|
|
|
defer func() {
|
|
|
|
if *verbose && err != nil {
|
|
|
|
log.Printf("%s gc output:\n%s", t, outStr)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
var errs []error
|
2016-09-22 11:50:16 -06:00
|
|
|
out := splitOutput(outStr, wantAuto)
|
2012-02-20 20:28:49 -07:00
|
|
|
|
2012-03-06 23:54:39 -07:00
|
|
|
// Cut directory name.
|
|
|
|
for i := range out {
|
2013-01-02 13:31:49 -07:00
|
|
|
for j := 0; j < len(fullshort); j += 2 {
|
|
|
|
full, short := fullshort[j], fullshort[j+1]
|
|
|
|
out[i] = strings.Replace(out[i], full, short, -1)
|
|
|
|
}
|
|
|
|
}
|
2013-01-11 14:00:48 -07:00
|
|
|
|
2013-01-02 13:31:49 -07:00
|
|
|
var want []wantedError
|
|
|
|
for j := 0; j < len(fullshort); j += 2 {
|
|
|
|
full, short := fullshort[j], fullshort[j+1]
|
|
|
|
want = append(want, t.wantedErrors(full, short)...)
|
2012-03-06 23:54:39 -07:00
|
|
|
}
|
|
|
|
|
2013-01-02 13:31:49 -07:00
|
|
|
for _, we := range want {
|
2012-02-20 20:28:49 -07:00
|
|
|
var errmsgs []string
|
2016-09-22 11:50:16 -06:00
|
|
|
if we.auto {
|
|
|
|
errmsgs, out = partitionStrings("<autogenerated>", out)
|
|
|
|
} else {
|
|
|
|
errmsgs, out = partitionStrings(we.prefix, out)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
if len(errmsgs) == 0 {
|
2012-03-06 23:54:39 -07:00
|
|
|
errs = append(errs, fmt.Errorf("%s:%d: missing error %q", we.file, we.lineNum, we.reStr))
|
2012-02-20 20:28:49 -07:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
matched := false
|
2013-02-01 21:10:02 -07:00
|
|
|
n := len(out)
|
2012-02-20 20:28:49 -07:00
|
|
|
for _, errmsg := range errmsgs {
|
2016-10-17 22:34:57 -06:00
|
|
|
// Assume errmsg says "file:line: foo".
|
|
|
|
// Cut leading "file:line: " to avoid accidental matching of file name instead of message.
|
|
|
|
text := errmsg
|
|
|
|
if i := strings.Index(text, " "); i >= 0 {
|
|
|
|
text = text[i+1:]
|
|
|
|
}
|
|
|
|
if we.re.MatchString(text) {
|
2012-02-20 20:28:49 -07:00
|
|
|
matched = true
|
|
|
|
} else {
|
|
|
|
out = append(out, errmsg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if !matched {
|
2013-02-01 21:10:02 -07:00
|
|
|
errs = append(errs, fmt.Errorf("%s:%d: no match for %#q in:\n\t%s", we.file, we.lineNum, we.reStr, strings.Join(out[n:], "\n\t")))
|
2012-02-20 20:28:49 -07:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-10-08 08:36:45 -06:00
|
|
|
if len(out) > 0 {
|
|
|
|
errs = append(errs, fmt.Errorf("Unmatched Errors:"))
|
|
|
|
for _, errLine := range out {
|
|
|
|
errs = append(errs, fmt.Errorf("%s", errLine))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-02-20 20:28:49 -07:00
|
|
|
if len(errs) == 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
if len(errs) == 1 {
|
|
|
|
return errs[0]
|
|
|
|
}
|
|
|
|
var buf bytes.Buffer
|
2012-03-06 23:54:39 -07:00
|
|
|
fmt.Fprintf(&buf, "\n")
|
2012-02-20 20:28:49 -07:00
|
|
|
for _, err := range errs {
|
|
|
|
fmt.Fprintf(&buf, "%s\n", err.Error())
|
|
|
|
}
|
|
|
|
return errors.New(buf.String())
|
2015-02-19 12:00:11 -07:00
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
|
2016-02-29 08:43:18 -07:00
|
|
|
func (t *test) updateErrors(out, file string) {
|
|
|
|
base := path.Base(file)
|
2015-02-19 12:00:11 -07:00
|
|
|
// Read in source file.
|
|
|
|
src, err := ioutil.ReadFile(file)
|
|
|
|
if err != nil {
|
|
|
|
fmt.Fprintln(os.Stderr, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
lines := strings.Split(string(src), "\n")
|
|
|
|
// Remove old errors.
|
|
|
|
for i, ln := range lines {
|
|
|
|
pos := strings.Index(ln, " // ERROR ")
|
|
|
|
if pos >= 0 {
|
|
|
|
lines[i] = ln[:pos]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Parse new errors.
|
|
|
|
errors := make(map[int]map[string]bool)
|
|
|
|
tmpRe := regexp.MustCompile(`autotmp_[0-9]+`)
|
2016-09-22 11:50:16 -06:00
|
|
|
for _, errStr := range splitOutput(out, false) {
|
2015-02-19 12:00:11 -07:00
|
|
|
colon1 := strings.Index(errStr, ":")
|
2015-04-27 17:50:05 -06:00
|
|
|
if colon1 < 0 || errStr[:colon1] != file {
|
2015-02-19 12:00:11 -07:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
colon2 := strings.Index(errStr[colon1+1:], ":")
|
|
|
|
if colon2 < 0 {
|
|
|
|
continue
|
|
|
|
}
|
2015-04-27 17:50:05 -06:00
|
|
|
colon2 += colon1 + 1
|
|
|
|
line, err := strconv.Atoi(errStr[colon1+1 : colon2])
|
2015-02-19 12:00:11 -07:00
|
|
|
line--
|
|
|
|
if err != nil || line < 0 || line >= len(lines) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
msg := errStr[colon2+2:]
|
2016-02-29 08:43:18 -07:00
|
|
|
msg = strings.Replace(msg, file, base, -1) // normalize file mentions in error itself
|
|
|
|
msg = strings.TrimLeft(msg, " \t")
|
2018-12-04 08:00:16 -07:00
|
|
|
for _, r := range []string{`\`, `*`, `+`, `?`, `[`, `]`, `(`, `)`} {
|
2015-04-27 17:50:05 -06:00
|
|
|
msg = strings.Replace(msg, r, `\`+r, -1)
|
2015-02-19 12:00:11 -07:00
|
|
|
}
|
|
|
|
msg = strings.Replace(msg, `"`, `.`, -1)
|
|
|
|
msg = tmpRe.ReplaceAllLiteralString(msg, `autotmp_[0-9]+`)
|
|
|
|
if errors[line] == nil {
|
|
|
|
errors[line] = make(map[string]bool)
|
|
|
|
}
|
|
|
|
errors[line][msg] = true
|
|
|
|
}
|
|
|
|
// Add new errors.
|
|
|
|
for line, errs := range errors {
|
|
|
|
var sorted []string
|
|
|
|
for e := range errs {
|
|
|
|
sorted = append(sorted, e)
|
|
|
|
}
|
|
|
|
sort.Strings(sorted)
|
|
|
|
lines[line] += " // ERROR"
|
|
|
|
for _, e := range sorted {
|
|
|
|
lines[line] += fmt.Sprintf(` "%s$"`, e)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// Write new file.
|
|
|
|
err = ioutil.WriteFile(file, []byte(strings.Join(lines, "\n")), 0640)
|
|
|
|
if err != nil {
|
|
|
|
fmt.Fprintln(os.Stderr, err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
// Polish.
|
2018-03-03 06:47:20 -07:00
|
|
|
exec.Command(goTool(), "fmt", file).CombinedOutput()
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
2014-03-11 21:58:24 -06:00
|
|
|
// matchPrefix reports whether s is of the form ^(.*/)?prefix(:|[),
|
|
|
|
// That is, it needs the file name prefix followed by a : or a [,
|
|
|
|
// and possibly preceded by a directory name.
|
|
|
|
func matchPrefix(s, prefix string) bool {
|
|
|
|
i := strings.Index(s, ":")
|
|
|
|
if i < 0 {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
j := strings.LastIndex(s[:i], "/")
|
|
|
|
s = s[j+1:]
|
|
|
|
if len(s) <= len(prefix) || s[:len(prefix)] != prefix {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
switch s[len(prefix)] {
|
|
|
|
case '[', ':':
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
func partitionStrings(prefix string, strs []string) (matched, unmatched []string) {
|
2012-02-20 20:28:49 -07:00
|
|
|
for _, s := range strs {
|
2014-03-11 21:58:24 -06:00
|
|
|
if matchPrefix(s, prefix) {
|
2012-02-20 20:28:49 -07:00
|
|
|
matched = append(matched, s)
|
|
|
|
} else {
|
|
|
|
unmatched = append(unmatched, s)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
type wantedError struct {
|
2014-08-01 14:34:36 -06:00
|
|
|
reStr string
|
|
|
|
re *regexp.Regexp
|
|
|
|
lineNum int
|
2016-09-22 11:50:16 -06:00
|
|
|
auto bool // match <autogenerated> line
|
2014-08-01 14:34:36 -06:00
|
|
|
file string
|
|
|
|
prefix string
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
var (
|
|
|
|
errRx = regexp.MustCompile(`// (?:GC_)?ERROR (.*)`)
|
2016-09-22 11:50:16 -06:00
|
|
|
errAutoRx = regexp.MustCompile(`// (?:GC_)?ERRORAUTO (.*)`)
|
2012-02-20 20:28:49 -07:00
|
|
|
errQuotesRx = regexp.MustCompile(`"([^"]*)"`)
|
|
|
|
lineRx = regexp.MustCompile(`LINE(([+-])([0-9]+))?`)
|
|
|
|
)
|
|
|
|
|
2012-10-06 01:23:31 -06:00
|
|
|
func (t *test) wantedErrors(file, short string) (errs []wantedError) {
|
2014-03-11 21:58:24 -06:00
|
|
|
cache := make(map[string]*regexp.Regexp)
|
|
|
|
|
2012-10-06 01:23:31 -06:00
|
|
|
src, _ := ioutil.ReadFile(file)
|
|
|
|
for i, line := range strings.Split(string(src), "\n") {
|
2012-02-20 20:28:49 -07:00
|
|
|
lineNum := i + 1
|
|
|
|
if strings.Contains(line, "////") {
|
|
|
|
// double comment disables ERROR
|
|
|
|
continue
|
|
|
|
}
|
2016-09-22 11:50:16 -06:00
|
|
|
var auto bool
|
|
|
|
m := errAutoRx.FindStringSubmatch(line)
|
|
|
|
if m != nil {
|
|
|
|
auto = true
|
|
|
|
} else {
|
|
|
|
m = errRx.FindStringSubmatch(line)
|
|
|
|
}
|
2012-02-20 20:28:49 -07:00
|
|
|
if m == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
all := m[1]
|
|
|
|
mm := errQuotesRx.FindAllStringSubmatch(all, -1)
|
|
|
|
if mm == nil {
|
2013-02-01 21:10:02 -07:00
|
|
|
log.Fatalf("%s:%d: invalid errchk line: %s", t.goFileName(), lineNum, line)
|
2012-02-20 20:28:49 -07:00
|
|
|
}
|
|
|
|
for _, m := range mm {
|
|
|
|
rx := lineRx.ReplaceAllStringFunc(m[1], func(m string) string {
|
|
|
|
n := lineNum
|
|
|
|
if strings.HasPrefix(m, "LINE+") {
|
|
|
|
delta, _ := strconv.Atoi(m[5:])
|
|
|
|
n += delta
|
|
|
|
} else if strings.HasPrefix(m, "LINE-") {
|
|
|
|
delta, _ := strconv.Atoi(m[5:])
|
|
|
|
n -= delta
|
|
|
|
}
|
2012-10-06 01:23:31 -06:00
|
|
|
return fmt.Sprintf("%s:%d", short, n)
|
2012-02-20 20:28:49 -07:00
|
|
|
})
|
2014-03-11 21:58:24 -06:00
|
|
|
re := cache[rx]
|
|
|
|
if re == nil {
|
|
|
|
var err error
|
|
|
|
re, err = regexp.Compile(rx)
|
|
|
|
if err != nil {
|
2015-02-19 12:00:11 -07:00
|
|
|
log.Fatalf("%s:%d: invalid regexp \"%s\" in ERROR line: %v", t.goFileName(), lineNum, rx, err)
|
2014-03-11 21:58:24 -06:00
|
|
|
}
|
|
|
|
cache[rx] = re
|
2013-02-01 21:10:02 -07:00
|
|
|
}
|
2014-03-11 21:58:24 -06:00
|
|
|
prefix := fmt.Sprintf("%s:%d", short, lineNum)
|
2012-02-20 20:28:49 -07:00
|
|
|
errs = append(errs, wantedError{
|
2014-08-01 14:34:36 -06:00
|
|
|
reStr: rx,
|
|
|
|
re: re,
|
|
|
|
prefix: prefix,
|
2016-09-22 11:50:16 -06:00
|
|
|
auto: auto,
|
2014-08-01 14:34:36 -06:00
|
|
|
lineNum: lineNum,
|
|
|
|
file: short,
|
2012-02-20 20:28:49 -07:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return
|
|
|
|
}
|
2012-09-23 11:16:14 -06:00
|
|
|
|
2018-02-28 17:39:01 -07:00
|
|
|
const (
|
|
|
|
// Regexp to match a single opcode check: optionally begin with "-" (to indicate
|
|
|
|
// a negative check), followed by a string literal enclosed in "" or ``. For "",
|
|
|
|
// backslashes must be handled.
|
|
|
|
reMatchCheck = `-?(?:\x60[^\x60]*\x60|"(?:[^"\\]|\\.)*")`
|
|
|
|
)
|
|
|
|
|
2018-02-26 17:59:58 -07:00
|
|
|
var (
|
2018-02-28 17:39:01 -07:00
|
|
|
// Regexp to split a line in code and comment, trimming spaces
|
2018-05-19 01:42:52 -06:00
|
|
|
rxAsmComment = regexp.MustCompile(`^\s*(.*?)\s*(?://\s*(.+)\s*)?$`)
|
2018-02-28 17:39:01 -07:00
|
|
|
|
2018-05-19 01:42:52 -06:00
|
|
|
// Regexp to extract an architecture check: architecture name (or triplet),
|
|
|
|
// followed by semi-colon, followed by a comma-separated list of opcode checks.
|
|
|
|
// Extraneous spaces are ignored.
|
|
|
|
rxAsmPlatform = regexp.MustCompile(`(\w+)(/\w+)?(/\w*)?\s*:\s*(` + reMatchCheck + `(?:\s*,\s*` + reMatchCheck + `)*)`)
|
2018-02-28 17:39:01 -07:00
|
|
|
|
|
|
|
// Regexp to extract a single opcoded check
|
|
|
|
rxAsmCheck = regexp.MustCompile(reMatchCheck)
|
2018-04-15 11:00:27 -06:00
|
|
|
|
|
|
|
// List of all architecture variants. Key is the GOARCH architecture,
|
2018-04-15 14:53:58 -06:00
|
|
|
// value[0] is the variant-changing environment variable, and values[1:]
|
2018-04-15 11:00:27 -06:00
|
|
|
// are the supported variants.
|
|
|
|
archVariants = map[string][]string{
|
2020-10-06 15:42:15 -06:00
|
|
|
"386": {"GO386", "sse2", "softfloat"},
|
2018-04-15 11:00:27 -06:00
|
|
|
"amd64": {},
|
|
|
|
"arm": {"GOARM", "5", "6", "7"},
|
|
|
|
"arm64": {},
|
|
|
|
"mips": {"GOMIPS", "hardfloat", "softfloat"},
|
2018-04-26 07:37:27 -06:00
|
|
|
"mips64": {"GOMIPS64", "hardfloat", "softfloat"},
|
2019-01-11 12:16:28 -07:00
|
|
|
"ppc64": {"GOPPC64", "power8", "power9"},
|
|
|
|
"ppc64le": {"GOPPC64", "power8", "power9"},
|
2018-04-15 11:00:27 -06:00
|
|
|
"s390x": {},
|
2019-03-04 17:56:17 -07:00
|
|
|
"wasm": {},
|
2018-04-15 11:00:27 -06:00
|
|
|
}
|
2018-02-26 17:59:58 -07:00
|
|
|
)
|
|
|
|
|
2018-04-15 11:00:27 -06:00
|
|
|
// wantedAsmOpcode is a single asmcheck check
|
2018-02-26 17:59:58 -07:00
|
|
|
type wantedAsmOpcode struct {
|
2018-03-03 11:44:47 -07:00
|
|
|
fileline string // original source file/line (eg: "/path/foo.go:45")
|
|
|
|
line int // original source line
|
|
|
|
opcode *regexp.Regexp // opcode check to be performed on assembly output
|
|
|
|
negative bool // true if the check is supposed to fail rather than pass
|
|
|
|
found bool // true if the opcode check matched at least one in the output
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
|
2020-10-06 15:42:15 -06:00
|
|
|
// A build environment triplet separated by slashes (eg: linux/386/sse2).
|
2018-04-15 14:53:58 -06:00
|
|
|
// The third field can be empty if the arch does not support variants (eg: "plan9/amd64/")
|
2018-04-15 11:00:27 -06:00
|
|
|
type buildEnv string
|
|
|
|
|
|
|
|
// Environ returns the environment it represents in cmd.Environ() "key=val" format
|
2020-10-06 15:42:15 -06:00
|
|
|
// For instance, "linux/386/sse2".Environ() returns {"GOOS=linux", "GOARCH=386", "GO386=sse2"}
|
2018-04-15 11:00:27 -06:00
|
|
|
func (b buildEnv) Environ() []string {
|
|
|
|
fields := strings.Split(string(b), "/")
|
2018-04-15 14:53:58 -06:00
|
|
|
if len(fields) != 3 {
|
2018-04-15 11:00:27 -06:00
|
|
|
panic("invalid buildEnv string: " + string(b))
|
|
|
|
}
|
|
|
|
env := []string{"GOOS=" + fields[0], "GOARCH=" + fields[1]}
|
2018-04-15 14:53:58 -06:00
|
|
|
if fields[2] != "" {
|
2018-04-15 11:00:27 -06:00
|
|
|
env = append(env, archVariants[fields[1]][0]+"="+fields[2])
|
|
|
|
}
|
|
|
|
return env
|
|
|
|
}
|
|
|
|
|
|
|
|
// asmChecks represents all the asmcheck checks present in a test file
|
|
|
|
// The outer map key is the build triplet in which the checks must be performed.
|
|
|
|
// The inner map key represent the source file line ("filename.go:1234") at which the
|
|
|
|
// checks must be performed.
|
|
|
|
type asmChecks map[buildEnv]map[string][]wantedAsmOpcode
|
|
|
|
|
|
|
|
// Envs returns all the buildEnv in which at least one check is present
|
|
|
|
func (a asmChecks) Envs() []buildEnv {
|
|
|
|
var envs []buildEnv
|
|
|
|
for e := range a {
|
|
|
|
envs = append(envs, e)
|
|
|
|
}
|
|
|
|
sort.Slice(envs, func(i, j int) bool {
|
|
|
|
return string(envs[i]) < string(envs[j])
|
|
|
|
})
|
|
|
|
return envs
|
|
|
|
}
|
|
|
|
|
|
|
|
func (t *test) wantedAsmOpcodes(fn string) asmChecks {
|
|
|
|
ops := make(asmChecks)
|
2018-02-26 17:59:58 -07:00
|
|
|
|
2018-02-28 17:39:01 -07:00
|
|
|
comment := ""
|
2018-02-26 17:59:58 -07:00
|
|
|
src, _ := ioutil.ReadFile(fn)
|
|
|
|
for i, line := range strings.Split(string(src), "\n") {
|
2018-02-28 17:39:01 -07:00
|
|
|
matches := rxAsmComment.FindStringSubmatch(line)
|
|
|
|
code, cmt := matches[1], matches[2]
|
|
|
|
|
|
|
|
// Keep comments pending in the comment variable until
|
|
|
|
// we find a line that contains some code.
|
|
|
|
comment += " " + cmt
|
|
|
|
if code == "" {
|
2018-02-26 17:59:58 -07:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2018-02-28 17:39:01 -07:00
|
|
|
// Parse and extract any architecture check from comments,
|
|
|
|
// made by one architecture name and multiple checks.
|
2018-02-26 17:59:58 -07:00
|
|
|
lnum := fn + ":" + strconv.Itoa(i+1)
|
2018-02-28 17:39:01 -07:00
|
|
|
for _, ac := range rxAsmPlatform.FindAllStringSubmatch(comment, -1) {
|
2018-04-15 11:00:27 -06:00
|
|
|
archspec, allchecks := ac[1:4], ac[4]
|
|
|
|
|
|
|
|
var arch, subarch, os string
|
|
|
|
switch {
|
2020-10-06 15:42:15 -06:00
|
|
|
case archspec[2] != "": // 3 components: "linux/386/sse2"
|
2018-04-15 11:00:27 -06:00
|
|
|
os, arch, subarch = archspec[0], archspec[1][1:], archspec[2][1:]
|
2020-10-06 15:42:15 -06:00
|
|
|
case archspec[1] != "": // 2 components: "386/sse2"
|
2018-04-15 11:00:27 -06:00
|
|
|
os, arch, subarch = "linux", archspec[0], archspec[1][1:]
|
2020-10-06 15:42:15 -06:00
|
|
|
default: // 1 component: "386"
|
2018-04-15 11:00:27 -06:00
|
|
|
os, arch, subarch = "linux", archspec[0], ""
|
2019-03-04 17:56:17 -07:00
|
|
|
if arch == "wasm" {
|
|
|
|
os = "js"
|
|
|
|
}
|
2018-04-15 11:00:27 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
if _, ok := archVariants[arch]; !ok {
|
|
|
|
log.Fatalf("%s:%d: unsupported architecture: %v", t.goFileName(), i+1, arch)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create the build environments corresponding the above specifiers
|
|
|
|
envs := make([]buildEnv, 0, 4)
|
|
|
|
if subarch != "" {
|
|
|
|
envs = append(envs, buildEnv(os+"/"+arch+"/"+subarch))
|
|
|
|
} else {
|
|
|
|
subarchs := archVariants[arch]
|
|
|
|
if len(subarchs) == 0 {
|
2018-04-15 14:53:58 -06:00
|
|
|
envs = append(envs, buildEnv(os+"/"+arch+"/"))
|
2018-04-15 11:00:27 -06:00
|
|
|
} else {
|
|
|
|
for _, sa := range archVariants[arch][1:] {
|
|
|
|
envs = append(envs, buildEnv(os+"/"+arch+"/"+sa))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2018-02-28 17:39:01 -07:00
|
|
|
|
|
|
|
for _, m := range rxAsmCheck.FindAllString(allchecks, -1) {
|
|
|
|
negative := false
|
|
|
|
if m[0] == '-' {
|
|
|
|
negative = true
|
|
|
|
m = m[1:]
|
|
|
|
}
|
|
|
|
|
|
|
|
rxsrc, err := strconv.Unquote(m)
|
|
|
|
if err != nil {
|
|
|
|
log.Fatalf("%s:%d: error unquoting string: %v", t.goFileName(), i+1, err)
|
|
|
|
}
|
2018-02-28 17:55:33 -07:00
|
|
|
|
|
|
|
// Compile the checks as regular expressions. Notice that we
|
|
|
|
// consider checks as matching from the beginning of the actual
|
|
|
|
// assembler source (that is, what is left on each line of the
|
|
|
|
// compile -S output after we strip file/line info) to avoid
|
|
|
|
// trivial bugs such as "ADD" matching "FADD". This
|
|
|
|
// doesn't remove genericity: it's still possible to write
|
|
|
|
// something like "F?ADD", but we make common cases simpler
|
|
|
|
// to get right.
|
|
|
|
oprx, err := regexp.Compile("^" + rxsrc)
|
2018-02-28 17:39:01 -07:00
|
|
|
if err != nil {
|
|
|
|
log.Fatalf("%s:%d: %v", t.goFileName(), i+1, err)
|
|
|
|
}
|
2018-04-15 11:00:27 -06:00
|
|
|
|
|
|
|
for _, env := range envs {
|
|
|
|
if ops[env] == nil {
|
|
|
|
ops[env] = make(map[string][]wantedAsmOpcode)
|
|
|
|
}
|
|
|
|
ops[env][lnum] = append(ops[env][lnum], wantedAsmOpcode{
|
|
|
|
negative: negative,
|
|
|
|
fileline: lnum,
|
|
|
|
line: i + 1,
|
|
|
|
opcode: oprx,
|
|
|
|
})
|
2018-02-28 17:39:01 -07:00
|
|
|
}
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
}
|
2018-02-28 17:39:01 -07:00
|
|
|
comment = ""
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
|
2018-04-15 11:00:27 -06:00
|
|
|
return ops
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
|
2018-04-15 11:00:27 -06:00
|
|
|
func (t *test) asmCheck(outStr string, fn string, env buildEnv, fullops map[string][]wantedAsmOpcode) (err error) {
|
2018-03-03 11:44:47 -07:00
|
|
|
// The assembly output contains the concatenated dump of multiple functions.
|
|
|
|
// the first line of each function begins at column 0, while the rest is
|
|
|
|
// indented by a tabulation. These data structures help us index the
|
|
|
|
// output by function.
|
|
|
|
functionMarkers := make([]int, 1)
|
|
|
|
lineFuncMap := make(map[string]int)
|
|
|
|
|
|
|
|
lines := strings.Split(outStr, "\n")
|
2018-02-26 17:59:58 -07:00
|
|
|
rxLine := regexp.MustCompile(fmt.Sprintf(`\((%s:\d+)\)\s+(.*)`, regexp.QuoteMeta(fn)))
|
|
|
|
|
2018-03-03 11:44:47 -07:00
|
|
|
for nl, line := range lines {
|
|
|
|
// Check if this line begins a function
|
|
|
|
if len(line) > 0 && line[0] != '\t' {
|
|
|
|
functionMarkers = append(functionMarkers, nl)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Search if this line contains a assembly opcode (which is prefixed by the
|
|
|
|
// original source file/line in parenthesis)
|
2018-02-26 17:59:58 -07:00
|
|
|
matches := rxLine.FindStringSubmatch(line)
|
|
|
|
if len(matches) == 0 {
|
|
|
|
continue
|
|
|
|
}
|
2018-03-03 11:44:47 -07:00
|
|
|
srcFileLine, asm := matches[1], matches[2]
|
|
|
|
|
|
|
|
// Associate the original file/line information to the current
|
|
|
|
// function in the output; it will be useful to dump it in case
|
|
|
|
// of error.
|
|
|
|
lineFuncMap[srcFileLine] = len(functionMarkers) - 1
|
2018-02-26 17:59:58 -07:00
|
|
|
|
2018-03-03 11:44:47 -07:00
|
|
|
// If there are opcode checks associated to this source file/line,
|
|
|
|
// run the checks.
|
|
|
|
if ops, found := fullops[srcFileLine]; found {
|
|
|
|
for i := range ops {
|
|
|
|
if !ops[i].found && ops[i].opcode.FindString(asm) != "" {
|
|
|
|
ops[i].found = true
|
|
|
|
}
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2018-03-03 11:44:47 -07:00
|
|
|
functionMarkers = append(functionMarkers, len(lines))
|
2018-02-26 17:59:58 -07:00
|
|
|
|
2018-02-28 17:56:07 -07:00
|
|
|
var failed []wantedAsmOpcode
|
2018-02-26 17:59:58 -07:00
|
|
|
for _, ops := range fullops {
|
|
|
|
for _, o := range ops {
|
2018-02-28 17:56:07 -07:00
|
|
|
// There's a failure if a negative match was found,
|
|
|
|
// or a positive match was not found.
|
|
|
|
if o.negative == o.found {
|
|
|
|
failed = append(failed, o)
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2018-02-28 17:56:07 -07:00
|
|
|
if len(failed) == 0 {
|
2018-02-26 17:59:58 -07:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// At least one asmcheck failed; report them
|
2018-02-28 17:56:07 -07:00
|
|
|
sort.Slice(failed, func(i, j int) bool {
|
|
|
|
return failed[i].line < failed[j].line
|
2018-02-26 17:59:58 -07:00
|
|
|
})
|
|
|
|
|
2018-03-03 11:44:47 -07:00
|
|
|
lastFunction := -1
|
2018-02-26 17:59:58 -07:00
|
|
|
var errbuf bytes.Buffer
|
|
|
|
fmt.Fprintln(&errbuf)
|
2018-02-28 17:56:07 -07:00
|
|
|
for _, o := range failed {
|
2018-03-03 11:44:47 -07:00
|
|
|
// Dump the function in which this opcode check was supposed to
|
|
|
|
// pass but failed.
|
|
|
|
funcIdx := lineFuncMap[o.fileline]
|
|
|
|
if funcIdx != 0 && funcIdx != lastFunction {
|
|
|
|
funcLines := lines[functionMarkers[funcIdx]:functionMarkers[funcIdx+1]]
|
|
|
|
log.Println(strings.Join(funcLines, "\n"))
|
|
|
|
lastFunction = funcIdx // avoid printing same function twice
|
|
|
|
}
|
|
|
|
|
2018-02-28 17:56:07 -07:00
|
|
|
if o.negative {
|
2018-04-15 11:00:27 -06:00
|
|
|
fmt.Fprintf(&errbuf, "%s:%d: %s: wrong opcode found: %q\n", t.goFileName(), o.line, env, o.opcode.String())
|
2018-02-28 17:56:07 -07:00
|
|
|
} else {
|
2018-04-15 11:00:27 -06:00
|
|
|
fmt.Fprintf(&errbuf, "%s:%d: %s: opcode not found: %q\n", t.goFileName(), o.line, env, o.opcode.String())
|
2018-02-28 17:56:07 -07:00
|
|
|
}
|
2018-02-26 17:59:58 -07:00
|
|
|
}
|
|
|
|
err = errors.New(errbuf.String())
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2013-01-11 23:52:52 -07:00
|
|
|
// defaultRunOutputLimit returns the number of runoutput tests that
|
|
|
|
// can be executed in parallel.
|
|
|
|
func defaultRunOutputLimit() int {
|
|
|
|
const maxArmCPU = 2
|
|
|
|
|
|
|
|
cpu := runtime.NumCPU()
|
|
|
|
if runtime.GOARCH == "arm" && cpu > maxArmCPU {
|
|
|
|
cpu = maxArmCPU
|
|
|
|
}
|
|
|
|
return cpu
|
|
|
|
}
|
2013-01-28 13:29:45 -07:00
|
|
|
|
2013-08-13 10:25:41 -06:00
|
|
|
// checkShouldTest runs sanity checks on the shouldTest function.
|
2013-01-28 13:29:45 -07:00
|
|
|
func checkShouldTest() {
|
|
|
|
assert := func(ok bool, _ string) {
|
|
|
|
if !ok {
|
|
|
|
panic("fail")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
assertNot := func(ok bool, _ string) { assert(!ok, "") }
|
2013-08-13 10:25:41 -06:00
|
|
|
|
|
|
|
// Simple tests.
|
2013-01-28 13:29:45 -07:00
|
|
|
assert(shouldTest("// +build linux", "linux", "arm"))
|
|
|
|
assert(shouldTest("// +build !windows", "linux", "arm"))
|
|
|
|
assertNot(shouldTest("// +build !windows", "windows", "amd64"))
|
2013-08-13 10:25:41 -06:00
|
|
|
|
|
|
|
// A file with no build tags will always be tested.
|
2013-01-28 13:29:45 -07:00
|
|
|
assert(shouldTest("// This is a test.", "os", "arch"))
|
2013-08-13 10:25:41 -06:00
|
|
|
|
|
|
|
// Build tags separated by a space are OR-ed together.
|
|
|
|
assertNot(shouldTest("// +build arm 386", "linux", "amd64"))
|
|
|
|
|
2013-12-27 09:59:02 -07:00
|
|
|
// Build tags separated by a comma are AND-ed together.
|
2013-08-13 10:25:41 -06:00
|
|
|
assertNot(shouldTest("// +build !windows,!plan9", "windows", "amd64"))
|
|
|
|
assertNot(shouldTest("// +build !windows,!plan9", "plan9", "386"))
|
|
|
|
|
|
|
|
// Build tags on multiple lines are AND-ed together.
|
|
|
|
assert(shouldTest("// +build !windows\n// +build amd64", "linux", "amd64"))
|
|
|
|
assertNot(shouldTest("// +build !windows\n// +build amd64", "windows", "amd64"))
|
|
|
|
|
|
|
|
// Test that (!a OR !b) matches anything.
|
|
|
|
assert(shouldTest("// +build !windows !plan9", "windows", "amd64"))
|
2013-01-28 13:29:45 -07:00
|
|
|
}
|
2013-02-14 12:21:26 -07:00
|
|
|
|
2014-07-24 15:18:54 -06:00
|
|
|
func getenv(key, def string) string {
|
|
|
|
value := os.Getenv(key)
|
|
|
|
if value != "" {
|
|
|
|
return value
|
|
|
|
}
|
|
|
|
return def
|
|
|
|
}
|
2020-03-24 14:18:02 -06:00
|
|
|
|
|
|
|
// overlayDir makes a minimal-overhead copy of srcRoot in which new files may be added.
|
|
|
|
func overlayDir(dstRoot, srcRoot string) error {
|
|
|
|
dstRoot = filepath.Clean(dstRoot)
|
|
|
|
if err := os.MkdirAll(dstRoot, 0777); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
srcRoot, err := filepath.Abs(srcRoot)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2020-11-04 16:20:17 -07:00
|
|
|
return filepath.WalkDir(srcRoot, func(srcPath string, d fs.DirEntry, err error) error {
|
2020-03-24 14:18:02 -06:00
|
|
|
if err != nil || srcPath == srcRoot {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
suffix := strings.TrimPrefix(srcPath, srcRoot)
|
|
|
|
for len(suffix) > 0 && suffix[0] == filepath.Separator {
|
|
|
|
suffix = suffix[1:]
|
|
|
|
}
|
|
|
|
dstPath := filepath.Join(dstRoot, suffix)
|
|
|
|
|
2020-11-04 16:20:17 -07:00
|
|
|
var info fs.FileInfo
|
|
|
|
if d.Type()&os.ModeSymlink != 0 {
|
2020-03-24 14:18:02 -06:00
|
|
|
info, err = os.Stat(srcPath)
|
2020-11-04 16:20:17 -07:00
|
|
|
} else {
|
|
|
|
info, err = d.Info()
|
2020-03-24 14:18:02 -06:00
|
|
|
}
|
2020-11-04 16:20:17 -07:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
perm := info.Mode() & os.ModePerm
|
2020-03-24 14:18:02 -06:00
|
|
|
|
|
|
|
// Always copy directories (don't symlink them).
|
|
|
|
// If we add a file in the overlay, we don't want to add it in the original.
|
|
|
|
if info.IsDir() {
|
|
|
|
return os.MkdirAll(dstPath, perm|0200)
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the OS supports symlinks, use them instead of copying bytes.
|
|
|
|
if err := os.Symlink(srcPath, dstPath); err == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise, copy the bytes.
|
|
|
|
src, err := os.Open(srcPath)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer src.Close()
|
|
|
|
|
|
|
|
dst, err := os.OpenFile(dstPath, os.O_WRONLY|os.O_CREATE|os.O_EXCL, perm)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
_, err = io.Copy(dst, src)
|
|
|
|
if closeErr := dst.Close(); err == nil {
|
|
|
|
err = closeErr
|
|
|
|
}
|
|
|
|
return err
|
|
|
|
})
|
|
|
|
}
|
2020-12-03 12:11:05 -07:00
|
|
|
|
|
|
|
// List of files that the compiler cannot errorcheck with the new typechecker (compiler -G option).
|
|
|
|
// Temporary scaffolding until we pass all the tests at which point this map can be removed.
|
|
|
|
var excluded = map[string]bool{
|
2020-12-09 21:14:07 -07:00
|
|
|
"complit1.go": true, // types2 reports extra errors
|
|
|
|
"const2.go": true, // types2 not run after syntax errors
|
2020-12-03 19:15:50 -07:00
|
|
|
"ddd1.go": true, // issue #42987
|
|
|
|
"directive.go": true, // misplaced compiler directive checks
|
2020-12-09 21:14:07 -07:00
|
|
|
"float_lit3.go": true, // types2 reports extra errors
|
|
|
|
"import1.go": true, // types2 reports extra errors
|
2020-12-03 19:15:50 -07:00
|
|
|
"import5.go": true, // issue #42988
|
2020-12-09 21:14:07 -07:00
|
|
|
"import6.go": true, // issue #43109
|
|
|
|
"initializerr.go": true, // types2 reports extra errors
|
|
|
|
"linkname2.go": true, // error reported by noder (not running for types2 errorcheck test)
|
2021-01-24 22:04:39 -07:00
|
|
|
"notinheap.go": true, // types2 doesn't report errors about conversions that are invalid due to //go:notinheap
|
2020-12-03 19:15:50 -07:00
|
|
|
"shift1.go": true, // issue #42989
|
|
|
|
"typecheck.go": true, // invalid function is not causing errors when called
|
2021-01-24 22:04:39 -07:00
|
|
|
"writebarrier.go": true, // correct diagnostics, but different lines (probably irgen's fault)
|
2020-12-03 12:11:05 -07:00
|
|
|
|
2021-02-03 13:09:25 -07:00
|
|
|
"fixedbugs/bug176.go": true, // types2 reports all errors (pref: types2)
|
|
|
|
"fixedbugs/bug195.go": true, // types2 reports slightly different (but correct) bugs
|
|
|
|
"fixedbugs/bug228.go": true, // types2 not run after syntax errors
|
|
|
|
"fixedbugs/bug231.go": true, // types2 bug? (same error reported twice)
|
|
|
|
"fixedbugs/bug255.go": true, // types2 reports extra errors
|
|
|
|
"fixedbugs/bug351.go": true, // types2 reports extra errors
|
|
|
|
"fixedbugs/bug374.go": true, // types2 reports extra errors
|
|
|
|
"fixedbugs/bug385_32.go": true, // types2 doesn't produce missing error "type .* too large" (32-bit specific)
|
|
|
|
"fixedbugs/bug388.go": true, // types2 not run due to syntax errors
|
|
|
|
"fixedbugs/bug412.go": true, // types2 produces a follow-on error
|
2020-12-09 13:28:15 -07:00
|
|
|
|
|
|
|
"fixedbugs/issue11590.go": true, // types2 doesn't report a follow-on error (pref: types2)
|
|
|
|
"fixedbugs/issue11610.go": true, // types2 not run after syntax errors
|
2020-12-08 23:01:22 -07:00
|
|
|
"fixedbugs/issue11614.go": true, // types2 reports an extra error
|
|
|
|
"fixedbugs/issue13415.go": true, // declared but not used conflict
|
|
|
|
"fixedbugs/issue14520.go": true, // missing import path error by types2
|
|
|
|
"fixedbugs/issue16428.go": true, // types2 reports two instead of one error
|
2020-12-09 13:28:15 -07:00
|
|
|
"fixedbugs/issue17038.go": true, // types2 doesn't report a follow-on error (pref: types2)
|
|
|
|
"fixedbugs/issue17645.go": true, // multiple errors on same line
|
2021-01-24 22:04:39 -07:00
|
|
|
"fixedbugs/issue18331.go": true, // missing error about misuse of //go:noescape (irgen needs code from noder)
|
2020-12-09 13:28:15 -07:00
|
|
|
"fixedbugs/issue18393.go": true, // types2 not run after syntax errors
|
|
|
|
"fixedbugs/issue19012.go": true, // multiple errors on same line
|
|
|
|
"fixedbugs/issue20233.go": true, // types2 reports two instead of one error (pref: compiler)
|
|
|
|
"fixedbugs/issue20245.go": true, // types2 reports two instead of one error (pref: compiler)
|
2021-01-24 22:04:39 -07:00
|
|
|
"fixedbugs/issue20250.go": true, // correct diagnostics, but different lines (probably irgen's fault)
|
2020-12-09 13:28:15 -07:00
|
|
|
"fixedbugs/issue21979.go": true, // types2 doesn't report a follow-on error (pref: types2)
|
|
|
|
"fixedbugs/issue23732.go": true, // types2 reports different (but ok) line numbers
|
|
|
|
"fixedbugs/issue25958.go": true, // types2 doesn't report a follow-on error (pref: types2)
|
|
|
|
"fixedbugs/issue28079b.go": true, // types2 reports follow-on errors
|
|
|
|
"fixedbugs/issue28268.go": true, // types2 reports follow-on errors
|
|
|
|
"fixedbugs/issue33460.go": true, // types2 reports alternative positions in separate error
|
|
|
|
"fixedbugs/issue41575.go": true, // types2 reports alternative positions in separate error
|
|
|
|
"fixedbugs/issue42058a.go": true, // types2 doesn't report "channel element type too large"
|
|
|
|
"fixedbugs/issue42058b.go": true, // types2 doesn't report "channel element type too large"
|
|
|
|
"fixedbugs/issue4232.go": true, // types2 reports (correct) extra errors
|
|
|
|
"fixedbugs/issue4452.go": true, // types2 reports (correct) extra errors
|
2020-12-08 23:01:22 -07:00
|
|
|
"fixedbugs/issue5609.go": true, // types2 needs a better error message
|
2020-12-08 18:48:39 -07:00
|
|
|
"fixedbugs/issue6889.go": true, // types2 can handle this without constant overflow
|
2020-12-09 13:28:15 -07:00
|
|
|
"fixedbugs/issue7525.go": true, // types2 reports init cycle error on different line - ok otherwise
|
|
|
|
"fixedbugs/issue7525b.go": true, // types2 reports init cycle error on different line - ok otherwise
|
|
|
|
"fixedbugs/issue7525c.go": true, // types2 reports init cycle error on different line - ok otherwise
|
|
|
|
"fixedbugs/issue7525d.go": true, // types2 reports init cycle error on different line - ok otherwise
|
|
|
|
"fixedbugs/issue7525e.go": true, // types2 reports init cycle error on different line - ok otherwise
|
2020-12-03 12:11:05 -07:00
|
|
|
}
|