qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 03:24:49 -07:00
Code Releases Activity
c85848a4a6
go/test/fixedbugs/issue47068.dir/main.go

16 lines
230 B
Go
Raw Normal View History

cmd/compile: do not mark arrays used for map initialization noalg Arrays marked noalg are created by the compiler to hold keys and values to initialize map literals. The ssa backend creates a pointer type for the array type when creating an OpAddr while processing the loop that initializes the map from the arrays. The pointer type does not inherit the noalg property but points to the noalg array type. This causes values created through reflect of types that should be equal to compare unequal because the noalg and alg type might be compared and these are not the same. A similar problem occurred in #32595 for argument arrays of defer structs. Created #47904 to track improve noalg handling to be able to reintroduce this optimization again. Fixes #47068 Change-Id: I87549342bd404b98d71a3c0f33e3c169e9d4efc8 Reviewed-on: https://go-review.googlesource.com/c/go/+/344349 Trust: Martin Möhrmann <martin@golang.org> Run-TryBot: Martin Möhrmann <martin@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-07-06 13:45:02 -06:00
// Copyright 2021 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
import (
test: use dot-relative imports where appropriate Currently, run.go's *dir tests allow "x.go" to be imported interchangeably as either "x" or "./x". This is generally fine, but can cause problems when "x" is the name of a standard library package (e.g., "fixedbugs/bug345.dir/io.go"). This CL is an automated rewrite to change all `import "x"` directives to use `import "./x"` instead. It has no effect today, but will allow subsequent CLs to update test/run.go to resolve "./x" to "test/x" to avoid stdlib collisions. Change-Id: Ic76cd7140e83b47e764f8a499e59936be2b3c876 Reviewed-on: https://go-review.googlesource.com/c/go/+/395116 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
2022-03-23 16:09:31 -06:00
"./a"
"./b"
cmd/compile: do not mark arrays used for map initialization noalg Arrays marked noalg are created by the compiler to hold keys and values to initialize map literals. The ssa backend creates a pointer type for the array type when creating an OpAddr while processing the loop that initializes the map from the arrays. The pointer type does not inherit the noalg property but points to the noalg array type. This causes values created through reflect of types that should be equal to compare unequal because the noalg and alg type might be compared and these are not the same. A similar problem occurred in #32595 for argument arrays of defer structs. Created #47904 to track improve noalg handling to be able to reintroduce this optimization again. Fixes #47068 Change-Id: I87549342bd404b98d71a3c0f33e3c169e9d4efc8 Reviewed-on: https://go-review.googlesource.com/c/go/+/344349 Trust: Martin Möhrmann <martin@golang.org> Run-TryBot: Martin Möhrmann <martin@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-07-06 13:45:02 -06:00
)
func main() {
a.A()
b.B()
}
Copy Permalink