2012-02-16 21:48:57 -07:00
|
|
|
// errorcheck
|
2008-10-16 16:59:31 -06:00
|
|
|
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2012-02-18 19:19:43 -07:00
|
|
|
// Verify that illegal assignments with both explicit and implicit conversions of literals are detected.
|
|
|
|
// Does not compile.
|
|
|
|
|
2008-10-16 16:59:31 -06:00
|
|
|
package main
|
|
|
|
|
2015-05-01 20:50:27 -06:00
|
|
|
import "unsafe"
|
|
|
|
|
2012-02-18 19:19:43 -07:00
|
|
|
// explicit conversion of constants
|
2010-09-03 18:36:13 -06:00
|
|
|
var x1 = string(1)
|
|
|
|
var x2 string = string(1)
|
2011-01-19 21:09:00 -07:00
|
|
|
var x3 = int(1.5) // ERROR "convert|truncate"
|
|
|
|
var x4 int = int(1.5) // ERROR "convert|truncate"
|
2010-09-03 18:36:13 -06:00
|
|
|
var x5 = "a" + string(1)
|
2011-01-19 21:09:00 -07:00
|
|
|
var x6 = int(1e100) // ERROR "overflow"
|
|
|
|
var x7 = float32(1e1000) // ERROR "overflow"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2015-05-01 20:50:27 -06:00
|
|
|
// unsafe.Pointer can only convert to/from uintptr
|
|
|
|
var _ = string(unsafe.Pointer(uintptr(65))) // ERROR "convert"
|
|
|
|
var _ = float64(unsafe.Pointer(uintptr(65))) // ERROR "convert"
|
|
|
|
var _ = int(unsafe.Pointer(uintptr(65))) // ERROR "convert"
|
|
|
|
|
2008-10-16 16:59:31 -06:00
|
|
|
// implicit conversions merit scrutiny
|
2010-09-03 18:36:13 -06:00
|
|
|
var s string
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad1 string = 1 // ERROR "conver|incompatible|invalid|cannot"
|
cmd/compile: rewrite untyped constant conversion logic
This CL detangles the hairy mess that was convlit+defaultlit. In
particular, it makes the following changes:
1. convlit1 now follows the standard typecheck behavior of setting
"n.Type = nil" if there's an error. Notably, this means for a lot of
test cases, we now avoid reporting useless follow-on error messages.
For example, after reporting that "1 << s + 1.0" has an invalid shift,
we no longer also report that it can't be assigned to string.
2. Previously, assignconvfn had some extra logic for trying to
suppress errors from convlit/defaultlit so that it could provide its
own errors with better context information. Instead, this extra
context information is now passed down into convlit1 directly.
3. Relatedly, this CL also removes redundant calls to defaultlit prior
to assignconv. As a consequence, when an expression doesn't make sense
for a particular assignment (e.g., assigning an untyped string to an
integer), the error messages now say "untyped string" instead of just
"string". This is more consistent with go/types behavior.
4. defaultlit2 is now smarter about only trying to convert pairs of
untyped constants when it's likely to succeed. This allows us to
report better error messages for things like 3+"x"; instead of "cannot
convert 3 to string" we now report "mismatched types untyped number
and untyped string".
Passes toolstash-check.
Change-Id: I26822a02dc35855bd0ac774907b1cf5737e91882
Reviewed-on: https://go-review.googlesource.com/c/go/+/187657
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2019-09-05 14:33:06 -06:00
|
|
|
var bad2 = s + 1 // ERROR "conver|incompatible|invalid|cannot"
|
|
|
|
var bad3 = s + 'a' // ERROR "conver|incompatible|invalid|cannot"
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad4 = "a" + 1 // ERROR "literals|incompatible|convert|invalid"
|
|
|
|
var bad5 = "a" + 'a' // ERROR "literals|incompatible|convert|invalid"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad6 int = 1.5 // ERROR "convert|truncate"
|
|
|
|
var bad7 int = 1e100 // ERROR "overflow"
|
|
|
|
var bad8 float32 = 1e200 // ERROR "overflow"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
|
|
|
// but these implicit conversions are okay
|
2010-09-03 18:36:13 -06:00
|
|
|
var good1 string = "a"
|
|
|
|
var good2 int = 1.0
|
|
|
|
var good3 int = 1e9
|
2011-01-19 21:09:00 -07:00
|
|
|
var good4 float64 = 1e20
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2010-02-25 16:11:07 -07:00
|
|
|
// explicit conversion of string is okay
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ = []rune("abc")
|
2010-02-25 16:11:07 -07:00
|
|
|
var _ = []byte("abc")
|
|
|
|
|
|
|
|
// implicit is not
|
2011-01-19 21:09:00 -07:00
|
|
|
var _ []int = "abc" // ERROR "cannot use|incompatible|invalid"
|
|
|
|
var _ []byte = "abc" // ERROR "cannot use|incompatible|invalid"
|
2010-02-25 16:11:07 -07:00
|
|
|
|
|
|
|
// named string is okay
|
|
|
|
type Tstring string
|
2011-01-19 21:09:00 -07:00
|
|
|
|
2010-02-25 16:11:07 -07:00
|
|
|
var ss Tstring = "abc"
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ = []rune(ss)
|
2010-02-25 16:11:07 -07:00
|
|
|
var _ = []byte(ss)
|
|
|
|
|
|
|
|
// implicit is still not
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ []rune = ss // ERROR "cannot use|incompatible|invalid"
|
2011-01-19 21:09:00 -07:00
|
|
|
var _ []byte = ss // ERROR "cannot use|incompatible|invalid"
|
2010-02-25 16:11:07 -07:00
|
|
|
|
2011-11-22 10:30:02 -07:00
|
|
|
// named slice is now ok
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
type Trune []rune
|
2010-02-25 16:11:07 -07:00
|
|
|
type Tbyte []byte
|
2011-01-19 21:09:00 -07:00
|
|
|
|
2011-11-22 10:30:02 -07:00
|
|
|
var _ = Trune("abc") // ok
|
|
|
|
var _ = Tbyte("abc") // ok
|
2010-02-25 16:11:07 -07:00
|
|
|
|
|
|
|
// implicit is still not
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ Trune = "abc" // ERROR "cannot use|incompatible|invalid"
|
2011-01-19 21:09:00 -07:00
|
|
|
var _ Tbyte = "abc" // ERROR "cannot use|incompatible|invalid"
|