go/test/fixedbugs/issue42686.go

// compile -goexperiment fieldtrack

// Copyright 2020 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package p

func a(x struct{ f int }) { _ = x.f }

func b() { a(struct{ f int }{}) }
test: switch fieldtrack test to use GOEXPERIMENT Now that we can set GOEXPERIMENT at build time, we no longer need -d=fieldtrack in the compiler to enabled field tracking at build time. Switch the one test that uses -d=fieldtrack to use GOEXPERIMENT instead so we can eliminate this debug flag and centralize on GOEXPERIMENT. Updates #42681. Change-Id: I14c352c9a97187b9c5ec8027ff672d685f22f543 Reviewed-on: https://go-review.googlesource.com/c/go/+/302969 Trust: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> 2021-03-18 09:35:45 -06:00			`// compile -goexperiment fieldtrack`
cmd/compile: fix panic in field tracking logic Within the frontend, we generally don't guarantee uniqueness of anonymous types. For example, each struct type literal gets represented by its own types.Type instance. However, the field tracking code was using the struct type as a map key. This broke in golang.org/cl/256457, because that CL started changing the inlined parameter variables from using the types.Type of the declared parameter to that of the call site argument. These are always identical types (e.g., types.Identical would report true), but they can be different pointer values, causing the map lookup to fail. The easiest fix is to simply get rid of the map and instead use Node.Opt for tracking the types.Field. To mitigate against more latent field tracking failures (e.g., if any other code were to start trying to use Opt on ODOT/ODOTPTR fields), we store this field unconditionally. I also expect having the types.Field will be useful to other frontend code in the future. Finally, to make it easier to test field tracking without having to run make.bash with GOEXPERIMENT=fieldtrack, this commit adds a -d=fieldtrack flag as an alternative way to enable field tracking within the compiler. See also #42681. Fixes #42686. Change-Id: I6923d206d5e2cab1e6798cba36cae96c1eeaea55 Reviewed-on: https://go-review.googlesource.com/c/go/+/271217 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com> Trust: Matthew Dempsky <mdempsky@google.com> 2020-11-18 13:08:59 -07:00
			`// Copyright 2020 The Go Authors. All rights reserved.`
			`// Use of this source code is governed by a BSD-style`
			`// license that can be found in the LICENSE file.`

			`package p`

			`func a(x struct{ f int }) { _ = x.f }`

			`func b() { a(struct{ f int }{}) }`