qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 05:44:40 -07:00
Code Releases Activity
a644f81d5e
go/internal/lsp/testdata/func_rank/func_rank.go.in

45 lines
1.6 KiB
Go
Raw Normal View History

internal/lsp: rank types higher when completing in return of a function Completion now ranks type names higher for func receiver, type params and type results (e.g. func (<>) foo(<>) (<>) {}). Fixes golang/go#29152 Change-Id: Icdd18b1b344c1cd617a4f45a7b071e53c1345478 GitHub-Last-Rev: e6acb1f2d2a7e571ffcecc500e407fdefd118fed GitHub-Pull-Request: golang/tools#73 Reviewed-on: https://go-review.googlesource.com/c/159797 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-01-31 23:40:03 -07:00
package func_rank
internal/lsp: improve expected type determination Improve expected type determination for the following cases: - search back further through ast path to handle cases where the position's node is more than two nodes from the ancestor node with type information - generate expected type for return statements - wrap and unwrap pointerness from expected type when position is preceded by "*" (dereference) or "&" (reference) operators, respectively - fix some false positive expected types when completing the "Fun" (left) side of a CallExpr Change-Id: I907ee3e405bd8420031a7b03329de5df1c3493b9 GitHub-Last-Rev: 20a0ac9bf2b5350494c6738f5960676cc50fb454 GitHub-Pull-Request: golang/tools#93 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 10:26:15 -06:00
var stringAVar = "var" //@item(stringAVar, "stringAVar", "string", "var")
internal/lsp: move function signature into detail instead of label Fixes golang/go#32414 Change-Id: If08e655d7a0e29b0865c13d8377e98be01cf24c5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/184777 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-07-02 16:10:05 -06:00
func stringBFunc() string { return "str" } //@item(stringBFunc, "stringBFunc", "func() string", "func")
internal/lsp: improve expected type determination Improve expected type determination for the following cases: - search back further through ast path to handle cases where the position's node is more than two nodes from the ancestor node with type information - generate expected type for return statements - wrap and unwrap pointerness from expected type when position is preceded by "*" (dereference) or "&" (reference) operators, respectively - fix some false positive expected types when completing the "Fun" (left) side of a CallExpr Change-Id: I907ee3e405bd8420031a7b03329de5df1c3493b9 GitHub-Last-Rev: 20a0ac9bf2b5350494c6738f5960676cc50fb454 GitHub-Pull-Request: golang/tools#93 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 10:26:15 -06:00
type stringer struct{} //@item(stringer, "stringer", "struct{...}", "struct")
internal/lsp: rank types higher when completing in return of a function Completion now ranks type names higher for func receiver, type params and type results (e.g. func (<>) foo(<>) (<>) {}). Fixes golang/go#29152 Change-Id: Icdd18b1b344c1cd617a4f45a7b071e53c1345478 GitHub-Last-Rev: e6acb1f2d2a7e571ffcecc500e407fdefd118fed GitHub-Pull-Request: golang/tools#73 Reviewed-on: https://go-review.googlesource.com/c/159797 TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-01-31 23:40:03 -07:00
func _() stringer //@complete("tr", stringer, stringAVar, stringBFunc)
func _(val stringer) {} //@complete("tr", stringer, stringAVar, stringBFunc)
func (stringer) _() {} //@complete("tr", stringer, stringAVar, stringBFunc)
internal/lsp: improve expected type determination Improve expected type determination for the following cases: - search back further through ast path to handle cases where the position's node is more than two nodes from the ancestor node with type information - generate expected type for return statements - wrap and unwrap pointerness from expected type when position is preceded by "*" (dereference) or "&" (reference) operators, respectively - fix some false positive expected types when completing the "Fun" (left) side of a CallExpr Change-Id: I907ee3e405bd8420031a7b03329de5df1c3493b9 GitHub-Last-Rev: 20a0ac9bf2b5350494c6738f5960676cc50fb454 GitHub-Pull-Request: golang/tools#93 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 10:26:15 -06:00
func _() {
var s struct {
AA int //@item(rankAA, "AA", "int", "field")
AB string //@item(rankAB, "AB", "string", "field")
AC int //@item(rankAC, "AC", "int", "field")
}
fnStr := func(string) {}
fnStr(s.A) //@complete(")", rankAB, rankAA, rankAC)
fnStr("" + s.A) //@complete(")", rankAB, rankAA, rankAC)
fnInt := func(int) {}
fnInt(-s.A) //@complete(")", rankAA, rankAC, rankAB)
// no expected type
fnInt(func() int { s.A }) //@complete(" }", rankAA, rankAB, rankAC)
fnInt(s.A()) //@complete("()", rankAA, rankAB, rankAC)
internal/lsp: handle more expected type cases Calculate expected type in the following cases: - switch case statements - index expressions (e.g. []int{}[<>] or map[string]int{}[<>]) - slice expressions (e.g. []int{}[1:<>]) - channel send statements - channel receive expression We now also prefer type names in type switch clauses and type asserts. Change-Id: Iff8c317a9116868b36701d931c802d9147f962d8 GitHub-Last-Rev: e039a45aebe1c6aa9b2011cad67ddaa5e4ed4d77 GitHub-Pull-Request: golang/tools#97 Reviewed-on: https://go-review.googlesource.com/c/tools/+/176941 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-15 16:29:19 -06:00
fnInt([]int{}[s.A]) //@complete("])", rankAA, rankAC, rankAB)
fnInt([]int{}[:s.A]) //@complete("])", rankAA, rankAC, rankAB)
internal/lsp: improve expected type determination Improve expected type determination for the following cases: - search back further through ast path to handle cases where the position's node is more than two nodes from the ancestor node with type information - generate expected type for return statements - wrap and unwrap pointerness from expected type when position is preceded by "*" (dereference) or "&" (reference) operators, respectively - fix some false positive expected types when completing the "Fun" (left) side of a CallExpr Change-Id: I907ee3e405bd8420031a7b03329de5df1c3493b9 GitHub-Last-Rev: 20a0ac9bf2b5350494c6738f5960676cc50fb454 GitHub-Pull-Request: golang/tools#93 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 10:26:15 -06:00
internal/lsp/source: improve completion in type assertions In cases like: var foo *someType = bar.(some<>) We will now complete "some" to "*someType". This involved two changes: 1. Properly detect expected type as *someType in above example. To do this I just removed *ast.TypeAssertExpr from breaksExpectedTypeInference() so we continue searching up the AST for the expected type. 2. If the given type name T doesn't match, also try *T. If *T does match, we mark the candidate as "makePointer=true" so we know to prepend the "*" when formatting the candidate. Change-Id: I05859c68082a798141755b614673a1483d864e3e Reviewed-on: https://go-review.googlesource.com/c/tools/+/212717 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-27 09:57:52 -07:00
fnInt(s.A.(int)) //@complete(".(", rankAA, rankAC, rankAB)
internal/lsp: improve expected type determination Improve expected type determination for the following cases: - search back further through ast path to handle cases where the position's node is more than two nodes from the ancestor node with type information - generate expected type for return statements - wrap and unwrap pointerness from expected type when position is preceded by "*" (dereference) or "&" (reference) operators, respectively - fix some false positive expected types when completing the "Fun" (left) side of a CallExpr Change-Id: I907ee3e405bd8420031a7b03329de5df1c3493b9 GitHub-Last-Rev: 20a0ac9bf2b5350494c6738f5960676cc50fb454 GitHub-Pull-Request: golang/tools#93 Reviewed-on: https://go-review.googlesource.com/c/tools/+/174477 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-05-10 10:26:15 -06:00
fnPtr := func(*string) {}
fnPtr(&s.A) //@complete(")", rankAB, rankAA, rankAC)
var aaPtr *string //@item(rankAAPtr, "aaPtr", "*string", "var")
var abPtr *int //@item(rankABPtr, "abPtr", "*int", "var")
fnInt(*a) //@complete(")", rankABPtr, rankAAPtr)
_ = func() string {
return s.A //@complete(" //", rankAB, rankAA, rankAC)
}
}
Copy Permalink