2013-12-13 08:04:55 -07:00
|
|
|
package oracle
|
|
|
|
|
|
|
|
// This file defines utilities for working with file positions.
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"go/parser"
|
|
|
|
"go/token"
|
|
|
|
"os"
|
|
|
|
"path/filepath"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
|
|
|
|
2015-01-08 19:32:51 -07:00
|
|
|
"golang.org/x/tools/go/ast/astutil"
|
2013-12-13 08:04:55 -07:00
|
|
|
)
|
|
|
|
|
|
|
|
// parseOctothorpDecimal returns the numeric value if s matches "#%d",
|
|
|
|
// otherwise -1.
|
|
|
|
func parseOctothorpDecimal(s string) int {
|
|
|
|
if s != "" && s[0] == '#' {
|
|
|
|
if s, err := strconv.ParseInt(s[1:], 10, 32); err == nil {
|
|
|
|
return int(s)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
|
|
|
|
// parsePosFlag parses a string of the form "file:pos" or
|
|
|
|
// file:start,end" where pos, start, end match #%d and represent byte
|
|
|
|
// offsets, and returns its components.
|
|
|
|
//
|
|
|
|
// (Numbers without a '#' prefix are reserved for future use,
|
|
|
|
// e.g. to indicate line/column positions.)
|
|
|
|
//
|
|
|
|
func parsePosFlag(posFlag string) (filename string, startOffset, endOffset int, err error) {
|
|
|
|
if posFlag == "" {
|
|
|
|
err = fmt.Errorf("no source position specified (-pos flag)")
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
colon := strings.LastIndex(posFlag, ":")
|
|
|
|
if colon < 0 {
|
|
|
|
err = fmt.Errorf("invalid source position -pos=%q", posFlag)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
filename, offset := posFlag[:colon], posFlag[colon+1:]
|
|
|
|
startOffset = -1
|
|
|
|
endOffset = -1
|
|
|
|
if hyphen := strings.Index(offset, ","); hyphen < 0 {
|
|
|
|
// e.g. "foo.go:#123"
|
|
|
|
startOffset = parseOctothorpDecimal(offset)
|
|
|
|
endOffset = startOffset
|
|
|
|
} else {
|
|
|
|
// e.g. "foo.go:#123,#456"
|
|
|
|
startOffset = parseOctothorpDecimal(offset[:hyphen])
|
|
|
|
endOffset = parseOctothorpDecimal(offset[hyphen+1:])
|
|
|
|
}
|
|
|
|
if startOffset < 0 || endOffset < 0 {
|
|
|
|
err = fmt.Errorf("invalid -pos offset %q", offset)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// findQueryPos searches fset for filename and translates the
|
|
|
|
// specified file-relative byte offsets into token.Pos form. It
|
|
|
|
// returns an error if the file was not found or the offsets were out
|
|
|
|
// of bounds.
|
|
|
|
//
|
|
|
|
func findQueryPos(fset *token.FileSet, filename string, startOffset, endOffset int) (start, end token.Pos, err error) {
|
|
|
|
var file *token.File
|
|
|
|
fset.Iterate(func(f *token.File) bool {
|
|
|
|
if sameFile(filename, f.Name()) {
|
|
|
|
// (f.Name() is absolute)
|
|
|
|
file = f
|
|
|
|
return false // done
|
|
|
|
}
|
|
|
|
return true // continue
|
|
|
|
})
|
|
|
|
if file == nil {
|
|
|
|
err = fmt.Errorf("couldn't find file containing position")
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Range check [start..end], inclusive of both end-points.
|
|
|
|
|
|
|
|
if 0 <= startOffset && startOffset <= file.Size() {
|
|
|
|
start = file.Pos(int(startOffset))
|
|
|
|
} else {
|
|
|
|
err = fmt.Errorf("start position is beyond end of file")
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if 0 <= endOffset && endOffset <= file.Size() {
|
|
|
|
end = file.Pos(int(endOffset))
|
|
|
|
} else {
|
|
|
|
err = fmt.Errorf("end position is beyond end of file")
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// sameFile returns true if x and y have the same basename and denote
|
|
|
|
// the same file.
|
|
|
|
//
|
|
|
|
func sameFile(x, y string) bool {
|
|
|
|
if filepath.Base(x) == filepath.Base(y) { // (optimisation)
|
|
|
|
if xi, err := os.Stat(x); err == nil {
|
|
|
|
if yi, err := os.Stat(y); err == nil {
|
|
|
|
return os.SameFile(xi, yi)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// fastQueryPos parses the -pos flag and returns a QueryPos.
|
|
|
|
// It parses only a single file, and does not run the type checker.
|
oracle: several major improvements
Features:
More robust: silently ignore type errors in modes that don't need
SSA form: describe, referrers, implements, freevars, description.
This makes the tool much more robust for everyday queries.
Less configuration: don't require a scope argument for all queries.
Only queries that do pointer analysis need it.
For the rest, the initial position is enough for
importQueryPackage to deduce the scope.
It now works for queries in GoFiles, TestGoFiles, or XTestGoFiles.
(It no longer works for ad-hoc main packages like
$GOROOT/src/net/http/triv.go)
More complete: "referrers" computes the scope automatically by
scanning the import graph of the entire workspace, using gorename's
refactor/importgraph package. This requires two passes at loading.
Faster: simplified start-up logic avoids unnecessary package loading
and SSA construction (a consequence of bad abstraction) in many
cases.
"callgraph": remove it. Unlike all the other commands it isn't
related to the current selection, and we have
golang.org/x/tools/cmdcallgraph now.
Internals:
Drop support for long-running clients (i.e., Pythia), since
godoc -analysis supports all the same features except "pointsto",
and precomputes all the results so latency is much lower.
Get rid of various unhelpful abstractions introduced to support
long-running clients. Expand out the set-up logic for each
subcommand. This is simpler, easier to read, and gives us more
control, at a small cost in duplication---the familiar story of
abstractions.
Discard PTA warnings. We weren't showing them (nor should we).
Split tests into separate directories (so that importgraph works).
Change-Id: I55d46b3ab33cdf7ac22436fcc2148fe04c901237
Reviewed-on: https://go-review.googlesource.com/8243
Reviewed-by: David Crawshaw <crawshaw@golang.org>
2015-03-30 09:21:48 -06:00
|
|
|
func fastQueryPos(posFlag string) (*queryPos, error) {
|
2013-12-13 08:04:55 -07:00
|
|
|
filename, startOffset, endOffset, err := parsePosFlag(posFlag)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
fset := token.NewFileSet()
|
|
|
|
f, err := parser.ParseFile(fset, filename, nil, 0)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
start, end, err := findQueryPos(fset, filename, startOffset, endOffset)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
path, exact := astutil.PathEnclosingInterval(f, start, end)
|
|
|
|
if path == nil {
|
|
|
|
return nil, fmt.Errorf("no syntax here")
|
|
|
|
}
|
|
|
|
|
oracle: several major improvements
Features:
More robust: silently ignore type errors in modes that don't need
SSA form: describe, referrers, implements, freevars, description.
This makes the tool much more robust for everyday queries.
Less configuration: don't require a scope argument for all queries.
Only queries that do pointer analysis need it.
For the rest, the initial position is enough for
importQueryPackage to deduce the scope.
It now works for queries in GoFiles, TestGoFiles, or XTestGoFiles.
(It no longer works for ad-hoc main packages like
$GOROOT/src/net/http/triv.go)
More complete: "referrers" computes the scope automatically by
scanning the import graph of the entire workspace, using gorename's
refactor/importgraph package. This requires two passes at loading.
Faster: simplified start-up logic avoids unnecessary package loading
and SSA construction (a consequence of bad abstraction) in many
cases.
"callgraph": remove it. Unlike all the other commands it isn't
related to the current selection, and we have
golang.org/x/tools/cmdcallgraph now.
Internals:
Drop support for long-running clients (i.e., Pythia), since
godoc -analysis supports all the same features except "pointsto",
and precomputes all the results so latency is much lower.
Get rid of various unhelpful abstractions introduced to support
long-running clients. Expand out the set-up logic for each
subcommand. This is simpler, easier to read, and gives us more
control, at a small cost in duplication---the familiar story of
abstractions.
Discard PTA warnings. We weren't showing them (nor should we).
Split tests into separate directories (so that importgraph works).
Change-Id: I55d46b3ab33cdf7ac22436fcc2148fe04c901237
Reviewed-on: https://go-review.googlesource.com/8243
Reviewed-by: David Crawshaw <crawshaw@golang.org>
2015-03-30 09:21:48 -06:00
|
|
|
return &queryPos{fset, start, end, path, exact, nil}, nil
|
2013-12-13 08:04:55 -07:00
|
|
|
}
|