2019-07-25 13:54:03 -06:00
|
|
|
// errorcheck -0 -m -l
|
2015-02-19 06:27:32 -07:00
|
|
|
|
2016-04-10 15:32:26 -06:00
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
2015-02-19 06:27:32 -07:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
// Test escape analysis for interface conversions.
|
|
|
|
|
|
|
|
package escape
|
|
|
|
|
|
|
|
var sink interface{}
|
|
|
|
|
|
|
|
type M interface {
|
|
|
|
M()
|
|
|
|
}
|
|
|
|
|
|
|
|
func mescapes(m M) { // ERROR "leaking param: m"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = m
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
func mdoesnotescape(m M) { // ERROR "m does not escape"
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests for type stored directly in iface and with value receiver method.
|
|
|
|
type M0 struct {
|
|
|
|
p *int
|
|
|
|
}
|
|
|
|
|
|
|
|
func (M0) M() {
|
|
|
|
}
|
|
|
|
|
|
|
|
func efaceEscape0() {
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
_ = x
|
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
|
|
|
sink = x
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(M0)
|
|
|
|
_ = v1
|
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
2015-02-19 06:27:32 -07:00
|
|
|
// BAD: v does not escape to heap here
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(M0)
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = v1
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
2020-10-28 19:49:10 -06:00
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2020-10-28 19:49:10 -06:00
|
|
|
x.M() // ERROR "devirtualizing x.M"
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
mescapes(x)
|
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M0{&i}
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
mdoesnotescape(x)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests for type stored indirectly in iface and with value receiver method.
|
|
|
|
type M1 struct {
|
|
|
|
p *int
|
|
|
|
x int
|
|
|
|
}
|
|
|
|
|
|
|
|
func (M1) M() {
|
|
|
|
}
|
|
|
|
|
|
|
|
func efaceEscape1() {
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-09-08 22:09:01 -06:00
|
|
|
var x M = v // ERROR "v does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
_ = x
|
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-09-08 22:09:01 -06:00
|
|
|
var x M = v // ERROR "v escapes to heap"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = x
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-09-08 22:09:01 -06:00
|
|
|
var x M = v // ERROR "v does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(M1)
|
|
|
|
_ = v1
|
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2019-09-12 11:18:03 -06:00
|
|
|
var x M = v // ERROR "v does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(M1)
|
|
|
|
sink = v1 // ERROR "v1 escapes to heap"
|
|
|
|
}
|
|
|
|
{
|
2020-10-28 19:49:10 -06:00
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-10-28 19:49:10 -06:00
|
|
|
var x M = v // ERROR "v does not escape"
|
|
|
|
x.M() // ERROR "devirtualizing x.M"
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
2020-09-08 22:09:01 -06:00
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-09-08 22:09:01 -06:00
|
|
|
var x M = v // ERROR "v escapes to heap"
|
2015-02-19 06:27:32 -07:00
|
|
|
mescapes(x)
|
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2019-04-01 12:58:33 -06:00
|
|
|
v := M1{&i, 0}
|
2020-09-08 22:09:01 -06:00
|
|
|
var x M = v // ERROR "v does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
mdoesnotescape(x)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tests for type stored directly in iface and with pointer receiver method.
|
|
|
|
type M2 struct {
|
|
|
|
p *int
|
|
|
|
}
|
|
|
|
|
|
|
|
func (*M2) M() {
|
|
|
|
}
|
|
|
|
|
|
|
|
func efaceEscape2() {
|
|
|
|
{
|
|
|
|
i := 0
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
_ = x
|
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} escapes to heap"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
|
|
|
sink = x
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(*M2)
|
|
|
|
_ = v1
|
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} escapes to heap"
|
2015-02-19 06:27:32 -07:00
|
|
|
// BAD: v does not escape to heap here
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(*M2)
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = v1
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
// BAD: v does not escape to heap here
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1 := x.(*M2)
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = *v1
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
2015-02-19 06:27:32 -07:00
|
|
|
// BAD: v does not escape to heap here
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
v1, ok := x.(*M2)
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = *v1
|
2015-02-19 06:27:32 -07:00
|
|
|
_ = ok
|
|
|
|
}
|
|
|
|
{
|
2020-10-28 19:49:10 -06:00
|
|
|
i := 0
|
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2020-10-28 19:49:10 -06:00
|
|
|
x.M() // ERROR "devirtualizing x.M"
|
2015-02-19 06:27:32 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} escapes to heap"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
mescapes(x)
|
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2020-09-08 22:09:01 -06:00
|
|
|
v := &M2{&i} // ERROR "&M2{...} does not escape"
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x M = v
|
2015-02-19 06:27:32 -07:00
|
|
|
mdoesnotescape(x)
|
|
|
|
}
|
|
|
|
}
|
2015-07-30 10:31:18 -06:00
|
|
|
|
|
|
|
type T1 struct {
|
|
|
|
p *int
|
|
|
|
}
|
|
|
|
|
|
|
|
type T2 struct {
|
|
|
|
T1 T1
|
|
|
|
}
|
|
|
|
|
|
|
|
func dotTypeEscape() *T2 { // #11931
|
|
|
|
var x interface{}
|
2020-09-08 22:09:01 -06:00
|
|
|
x = &T1{p: new(int)} // ERROR "new\(int\) escapes to heap" "&T1{...} does not escape"
|
|
|
|
return &T2{ // ERROR "&T2{...} escapes to heap"
|
2019-09-25 00:56:50 -06:00
|
|
|
T1: *(x.(*T1)),
|
2015-07-30 10:31:18 -06:00
|
|
|
}
|
|
|
|
}
|
2016-02-13 23:39:16 -07:00
|
|
|
|
2016-07-13 12:29:39 -06:00
|
|
|
func dotTypeEscape2() { // #13805, #15796
|
2016-02-13 23:39:16 -07:00
|
|
|
{
|
|
|
|
i := 0
|
2016-07-13 12:29:39 -06:00
|
|
|
j := 0
|
2016-02-13 23:39:16 -07:00
|
|
|
var v int
|
2016-07-13 12:29:39 -06:00
|
|
|
var ok bool
|
2016-02-13 23:39:16 -07:00
|
|
|
var x interface{} = i // ERROR "i does not escape"
|
2016-07-13 12:29:39 -06:00
|
|
|
var y interface{} = j // ERROR "j does not escape"
|
|
|
|
|
2019-04-01 12:58:33 -06:00
|
|
|
*(&v) = x.(int)
|
|
|
|
*(&v), *(&ok) = y.(int)
|
2016-02-13 23:39:16 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0
|
2016-07-13 12:29:39 -06:00
|
|
|
j := 0
|
|
|
|
var ok bool
|
2016-02-13 23:39:16 -07:00
|
|
|
var x interface{} = i // ERROR "i does not escape"
|
2016-07-13 12:29:39 -06:00
|
|
|
var y interface{} = j // ERROR "j does not escape"
|
2016-02-13 23:39:16 -07:00
|
|
|
|
2020-09-08 22:09:01 -06:00
|
|
|
sink = x.(int) // ERROR "x.\(int\) escapes to heap"
|
2019-04-01 12:58:33 -06:00
|
|
|
sink, *(&ok) = y.(int)
|
2016-02-13 23:39:16 -07:00
|
|
|
}
|
|
|
|
{
|
|
|
|
i := 0 // ERROR "moved to heap: i"
|
2016-07-13 12:29:39 -06:00
|
|
|
j := 0 // ERROR "moved to heap: j"
|
|
|
|
var ok bool
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
var x interface{} = &i
|
|
|
|
var y interface{} = &j
|
2016-07-13 12:29:39 -06:00
|
|
|
|
cmd/compile: silence esc diagnostics about directiface OCONVIFACEs
In general, a conversion to interface type may require values to be
boxed, which in turn necessitates escape analysis to determine whether
the boxed representation can be stack allocated.
However, esc.go used to unconditionally print escape analysis
decisions about OCONVIFACE, even for conversions that don't require
boxing (e.g., pointers, channels, maps, functions).
For test compatibility with esc.go, escape.go similarly printed these
useless diagnostics. This CL removes the diagnostics, and updates test
expectations accordingly.
Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12
Reviewed-on: https://go-review.googlesource.com/c/go/+/192697
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2019-08-30 11:56:30 -06:00
|
|
|
sink = x.(*int)
|
2019-04-01 12:58:33 -06:00
|
|
|
sink, *(&ok) = y.(*int)
|
2016-02-13 23:39:16 -07:00
|
|
|
}
|
|
|
|
}
|
2020-10-29 14:30:54 -06:00
|
|
|
|
|
|
|
func issue42279() {
|
|
|
|
type I interface{ M() }
|
|
|
|
type T struct{ I }
|
|
|
|
|
|
|
|
var i I = T{} // ERROR "T\{\} does not escape"
|
|
|
|
i.M() // ERROR "partially devirtualizing i.M to T"
|
|
|
|
}
|