2012-02-16 21:48:57 -07:00
|
|
|
// errorcheck
|
2008-10-16 16:59:31 -06:00
|
|
|
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2012-02-18 19:19:43 -07:00
|
|
|
// Verify that illegal assignments with both explicit and implicit conversions of literals are detected.
|
|
|
|
// Does not compile.
|
|
|
|
|
2008-10-16 16:59:31 -06:00
|
|
|
package main
|
|
|
|
|
2015-05-01 20:50:27 -06:00
|
|
|
import "unsafe"
|
|
|
|
|
2012-02-18 19:19:43 -07:00
|
|
|
// explicit conversion of constants
|
2010-09-03 18:36:13 -06:00
|
|
|
var x1 = string(1)
|
|
|
|
var x2 string = string(1)
|
2011-01-19 21:09:00 -07:00
|
|
|
var x3 = int(1.5) // ERROR "convert|truncate"
|
|
|
|
var x4 int = int(1.5) // ERROR "convert|truncate"
|
2010-09-03 18:36:13 -06:00
|
|
|
var x5 = "a" + string(1)
|
2020-12-09 21:14:07 -07:00
|
|
|
var x6 = int(1e100) // ERROR "overflow|cannot convert"
|
|
|
|
var x7 = float32(1e1000) // ERROR "overflow|cannot convert"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2015-05-01 20:50:27 -06:00
|
|
|
// unsafe.Pointer can only convert to/from uintptr
|
test: match gofrontend error messages
These changes match the following gofrontend error messages:
blank1.go:16:1: error: may not define methods on non-local type
chan/perm.go:28:9: error: expected channel
chan/perm.go:29:11: error: left operand of ‘<-’ must be channel
chan/perm.go:69:9: error: argument must be channel
complit1.go:25:16: error: attempt to slice object that is not array, slice, or string
complit1.go:26:16: error: attempt to slice object that is not array, slice, or string
complit1.go:27:17: error: attempt to slice object that is not array, slice, or string
complit1.go:49:41: error: may only omit types within composite literals of slice, array, or map type
complit1.go:50:14: error: expected struct, slice, array, or map type for composite literal
convlit.go:24:9: error: invalid type conversion (cannot use type unsafe.Pointer as type string)
convlit.go:25:9: error: invalid type conversion (cannot use type unsafe.Pointer as type float64)
convlit.go:26:9: error: invalid type conversion (cannot use type unsafe.Pointer as type int)
ddd1.go:63:9: error: invalid use of ‘...’ calling non-variadic function
fixedbugs/bug176.go:12:18: error: index expression is not integer constant
fixedbugs/bug332.go:17:10: error: use of undefined type ‘T’
fixedbugs/issue4232.go:22:16: error: integer constant overflow
fixedbugs/issue4232.go:33:16: error: integer constant overflow
fixedbugs/issue4232.go:44:25: error: integer constant overflow
fixedbugs/issue4232.go:55:16: error: integer constant overflow
fixedbugs/issue4458.go:19:14: error: type has no method ‘foo’
fixedbugs/issue5172.go:24:14: error: too many expressions for struct
init.go:17:9: error: reference to undefined name ‘runtime’
initializerr.go:26:29: error: duplicate value for index 1
interface/explicit.go:60:14: error: type assertion only valid for interface types
label.go:64:9: error: reference to undefined label ‘go2’
label1.go:18:97: error: continue statement not within for
label1.go:22:97: error: continue statement not within for
label1.go:106:89: error: continue statement not within for
label1.go:108:26: error: invalid continue label ‘on’
label1.go:111:118: error: break statement not within for or switch or select
label1.go:113:23: error: invalid break label ‘dance’
map1.go:64:9: error: not enough arguments
map1.go:65:9: error: not enough arguments
map1.go:67:9: error: argument 1 must be a map
method2.go:36:11: error: reference to undefined field or method ‘val’
method2.go:37:11: error: reference to undefined field or method ‘val’
method2.go:41:12: error: method requires pointer (use ‘(*T).g’)
syntax/chan1.go:13:19: error: send statement used as value; use select for non-blocking send
syntax/chan1.go:17:11: error: send statement used as value; use select for non-blocking send
Change-Id: I98047b60a376e3d2788836300f7fcac3f2c285cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/273527
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
2020-11-26 13:26:02 -07:00
|
|
|
var _ = string(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
|
|
|
var _ = float64(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
|
|
|
var _ = int(unsafe.Pointer(uintptr(65))) // ERROR "convert|conversion"
|
2015-05-01 20:50:27 -06:00
|
|
|
|
2008-10-16 16:59:31 -06:00
|
|
|
// implicit conversions merit scrutiny
|
2010-09-03 18:36:13 -06:00
|
|
|
var s string
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad1 string = 1 // ERROR "conver|incompatible|invalid|cannot"
|
cmd/compile: rewrite untyped constant conversion logic
This CL detangles the hairy mess that was convlit+defaultlit. In
particular, it makes the following changes:
1. convlit1 now follows the standard typecheck behavior of setting
"n.Type = nil" if there's an error. Notably, this means for a lot of
test cases, we now avoid reporting useless follow-on error messages.
For example, after reporting that "1 << s + 1.0" has an invalid shift,
we no longer also report that it can't be assigned to string.
2. Previously, assignconvfn had some extra logic for trying to
suppress errors from convlit/defaultlit so that it could provide its
own errors with better context information. Instead, this extra
context information is now passed down into convlit1 directly.
3. Relatedly, this CL also removes redundant calls to defaultlit prior
to assignconv. As a consequence, when an expression doesn't make sense
for a particular assignment (e.g., assigning an untyped string to an
integer), the error messages now say "untyped string" instead of just
"string". This is more consistent with go/types behavior.
4. defaultlit2 is now smarter about only trying to convert pairs of
untyped constants when it's likely to succeed. This allows us to
report better error messages for things like 3+"x"; instead of "cannot
convert 3 to string" we now report "mismatched types untyped number
and untyped string".
Passes toolstash-check.
Change-Id: I26822a02dc35855bd0ac774907b1cf5737e91882
Reviewed-on: https://go-review.googlesource.com/c/go/+/187657
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
2019-09-05 14:33:06 -06:00
|
|
|
var bad2 = s + 1 // ERROR "conver|incompatible|invalid|cannot"
|
|
|
|
var bad3 = s + 'a' // ERROR "conver|incompatible|invalid|cannot"
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad4 = "a" + 1 // ERROR "literals|incompatible|convert|invalid"
|
|
|
|
var bad5 = "a" + 'a' // ERROR "literals|incompatible|convert|invalid"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad6 int = 1.5 // ERROR "convert|truncate"
|
2021-03-17 23:13:16 -06:00
|
|
|
var bad7 int = 1e100 // ERROR "overflow|truncated to int|truncated"
|
2011-01-19 21:09:00 -07:00
|
|
|
var bad8 float32 = 1e200 // ERROR "overflow"
|
2008-10-16 16:59:31 -06:00
|
|
|
|
|
|
|
// but these implicit conversions are okay
|
2010-09-03 18:36:13 -06:00
|
|
|
var good1 string = "a"
|
|
|
|
var good2 int = 1.0
|
|
|
|
var good3 int = 1e9
|
2011-01-19 21:09:00 -07:00
|
|
|
var good4 float64 = 1e20
|
2008-10-16 16:59:31 -06:00
|
|
|
|
2010-02-25 16:11:07 -07:00
|
|
|
// explicit conversion of string is okay
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ = []rune("abc")
|
2010-02-25 16:11:07 -07:00
|
|
|
var _ = []byte("abc")
|
|
|
|
|
|
|
|
// implicit is not
|
2020-12-09 21:14:07 -07:00
|
|
|
var _ []int = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
|
|
|
var _ []byte = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
2010-02-25 16:11:07 -07:00
|
|
|
|
|
|
|
// named string is okay
|
|
|
|
type Tstring string
|
2011-01-19 21:09:00 -07:00
|
|
|
|
2010-02-25 16:11:07 -07:00
|
|
|
var ss Tstring = "abc"
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ = []rune(ss)
|
2010-02-25 16:11:07 -07:00
|
|
|
var _ = []byte(ss)
|
|
|
|
|
|
|
|
// implicit is still not
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
var _ []rune = ss // ERROR "cannot use|incompatible|invalid"
|
2011-01-19 21:09:00 -07:00
|
|
|
var _ []byte = ss // ERROR "cannot use|incompatible|invalid"
|
2010-02-25 16:11:07 -07:00
|
|
|
|
2011-11-22 10:30:02 -07:00
|
|
|
// named slice is now ok
|
cgo, goyacc, go/build, html, http, path, path/filepath, testing/quick, test: use rune
Nothing terribly interesting here.
R=golang-dev, bradfitz, gri, r
CC=golang-dev
https://golang.org/cl/5300043
2011-10-25 23:20:02 -06:00
|
|
|
type Trune []rune
|
2010-02-25 16:11:07 -07:00
|
|
|
type Tbyte []byte
|
2011-01-19 21:09:00 -07:00
|
|
|
|
2011-11-22 10:30:02 -07:00
|
|
|
var _ = Trune("abc") // ok
|
|
|
|
var _ = Tbyte("abc") // ok
|
2010-02-25 16:11:07 -07:00
|
|
|
|
|
|
|
// implicit is still not
|
2020-12-09 21:14:07 -07:00
|
|
|
var _ Trune = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|
|
|
|
var _ Tbyte = "abc" // ERROR "cannot use|incompatible|invalid|cannot convert"
|