2019-05-10 14:35:43 -06:00
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2019-04-24 17:26:34 -06:00
|
|
|
package source
|
|
|
|
|
|
|
|
import (
|
2019-08-02 17:45:56 -06:00
|
|
|
"context"
|
2019-04-24 17:26:34 -06:00
|
|
|
"fmt"
|
|
|
|
"go/ast"
|
|
|
|
"go/token"
|
|
|
|
"go/types"
|
2019-06-27 12:59:09 -06:00
|
|
|
"path/filepath"
|
2019-08-02 17:45:56 -06:00
|
|
|
"regexp"
|
2019-04-29 19:08:16 -06:00
|
|
|
"strings"
|
2019-08-02 17:45:56 -06:00
|
|
|
|
2019-08-16 15:05:40 -06:00
|
|
|
"golang.org/x/tools/internal/lsp/protocol"
|
2019-08-02 17:45:56 -06:00
|
|
|
"golang.org/x/tools/internal/span"
|
2019-08-26 22:26:45 -06:00
|
|
|
errors "golang.org/x/xerrors"
|
2019-04-24 17:26:34 -06:00
|
|
|
)
|
|
|
|
|
2019-08-16 15:05:40 -06:00
|
|
|
type mappedRange struct {
|
|
|
|
spanRange span.Range
|
|
|
|
m *protocol.ColumnMapper
|
|
|
|
|
|
|
|
// protocolRange is the result of converting the spanRange using the mapper.
|
|
|
|
// It is computed on-demand.
|
|
|
|
protocolRange *protocol.Range
|
|
|
|
}
|
|
|
|
|
|
|
|
func (s mappedRange) Range() (protocol.Range, error) {
|
|
|
|
if s.protocolRange == nil {
|
|
|
|
spn, err := s.spanRange.Span()
|
|
|
|
if err != nil {
|
|
|
|
return protocol.Range{}, err
|
|
|
|
}
|
|
|
|
prng, err := s.m.Range(spn)
|
|
|
|
if err != nil {
|
|
|
|
return protocol.Range{}, err
|
|
|
|
}
|
|
|
|
s.protocolRange = &prng
|
|
|
|
}
|
|
|
|
return *s.protocolRange, nil
|
|
|
|
}
|
|
|
|
|
2019-08-26 22:26:45 -06:00
|
|
|
func (s mappedRange) Span() (span.Span, error) {
|
|
|
|
return s.spanRange.Span()
|
|
|
|
}
|
|
|
|
|
2019-08-16 15:05:40 -06:00
|
|
|
func (s mappedRange) URI() span.URI {
|
|
|
|
return s.m.URI
|
|
|
|
}
|
|
|
|
|
2019-09-09 17:26:26 -06:00
|
|
|
// NarrowestCheckPackageHandle picks the "narrowest" package for a given file.
|
2019-09-09 18:22:42 -06:00
|
|
|
//
|
|
|
|
// By "narrowest" package, we mean the package with the fewest number of files
|
|
|
|
// that includes the given file. This solves the problem of test variants,
|
|
|
|
// as the test will have more files than the non-test package.
|
2019-10-10 13:22:30 -06:00
|
|
|
func NarrowestCheckPackageHandle(handles []CheckPackageHandle) (CheckPackageHandle, error) {
|
2019-09-09 17:26:26 -06:00
|
|
|
if len(handles) < 1 {
|
2019-10-10 13:22:30 -06:00
|
|
|
return nil, errors.Errorf("no CheckPackageHandles")
|
2019-09-09 17:26:26 -06:00
|
|
|
}
|
|
|
|
result := handles[0]
|
|
|
|
for _, handle := range handles[1:] {
|
|
|
|
if result == nil || len(handle.Files()) < len(result.Files()) {
|
|
|
|
result = handle
|
2019-09-09 18:22:42 -06:00
|
|
|
}
|
|
|
|
}
|
2019-10-10 13:22:30 -06:00
|
|
|
if result == nil {
|
|
|
|
return nil, errors.Errorf("nil CheckPackageHandles have been returned")
|
|
|
|
}
|
|
|
|
return result, nil
|
2019-09-09 17:26:26 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
// WidestCheckPackageHandle returns the CheckPackageHandle containing the most files.
|
|
|
|
//
|
|
|
|
// This is useful for something like diagnostics, where we'd prefer to offer diagnostics
|
|
|
|
// for as many files as possible.
|
2019-10-10 13:22:30 -06:00
|
|
|
func WidestCheckPackageHandle(handles []CheckPackageHandle) (CheckPackageHandle, error) {
|
2019-09-09 17:26:26 -06:00
|
|
|
if len(handles) < 1 {
|
2019-10-10 13:22:30 -06:00
|
|
|
return nil, errors.Errorf("no CheckPackageHandles")
|
2019-09-09 17:26:26 -06:00
|
|
|
}
|
|
|
|
result := handles[0]
|
|
|
|
for _, handle := range handles[1:] {
|
|
|
|
if result == nil || len(handle.Files()) > len(result.Files()) {
|
|
|
|
result = handle
|
|
|
|
}
|
2019-09-09 18:22:42 -06:00
|
|
|
}
|
2019-10-10 13:22:30 -06:00
|
|
|
if result == nil {
|
|
|
|
return nil, errors.Errorf("nil CheckPackageHandles have been returned")
|
|
|
|
}
|
|
|
|
return result, nil
|
2019-09-09 18:22:42 -06:00
|
|
|
}
|
|
|
|
|
2019-08-02 17:45:56 -06:00
|
|
|
func IsGenerated(ctx context.Context, view View, uri span.URI) bool {
|
|
|
|
f, err := view.GetFile(ctx, uri)
|
|
|
|
if err != nil {
|
|
|
|
return false
|
|
|
|
}
|
2019-09-27 11:17:59 -06:00
|
|
|
ph := view.Session().Cache().ParseGoHandle(view.Snapshot().Handle(ctx, f), ParseHeader)
|
2019-09-17 09:19:11 -06:00
|
|
|
parsed, _, _, err := ph.Parse(ctx)
|
|
|
|
if err != nil {
|
2019-08-02 17:45:56 -06:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
tok := view.Session().Cache().FileSet().File(parsed.Pos())
|
|
|
|
if tok == nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
for _, commentGroup := range parsed.Comments {
|
|
|
|
for _, comment := range commentGroup.List {
|
|
|
|
if matched := generatedRx.MatchString(comment.Text); matched {
|
|
|
|
// Check if comment is at the beginning of the line in source.
|
|
|
|
if pos := tok.Position(comment.Slash); pos.Column == 1 {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func nodeToProtocolRange(ctx context.Context, view View, m *protocol.ColumnMapper, n ast.Node) (protocol.Range, error) {
|
|
|
|
mrng, err := nodeToMappedRange(ctx, view, m, n)
|
2019-09-05 16:54:05 -06:00
|
|
|
if err != nil {
|
|
|
|
return protocol.Range{}, err
|
|
|
|
}
|
|
|
|
return mrng.Range()
|
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func objToMappedRange(ctx context.Context, view View, pkg Package, obj types.Object) (mappedRange, error) {
|
2019-09-05 16:54:05 -06:00
|
|
|
if pkgName, ok := obj.(*types.PkgName); ok {
|
|
|
|
// An imported Go package has a package-local, unqualified name.
|
|
|
|
// When the name matches the imported package name, there is no
|
|
|
|
// identifier in the import spec with the local package name.
|
|
|
|
//
|
|
|
|
// For example:
|
|
|
|
// import "go/ast" // name "ast" matches package name
|
|
|
|
// import a "go/ast" // name "a" does not match package name
|
|
|
|
//
|
|
|
|
// When the identifier does not appear in the source, have the range
|
|
|
|
// of the object be the point at the beginning of the declaration.
|
|
|
|
if pkgName.Imported().Name() == pkgName.Name() {
|
2019-09-16 16:17:51 -06:00
|
|
|
return nameToMappedRange(ctx, view, pkg, obj.Pos(), "")
|
2019-09-05 16:54:05 -06:00
|
|
|
}
|
|
|
|
}
|
2019-09-16 16:17:51 -06:00
|
|
|
return nameToMappedRange(ctx, view, pkg, obj.Pos(), obj.Name())
|
2019-09-05 16:54:05 -06:00
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func nameToMappedRange(ctx context.Context, view View, pkg Package, pos token.Pos, name string) (mappedRange, error) {
|
|
|
|
return posToMappedRange(ctx, view, pkg, pos, pos+token.Pos(len(name)))
|
2019-09-05 16:54:05 -06:00
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func nodeToMappedRange(ctx context.Context, view View, m *protocol.ColumnMapper, n ast.Node) (mappedRange, error) {
|
|
|
|
return posToRange(ctx, view, m, n.Pos(), n.End())
|
|
|
|
}
|
|
|
|
|
|
|
|
func posToMappedRange(ctx context.Context, view View, pkg Package, pos, end token.Pos) (mappedRange, error) {
|
|
|
|
m, err := posToMapper(ctx, view, pkg, pos)
|
|
|
|
if err != nil {
|
|
|
|
return mappedRange{}, err
|
|
|
|
}
|
|
|
|
return posToRange(ctx, view, m, pos, end)
|
2019-09-05 16:54:05 -06:00
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func posToRange(ctx context.Context, view View, m *protocol.ColumnMapper, pos, end token.Pos) (mappedRange, error) {
|
2019-09-05 16:54:05 -06:00
|
|
|
if !pos.IsValid() {
|
|
|
|
return mappedRange{}, errors.Errorf("invalid position for %v", pos)
|
|
|
|
}
|
|
|
|
if !end.IsValid() {
|
|
|
|
return mappedRange{}, errors.Errorf("invalid position for %v", end)
|
|
|
|
}
|
|
|
|
return mappedRange{
|
|
|
|
m: m,
|
|
|
|
spanRange: span.NewRange(view.Session().Cache().FileSet(), pos, end),
|
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
2019-09-16 16:17:51 -06:00
|
|
|
func posToMapper(ctx context.Context, view View, pkg Package, pos token.Pos) (*protocol.ColumnMapper, error) {
|
|
|
|
posn := view.Session().Cache().FileSet().Position(pos)
|
|
|
|
ph, _, err := pkg.FindFile(ctx, span.FileURI(posn.Filename))
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2019-09-17 09:19:11 -06:00
|
|
|
_, m, _, err := ph.Cached(ctx)
|
|
|
|
return m, err
|
2019-09-16 16:17:51 -06:00
|
|
|
}
|
|
|
|
|
2019-08-02 17:45:56 -06:00
|
|
|
// Matches cgo generated comment as well as the proposed standard:
|
|
|
|
// https://golang.org/s/generatedcode
|
|
|
|
var generatedRx = regexp.MustCompile(`// .*DO NOT EDIT\.?`)
|
|
|
|
|
2019-06-27 12:59:09 -06:00
|
|
|
func DetectLanguage(langID, filename string) FileKind {
|
|
|
|
switch langID {
|
|
|
|
case "go":
|
|
|
|
return Go
|
|
|
|
case "go.mod":
|
|
|
|
return Mod
|
|
|
|
case "go.sum":
|
|
|
|
return Sum
|
|
|
|
}
|
|
|
|
// Fallback to detecting the language based on the file extension.
|
|
|
|
switch filepath.Ext(filename) {
|
|
|
|
case ".mod":
|
|
|
|
return Mod
|
|
|
|
case ".sum":
|
|
|
|
return Sum
|
|
|
|
default: // fallback to Go
|
|
|
|
return Go
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (k FileKind) String() string {
|
|
|
|
switch k {
|
|
|
|
case Mod:
|
|
|
|
return "go.mod"
|
|
|
|
case Sum:
|
|
|
|
return "go.sum"
|
|
|
|
default:
|
|
|
|
return "go"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-24 17:26:34 -06:00
|
|
|
// indexExprAtPos returns the index of the expression containing pos.
|
|
|
|
func indexExprAtPos(pos token.Pos, args []ast.Expr) int {
|
|
|
|
for i, expr := range args {
|
|
|
|
if expr.Pos() <= pos && pos <= expr.End() {
|
|
|
|
return i
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return len(args)
|
|
|
|
}
|
|
|
|
|
|
|
|
func exprAtPos(pos token.Pos, args []ast.Expr) ast.Expr {
|
|
|
|
for _, expr := range args {
|
|
|
|
if expr.Pos() <= pos && pos <= expr.End() {
|
|
|
|
return expr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// fieldSelections returns the set of fields that can
|
|
|
|
// be selected from a value of type T.
|
|
|
|
func fieldSelections(T types.Type) (fields []*types.Var) {
|
|
|
|
// TODO(adonovan): this algorithm doesn't exclude ambiguous
|
|
|
|
// selections that match more than one field/method.
|
|
|
|
// types.NewSelectionSet should do that for us.
|
|
|
|
|
2019-06-27 11:50:01 -06:00
|
|
|
seen := make(map[*types.Var]bool) // for termination on recursive types
|
|
|
|
|
2019-04-24 17:26:34 -06:00
|
|
|
var visit func(T types.Type)
|
|
|
|
visit = func(T types.Type) {
|
2019-06-27 11:50:01 -06:00
|
|
|
if T, ok := deref(T).Underlying().(*types.Struct); ok {
|
|
|
|
for i := 0; i < T.NumFields(); i++ {
|
|
|
|
f := T.Field(i)
|
|
|
|
if seen[f] {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
seen[f] = true
|
|
|
|
fields = append(fields, f)
|
|
|
|
if f.Anonymous() {
|
|
|
|
visit(f.Type())
|
2019-04-24 17:26:34 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
visit(T)
|
|
|
|
|
|
|
|
return fields
|
|
|
|
}
|
|
|
|
|
|
|
|
// resolveInvalid traverses the node of the AST that defines the scope
|
|
|
|
// containing the declaration of obj, and attempts to find a user-friendly
|
|
|
|
// name for its invalid type. The resulting Object and its Type are fake.
|
|
|
|
func resolveInvalid(obj types.Object, node ast.Node, info *types.Info) types.Object {
|
|
|
|
// Construct a fake type for the object and return a fake object with this type.
|
|
|
|
formatResult := func(expr ast.Expr) types.Object {
|
|
|
|
var typename string
|
|
|
|
switch t := expr.(type) {
|
|
|
|
case *ast.SelectorExpr:
|
|
|
|
typename = fmt.Sprintf("%s.%s", t.X, t.Sel)
|
|
|
|
case *ast.Ident:
|
|
|
|
typename = t.String()
|
|
|
|
default:
|
|
|
|
return nil
|
|
|
|
}
|
2019-06-17 12:11:13 -06:00
|
|
|
typ := types.NewNamed(types.NewTypeName(token.NoPos, obj.Pkg(), typename, nil), types.Typ[types.Invalid], nil)
|
2019-04-24 17:26:34 -06:00
|
|
|
return types.NewVar(obj.Pos(), obj.Pkg(), obj.Name(), typ)
|
|
|
|
}
|
|
|
|
var resultExpr ast.Expr
|
|
|
|
ast.Inspect(node, func(node ast.Node) bool {
|
|
|
|
switch n := node.(type) {
|
|
|
|
case *ast.ValueSpec:
|
|
|
|
for _, name := range n.Names {
|
|
|
|
if info.Defs[name] == obj {
|
|
|
|
resultExpr = n.Type
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
case *ast.Field: // This case handles parameters and results of a FuncDecl or FuncLit.
|
|
|
|
for _, name := range n.Names {
|
|
|
|
if info.Defs[name] == obj {
|
|
|
|
resultExpr = n.Type
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
// TODO(rstambler): Handle range statements.
|
|
|
|
default:
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
})
|
|
|
|
return formatResult(resultExpr)
|
|
|
|
}
|
|
|
|
|
|
|
|
func isPointer(T types.Type) bool {
|
|
|
|
_, ok := T.(*types.Pointer)
|
|
|
|
return ok
|
|
|
|
}
|
|
|
|
|
|
|
|
// deref returns a pointer's element type; otherwise it returns typ.
|
|
|
|
func deref(typ types.Type) types.Type {
|
|
|
|
if p, ok := typ.Underlying().(*types.Pointer); ok {
|
|
|
|
return p.Elem()
|
|
|
|
}
|
|
|
|
return typ
|
|
|
|
}
|
2019-04-29 19:08:16 -06:00
|
|
|
|
2019-06-17 12:11:13 -06:00
|
|
|
func isTypeName(obj types.Object) bool {
|
|
|
|
_, ok := obj.(*types.TypeName)
|
|
|
|
return ok
|
|
|
|
}
|
|
|
|
|
2019-06-19 16:24:05 -06:00
|
|
|
func isFunc(obj types.Object) bool {
|
|
|
|
_, ok := obj.(*types.Func)
|
|
|
|
return ok
|
|
|
|
}
|
|
|
|
|
internal/lsp: add literal completion candidates
Add support for literal completion candidates such as "[]int{}" or
"make([]int, 0)". We support both named and unnamed types. I used the
existing type matching logic, so, for example, if the expected type is
an interface, we will suggest literal candidates that implement the
interface.
The literal candidates have a lower score than normal matching
candidates, so they shouldn't be disruptive in cases where you don't
want a literal candidate.
This commit adds support for slice, array, struct, map, and channel
literal candidates since they are pretty similar. Functions will be
supported in a subsequent commit.
I also added support for setting a snippet's final tab stop. This is
useful if you want the cursor to end up somewhere other than the
character after the snippet.
Change-Id: Id3b74260fff4d61703989b422267021b00cec005
Reviewed-on: https://go-review.googlesource.com/c/tools/+/193698
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-04 17:12:37 -06:00
|
|
|
func isEmptyInterface(T types.Type) bool {
|
|
|
|
intf, _ := T.(*types.Interface)
|
|
|
|
return intf != nil && intf.NumMethods() == 0
|
|
|
|
}
|
|
|
|
|
2019-06-27 16:37:50 -06:00
|
|
|
// typeConversion returns the type being converted to if call is a type
|
|
|
|
// conversion expression.
|
|
|
|
func typeConversion(call *ast.CallExpr, info *types.Info) types.Type {
|
|
|
|
var ident *ast.Ident
|
|
|
|
switch expr := call.Fun.(type) {
|
|
|
|
case *ast.Ident:
|
|
|
|
ident = expr
|
|
|
|
case *ast.SelectorExpr:
|
|
|
|
ident = expr.Sel
|
|
|
|
default:
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Type conversion (e.g. "float64(foo)").
|
|
|
|
if fun, _ := info.ObjectOf(ident).(*types.TypeName); fun != nil {
|
|
|
|
return fun.Type()
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2019-04-29 19:08:16 -06:00
|
|
|
func formatParams(tup *types.Tuple, variadic bool, qf types.Qualifier) []string {
|
|
|
|
params := make([]string, 0, tup.Len())
|
|
|
|
for i := 0; i < tup.Len(); i++ {
|
|
|
|
el := tup.At(i)
|
|
|
|
typ := types.TypeString(el.Type(), qf)
|
|
|
|
|
|
|
|
// Handle a variadic parameter (can only be the final parameter).
|
|
|
|
if variadic && i == tup.Len()-1 {
|
|
|
|
typ = strings.Replace(typ, "[]", "...", 1)
|
|
|
|
}
|
|
|
|
|
|
|
|
if el.Name() == "" {
|
|
|
|
params = append(params, typ)
|
|
|
|
} else {
|
|
|
|
params = append(params, el.Name()+" "+typ)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return params
|
|
|
|
}
|
|
|
|
|
|
|
|
func formatResults(tup *types.Tuple, qf types.Qualifier) ([]string, bool) {
|
|
|
|
var writeResultParens bool
|
|
|
|
results := make([]string, 0, tup.Len())
|
|
|
|
for i := 0; i < tup.Len(); i++ {
|
|
|
|
if i >= 1 {
|
|
|
|
writeResultParens = true
|
|
|
|
}
|
|
|
|
el := tup.At(i)
|
|
|
|
typ := types.TypeString(el.Type(), qf)
|
|
|
|
|
|
|
|
if el.Name() == "" {
|
|
|
|
results = append(results, typ)
|
|
|
|
} else {
|
|
|
|
if i == 0 {
|
|
|
|
writeResultParens = true
|
|
|
|
}
|
|
|
|
results = append(results, el.Name()+" "+typ)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return results, writeResultParens
|
|
|
|
}
|
|
|
|
|
|
|
|
// formatType returns the detail and kind for an object of type *types.TypeName.
|
2019-09-24 22:46:57 -06:00
|
|
|
func formatType(typ types.Type, qf types.Qualifier) (detail string, kind protocol.CompletionItemKind) {
|
2019-04-29 19:08:16 -06:00
|
|
|
if types.IsInterface(typ) {
|
|
|
|
detail = "interface{...}"
|
2019-09-24 22:46:57 -06:00
|
|
|
kind = protocol.InterfaceCompletion
|
2019-04-29 19:08:16 -06:00
|
|
|
} else if _, ok := typ.(*types.Struct); ok {
|
|
|
|
detail = "struct{...}"
|
2019-09-24 22:46:57 -06:00
|
|
|
kind = protocol.StructCompletion
|
2019-04-29 19:08:16 -06:00
|
|
|
} else if typ != typ.Underlying() {
|
|
|
|
detail, kind = formatType(typ.Underlying(), qf)
|
|
|
|
} else {
|
|
|
|
detail = types.TypeString(typ, qf)
|
2019-09-24 22:46:57 -06:00
|
|
|
kind = protocol.ClassCompletion
|
2019-04-29 19:08:16 -06:00
|
|
|
}
|
|
|
|
return detail, kind
|
|
|
|
}
|
|
|
|
|
2019-07-02 16:10:05 -06:00
|
|
|
func formatFunction(params []string, results []string, writeResultParens bool) string {
|
|
|
|
var detail strings.Builder
|
|
|
|
|
|
|
|
detail.WriteByte('(')
|
2019-04-29 19:08:16 -06:00
|
|
|
for i, p := range params {
|
|
|
|
if i > 0 {
|
2019-07-02 16:10:05 -06:00
|
|
|
detail.WriteString(", ")
|
2019-04-29 19:08:16 -06:00
|
|
|
}
|
2019-07-02 16:10:05 -06:00
|
|
|
detail.WriteString(p)
|
|
|
|
}
|
|
|
|
detail.WriteByte(')')
|
|
|
|
|
|
|
|
// Add space between parameters and results.
|
|
|
|
if len(results) > 0 {
|
|
|
|
detail.WriteByte(' ')
|
2019-04-29 19:08:16 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
if writeResultParens {
|
|
|
|
detail.WriteByte('(')
|
|
|
|
}
|
|
|
|
for i, p := range results {
|
|
|
|
if i > 0 {
|
|
|
|
detail.WriteString(", ")
|
|
|
|
}
|
|
|
|
detail.WriteString(p)
|
|
|
|
}
|
|
|
|
if writeResultParens {
|
|
|
|
detail.WriteByte(')')
|
|
|
|
}
|
|
|
|
|
2019-07-02 16:10:05 -06:00
|
|
|
return detail.String()
|
2019-04-29 19:08:16 -06:00
|
|
|
}
|