qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 23:05:06 -07:00
Code Releases Activity
8bb11ff117
go/internal/lsp/testdata/unresolved/unresolved.go.in

7 lines
196 B
Go
Raw Normal View History

internal/lsp: suggest completions that satisfy interfaces When checking if a completion candidate matches the expected type at the cursor position, we now use types.AssignableTo instead of types.Identical. This properly handles cases like using a concrete type to satisfy an interface type. Calling AssignableTo triggered some crashes related to the fake "resolved" types we create. Their underlying type was nil, which is not allowed. We now set their underlying type to the invalid type. I've also rearranged things so expected type information lives in a dedicated typeInference struct. For now there is no new information added, but in subsequent commits there will be more metadata about the expected type. Change-Id: I14e537c548960c30e444cf512a4413d75bb3ee45 GitHub-Last-Rev: 7e64ebe32938562648938d7a480195d954b018f2 GitHub-Pull-Request: golang/tools#116 Reviewed-on: https://go-review.googlesource.com/c/tools/+/182358 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-06-17 12:11:13 -06:00
package unresolved
internal/lsp: fix function value completions Previously we would always expand *types.Func completion candidates to function calls, even if the expected type matched the function itself, not its return value. Now we check the function itself before we check its return value. This fixes cases like this: func foo() int { return 0 } var f func() int f = <foo> // now completes to "foo" instead of "foo()" Also, *types.Var function values were never getting expanded to calls. I fixed the completion formatting to know that both *types.Func and *types.Var objects might need to be invoked in the completion item. This fixes cases like this: foo := func() int { return 0 } var i int i = <foo()> // now completes to "foo()" instead of "foo" Change-Id: I8d0e9e2774f92866a3dd881092c13019fb3f3fd5 GitHub-Last-Rev: 7442bc84b5bbb86296289bbc745ec56a5f89d901 GitHub-Pull-Request: golang/tools#122 Reviewed-on: https://go-review.googlesource.com/c/tools/+/182879 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-06-19 16:24:05 -06:00
func foo(interface{}) { //@item(unresolvedFoo, "foo", "func(interface{})", "func")
internal/lsp: suggest completions that satisfy interfaces When checking if a completion candidate matches the expected type at the cursor position, we now use types.AssignableTo instead of types.Identical. This properly handles cases like using a concrete type to satisfy an interface type. Calling AssignableTo triggered some crashes related to the fake "resolved" types we create. Their underlying type was nil, which is not allowed. We now set their underlying type to the invalid type. I've also rearranged things so expected type information lives in a dedicated typeInference struct. For now there is no new information added, but in subsequent commits there will be more metadata about the expected type. Change-Id: I14e537c548960c30e444cf512a4413d75bb3ee45 GitHub-Last-Rev: 7e64ebe32938562648938d7a480195d954b018f2 GitHub-Pull-Request: golang/tools#116 Reviewed-on: https://go-review.googlesource.com/c/tools/+/182358 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-06-17 12:11:13 -06:00
// don't crash on fake "resolved" type
foo(func(i, j f //@complete(" //", unresolvedFoo)
}
Copy Permalink