2016-04-10 15:32:26 -06:00
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
2015-05-07 03:29:47 -06:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
package shared_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bufio"
|
|
|
|
"bytes"
|
|
|
|
"debug/elf"
|
2015-05-24 19:59:08 -06:00
|
|
|
"encoding/binary"
|
2015-05-07 03:29:47 -06:00
|
|
|
"errors"
|
2017-08-15 05:53:49 -06:00
|
|
|
"flag"
|
2015-05-07 03:29:47 -06:00
|
|
|
"fmt"
|
|
|
|
"go/build"
|
2015-05-24 19:59:08 -06:00
|
|
|
"io"
|
2015-05-07 03:29:47 -06:00
|
|
|
"io/ioutil"
|
|
|
|
"log"
|
|
|
|
"math/rand"
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
"path/filepath"
|
2015-05-10 19:39:28 -06:00
|
|
|
"regexp"
|
2015-09-02 04:26:42 -06:00
|
|
|
"runtime"
|
2015-05-07 03:29:47 -06:00
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
"time"
|
|
|
|
)
|
|
|
|
|
|
|
|
var gopathInstallDir, gorootInstallDir, suffix string
|
|
|
|
|
|
|
|
// This is the smallest set of packages we can link into a shared
|
|
|
|
// library (runtime/cgo is built implicitly).
|
|
|
|
var minpkgs = []string{"runtime", "sync/atomic"}
|
|
|
|
var soname = "libruntime,sync-atomic.so"
|
|
|
|
|
|
|
|
// run runs a command and calls t.Errorf if it fails.
|
|
|
|
func run(t *testing.T, msg string, args ...string) {
|
|
|
|
c := exec.Command(args[0], args[1:]...)
|
|
|
|
if output, err := c.CombinedOutput(); err != nil {
|
|
|
|
t.Errorf("executing %s (%s) failed %s:\n%s", strings.Join(args, " "), msg, err, output)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// goCmd invokes the go tool with the installsuffix set up by TestMain. It calls
|
2016-07-14 15:07:18 -06:00
|
|
|
// t.Fatalf if the command fails.
|
2015-05-07 03:29:47 -06:00
|
|
|
func goCmd(t *testing.T, args ...string) {
|
|
|
|
newargs := []string{args[0], "-installsuffix=" + suffix}
|
|
|
|
if testing.Verbose() {
|
2017-06-09 09:15:53 -06:00
|
|
|
newargs = append(newargs, "-x")
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
newargs = append(newargs, args[1:]...)
|
|
|
|
c := exec.Command("go", newargs...)
|
2015-05-26 16:30:55 -06:00
|
|
|
var output []byte
|
|
|
|
var err error
|
2015-05-07 03:29:47 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ go %s\n", strings.Join(newargs, " "))
|
2015-05-26 16:30:55 -06:00
|
|
|
c.Stdout = os.Stdout
|
|
|
|
c.Stderr = os.Stderr
|
|
|
|
err = c.Run()
|
2017-06-09 09:15:53 -06:00
|
|
|
output = []byte("(output above)")
|
2015-05-26 16:30:55 -06:00
|
|
|
} else {
|
|
|
|
output, err = c.CombinedOutput()
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
2015-05-26 16:30:55 -06:00
|
|
|
if err != nil {
|
2015-05-07 03:29:47 -06:00
|
|
|
if t != nil {
|
2016-07-14 15:07:18 -06:00
|
|
|
t.Fatalf("executing %s failed %v:\n%s", strings.Join(c.Args, " "), err, output)
|
2015-05-07 03:29:47 -06:00
|
|
|
} else {
|
|
|
|
log.Fatalf("executing %s failed %v:\n%s", strings.Join(c.Args, " "), err, output)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestMain calls testMain so that the latter can use defer (TestMain exits with os.Exit).
|
|
|
|
func testMain(m *testing.M) (int, error) {
|
|
|
|
// Because go install -buildmode=shared $standard_library_package always
|
|
|
|
// installs into $GOROOT, here are some gymnastics to come up with a unique
|
|
|
|
// installsuffix to use in this test that we can clean up afterwards.
|
|
|
|
myContext := build.Default
|
|
|
|
runtimeP, err := myContext.Import("runtime", ".", build.ImportComment)
|
|
|
|
if err != nil {
|
|
|
|
return 0, fmt.Errorf("import failed: %v", err)
|
|
|
|
}
|
|
|
|
for i := 0; i < 10000; i++ {
|
|
|
|
try := fmt.Sprintf("%s_%d_dynlink", runtimeP.PkgTargetRoot, rand.Int63())
|
|
|
|
err = os.Mkdir(try, 0700)
|
|
|
|
if os.IsExist(err) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
if err == nil {
|
|
|
|
gorootInstallDir = try
|
|
|
|
}
|
|
|
|
break
|
|
|
|
}
|
|
|
|
if err != nil {
|
|
|
|
return 0, fmt.Errorf("can't create temporary directory: %v", err)
|
|
|
|
}
|
|
|
|
if gorootInstallDir == "" {
|
|
|
|
return 0, errors.New("could not create temporary directory after 10000 tries")
|
|
|
|
}
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ mkdir -p %s\n", gorootInstallDir)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
defer os.RemoveAll(gorootInstallDir)
|
|
|
|
|
|
|
|
// Some tests need to edit the source in GOPATH, so copy this directory to a
|
|
|
|
// temporary directory and chdir to that.
|
|
|
|
scratchDir, err := ioutil.TempDir("", "testshared")
|
|
|
|
if err != nil {
|
|
|
|
return 0, fmt.Errorf("TempDir failed: %v", err)
|
|
|
|
}
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ mkdir -p %s\n", scratchDir)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
defer os.RemoveAll(scratchDir)
|
|
|
|
err = filepath.Walk(".", func(path string, info os.FileInfo, err error) error {
|
|
|
|
scratchPath := filepath.Join(scratchDir, path)
|
|
|
|
if info.IsDir() {
|
|
|
|
if path == "." {
|
|
|
|
return nil
|
|
|
|
}
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ mkdir -p %s\n", scratchPath)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
return os.Mkdir(scratchPath, info.Mode())
|
|
|
|
} else {
|
|
|
|
fromBytes, err := ioutil.ReadFile(path)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ cp %s %s\n", path, scratchPath)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
return ioutil.WriteFile(scratchPath, fromBytes, info.Mode())
|
|
|
|
}
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
return 0, fmt.Errorf("walk failed: %v", err)
|
|
|
|
}
|
|
|
|
os.Setenv("GOPATH", scratchDir)
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ export GOPATH=%s\n", scratchDir)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
myContext.GOPATH = scratchDir
|
2016-08-15 14:51:00 -06:00
|
|
|
if testing.Verbose() {
|
|
|
|
fmt.Printf("+ cd %s\n", scratchDir)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
os.Chdir(scratchDir)
|
|
|
|
|
|
|
|
// All tests depend on runtime being built into a shared library. Because
|
|
|
|
// that takes a few seconds, do it here and have all tests use the version
|
|
|
|
// built here.
|
|
|
|
suffix = strings.Split(filepath.Base(gorootInstallDir), "_")[2]
|
|
|
|
goCmd(nil, append([]string{"install", "-buildmode=shared"}, minpkgs...)...)
|
|
|
|
|
|
|
|
myContext.InstallSuffix = suffix + "_dynlink"
|
2016-05-03 17:23:24 -06:00
|
|
|
depP, err := myContext.Import("depBase", ".", build.ImportComment)
|
2015-05-07 03:29:47 -06:00
|
|
|
if err != nil {
|
|
|
|
return 0, fmt.Errorf("import failed: %v", err)
|
|
|
|
}
|
|
|
|
gopathInstallDir = depP.PkgTargetRoot
|
|
|
|
return m.Run(), nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestMain(m *testing.M) {
|
2017-08-15 05:53:49 -06:00
|
|
|
flag.Parse()
|
|
|
|
|
2015-07-12 11:18:32 -06:00
|
|
|
// Some of the tests install binaries into a custom GOPATH.
|
|
|
|
// That won't work if GOBIN is set.
|
|
|
|
os.Unsetenv("GOBIN")
|
|
|
|
|
2015-05-07 03:29:47 -06:00
|
|
|
exitCode, err := testMain(m)
|
|
|
|
if err != nil {
|
|
|
|
log.Fatal(err)
|
|
|
|
}
|
|
|
|
os.Exit(exitCode)
|
|
|
|
}
|
|
|
|
|
|
|
|
// The shared library was built at the expected location.
|
|
|
|
func TestSOBuilt(t *testing.T) {
|
|
|
|
_, err := os.Stat(filepath.Join(gorootInstallDir, soname))
|
|
|
|
if err != nil {
|
|
|
|
t.Error(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-20 19:07:19 -06:00
|
|
|
func hasDynTag(f *elf.File, tag elf.DynTag) bool {
|
|
|
|
ds := f.SectionByType(elf.SHT_DYNAMIC)
|
|
|
|
if ds == nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
d, err := ds.Data()
|
|
|
|
if err != nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
for len(d) > 0 {
|
|
|
|
var t elf.DynTag
|
|
|
|
switch f.Class {
|
|
|
|
case elf.ELFCLASS32:
|
|
|
|
t = elf.DynTag(f.ByteOrder.Uint32(d[0:4]))
|
|
|
|
d = d[8:]
|
|
|
|
case elf.ELFCLASS64:
|
|
|
|
t = elf.DynTag(f.ByteOrder.Uint64(d[0:8]))
|
|
|
|
d = d[16:]
|
|
|
|
}
|
|
|
|
if t == tag {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// The shared library does not have relocations against the text segment.
|
|
|
|
func TestNoTextrel(t *testing.T) {
|
|
|
|
sopath := filepath.Join(gorootInstallDir, soname)
|
|
|
|
f, err := elf.Open(sopath)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("elf.Open failed: ", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
if hasDynTag(f, elf.DT_TEXTREL) {
|
|
|
|
t.Errorf("%s has DT_TEXTREL set", soname)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-03-16 17:38:51 -06:00
|
|
|
// The shared library does not contain symbols called ".dup"
|
|
|
|
func TestNoDupSymbols(t *testing.T) {
|
|
|
|
sopath := filepath.Join(gorootInstallDir, soname)
|
|
|
|
f, err := elf.Open(sopath)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("elf.Open failed: ", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
syms, err := f.Symbols()
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("error reading symbols %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
for _, s := range syms {
|
|
|
|
if s.Name == ".dup" {
|
|
|
|
t.Fatalf("%s contains symbol called .dup", sopath)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-07 03:29:47 -06:00
|
|
|
// The install command should have created a "shlibname" file for the
|
2015-09-02 04:26:42 -06:00
|
|
|
// listed packages (and runtime/cgo, and math on arm) indicating the
|
|
|
|
// name of the shared library containing it.
|
2015-05-07 03:29:47 -06:00
|
|
|
func TestShlibnameFiles(t *testing.T) {
|
|
|
|
pkgs := append([]string{}, minpkgs...)
|
|
|
|
pkgs = append(pkgs, "runtime/cgo")
|
2015-09-02 04:26:42 -06:00
|
|
|
if runtime.GOARCH == "arm" {
|
|
|
|
pkgs = append(pkgs, "math")
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
for _, pkg := range pkgs {
|
|
|
|
shlibnamefile := filepath.Join(gorootInstallDir, pkg+".shlibname")
|
|
|
|
contentsb, err := ioutil.ReadFile(shlibnamefile)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("error reading shlibnamefile for %s: %v", pkg, err)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
contents := strings.TrimSpace(string(contentsb))
|
|
|
|
if contents != soname {
|
|
|
|
t.Errorf("shlibnamefile for %s has wrong contents: %q", pkg, contents)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-24 19:59:08 -06:00
|
|
|
// Is a given offset into the file contained in a loaded segment?
|
|
|
|
func isOffsetLoaded(f *elf.File, offset uint64) bool {
|
|
|
|
for _, prog := range f.Progs {
|
|
|
|
if prog.Type == elf.PT_LOAD {
|
|
|
|
if prog.Off <= offset && offset < prog.Off+prog.Filesz {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
func rnd(v int32, r int32) int32 {
|
|
|
|
if r <= 0 {
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
v += r - 1
|
|
|
|
c := v % r
|
|
|
|
if c < 0 {
|
|
|
|
c += r
|
|
|
|
}
|
|
|
|
v -= c
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
|
|
|
|
func readwithpad(r io.Reader, sz int32) ([]byte, error) {
|
|
|
|
data := make([]byte, rnd(sz, 4))
|
|
|
|
_, err := io.ReadFull(r, data)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
data = data[:sz]
|
|
|
|
return data, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
type note struct {
|
|
|
|
name string
|
|
|
|
tag int32
|
|
|
|
desc string
|
|
|
|
section *elf.Section
|
|
|
|
}
|
|
|
|
|
|
|
|
// Read all notes from f. As ELF section names are not supposed to be special, one
|
|
|
|
// looks for a particular note by scanning all SHT_NOTE sections looking for a note
|
|
|
|
// with a particular "name" and "tag".
|
|
|
|
func readNotes(f *elf.File) ([]*note, error) {
|
|
|
|
var notes []*note
|
|
|
|
for _, sect := range f.Sections {
|
|
|
|
if sect.Type != elf.SHT_NOTE {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
r := sect.Open()
|
|
|
|
for {
|
|
|
|
var namesize, descsize, tag int32
|
|
|
|
err := binary.Read(r, f.ByteOrder, &namesize)
|
|
|
|
if err != nil {
|
|
|
|
if err == io.EOF {
|
|
|
|
break
|
|
|
|
}
|
2015-11-21 02:54:34 -07:00
|
|
|
return nil, fmt.Errorf("read namesize failed: %v", err)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
err = binary.Read(r, f.ByteOrder, &descsize)
|
|
|
|
if err != nil {
|
2015-11-21 02:54:34 -07:00
|
|
|
return nil, fmt.Errorf("read descsize failed: %v", err)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
err = binary.Read(r, f.ByteOrder, &tag)
|
|
|
|
if err != nil {
|
2015-11-21 02:54:34 -07:00
|
|
|
return nil, fmt.Errorf("read type failed: %v", err)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
name, err := readwithpad(r, namesize)
|
|
|
|
if err != nil {
|
2015-11-21 02:54:34 -07:00
|
|
|
return nil, fmt.Errorf("read name failed: %v", err)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
desc, err := readwithpad(r, descsize)
|
|
|
|
if err != nil {
|
2015-11-21 02:54:34 -07:00
|
|
|
return nil, fmt.Errorf("read desc failed: %v", err)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
notes = append(notes, ¬e{name: string(name), tag: tag, desc: string(desc), section: sect})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return notes, nil
|
|
|
|
}
|
|
|
|
|
2016-04-18 05:24:48 -06:00
|
|
|
func dynStrings(t *testing.T, path string, flag elf.DynTag) []string {
|
2015-05-07 03:29:47 -06:00
|
|
|
f, err := elf.Open(path)
|
|
|
|
defer f.Close()
|
|
|
|
if err != nil {
|
2016-04-18 05:24:48 -06:00
|
|
|
t.Fatalf("elf.Open(%q) failed: %v", path, err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
dynstrings, err := f.DynString(flag)
|
|
|
|
if err != nil {
|
2016-04-18 05:24:48 -06:00
|
|
|
t.Fatalf("DynString(%s) failed on %s: %v", flag, path, err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
return dynstrings
|
|
|
|
}
|
|
|
|
|
2015-05-10 19:39:28 -06:00
|
|
|
func AssertIsLinkedToRegexp(t *testing.T, path string, re *regexp.Regexp) {
|
2016-04-18 05:24:48 -06:00
|
|
|
for _, dynstring := range dynStrings(t, path, elf.DT_NEEDED) {
|
2015-05-10 19:39:28 -06:00
|
|
|
if re.MatchString(dynstring) {
|
2015-05-07 03:29:47 -06:00
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
2015-05-10 19:39:28 -06:00
|
|
|
t.Errorf("%s is not linked to anything matching %v", path, re)
|
|
|
|
}
|
|
|
|
|
|
|
|
func AssertIsLinkedTo(t *testing.T, path, lib string) {
|
|
|
|
AssertIsLinkedToRegexp(t, path, regexp.MustCompile(regexp.QuoteMeta(lib)))
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
func AssertHasRPath(t *testing.T, path, dir string) {
|
2015-05-19 00:48:15 -06:00
|
|
|
for _, tag := range []elf.DynTag{elf.DT_RPATH, elf.DT_RUNPATH} {
|
2016-04-18 05:24:48 -06:00
|
|
|
for _, dynstring := range dynStrings(t, path, tag) {
|
2015-05-19 00:48:15 -06:00
|
|
|
for _, rpath := range strings.Split(dynstring, ":") {
|
|
|
|
if filepath.Clean(rpath) == filepath.Clean(dir) {
|
|
|
|
return
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
t.Errorf("%s does not have rpath %s", path, dir)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Build a trivial program that links against the shared runtime and check it runs.
|
|
|
|
func TestTrivialExecutable(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-linkshared", "trivial")
|
|
|
|
run(t, "trivial executable", "./bin/trivial")
|
|
|
|
AssertIsLinkedTo(t, "./bin/trivial", soname)
|
|
|
|
AssertHasRPath(t, "./bin/trivial", gorootInstallDir)
|
|
|
|
}
|
|
|
|
|
2016-09-12 19:29:13 -06:00
|
|
|
// Build a trivial program in PIE mode that links against the shared runtime and check it runs.
|
|
|
|
func TestTrivialExecutablePIE(t *testing.T) {
|
|
|
|
goCmd(t, "build", "-buildmode=pie", "-o", "trivial.pie", "-linkshared", "trivial")
|
|
|
|
run(t, "trivial executable", "./trivial.pie")
|
|
|
|
AssertIsLinkedTo(t, "./trivial.pie", soname)
|
|
|
|
AssertHasRPath(t, "./trivial.pie", gorootInstallDir)
|
|
|
|
}
|
|
|
|
|
2017-02-27 00:56:57 -07:00
|
|
|
// Build a division test program and check it runs.
|
|
|
|
func TestDivisionExecutable(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-linkshared", "division")
|
|
|
|
run(t, "division executable", "./bin/division")
|
|
|
|
}
|
|
|
|
|
2015-06-15 19:41:11 -06:00
|
|
|
// Build an executable that uses cgo linked against the shared runtime and check it
|
|
|
|
// runs.
|
|
|
|
func TestCgoExecutable(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-linkshared", "execgo")
|
|
|
|
run(t, "cgo executable", "./bin/execgo")
|
|
|
|
}
|
|
|
|
|
2015-10-19 14:31:20 -06:00
|
|
|
func checkPIE(t *testing.T, name string) {
|
|
|
|
f, err := elf.Open(name)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("elf.Open failed: ", err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
if f.Type != elf.ET_DYN {
|
|
|
|
t.Errorf("%s has type %v, want ET_DYN", name, f.Type)
|
|
|
|
}
|
|
|
|
if hasDynTag(f, elf.DT_TEXTREL) {
|
|
|
|
t.Errorf("%s has DT_TEXTREL set", name)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTrivialPIE(t *testing.T) {
|
|
|
|
name := "trivial_pie"
|
|
|
|
goCmd(t, "build", "-buildmode=pie", "-o="+name, "trivial")
|
|
|
|
defer os.Remove(name)
|
|
|
|
run(t, name, "./"+name)
|
|
|
|
checkPIE(t, name)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestCgoPIE(t *testing.T) {
|
|
|
|
name := "cgo_pie"
|
|
|
|
goCmd(t, "build", "-buildmode=pie", "-o="+name, "execgo")
|
|
|
|
defer os.Remove(name)
|
|
|
|
run(t, name, "./"+name)
|
|
|
|
checkPIE(t, name)
|
|
|
|
}
|
|
|
|
|
2015-05-07 03:29:47 -06:00
|
|
|
// Build a GOPATH package into a shared library that links against the goroot runtime
|
|
|
|
// and an executable that links against both.
|
2015-05-10 19:39:28 -06:00
|
|
|
func TestGopathShlib(t *testing.T) {
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
|
|
|
AssertIsLinkedTo(t, filepath.Join(gopathInstallDir, "libdepBase.so"), soname)
|
2015-05-07 03:29:47 -06:00
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
AssertIsLinkedTo(t, "./bin/exe", soname)
|
2016-05-03 17:23:24 -06:00
|
|
|
AssertIsLinkedTo(t, "./bin/exe", "libdepBase.so")
|
2015-05-07 03:29:47 -06:00
|
|
|
AssertHasRPath(t, "./bin/exe", gorootInstallDir)
|
|
|
|
AssertHasRPath(t, "./bin/exe", gopathInstallDir)
|
|
|
|
// And check it runs.
|
|
|
|
run(t, "executable linked to GOPATH library", "./bin/exe")
|
|
|
|
}
|
|
|
|
|
2015-05-24 19:59:08 -06:00
|
|
|
// The shared library contains a note listing the packages it contains in a section
|
|
|
|
// that is not mapped into memory.
|
|
|
|
func testPkgListNote(t *testing.T, f *elf.File, note *note) {
|
|
|
|
if note.section.Flags != 0 {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("package list section has flags %v, want 0", note.section.Flags)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
if isOffsetLoaded(f, note.section.Offset) {
|
|
|
|
t.Errorf("package list section contained in PT_LOAD segment")
|
|
|
|
}
|
2016-05-03 17:23:24 -06:00
|
|
|
if note.desc != "depBase\n" {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("incorrect package list %q, want %q", note.desc, "depBase\n")
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// The shared library contains a note containing the ABI hash that is mapped into
|
|
|
|
// memory and there is a local symbol called go.link.abihashbytes that points 16
|
|
|
|
// bytes into it.
|
|
|
|
func testABIHashNote(t *testing.T, f *elf.File, note *note) {
|
|
|
|
if note.section.Flags != elf.SHF_ALLOC {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("abi hash section has flags %v, want SHF_ALLOC", note.section.Flags)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
if !isOffsetLoaded(f, note.section.Offset) {
|
|
|
|
t.Errorf("abihash section not contained in PT_LOAD segment")
|
|
|
|
}
|
|
|
|
var hashbytes elf.Symbol
|
|
|
|
symbols, err := f.Symbols()
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("error reading symbols %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
for _, sym := range symbols {
|
|
|
|
if sym.Name == "go.link.abihashbytes" {
|
|
|
|
hashbytes = sym
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if hashbytes.Name == "" {
|
|
|
|
t.Errorf("no symbol called go.link.abihashbytes")
|
|
|
|
return
|
|
|
|
}
|
|
|
|
if elf.ST_BIND(hashbytes.Info) != elf.STB_LOCAL {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("%s has incorrect binding %v, want STB_LOCAL", hashbytes.Name, elf.ST_BIND(hashbytes.Info))
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
if f.Sections[hashbytes.Section] != note.section {
|
cmd/go: run vet automatically during go test
This CL adds an automatic, limited "go vet" to "go test".
If the building of a test package fails, vet is not run.
If vet fails, the test is not run.
The goal is that users don't notice vet as part of the "go test"
process at all, until vet speaks up and says something important.
This should help users find real problems in their code faster
(vet can just point to them instead of needing to debug a
test failure) and expands the scope of what kinds of things
vet can help with.
The "go vet" runs in parallel with the linking of the test binary,
so for incremental builds it typically does not slow the overall
"go test" at all: there's spare machine capacity during the link.
all.bash has less spare machine capacity. This CL increases
the time for all.bash on my laptop from 4m41s to 4m48s (+2.5%)
To opt out for a given run, use "go test -vet=off".
The vet checks used during "go test" are a subset of the full set,
restricted to ones that are 100% correct and therefore acceptable
to make mandatory. In this CL, that set is atomic, bool, buildtags,
nilfunc, and printf. Including printf is debatable, but I want to
include it for now and find out what needs to be scaled back.
(It already found one real problem in package os's tests that
previous go vet os had not turned up.)
Now that we can rely on type information it may be that printf
should make its function-name-based heuristic less aggressive
and have a whitelist of known print/printf functions.
Determining the exact set for Go 1.10 is #18085.
Running vet also means that programs now have to type-check
with both cmd/compile and go/types in order to pass "go test".
We don't start vet until cmd/compile has built the test package,
so normally the added go/types check doesn't find anything.
However, there is at least one instance where go/types is more
precise than cmd/compile: declared and not used errors involving
variables captured into closures.
This CL includes a printf fix to os/os_test.go and many declared
and not used fixes in the race detector tests.
Fixes #18084.
Change-Id: I353e00b9d1f9fec540c7557db5653e7501f5e1c9
Reviewed-on: https://go-review.googlesource.com/74356
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
2017-10-31 11:00:51 -06:00
|
|
|
t.Errorf("%s has incorrect section %v, want %s", hashbytes.Name, f.Sections[hashbytes.Section].Name, note.section.Name)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
if hashbytes.Value-note.section.Addr != 16 {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("%s has incorrect offset into section %d, want 16", hashbytes.Name, hashbytes.Value-note.section.Addr)
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-24 20:51:02 -06:00
|
|
|
// A Go shared library contains a note indicating which other Go shared libraries it
|
|
|
|
// was linked against in an unmapped section.
|
|
|
|
func testDepsNote(t *testing.T, f *elf.File, note *note) {
|
|
|
|
if note.section.Flags != 0 {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("package list section has flags %v, want 0", note.section.Flags)
|
2015-05-24 20:51:02 -06:00
|
|
|
}
|
|
|
|
if isOffsetLoaded(f, note.section.Offset) {
|
|
|
|
t.Errorf("package list section contained in PT_LOAD segment")
|
|
|
|
}
|
2016-05-03 17:23:24 -06:00
|
|
|
// libdepBase.so just links against the lib containing the runtime.
|
2015-05-24 20:51:02 -06:00
|
|
|
if note.desc != soname {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Errorf("incorrect dependency list %q, want %q", note.desc, soname)
|
2015-05-24 20:51:02 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-24 19:59:08 -06:00
|
|
|
// The shared library contains notes with defined contents; see above.
|
|
|
|
func TestNotes(t *testing.T) {
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
|
|
|
f, err := elf.Open(filepath.Join(gopathInstallDir, "libdepBase.so"))
|
2015-05-24 19:59:08 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
defer f.Close()
|
|
|
|
notes, err := readNotes(f)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
pkgListNoteFound := false
|
|
|
|
abiHashNoteFound := false
|
2015-05-24 20:51:02 -06:00
|
|
|
depsNoteFound := false
|
2015-05-24 19:59:08 -06:00
|
|
|
for _, note := range notes {
|
2015-06-04 12:27:39 -06:00
|
|
|
if note.name != "Go\x00\x00" {
|
2015-05-24 19:59:08 -06:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
switch note.tag {
|
|
|
|
case 1: // ELF_NOTE_GOPKGLIST_TAG
|
|
|
|
if pkgListNoteFound {
|
|
|
|
t.Error("multiple package list notes")
|
|
|
|
}
|
|
|
|
testPkgListNote(t, f, note)
|
|
|
|
pkgListNoteFound = true
|
|
|
|
case 2: // ELF_NOTE_GOABIHASH_TAG
|
|
|
|
if abiHashNoteFound {
|
|
|
|
t.Error("multiple abi hash notes")
|
|
|
|
}
|
|
|
|
testABIHashNote(t, f, note)
|
|
|
|
abiHashNoteFound = true
|
2015-05-24 20:51:02 -06:00
|
|
|
case 3: // ELF_NOTE_GODEPS_TAG
|
|
|
|
if depsNoteFound {
|
2017-10-09 19:07:32 -06:00
|
|
|
t.Error("multiple depedency list notes")
|
2015-05-24 20:51:02 -06:00
|
|
|
}
|
|
|
|
testDepsNote(t, f, note)
|
|
|
|
depsNoteFound = true
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
if !pkgListNoteFound {
|
|
|
|
t.Error("package list note not found")
|
|
|
|
}
|
|
|
|
if !abiHashNoteFound {
|
|
|
|
t.Error("abi hash note not found")
|
|
|
|
}
|
2015-05-24 20:51:02 -06:00
|
|
|
if !depsNoteFound {
|
|
|
|
t.Error("deps note not found")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
// Build a GOPATH package (depBase) into a shared library that links against the goroot
|
2015-05-24 20:51:02 -06:00
|
|
|
// runtime, another package (dep2) that links against the first, and and an
|
|
|
|
// executable that links against dep2.
|
2015-05-10 19:39:28 -06:00
|
|
|
func TestTwoGopathShlibs(t *testing.T) {
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-24 20:51:02 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep2")
|
|
|
|
goCmd(t, "install", "-linkshared", "exe2")
|
|
|
|
run(t, "executable linked to GOPATH library", "./bin/exe2")
|
2015-05-24 19:59:08 -06:00
|
|
|
}
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
func TestThreeGopathShlibs(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep2")
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "dep3")
|
|
|
|
goCmd(t, "install", "-linkshared", "exe3")
|
|
|
|
run(t, "executable linked to GOPATH library", "./bin/exe3")
|
|
|
|
}
|
|
|
|
|
2015-08-23 16:44:36 -06:00
|
|
|
// If gccgo is not available or not new enough call t.Skip. Otherwise,
|
|
|
|
// return a build.Context that is set up for gccgo.
|
|
|
|
func prepGccgo(t *testing.T) build.Context {
|
cmd/go: switch to entirely content-based staleness determination
This CL changes the go command to base all its rebuilding decisions
on the content of the files being processed and not their file system
modification times. It also eliminates the special handling of release
toolchains, which were previously considered always up-to-date
because modification time order could not be trusted when unpacking
a pre-built release.
The go command previously tracked "build IDs" as a backup to
modification times, to catch changes not reflected in modification times.
For example, if you remove one .go file in a package with multiple .go
files, there is no modification time remaining in the system that indicates
that the installed package is out of date. The old build ID was the hash
of a list of file names and a few other factors, expected to change if
those factors changed.
This CL moves to using this kind of build ID as the only way to
detect staleness, making sure that the build ID hash includes all
possible factors that need to influence the rebuild decision.
One such factor is the compiler flags. As of this CL, if you run
go build -gcflags -N cmd/gofmt
you will get a gofmt where every package is built with -N,
regardless of what may or may not be installed already.
Another such factor is the linker flags. As of this CL, if you run
go install myprog
go install -ldflags=-s myprog
the second go install will now correctly build a new myprog with
the updated linker flags. (Previously the installed myprog appeared
up-to-date, because the ldflags were not included in the build ID.)
Because we have more precise information we can also validate whether
the target of a "go test -c" operation is already the right binary and
therefore can avoid a rebuild.
This CL sets us up for having a more general build artifact cache,
maybe even a step toward not having a pkg directory with .a files,
but this CL does not take that step. For now the result of go install
is the same as it ever was; we just do a better job of what needs to
be installed.
This CL does slow down builds a small amount by reading all the
dependent source files in full. (The go command already read the
beginning of every dependent source file to discover build tags
and imports.) On my MacBook Pro, before this CL all.bash takes
3m58s, while after this CL and a few optimizations stacked above it
all.bash takes 4m28s. Given that CL 73850 cut 1m43s off the all.bash
time earlier today, we can afford adding 30s back for now.
More optimizations are planned that should make the go command
more efficient than it was even before this CL.
Fixes #15799.
Fixes #18369.
Fixes #19340.
Fixes #21477.
Change-Id: I10d7ca0e31ca3f58aabb9b1f11e2e3d9d18f0bc9
Reviewed-on: https://go-review.googlesource.com/73212
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
2017-10-11 18:39:28 -06:00
|
|
|
t.Skip("golang.org/issue/22472")
|
2015-05-10 19:39:28 -06:00
|
|
|
gccgoName := os.Getenv("GCCGO")
|
|
|
|
if gccgoName == "" {
|
|
|
|
gccgoName = "gccgo"
|
|
|
|
}
|
2015-08-23 16:44:36 -06:00
|
|
|
gccgoPath, err := exec.LookPath(gccgoName)
|
2015-05-10 19:39:28 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Skip("gccgo not found")
|
|
|
|
}
|
2015-08-23 16:44:36 -06:00
|
|
|
cmd := exec.Command(gccgoPath, "-dumpversion")
|
|
|
|
output, err := cmd.CombinedOutput()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("%s -dumpversion failed: %v\n%s", gccgoPath, err, output)
|
|
|
|
}
|
|
|
|
if string(output) < "5" {
|
|
|
|
t.Skipf("gccgo too old (%s)", strings.TrimSpace(string(output)))
|
|
|
|
}
|
2015-05-10 19:39:28 -06:00
|
|
|
gccgoContext := build.Default
|
|
|
|
gccgoContext.InstallSuffix = suffix + "_fPIC"
|
|
|
|
gccgoContext.Compiler = "gccgo"
|
|
|
|
gccgoContext.GOPATH = os.Getenv("GOPATH")
|
2015-08-23 16:44:36 -06:00
|
|
|
return gccgoContext
|
|
|
|
}
|
|
|
|
|
|
|
|
// Build a GOPATH package into a shared library with gccgo and an executable that
|
|
|
|
// links against it.
|
|
|
|
func TestGoPathShlibGccgo(t *testing.T) {
|
|
|
|
gccgoContext := prepGccgo(t)
|
|
|
|
|
|
|
|
libgoRE := regexp.MustCompile("libgo.so.[0-9]+")
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
depP, err := gccgoContext.Import("depBase", ".", build.ImportComment)
|
2015-05-10 19:39:28 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("import failed: %v", err)
|
|
|
|
}
|
|
|
|
gccgoInstallDir := filepath.Join(depP.PkgTargetRoot, "shlibs")
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-compiler=gccgo", "-buildmode=shared", "-linkshared", "depBase")
|
|
|
|
AssertIsLinkedToRegexp(t, filepath.Join(gccgoInstallDir, "libdepBase.so"), libgoRE)
|
2015-05-10 19:39:28 -06:00
|
|
|
goCmd(t, "install", "-compiler=gccgo", "-linkshared", "exe")
|
|
|
|
AssertIsLinkedToRegexp(t, "./bin/exe", libgoRE)
|
2016-05-03 17:23:24 -06:00
|
|
|
AssertIsLinkedTo(t, "./bin/exe", "libdepBase.so")
|
2015-05-10 19:39:28 -06:00
|
|
|
AssertHasRPath(t, "./bin/exe", gccgoInstallDir)
|
|
|
|
// And check it runs.
|
|
|
|
run(t, "gccgo-built", "./bin/exe")
|
|
|
|
}
|
|
|
|
|
|
|
|
// The gccgo version of TestTwoGopathShlibs: build a GOPATH package into a shared
|
|
|
|
// library with gccgo, another GOPATH package that depends on the first and an
|
|
|
|
// executable that links the second library.
|
|
|
|
func TestTwoGopathShlibsGccgo(t *testing.T) {
|
2017-10-26 21:11:32 -06:00
|
|
|
t.Skip("golang.org/issue/22224")
|
|
|
|
|
2015-08-23 16:44:36 -06:00
|
|
|
gccgoContext := prepGccgo(t)
|
2015-05-10 19:39:28 -06:00
|
|
|
|
|
|
|
libgoRE := regexp.MustCompile("libgo.so.[0-9]+")
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
depP, err := gccgoContext.Import("depBase", ".", build.ImportComment)
|
2015-05-10 19:39:28 -06:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("import failed: %v", err)
|
|
|
|
}
|
|
|
|
gccgoInstallDir := filepath.Join(depP.PkgTargetRoot, "shlibs")
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-compiler=gccgo", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-10 19:39:28 -06:00
|
|
|
goCmd(t, "install", "-compiler=gccgo", "-buildmode=shared", "-linkshared", "dep2")
|
|
|
|
goCmd(t, "install", "-compiler=gccgo", "-linkshared", "exe2")
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
AssertIsLinkedToRegexp(t, filepath.Join(gccgoInstallDir, "libdepBase.so"), libgoRE)
|
2015-05-10 19:39:28 -06:00
|
|
|
AssertIsLinkedToRegexp(t, filepath.Join(gccgoInstallDir, "libdep2.so"), libgoRE)
|
2016-05-03 17:23:24 -06:00
|
|
|
AssertIsLinkedTo(t, filepath.Join(gccgoInstallDir, "libdep2.so"), "libdepBase.so")
|
2015-05-10 19:39:28 -06:00
|
|
|
AssertIsLinkedToRegexp(t, "./bin/exe2", libgoRE)
|
|
|
|
AssertIsLinkedTo(t, "./bin/exe2", "libdep2")
|
2016-05-03 17:23:24 -06:00
|
|
|
AssertIsLinkedTo(t, "./bin/exe2", "libdepBase.so")
|
2015-05-10 19:39:28 -06:00
|
|
|
|
|
|
|
// And check it runs.
|
|
|
|
run(t, "gccgo-built", "./bin/exe2")
|
|
|
|
}
|
|
|
|
|
2015-05-07 03:29:47 -06:00
|
|
|
// Testing rebuilding of shared libraries when they are stale is a bit more
|
|
|
|
// complicated that it seems like it should be. First, we make everything "old": but
|
2015-06-23 17:50:12 -06:00
|
|
|
// only a few seconds old, or it might be older than gc (or the runtime source) and
|
2015-05-07 03:29:47 -06:00
|
|
|
// everything will get rebuilt. Then define a timestamp slightly newer than this
|
|
|
|
// time, which is what we set the mtime to of a file to cause it to be seen as new,
|
|
|
|
// and finally another slightly even newer one that we can compare files against to
|
|
|
|
// see if they have been rebuilt.
|
|
|
|
var oldTime = time.Now().Add(-9 * time.Second)
|
|
|
|
var nearlyNew = time.Now().Add(-6 * time.Second)
|
|
|
|
var stampTime = time.Now().Add(-3 * time.Second)
|
|
|
|
|
|
|
|
// resetFileStamps makes "everything" (bin, src, pkg from GOPATH and the
|
|
|
|
// test-specific parts of GOROOT) appear old.
|
|
|
|
func resetFileStamps() {
|
|
|
|
chtime := func(path string, info os.FileInfo, err error) error {
|
|
|
|
return os.Chtimes(path, oldTime, oldTime)
|
|
|
|
}
|
|
|
|
reset := func(path string) {
|
|
|
|
if err := filepath.Walk(path, chtime); err != nil {
|
|
|
|
log.Fatalf("resetFileStamps failed: %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
reset("bin")
|
|
|
|
reset("pkg")
|
|
|
|
reset("src")
|
|
|
|
reset(gorootInstallDir)
|
|
|
|
}
|
|
|
|
|
2017-10-27 18:36:14 -06:00
|
|
|
// touch changes path and returns a function that changes it back.
|
|
|
|
// It also sets the time of the file, so that we can see if it is rewritten.
|
|
|
|
func touch(t *testing.T, path string) (cleanup func()) {
|
|
|
|
data, err := ioutil.ReadFile(path)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
old := make([]byte, len(data))
|
|
|
|
copy(old, data)
|
|
|
|
if bytes.HasPrefix(data, []byte("!<arch>\n")) {
|
|
|
|
// Change last digit of build ID.
|
|
|
|
// (Content ID in the new content-based build IDs.)
|
|
|
|
const marker = `build id "`
|
|
|
|
i := bytes.Index(data, []byte(marker))
|
|
|
|
if i < 0 {
|
|
|
|
t.Fatal("cannot find build id in archive")
|
|
|
|
}
|
|
|
|
j := bytes.IndexByte(data[i+len(marker):], '"')
|
|
|
|
if j < 0 {
|
|
|
|
t.Fatal("cannot find build id in archive")
|
|
|
|
}
|
|
|
|
i += len(marker) + j - 1
|
|
|
|
if data[i] == 'a' {
|
|
|
|
data[i] = 'b'
|
|
|
|
} else {
|
|
|
|
data[i] = 'a'
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// assume it's a text file
|
|
|
|
data = append(data, '\n')
|
|
|
|
}
|
|
|
|
if err := ioutil.WriteFile(path, data, 0666); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
if err := os.Chtimes(path, nearlyNew, nearlyNew); err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
return func() {
|
|
|
|
if err := ioutil.WriteFile(path, old, 0666); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// isNew returns if the path is newer than the time stamp used by touch.
|
2017-10-27 18:36:14 -06:00
|
|
|
func isNew(t *testing.T, path string) bool {
|
2015-05-07 03:29:47 -06:00
|
|
|
fi, err := os.Stat(path)
|
|
|
|
if err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatal(err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
return fi.ModTime().After(stampTime)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fail unless path has been rebuilt (i.e. is newer than the time stamp used by
|
|
|
|
// isNew)
|
|
|
|
func AssertRebuilt(t *testing.T, msg, path string) {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Helper()
|
|
|
|
if !isNew(t, path) {
|
2015-05-07 03:29:47 -06:00
|
|
|
t.Errorf("%s was not rebuilt (%s)", msg, path)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Fail if path has been rebuilt (i.e. is newer than the time stamp used by isNew)
|
|
|
|
func AssertNotRebuilt(t *testing.T, msg, path string) {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Helper()
|
|
|
|
if isNew(t, path) {
|
2015-05-07 03:29:47 -06:00
|
|
|
t.Errorf("%s was rebuilt (%s)", msg, path)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRebuilding(t *testing.T) {
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-07 03:29:47 -06:00
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
|
|
|
|
// If the source is newer than both the .a file and the .so, both are rebuilt.
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Run("newsource", func(t *testing.T) {
|
|
|
|
resetFileStamps()
|
|
|
|
cleanup := touch(t, "src/depBase/dep.go")
|
|
|
|
defer func() {
|
|
|
|
cleanup()
|
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
}()
|
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
AssertRebuilt(t, "new source", filepath.Join(gopathInstallDir, "depBase.a"))
|
|
|
|
AssertRebuilt(t, "new source", filepath.Join(gopathInstallDir, "libdepBase.so"))
|
|
|
|
})
|
2015-05-07 03:29:47 -06:00
|
|
|
|
|
|
|
// If the .a file is newer than the .so, the .so is rebuilt (but not the .a)
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Run("newarchive", func(t *testing.T) {
|
|
|
|
resetFileStamps()
|
|
|
|
goCmd(t, "list", "-linkshared", "-f={{.ImportPath}} {{.Stale}} {{.StaleReason}} {{.Target}}", "depBase")
|
|
|
|
AssertNotRebuilt(t, "new .a file before build", filepath.Join(gopathInstallDir, "depBase.a"))
|
|
|
|
cleanup := touch(t, filepath.Join(gopathInstallDir, "depBase.a"))
|
|
|
|
defer func() {
|
|
|
|
cleanup()
|
|
|
|
goCmd(t, "install", "-v", "-linkshared", "exe")
|
|
|
|
}()
|
|
|
|
goCmd(t, "install", "-v", "-linkshared", "exe")
|
|
|
|
AssertNotRebuilt(t, "new .a file", filepath.Join(gopathInstallDir, "depBase.a"))
|
|
|
|
AssertRebuilt(t, "new .a file", filepath.Join(gopathInstallDir, "libdepBase.so"))
|
|
|
|
})
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
|
2017-10-27 18:36:14 -06:00
|
|
|
func appendFile(t *testing.T, path, content string) {
|
2015-05-07 03:29:47 -06:00
|
|
|
f, err := os.OpenFile(path, os.O_WRONLY|os.O_APPEND, 0660)
|
|
|
|
if err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatalf("os.OpenFile failed: %v", err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
defer func() {
|
|
|
|
err := f.Close()
|
|
|
|
if err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatalf("f.Close failed: %v", err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
}()
|
|
|
|
_, err = f.WriteString(content)
|
|
|
|
if err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatalf("f.WriteString failed: %v", err)
|
2015-05-07 03:29:47 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-10-27 18:36:14 -06:00
|
|
|
func writeFile(t *testing.T, path, content string) {
|
2017-04-11 22:08:46 -06:00
|
|
|
err := ioutil.WriteFile(path, []byte(content), 0644)
|
|
|
|
if err != nil {
|
2017-10-27 18:36:14 -06:00
|
|
|
t.Fatalf("ioutil.WriteFile failed: %v", err)
|
2017-04-11 22:08:46 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-05-07 03:29:47 -06:00
|
|
|
func TestABIChecking(t *testing.T) {
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-07 03:29:47 -06:00
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
|
2016-05-03 17:23:24 -06:00
|
|
|
// If we make an ABI-breaking change to depBase and rebuild libp.so but not exe,
|
2015-05-07 03:29:47 -06:00
|
|
|
// exe will abort with a complaint on startup.
|
|
|
|
// This assumes adding an exported function breaks ABI, which is not true in
|
2016-04-03 05:43:27 -06:00
|
|
|
// some senses but suffices for the narrow definition of ABI compatibility the
|
2015-05-07 03:29:47 -06:00
|
|
|
// toolchain uses today.
|
2015-06-16 12:03:19 -06:00
|
|
|
resetFileStamps()
|
2017-10-27 18:36:14 -06:00
|
|
|
appendFile(t, "src/depBase/dep.go", "func ABIBreak() {}\n")
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-07 03:29:47 -06:00
|
|
|
c := exec.Command("./bin/exe")
|
|
|
|
output, err := c.CombinedOutput()
|
|
|
|
if err == nil {
|
|
|
|
t.Fatal("executing exe did not fail after ABI break")
|
|
|
|
}
|
|
|
|
scanner := bufio.NewScanner(bytes.NewReader(output))
|
|
|
|
foundMsg := false
|
2016-05-03 17:23:24 -06:00
|
|
|
const wantLine = "abi mismatch detected between the executable and libdepBase.so"
|
2015-05-07 03:29:47 -06:00
|
|
|
for scanner.Scan() {
|
|
|
|
if scanner.Text() == wantLine {
|
|
|
|
foundMsg = true
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if err = scanner.Err(); err != nil {
|
|
|
|
t.Errorf("scanner encountered error: %v", err)
|
|
|
|
}
|
|
|
|
if !foundMsg {
|
|
|
|
t.Fatalf("exe failed, but without line %q; got output:\n%s", wantLine, output)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Rebuilding exe makes it work again.
|
|
|
|
goCmd(t, "install", "-linkshared", "exe")
|
|
|
|
run(t, "rebuilt exe", "./bin/exe")
|
|
|
|
|
|
|
|
// If we make a change which does not break ABI (such as adding an unexported
|
2017-04-11 22:08:46 -06:00
|
|
|
// function) and rebuild libdepBase.so, exe still works, even if new function
|
|
|
|
// is in a file by itself.
|
2015-06-16 12:03:19 -06:00
|
|
|
resetFileStamps()
|
2017-10-27 18:36:14 -06:00
|
|
|
writeFile(t, "src/depBase/dep2.go", "package depBase\nfunc noABIBreak() {}\n")
|
2016-05-03 17:23:24 -06:00
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "depBase")
|
2015-05-07 03:29:47 -06:00
|
|
|
run(t, "after non-ABI breaking change", "./bin/exe")
|
|
|
|
}
|
2016-01-19 19:31:26 -07:00
|
|
|
|
|
|
|
// If a package 'explicit' imports a package 'implicit', building
|
|
|
|
// 'explicit' into a shared library implicitly includes implicit in
|
|
|
|
// the shared library. Building an executable that imports both
|
|
|
|
// explicit and implicit builds the code from implicit into the
|
|
|
|
// executable rather than fetching it from the shared library. The
|
|
|
|
// link still succeeds and the executable still runs though.
|
|
|
|
func TestImplicitInclusion(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "explicit")
|
|
|
|
goCmd(t, "install", "-linkshared", "implicitcmd")
|
|
|
|
run(t, "running executable linked against library that contains same package as it", "./bin/implicitcmd")
|
|
|
|
}
|
2017-01-11 16:02:16 -07:00
|
|
|
|
|
|
|
// Tests to make sure that the type fields of empty interfaces and itab
|
|
|
|
// fields of nonempty interfaces are unique even across modules,
|
|
|
|
// so that interface equality works correctly.
|
|
|
|
func TestInterface(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "iface_a")
|
|
|
|
// Note: iface_i gets installed implicitly as a dependency of iface_a.
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "iface_b")
|
|
|
|
goCmd(t, "install", "-linkshared", "iface")
|
|
|
|
run(t, "running type/itab uniqueness tester", "./bin/iface")
|
|
|
|
}
|
2017-09-20 10:12:33 -06:00
|
|
|
|
|
|
|
// Access a global variable from a library.
|
|
|
|
func TestGlobal(t *testing.T) {
|
|
|
|
goCmd(t, "install", "-buildmode=shared", "-linkshared", "globallib")
|
|
|
|
goCmd(t, "install", "-linkshared", "global")
|
|
|
|
run(t, "global executable", "./bin/global")
|
|
|
|
AssertIsLinkedTo(t, "./bin/global", soname)
|
|
|
|
AssertHasRPath(t, "./bin/global", gorootInstallDir)
|
|
|
|
}
|