go/test/fixedbugs/issue23179.dir/b.go

// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package b

import "a"

func G(x int) int {
	return a.F(x, 1, false, a.Large{})
}
cmd/compile: fix corner case in DWARF inline info generation The helper routine for returning pre-inlining parameter declarations wasn't properly handling the case where you have more than one parameter named "_" in a function signature; this triggered a map collision later on when the function was inlined and DWARF was generated for the inlined routine instance. Fixes #23179. Change-Id: I12e5d6556ec5ce08e982a6b53666a4dcc1d22201 Reviewed-on: https://go-review.googlesource.com/84755 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> 2017-12-19 10:08:32 -07:00			`// Copyright 2017 The Go Authors. All rights reserved.`
			`// Use of this source code is governed by a BSD-style`
			`// license that can be found in the LICENSE file.`

			`package b`

			`import "a"`

			`func G(x int) int {`
cmd/compile: second attempt at fix for issue 23179 My previous fix for issue 23179 was incomplete; it turns out that if an unnamed parameter is below a specific size threshold, it gets register-promoted away by the compiler (hence not encountered during some parts of DWARF inline info processing), but if it is sufficiently large, it is allocated to the stack as a named variable and treated as a regular parameter by DWARF generation. Interestingly, something in the ppc64le build of k8s causes an unnamed parameter to be retained (where on amd64 it is deleted), meaning that this wasn't caught in my amd64 testing. The fix is to insure that "_" params are treated in the same way that "~r%d" return temps are when matching up post-optimization inlined routine params with pre-inlining declarations. I've also updated the test case to include a "_" parameter with a very large size, which also triggers the bug on amd64. Fixes #23179. Change-Id: I961c84cc7a873ad3f8f91db098a5e13896c4856e Reviewed-on: https://go-review.googlesource.com/84975 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> Reviewed-by: Heschi Kreinick <heschi@google.com> 2017-12-20 07:54:13 -07:00			`return a.F(x, 1, false, a.Large{})`
cmd/compile: fix corner case in DWARF inline info generation The helper routine for returning pre-inlining parameter declarations wasn't properly handling the case where you have more than one parameter named "_" in a function signature; this triggered a map collision later on when the function was inlined and DWARF was generated for the inlined routine instance. Fixes #23179. Change-Id: I12e5d6556ec5ce08e982a6b53666a4dcc1d22201 Reviewed-on: https://go-review.googlesource.com/84755 Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> 2017-12-19 10:08:32 -07:00			`}`