2018-12-14 13:46:12 -07:00
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
package cmd_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"flag"
|
|
|
|
"fmt"
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
"path/filepath"
|
|
|
|
"regexp"
|
2019-03-15 09:11:23 -06:00
|
|
|
"runtime"
|
2018-12-14 13:46:12 -07:00
|
|
|
"strconv"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"golang.org/x/tools/go/packages/packagestest"
|
|
|
|
"golang.org/x/tools/internal/lsp/cmd"
|
2019-02-19 19:11:15 -07:00
|
|
|
"golang.org/x/tools/internal/span"
|
2018-12-14 13:46:12 -07:00
|
|
|
"golang.org/x/tools/internal/tool"
|
|
|
|
)
|
|
|
|
|
2019-03-25 16:30:55 -06:00
|
|
|
const (
|
|
|
|
expectedDefinitionsCount = 25
|
|
|
|
expectedTypeDefinitionsCount = 2
|
|
|
|
)
|
|
|
|
|
|
|
|
type definition struct {
|
2019-04-02 10:06:03 -06:00
|
|
|
src span.Span
|
|
|
|
flags string
|
|
|
|
def span.Span
|
|
|
|
pattern pattern
|
2019-03-25 16:30:55 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
type definitions map[span.Span]definition
|
|
|
|
|
2018-12-14 13:46:12 -07:00
|
|
|
var verifyGuru = flag.Bool("verify-guru", false, "Check that the guru compatability matches")
|
|
|
|
|
|
|
|
func TestDefinitionHelpExample(t *testing.T) {
|
2019-03-15 09:11:23 -06:00
|
|
|
if runtime.GOOS == "android" {
|
|
|
|
t.Skip("not all source files are available on android")
|
|
|
|
}
|
2018-12-14 13:46:12 -07:00
|
|
|
dir, err := os.Getwd()
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("could not get wd: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
thisFile := filepath.Join(dir, "definition.go")
|
2019-03-18 13:07:21 -06:00
|
|
|
baseArgs := []string{"query", "definition"}
|
2019-03-20 08:12:34 -06:00
|
|
|
expect := regexp.MustCompile(`^[\w/\\:_-]+flag[/\\]flag.go:\d+:\d+-\d+: defined here as type flag.FlagSet struct{.*}$`)
|
2019-03-18 12:40:57 -06:00
|
|
|
for _, query := range []string{
|
|
|
|
fmt.Sprintf("%v:%v:%v", thisFile, cmd.ExampleLine, cmd.ExampleColumn),
|
|
|
|
fmt.Sprintf("%v:#%v", thisFile, cmd.ExampleOffset)} {
|
2019-03-18 13:07:21 -06:00
|
|
|
args := append(baseArgs, query)
|
|
|
|
got := captureStdOut(t, func() {
|
|
|
|
tool.Main(context.Background(), &cmd.Application{}, args)
|
|
|
|
})
|
|
|
|
if !expect.MatchString(got) {
|
|
|
|
t.Errorf("test with %v\nexpected:\n%s\ngot:\n%s", args, expect, got)
|
|
|
|
}
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-25 16:30:55 -06:00
|
|
|
func (l definitions) godef(src, def span.Span) {
|
|
|
|
l[src] = definition{
|
2019-04-02 10:06:03 -06:00
|
|
|
src: src,
|
|
|
|
def: def,
|
|
|
|
pattern: newPattern("", def),
|
2019-03-25 16:30:55 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (l definitions) typdef(src, def span.Span) {
|
|
|
|
l[src] = definition{
|
2019-04-02 10:06:03 -06:00
|
|
|
src: src,
|
|
|
|
def: def,
|
|
|
|
pattern: newPattern("", def),
|
2019-03-25 16:30:55 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (l definitions) definition(src span.Span, flags string, def span.Span, match string) {
|
|
|
|
l[src] = definition{
|
2019-04-02 10:06:03 -06:00
|
|
|
src: src,
|
|
|
|
flags: flags,
|
|
|
|
def: def,
|
|
|
|
pattern: newPattern(match, def),
|
2019-03-25 16:30:55 -06:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (l definitions) testDefinitions(t *testing.T, e *packagestest.Exported) {
|
|
|
|
if len(l) != expectedDefinitionsCount {
|
|
|
|
t.Errorf("got %v definitions expected %v", len(l), expectedDefinitionsCount)
|
|
|
|
}
|
|
|
|
for _, d := range l {
|
|
|
|
args := []string{"query"}
|
|
|
|
if d.flags != "" {
|
|
|
|
args = append(args, strings.Split(d.flags, " ")...)
|
|
|
|
}
|
|
|
|
args = append(args, "definition")
|
|
|
|
src := span.New(d.src.URI(), span.NewPoint(0, 0, d.src.Start().Offset()), span.Point{})
|
|
|
|
args = append(args, fmt.Sprint(src))
|
|
|
|
app := &cmd.Application{}
|
|
|
|
app.Config = *e.Config
|
|
|
|
got := captureStdOut(t, func() {
|
|
|
|
tool.Main(context.Background(), app, args)
|
|
|
|
})
|
2019-04-02 10:06:03 -06:00
|
|
|
if !d.pattern.matches(got) {
|
|
|
|
t.Errorf("definition %v\nexpected:\n%s\ngot:\n%s", args, d.pattern, got)
|
|
|
|
}
|
|
|
|
if *verifyGuru {
|
|
|
|
moduleMode := e.File(e.Modules[0].Name, "go.mod") != ""
|
|
|
|
var guruArgs []string
|
|
|
|
runGuru := false
|
|
|
|
if !moduleMode {
|
|
|
|
for _, arg := range args {
|
|
|
|
switch {
|
|
|
|
case arg == "query":
|
|
|
|
// just ignore this one
|
|
|
|
case arg == "-json":
|
|
|
|
guruArgs = append(guruArgs, arg)
|
|
|
|
case arg == "-emulate=guru":
|
|
|
|
// if we don't see this one we should not run guru
|
|
|
|
runGuru = true
|
|
|
|
case strings.HasPrefix(arg, "-"):
|
|
|
|
// unknown flag, ignore it
|
|
|
|
break
|
|
|
|
default:
|
|
|
|
guruArgs = append(guruArgs, arg)
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
|
|
|
}
|
2019-04-02 10:06:03 -06:00
|
|
|
}
|
|
|
|
if runGuru {
|
|
|
|
cmd := exec.Command("guru", guruArgs...)
|
|
|
|
cmd.Env = e.Config.Env
|
|
|
|
out, err := cmd.CombinedOutput()
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("Could not run guru %v: %v\n%s", guruArgs, err, out)
|
|
|
|
} else {
|
|
|
|
guru := strings.TrimSpace(string(out))
|
|
|
|
if !d.pattern.matches(guru) {
|
|
|
|
t.Errorf("definition %v\nexpected:\n%s\nguru gave:\n%s", args, d.pattern, guru)
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-03-25 16:30:55 -06:00
|
|
|
}
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-25 16:30:55 -06:00
|
|
|
func (l definitions) testTypeDefinitions(t *testing.T, e *packagestest.Exported) {
|
|
|
|
if len(l) != expectedTypeDefinitionsCount {
|
|
|
|
t.Errorf("got %v definitions expected %v", len(l), expectedTypeDefinitionsCount)
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
2019-03-25 16:30:55 -06:00
|
|
|
//TODO: add command line type definition tests when it works
|
2018-12-14 13:46:12 -07:00
|
|
|
}
|
2019-04-02 10:06:03 -06:00
|
|
|
|
|
|
|
type pattern struct {
|
|
|
|
raw string
|
|
|
|
expanded []string
|
|
|
|
matchAll bool
|
|
|
|
}
|
|
|
|
|
|
|
|
func newPattern(s string, def span.Span) pattern {
|
|
|
|
p := pattern{raw: s}
|
|
|
|
if s == "" {
|
|
|
|
p.expanded = []string{fmt.Sprintf("%v: ", def)}
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
p.matchAll = strings.HasSuffix(s, "$$")
|
|
|
|
for _, fragment := range strings.Split(s, "$$") {
|
|
|
|
p.expanded = append(p.expanded, os.Expand(fragment, func(name string) string {
|
|
|
|
switch name {
|
|
|
|
case "file":
|
|
|
|
fname, _ := def.URI().Filename()
|
|
|
|
return fname
|
|
|
|
case "efile":
|
|
|
|
fname, _ := def.URI().Filename()
|
|
|
|
qfile := strconv.Quote(fname)
|
|
|
|
return qfile[1 : len(qfile)-1]
|
|
|
|
case "euri":
|
|
|
|
quri := strconv.Quote(string(def.URI()))
|
|
|
|
return quri[1 : len(quri)-1]
|
|
|
|
case "line":
|
|
|
|
return fmt.Sprint(def.Start().Line())
|
|
|
|
case "col":
|
|
|
|
return fmt.Sprint(def.Start().Column())
|
|
|
|
case "offset":
|
|
|
|
return fmt.Sprint(def.Start().Offset())
|
|
|
|
case "eline":
|
|
|
|
return fmt.Sprint(def.End().Line())
|
|
|
|
case "ecol":
|
|
|
|
return fmt.Sprint(def.End().Column())
|
|
|
|
case "eoffset":
|
|
|
|
return fmt.Sprint(def.End().Offset())
|
|
|
|
default:
|
|
|
|
return name
|
|
|
|
}
|
|
|
|
}))
|
|
|
|
}
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p pattern) String() string {
|
|
|
|
return strings.Join(p.expanded, "$$")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p pattern) matches(s string) bool {
|
|
|
|
if len(p.expanded) == 0 {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
if !strings.HasPrefix(s, p.expanded[0]) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
remains := s[len(p.expanded[0]):]
|
|
|
|
for _, fragment := range p.expanded[1:] {
|
|
|
|
i := strings.Index(remains, fragment)
|
|
|
|
if i < 0 {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
remains = remains[i+len(fragment):]
|
|
|
|
}
|
|
|
|
if !p.matchAll {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
return len(remains) == 0
|
|
|
|
}
|