go/internal/lsp/testdata/bad/badimport.go

package bad

import (
	_ "nosuchpkg" //@diag("_", "compiler", "could not import nosuchpkg (no package for import nosuchpkg)")
)
internal/lsp: add a test to make sure we handle bad imports There was a regression where gopls would not type-check any package with a bad import. This change fixes the regression and adds a test to make sure it doesn't happen again. Change-Id: I3acf0917d46e9444c20135559f057f0ecd20e15b Reviewed-on: https://go-review.googlesource.com/c/tools/+/201539 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> 2019-10-16 17:09:37 -06:00			`package bad`

			`import (`
internal/lsp: do not close over the handle in the memoize function Closing over the checkPackageHandle creates a cycle that forces the checkPackageHandle not to be garbage collected until the value is created. If a value is never created, the handle will not be collected. Change-Id: I0f94557da917330ebe307a0e843b16ca7382e210 Reviewed-on: https://go-review.googlesource.com/c/tools/+/204079 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> 2019-10-29 10:16:15 -06:00			`_ "nosuchpkg" //@diag("_", "compiler", "could not import nosuchpkg (no package for import nosuchpkg)")`
internal/lsp: add a test to make sure we handle bad imports There was a regression where gopls would not type-check any package with a bad import. This change fixes the regression and adds a test to make sure it doesn't happen again. Change-Id: I3acf0917d46e9444c20135559f057f0ecd20e15b Reviewed-on: https://go-review.googlesource.com/c/tools/+/201539 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com> 2019-10-16 17:09:37 -06:00			`)`