qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 02:34:44 -07:00
Code Releases Activity
49a3e744a4
go/internal/lsp/testdata/summary.txt.golden

25 lines
517 B
Plaintext
Raw Normal View History

use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
-- summary --
internal/lsp: remove useless signature cast completion candidate In a previous change I inadvertently added completion candidates like: var f func(int) f = <> // useless candidate "func(int)(<>)" Ignoring the fact it is a syntax error without more parens around the signature, it isn't a useful candidate because you don't need to cast when assigning a named signature type to an unnamed type. Change-Id: Ic261817af344ee47193240a11dca5d3a32cbd293 Reviewed-on: https://go-review.googlesource.com/c/tools/+/211319 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-13 17:17:40 -07:00
CompletionsCount = 223
internal/lsp: offer basic type conversion candidates When the expected type is a basic type, we will now offer a corresponding type conversion candidate. For example: var foo int64 foo = // offer "int64(<>)" as a candidate The type conversion candidate will be ranked below matching concrete candidates but above the sea of non-matching candidates. This change broke almost every completion test. I added a new completion option for literal candidates so tests can selectively ask for literal completions. Updates golang/go#36015. Change-Id: I63fbdb33436d662a666c1ffd3b2d918d840dccc7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210288 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-06 15:29:09 -07:00
CompletionSnippetCount = 53
internal/lsp/source: cap number of unimported completions Building unimported completions requires re-parsing and formatting at least some of the file for each one, which adds up. Limit it to 20; I expect people will just type more rather than scroll through a giant list. Updates golang/go#36001. Change-Id: Ib41232b91c327d4b824e6176e30306abf356f5b4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210198 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 16:08:19 -07:00
UnimportedCompletionsCount = 4
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
DeepCompletionsCount = 5
internal/lsp: search for deep completions across function calls We now continue deep completion search across function calls. The function must take no arguments and return a single argument. For example, when completing "fo<>" you might get candidates such as "foo.bar().baz()". Previously we would stop searching for deep completions when we hit a function call. For example, we would stop at "foo.bar()", never finding "foo.bar().baz()". At the time I was worried about the search scope growing too large, but now that we dynamically limit the search scope there isn't much left to worry about. Change-Id: I48772c154400662876682503c1f58ef6e3dca688 Reviewed-on: https://go-review.googlesource.com/c/tools/+/201222 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org>
2019-10-01 14:36:34 -06:00
FuzzyCompletionsCount = 7
internal/lsp: fix variadic interface completion ranking In cases like: var foo []io.Writer var buf *bytes.Buffer foo = append(foo, <>) we weren't giving "buf" a good score. When comparing the candidate type *bytes.Buffer to the (variadic) expected type []io.Writer we were turning the candidate type into []*bytes.Buffer. However, of course, []*bytes.Buffer is not assignable to []io.Writer, so the types didn't match. Now we instead turn the expected type []io.Writer into io.Writer and compare to *bytes.Buffer. I fixed the @rank test note to check that the candidates' scores are strictly decreasing. Previously it would allow candidates with the same score if they happened to be in the right order. This made it easier to right a test for this issue, but also uncovered an issue with untyped completion logic. I fixed it to do the untyped constant check if _either_ the expected or candidate type is untyped (previously it required the candidate type to be untyped). Fixes golang/go#35625. Change-Id: I9a837d6a781669cb7a2f1d6d3d7f360c85be49eb Reviewed-on: https://go-review.googlesource.com/c/tools/+/207518 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-11-15 17:14:15 -07:00
RankedCompletionsCount = 26
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
CaseSensitiveCompletionsCount = 4
internal/lsp: add diagnostic on import causing import cycle After the addition of golang/go#35964, the import cycle error now has the import stack attached in the message. This CL parses that stack and attached the import cycle diagnostic to the import versus just adding it to the first character of the .go file. Fixes golang/go#33085 Change-Id: I6f5f067c338879b898829951236f816aa63d9dfa Reviewed-on: https://go-review.googlesource.com/c/tools/+/210942 Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-11 12:30:48 -07:00
DiagnosticsCount = 35
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
FoldingRangesCount = 2
FormatCount = 6
internal/lsp/source: start import diffs at byte 0 I assumed that f.Pos() would be the first byte of the file, but it's the position of the package declaration. This kills the file. Just use 0. Fixes golang/go#35458. Change-Id: Ic77c93344c71435ef8e5624c2f2defb619139a15 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206145 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-08 11:43:54 -07:00
ImportCount = 7
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
SuggestedFixCount = 1
internal/lsp: improve link in documentation on hover This change refactors some of the logic that builds a link anchor for a given symbol, pushing the actual Link into the HoverInformation struct. This is necessary because type information is needed to build up that link in certain cases, like methods. The last step will be to correctly display struct fields. Updates golang/go#34240 Fixes golang/go#36031 Change-Id: I7f989faddbaa07f91838a870b4477bf78ce8ddf7 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210201 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-06 00:44:16 -07:00
DefinitionsCount = 39
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
TypeDefinitionsCount = 2
internal/lsp: skip return highlighting if cursor is in arglist of func If the cursor is within an argument that is within a callExpr which is in a return statement, we only want it to highlight the ident that the cursor is in. We do not want it to highlight the entire function. Updates golang/go#34496 Change-Id: If4025660a99fd5df90098e0560a5e9e7260e33c8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/211338 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rohan Challa <rohan@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-12-13 14:06:33 -07:00
HighlightsCount = 44
internal/lsp/source: add support for references in the same workspace When looking for references, look in the entire workspace rather than the same package. This makes the references query more expensive because it needs to look at every package in the workspace, but hopefully it shouln't be user-noticable. This can be made more efficient by only checking packages that are transitive reverse dependencies. I don't think a mechanism to get all transitive reverse dependencies exists yet. One of the references test have been changed: it looked up references of the builtin int type, but now there are so many refererences that the test too slow and doesn't make sense any more. Instead look up references of the type "i" in that file. Change-Id: I93b3bd3795386f06ce488e76e6c7c8c1b1074e22 Reviewed-on: https://go-review.googlesource.com/c/tools/+/206883 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-12 18:16:00 -07:00
ReferencesCount = 7
internal/lsp/testadata/rename: add a test case for renames across packages Renames across packages works as of https://golang.org/cl/206883. Add a test for it. Fixes golang/go#32877 Change-Id: I234fafe95a1060c0ca8d03462bf7b2c241d59e4a Reviewed-on: https://go-review.googlesource.com/c/tools/+/207264 Run-TryBot: Michael Matloob <matloob@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-11-14 13:40:29 -07:00
RenamesCount = 22
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
PrepareRenamesCount = 8
SymbolsCount = 1
internal/lsp: use AST to construct placeholders Type aliases don't work well with types.TypeString. Work around that by using the AST to build this information. Follow up from CL 201677. Fixes golang/go#33500 Change-Id: I8b2d4ea238eb5d284a419f2b0bbf9655e69d434d Reviewed-on: https://go-review.googlesource.com/c/tools/+/208497 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-11-22 12:49:12 -07:00
SignaturesCount = 22
internal/lsp: use import path literal for documentLink range Instead of using the entire import node as the range for the link, use only the link text in the path node itself. This looks better when using a _ or named import, as well as constraining the link to inside the quotes. Fixes golang/go#35565 Change-Id: Ie93d9df993fbd8e0106ca6c3b40e0885355be66b Reviewed-on: https://go-review.googlesource.com/c/tools/+/207137 Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com>
2019-11-13 21:53:00 -07:00
LinksCount = 6
internal/lsp: tweak implementation tests - Add test count to golden file so test count gets checked. - Make @implementation note take a list of marks similar to completion tests. - Get rid of unnecessary intermediate test data type. Change-Id: I741eb14b77b0b8ed08e86c634ed39457116e8718 Reviewed-on: https://go-review.googlesource.com/c/tools/+/210278 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-12-05 20:27:32 -07:00
ImplementationsCount = 4
use a golden file for the expected test counts This makes it much easier to keep them up to date. It is also less fragile against accidental changes. Change-Id: If119f8527c0896d210650859960e77f3e0fa5a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/197505 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-09-26 10:54:25 -06:00
Copy Permalink