2019-03-13 14:42:18 -06:00
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
// Package reboot_test verifies that the current GOROOT can be used to bootstrap
|
|
|
|
// itself.
|
|
|
|
package reboot_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"os"
|
|
|
|
"os/exec"
|
|
|
|
"path/filepath"
|
|
|
|
"runtime"
|
|
|
|
"testing"
|
misc/reboot: don't use symlinks when copying GOROOT/src
go:embed disallows using symlinked files by design.
crypto/elliptic is the first std package to use it as of CL 380475,
and unfortunately that broke the TestRepeatBootstrap long test.
The reason it uses symlinks is for speed; it wants to copy GOROOT/src,
but regular files aren't going to be modified in any way,
so a symlink, if supported, means not needing to copy the contents.
Replace the symlink attempt with hard links,
which will mean regular files remain as such, fixing go:embed.
It's worth noting that on many systems hard links won't work,
as the temporary filesystem tends to be separate,
but it doesn't hurt to try.
In my system, where /tmp is tmpfs, the test now copies more bytes.
With the added Logf, I can see overlayDir goes from ~30ms to ~100ms.
This makes sense, as GOROOT/src currently weighs around 100MiB.
To alleviate that slow-down, stop copying testdata directories,
as they currently weigh around 20MiB and aren't needed for the test.
This gets overlayDir on my system down to an acceptable ~70ms.
I briefly considered teaching overlayDir what files can be symlinks,
but that seemed fairly complex long-term, as any file could be embedded.
While here, start using testing.T.TempDir and fs.WalkDir.
For #50995.
Change-Id: I17947e6bdee96237e1ca0606ad0b95e7c5987bc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/383995
Trust: Daniel Martí <mvdan@mvdan.cc>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-08 07:49:30 -07:00
|
|
|
"time"
|
2019-03-13 14:42:18 -06:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestRepeatBootstrap(t *testing.T) {
|
2021-11-23 08:54:49 -07:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skipf("skipping test that rebuilds the entire toolchain")
|
|
|
|
}
|
|
|
|
|
2022-09-09 15:29:12 -06:00
|
|
|
realGoroot, err := filepath.Abs(filepath.Join("..", ".."))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// To ensure that bootstrapping doesn't unexpectedly depend
|
|
|
|
// on the Go repo's git metadata, add a fake (unreadable) git
|
|
|
|
// directory above the simulated GOROOT.
|
|
|
|
// This mimics the configuration one much have when
|
|
|
|
// building from distro-packaged source code
|
|
|
|
// (see https://go.dev/issue/54852).
|
|
|
|
parent := t.TempDir()
|
|
|
|
dotGit := filepath.Join(parent, ".git")
|
|
|
|
if err := os.Mkdir(dotGit, 000); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
goroot := filepath.Join(parent, "goroot")
|
2019-03-13 14:42:18 -06:00
|
|
|
|
|
|
|
gorootSrc := filepath.Join(goroot, "src")
|
misc/reboot: don't use symlinks when copying GOROOT/src
go:embed disallows using symlinked files by design.
crypto/elliptic is the first std package to use it as of CL 380475,
and unfortunately that broke the TestRepeatBootstrap long test.
The reason it uses symlinks is for speed; it wants to copy GOROOT/src,
but regular files aren't going to be modified in any way,
so a symlink, if supported, means not needing to copy the contents.
Replace the symlink attempt with hard links,
which will mean regular files remain as such, fixing go:embed.
It's worth noting that on many systems hard links won't work,
as the temporary filesystem tends to be separate,
but it doesn't hurt to try.
In my system, where /tmp is tmpfs, the test now copies more bytes.
With the added Logf, I can see overlayDir goes from ~30ms to ~100ms.
This makes sense, as GOROOT/src currently weighs around 100MiB.
To alleviate that slow-down, stop copying testdata directories,
as they currently weigh around 20MiB and aren't needed for the test.
This gets overlayDir on my system down to an acceptable ~70ms.
I briefly considered teaching overlayDir what files can be symlinks,
but that seemed fairly complex long-term, as any file could be embedded.
While here, start using testing.T.TempDir and fs.WalkDir.
For #50995.
Change-Id: I17947e6bdee96237e1ca0606ad0b95e7c5987bc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/383995
Trust: Daniel Martí <mvdan@mvdan.cc>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-08 07:49:30 -07:00
|
|
|
overlayStart := time.Now()
|
2022-09-09 15:29:12 -06:00
|
|
|
if err := overlayDir(gorootSrc, filepath.Join(realGoroot, "src")); err != nil {
|
2019-03-13 14:42:18 -06:00
|
|
|
t.Fatal(err)
|
|
|
|
}
|
misc/reboot: don't use symlinks when copying GOROOT/src
go:embed disallows using symlinked files by design.
crypto/elliptic is the first std package to use it as of CL 380475,
and unfortunately that broke the TestRepeatBootstrap long test.
The reason it uses symlinks is for speed; it wants to copy GOROOT/src,
but regular files aren't going to be modified in any way,
so a symlink, if supported, means not needing to copy the contents.
Replace the symlink attempt with hard links,
which will mean regular files remain as such, fixing go:embed.
It's worth noting that on many systems hard links won't work,
as the temporary filesystem tends to be separate,
but it doesn't hurt to try.
In my system, where /tmp is tmpfs, the test now copies more bytes.
With the added Logf, I can see overlayDir goes from ~30ms to ~100ms.
This makes sense, as GOROOT/src currently weighs around 100MiB.
To alleviate that slow-down, stop copying testdata directories,
as they currently weigh around 20MiB and aren't needed for the test.
This gets overlayDir on my system down to an acceptable ~70ms.
I briefly considered teaching overlayDir what files can be symlinks,
but that seemed fairly complex long-term, as any file could be embedded.
While here, start using testing.T.TempDir and fs.WalkDir.
For #50995.
Change-Id: I17947e6bdee96237e1ca0606ad0b95e7c5987bc1
Reviewed-on: https://go-review.googlesource.com/c/go/+/383995
Trust: Daniel Martí <mvdan@mvdan.cc>
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-08 07:49:30 -07:00
|
|
|
t.Logf("GOROOT/src overlay set up in %s", time.Since(overlayStart))
|
2019-03-13 14:42:18 -06:00
|
|
|
|
2021-04-03 02:10:47 -06:00
|
|
|
if err := os.WriteFile(filepath.Join(goroot, "VERSION"), []byte(runtime.Version()), 0666); err != nil {
|
2019-03-13 14:42:18 -06:00
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
var makeScript string
|
|
|
|
switch runtime.GOOS {
|
|
|
|
case "windows":
|
|
|
|
makeScript = "make.bat"
|
|
|
|
case "plan9":
|
|
|
|
makeScript = "make.rc"
|
|
|
|
default:
|
|
|
|
makeScript = "make.bash"
|
|
|
|
}
|
|
|
|
|
2022-09-09 15:29:12 -06:00
|
|
|
cmd := exec.Command(filepath.Join(goroot, "src", makeScript))
|
2019-03-13 14:42:18 -06:00
|
|
|
cmd.Dir = gorootSrc
|
2022-09-09 15:29:12 -06:00
|
|
|
cmd.Env = append(cmd.Environ(), "GOROOT=", "GOROOT_BOOTSTRAP="+realGoroot)
|
2019-03-13 14:42:18 -06:00
|
|
|
cmd.Stderr = os.Stderr
|
|
|
|
cmd.Stdout = os.Stdout
|
|
|
|
if err := cmd.Run(); err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
}
|