2016-02-11 15:57:17 -07:00
|
|
|
// Copyright 2013 The Go Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
|
|
|
package main
|
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
|
|
|
"fmt"
|
|
|
|
"go/ast"
|
2016-02-14 20:14:31 -07:00
|
|
|
"go/build"
|
2016-02-11 15:57:17 -07:00
|
|
|
"go/token"
|
|
|
|
"go/types"
|
2016-02-14 20:14:31 -07:00
|
|
|
"io"
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
"log"
|
2016-02-11 15:57:17 -07:00
|
|
|
"sort"
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
"strings"
|
|
|
|
"sync"
|
2016-02-11 15:57:17 -07:00
|
|
|
|
|
|
|
"golang.org/x/tools/cmd/guru/serial"
|
2016-02-14 20:14:31 -07:00
|
|
|
"golang.org/x/tools/go/buildutil"
|
2016-02-11 20:57:18 -07:00
|
|
|
"golang.org/x/tools/go/loader"
|
2016-02-11 15:57:17 -07:00
|
|
|
"golang.org/x/tools/refactor/importgraph"
|
|
|
|
)
|
|
|
|
|
|
|
|
// Referrers reports all identifiers that resolve to the same object
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// as the queried identifier, within any package in the workspace.
|
2016-02-11 15:57:17 -07:00
|
|
|
func referrers(q *Query) error {
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
fset := token.NewFileSet()
|
|
|
|
lconf := loader.Config{Fset: fset, Build: q.Build}
|
2016-02-11 15:57:17 -07:00
|
|
|
allowErrors(&lconf)
|
|
|
|
|
|
|
|
if _, err := importQueryPackage(q.Pos, &lconf); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// Load/parse/type-check the query package.
|
|
|
|
lprog, err := lconf.Load()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
qpos, err := parseQueryPos(lprog, q.Pos, false)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
id, _ := qpos.path[0].(*ast.Ident)
|
|
|
|
if id == nil {
|
|
|
|
return fmt.Errorf("no identifier here")
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
obj := qpos.info.ObjectOf(id)
|
|
|
|
if obj == nil {
|
|
|
|
// Happens for y in "switch y := x.(type)",
|
|
|
|
// the package declaration,
|
|
|
|
// and unresolved identifiers.
|
|
|
|
if _, ok := qpos.path[1].(*ast.File); ok { // package decl?
|
|
|
|
return packageReferrers(q, qpos.info.Pkg.Path())
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
return fmt.Errorf("no object for identifier: %T", qpos.path[1])
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// Imported package name?
|
|
|
|
if pkgname, ok := obj.(*types.PkgName); ok {
|
|
|
|
return packageReferrers(q, pkgname.Imported().Path())
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
if obj.Pkg() == nil {
|
|
|
|
return fmt.Errorf("references to predeclared %q are everywhere!", obj.Name())
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// For a globally accessible object defined in package P, we
|
|
|
|
// must load packages that depend on P. Specifically, for a
|
|
|
|
// package-level object, we need load only direct importers
|
|
|
|
// of P, but for a field or interface method, we must load
|
|
|
|
// any package that transitively imports P.
|
|
|
|
if global, pkglevel := classify(obj); global {
|
|
|
|
// We'll use the the object's position to identify it in the larger program.
|
|
|
|
objposn := fset.Position(obj.Pos())
|
|
|
|
defpkg := obj.Pkg().Path() // defining package
|
|
|
|
return globalReferrers(q, qpos.info.Pkg.Path(), defpkg, objposn, pkglevel)
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
q.Output(fset, &referrersInitialResult{
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
qinfo: qpos.info,
|
|
|
|
obj: obj,
|
2016-04-01 13:04:45 -06:00
|
|
|
})
|
|
|
|
|
|
|
|
outputUses(q, fset, usesOf(obj, qpos.info), obj.Pkg())
|
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
return nil // success
|
|
|
|
}
|
|
|
|
|
|
|
|
// classify classifies objects by how far
|
|
|
|
// we have to look to find references to them.
|
|
|
|
func classify(obj types.Object) (global, pkglevel bool) {
|
|
|
|
if obj.Exported() {
|
|
|
|
if obj.Parent() == nil {
|
|
|
|
// selectable object (field or method)
|
|
|
|
return true, false
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
if obj.Parent() == obj.Pkg().Scope() {
|
|
|
|
// lexical object (package-level var/const/func/type)
|
|
|
|
return true, true
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|
|
|
|
}
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// object with unexported named or defined in local scope
|
|
|
|
return false, false
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
// packageReferrers reports all references to the specified package
|
|
|
|
// throughout the workspace.
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
func packageReferrers(q *Query, path string) error {
|
|
|
|
// Scan the workspace and build the import graph.
|
|
|
|
// Ignore broken packages.
|
|
|
|
_, rev, _ := importgraph.Build(q.Build)
|
|
|
|
|
|
|
|
// Find the set of packages that directly import the query package.
|
|
|
|
// Only those packages need typechecking of function bodies.
|
|
|
|
users := rev[path]
|
|
|
|
|
|
|
|
// Load the larger program.
|
|
|
|
fset := token.NewFileSet()
|
|
|
|
lconf := loader.Config{
|
|
|
|
Fset: fset,
|
|
|
|
Build: q.Build,
|
|
|
|
TypeCheckFuncBodies: func(p string) bool {
|
|
|
|
return users[strings.TrimSuffix(p, "_test")]
|
|
|
|
},
|
|
|
|
}
|
|
|
|
allowErrors(&lconf)
|
2016-04-01 13:04:45 -06:00
|
|
|
|
|
|
|
// The importgraph doesn't treat external test packages
|
|
|
|
// as separate nodes, so we must use ImportWithTests.
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
for path := range users {
|
|
|
|
lconf.ImportWithTests(path)
|
|
|
|
}
|
2016-04-01 13:04:45 -06:00
|
|
|
|
|
|
|
// Subtle! AfterTypeCheck needs no mutex for qpkg because the
|
|
|
|
// topological import order gives us the necessary happens-before edges.
|
|
|
|
// TODO(adonovan): what about import cycles?
|
|
|
|
var qpkg *types.Package
|
|
|
|
|
|
|
|
// For efficiency, we scan each package for references
|
|
|
|
// just after it has been type-checked. The loader calls
|
|
|
|
// AfterTypeCheck (concurrently), providing us with a stream of
|
|
|
|
// packages.
|
|
|
|
lconf.AfterTypeCheck = func(info *loader.PackageInfo, files []*ast.File) {
|
|
|
|
// AfterTypeCheck may be called twice for the same package due to augmentation.
|
|
|
|
|
|
|
|
if info.Pkg.Path() == path && qpkg == nil {
|
|
|
|
// Found the package of interest.
|
|
|
|
qpkg = info.Pkg
|
|
|
|
fakepkgname := types.NewPkgName(token.NoPos, qpkg, qpkg.Name(), qpkg)
|
|
|
|
q.Output(fset, &referrersInitialResult{
|
|
|
|
qinfo: info,
|
|
|
|
obj: fakepkgname, // bogus
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// Only inspect packages that directly import the
|
|
|
|
// declaring package (and thus were type-checked).
|
|
|
|
if lconf.TypeCheckFuncBodies(info.Pkg.Path()) {
|
|
|
|
// Find PkgNames that refer to qpkg.
|
|
|
|
// TODO(adonovan): perhaps more useful would be to show imports
|
|
|
|
// of the package instead of qualified identifiers.
|
|
|
|
var refs []*ast.Ident
|
|
|
|
for id, obj := range info.Uses {
|
|
|
|
if obj, ok := obj.(*types.PkgName); ok && obj.Imported() == qpkg {
|
|
|
|
refs = append(refs, id)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
outputUses(q, fset, refs, info.Pkg)
|
|
|
|
}
|
|
|
|
|
|
|
|
clearInfoFields(info) // save memory
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
lconf.Load() // ignore error
|
|
|
|
|
|
|
|
if qpkg == nil {
|
|
|
|
log.Fatalf("query package %q not found during reloading", path)
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
}
|
2016-04-01 13:04:45 -06:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
func usesOf(queryObj types.Object, info *loader.PackageInfo) []*ast.Ident {
|
|
|
|
var refs []*ast.Ident
|
|
|
|
for id, obj := range info.Uses {
|
|
|
|
if sameObj(queryObj, obj) {
|
|
|
|
refs = append(refs, id)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return refs
|
|
|
|
}
|
|
|
|
|
|
|
|
// outputUses outputs a result describing refs, which appear in the package denoted by info.
|
|
|
|
func outputUses(q *Query, fset *token.FileSet, refs []*ast.Ident, pkg *types.Package) {
|
|
|
|
if len(refs) > 0 {
|
|
|
|
sort.Sort(byNamePos{fset, refs})
|
|
|
|
q.Output(fset, &referrersPackageResult{
|
|
|
|
pkg: pkg,
|
|
|
|
build: q.Build,
|
|
|
|
fset: fset,
|
|
|
|
refs: refs,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// globalReferrers reports references throughout the entire workspace to the
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// object at the specified source position. Its defining package is defpkg,
|
|
|
|
// and the query package is qpkg. isPkgLevel indicates whether the object
|
|
|
|
// is defined at package-level.
|
|
|
|
func globalReferrers(q *Query, qpkg, defpkg string, objposn token.Position, isPkgLevel bool) error {
|
|
|
|
// Scan the workspace and build the import graph.
|
|
|
|
// Ignore broken packages.
|
|
|
|
_, rev, _ := importgraph.Build(q.Build)
|
|
|
|
|
|
|
|
// Find the set of packages that depend on defpkg.
|
|
|
|
// Only function bodies in those packages need type-checking.
|
|
|
|
var users map[string]bool
|
|
|
|
if isPkgLevel {
|
2016-03-21 13:42:17 -06:00
|
|
|
users = rev[defpkg] // direct importers
|
|
|
|
if users == nil {
|
|
|
|
users = make(map[string]bool)
|
|
|
|
}
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
users[defpkg] = true // plus the defining package itself
|
|
|
|
} else {
|
|
|
|
users = rev.Search(defpkg) // transitive importers
|
|
|
|
}
|
|
|
|
|
|
|
|
// Prepare to load the larger program.
|
|
|
|
fset := token.NewFileSet()
|
|
|
|
lconf := loader.Config{
|
|
|
|
Fset: fset,
|
|
|
|
Build: q.Build,
|
|
|
|
TypeCheckFuncBodies: func(p string) bool {
|
|
|
|
return users[strings.TrimSuffix(p, "_test")]
|
|
|
|
},
|
|
|
|
}
|
|
|
|
allowErrors(&lconf)
|
|
|
|
|
|
|
|
// The importgraph doesn't treat external test packages
|
|
|
|
// as separate nodes, so we must use ImportWithTests.
|
|
|
|
for path := range users {
|
|
|
|
lconf.ImportWithTests(path)
|
|
|
|
}
|
|
|
|
|
|
|
|
// The remainder of this function is somewhat tricky because it
|
|
|
|
// operates on the concurrent stream of packages observed by the
|
|
|
|
// loader's AfterTypeCheck hook. Most of guru's helper
|
|
|
|
// functions assume the entire program has already been loaded,
|
|
|
|
// so we can't use them here.
|
|
|
|
// TODO(adonovan): smooth things out once the other changes have landed.
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
// Results are reported concurrently from within the
|
|
|
|
// AfterTypeCheck hook. The program may provide a useful stream
|
|
|
|
// of information even if the user doesn't let the program run
|
|
|
|
// to completion.
|
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
var (
|
|
|
|
mu sync.Mutex
|
|
|
|
qobj types.Object
|
|
|
|
qinfo *loader.PackageInfo // info for qpkg
|
|
|
|
)
|
|
|
|
|
|
|
|
// For efficiency, we scan each package for references
|
|
|
|
// just after it has been type-checked. The loader calls
|
|
|
|
// AfterTypeCheck (concurrently), providing us with a stream of
|
|
|
|
// packages.
|
|
|
|
lconf.AfterTypeCheck = func(info *loader.PackageInfo, files []*ast.File) {
|
2016-04-01 13:04:45 -06:00
|
|
|
// AfterTypeCheck may be called twice for the same package due to augmentation.
|
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
// Only inspect packages that depend on the declaring package
|
|
|
|
// (and thus were type-checked).
|
|
|
|
if lconf.TypeCheckFuncBodies(info.Pkg.Path()) {
|
|
|
|
// Record the query object and its package when we see it.
|
|
|
|
mu.Lock()
|
|
|
|
if qobj == nil && info.Pkg.Path() == defpkg {
|
|
|
|
// Find the object by its position (slightly ugly).
|
|
|
|
qobj = findObject(fset, &info.Info, objposn)
|
|
|
|
if qobj == nil {
|
|
|
|
// It really ought to be there;
|
|
|
|
// we found it once already.
|
|
|
|
log.Fatalf("object at %s not found in package %s",
|
|
|
|
objposn, defpkg)
|
|
|
|
}
|
2016-04-01 13:04:45 -06:00
|
|
|
|
|
|
|
// Object found.
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
qinfo = info
|
2016-04-01 13:04:45 -06:00
|
|
|
q.Output(fset, &referrersInitialResult{
|
|
|
|
qinfo: qinfo,
|
|
|
|
obj: qobj,
|
|
|
|
})
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
}
|
|
|
|
obj := qobj
|
|
|
|
mu.Unlock()
|
|
|
|
|
|
|
|
// Look for references to the query object.
|
|
|
|
if obj != nil {
|
2016-04-01 13:04:45 -06:00
|
|
|
outputUses(q, fset, usesOf(obj, info), info.Pkg)
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|
|
|
|
}
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
clearInfoFields(info) // save memory
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
lconf.Load() // ignore error
|
2016-02-11 15:57:17 -07:00
|
|
|
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
if qobj == nil {
|
|
|
|
log.Fatal("query object not found during reloading")
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil // success
|
|
|
|
}
|
|
|
|
|
|
|
|
// findObject returns the object defined at the specified position.
|
|
|
|
func findObject(fset *token.FileSet, info *types.Info, objposn token.Position) types.Object {
|
|
|
|
good := func(obj types.Object) bool {
|
|
|
|
if obj == nil {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
posn := fset.Position(obj.Pos())
|
|
|
|
return posn.Filename == objposn.Filename && posn.Offset == objposn.Offset
|
|
|
|
}
|
|
|
|
for _, obj := range info.Defs {
|
|
|
|
if good(obj) {
|
|
|
|
return obj
|
|
|
|
}
|
|
|
|
}
|
|
|
|
for _, obj := range info.Implicits {
|
|
|
|
if good(obj) {
|
|
|
|
return obj
|
|
|
|
}
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// same reports whether x and y are identical, or both are PkgNames
|
|
|
|
// that import the same Package.
|
|
|
|
//
|
|
|
|
func sameObj(x, y types.Object) bool {
|
|
|
|
if x == y {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
if x, ok := x.(*types.PkgName); ok {
|
|
|
|
if y, ok := y.(*types.PkgName); ok {
|
|
|
|
return x.Imported() == y.Imported()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
func clearInfoFields(info *loader.PackageInfo) {
|
|
|
|
// TODO(adonovan): opt: save memory by eliminating unneeded scopes/objects.
|
|
|
|
// (Requires go/types change for Go 1.7.)
|
|
|
|
// info.Pkg.Scope().ClearChildren()
|
|
|
|
|
|
|
|
// Discard the file ASTs and their accumulated type
|
|
|
|
// information to save memory.
|
|
|
|
info.Files = nil
|
|
|
|
info.Defs = make(map[*ast.Ident]types.Object)
|
|
|
|
info.Uses = make(map[*ast.Ident]types.Object)
|
|
|
|
info.Implicits = make(map[ast.Node]types.Object)
|
|
|
|
|
|
|
|
// Also, disable future collection of wholly unneeded
|
|
|
|
// type information for the package in case there is
|
|
|
|
// more type-checking to do (augmentation).
|
|
|
|
info.Types = nil
|
|
|
|
info.Scopes = nil
|
|
|
|
info.Selections = nil
|
|
|
|
}
|
|
|
|
|
2016-02-11 15:57:17 -07:00
|
|
|
// -------- utils --------
|
|
|
|
|
|
|
|
// An deterministic ordering for token.Pos that doesn't
|
|
|
|
// depend on the order in which packages were loaded.
|
|
|
|
func lessPos(fset *token.FileSet, x, y token.Pos) bool {
|
|
|
|
fx := fset.File(x)
|
|
|
|
fy := fset.File(y)
|
|
|
|
if fx != fy {
|
|
|
|
return fx.Name() < fy.Name()
|
|
|
|
}
|
|
|
|
return x < y
|
|
|
|
}
|
|
|
|
|
|
|
|
type byNamePos struct {
|
|
|
|
fset *token.FileSet
|
|
|
|
ids []*ast.Ident
|
|
|
|
}
|
|
|
|
|
|
|
|
func (p byNamePos) Len() int { return len(p.ids) }
|
|
|
|
func (p byNamePos) Swap(i, j int) { p.ids[i], p.ids[j] = p.ids[j], p.ids[i] }
|
|
|
|
func (p byNamePos) Less(i, j int) bool {
|
|
|
|
return lessPos(p.fset, p.ids[i].NamePos, p.ids[j].NamePos)
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
// referrersInitialResult is the initial result of a "referrers" query.
|
|
|
|
type referrersInitialResult struct {
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
qinfo *loader.PackageInfo
|
2016-02-11 15:57:17 -07:00
|
|
|
obj types.Object // object it denotes
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
func (r *referrersInitialResult) PrintPlain(printf printfFunc) {
|
|
|
|
printf(r.obj, "references to %s",
|
|
|
|
types.ObjectString(r.obj, types.RelativeTo(r.qinfo.Pkg)))
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *referrersInitialResult) JSON(fset *token.FileSet) []byte {
|
|
|
|
var objpos string
|
|
|
|
if pos := r.obj.Pos(); pos.IsValid() {
|
|
|
|
objpos = fset.Position(pos).String()
|
|
|
|
}
|
|
|
|
return toJSON(&serial.ReferrersInitial{
|
|
|
|
Desc: r.obj.String(),
|
|
|
|
ObjPos: objpos,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
// referrersPackageResult is the streaming result for one package of a "referrers" query.
|
|
|
|
type referrersPackageResult struct {
|
|
|
|
pkg *types.Package
|
|
|
|
build *build.Context
|
|
|
|
fset *token.FileSet
|
|
|
|
refs []*ast.Ident // set of all other references to it
|
|
|
|
}
|
2016-02-11 15:57:17 -07:00
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
// forEachRef calls f(id, text) for id in r.refs, in order.
|
|
|
|
// Text is the text of the line on which id appears.
|
|
|
|
func (r *referrersPackageResult) foreachRef(f func(id *ast.Ident, text string)) {
|
2016-02-11 15:57:17 -07:00
|
|
|
// Show referring lines, like grep.
|
|
|
|
type fileinfo struct {
|
|
|
|
refs []*ast.Ident
|
|
|
|
linenums []int // line number of refs[i]
|
|
|
|
data chan interface{} // file contents or error
|
|
|
|
}
|
|
|
|
var fileinfos []*fileinfo
|
|
|
|
fileinfosByName := make(map[string]*fileinfo)
|
|
|
|
|
|
|
|
// First pass: start the file reads concurrently.
|
|
|
|
sema := make(chan struct{}, 20) // counting semaphore to limit I/O concurrency
|
|
|
|
for _, ref := range r.refs {
|
cmd/guru: compute referrers as packages are type checked
This CL makes little observable difference to the behavior but paves the
way for streaming 'referrers' and (later) 'implements' queries which
scan the entire workspace, but print each result as soon as it is found.
The go/loader package now exposes a hook, AfterTypeCheck, that lets
clients inspect each package as soon as it is type-checked, and also
modify it, for instance to release unneeded data structures.
A 'referrers' query applied to an exported object must scan the entire
workspace. It uses this hook so to gather uses of the query object in
streaming fashion. However, for now, it still accumulates the results
and prints them all at the end, though I propose to change that in a
follow-up.
Code details:
- The referrers logic had a 2-iteration loop to load first the query
package and then if necessary the enlarged program. The second
iteration has now been unrolled and split into globalReferrers.
- Queries for package names (whether in a package declaration or
a qualified identifier) have been split off into packageReferrers.
It now loads all direct importers of the query package,
which catches some references that were missing before.
(It used to inspect only the forward dependencies of the query
package.)
Also:
- Referrers.Pos (the position of query identifier) was removed from the
JSON output. It's a nuisance to compute now, and it's already
absent from the plain output.
(In a follow-up, I plan to simplify the information content of the
JSON output exactly what is currently printed in the plain output.)
Change-Id: Ia5677636dc7b0fe4461a5d393107665757fb9a97
Reviewed-on: https://go-review.googlesource.com/19794
Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com>
2016-02-21 16:45:02 -07:00
|
|
|
posn := r.fset.Position(ref.Pos())
|
2016-02-11 15:57:17 -07:00
|
|
|
fi := fileinfosByName[posn.Filename]
|
|
|
|
if fi == nil {
|
|
|
|
fi = &fileinfo{data: make(chan interface{})}
|
|
|
|
fileinfosByName[posn.Filename] = fi
|
|
|
|
fileinfos = append(fileinfos, fi)
|
|
|
|
|
|
|
|
// First request for this file:
|
|
|
|
// start asynchronous read.
|
|
|
|
go func() {
|
|
|
|
sema <- struct{}{} // acquire token
|
2016-02-14 20:14:31 -07:00
|
|
|
content, err := readFile(r.build, posn.Filename)
|
2016-02-11 15:57:17 -07:00
|
|
|
<-sema // release token
|
|
|
|
if err != nil {
|
|
|
|
fi.data <- err
|
|
|
|
} else {
|
|
|
|
fi.data <- content
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
}
|
|
|
|
fi.refs = append(fi.refs, ref)
|
|
|
|
fi.linenums = append(fi.linenums, posn.Line)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Second pass: print refs in original order.
|
|
|
|
// One line may have several refs at different columns.
|
|
|
|
for _, fi := range fileinfos {
|
|
|
|
v := <-fi.data // wait for I/O completion
|
|
|
|
|
|
|
|
// Print one item for all refs in a file that could not
|
|
|
|
// be loaded (perhaps due to //line directives).
|
|
|
|
if err, ok := v.(error); ok {
|
|
|
|
var suffix string
|
|
|
|
if more := len(fi.refs) - 1; more > 0 {
|
|
|
|
suffix = fmt.Sprintf(" (+ %d more refs in this file)", more)
|
|
|
|
}
|
2016-04-01 13:04:45 -06:00
|
|
|
f(fi.refs[0], err.Error()+suffix)
|
2016-02-11 15:57:17 -07:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
lines := bytes.Split(v.([]byte), []byte("\n"))
|
|
|
|
for i, ref := range fi.refs {
|
2016-04-01 13:04:45 -06:00
|
|
|
f(ref, string(lines[fi.linenums[i]-1]))
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-02-14 20:14:31 -07:00
|
|
|
// readFile is like ioutil.ReadFile, but
|
|
|
|
// it goes through the virtualized build.Context.
|
|
|
|
func readFile(ctxt *build.Context, filename string) ([]byte, error) {
|
|
|
|
rc, err := buildutil.OpenFile(ctxt, filename)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
defer rc.Close()
|
|
|
|
var buf bytes.Buffer
|
|
|
|
if _, err := io.Copy(&buf, rc); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
return buf.Bytes(), nil
|
|
|
|
}
|
|
|
|
|
2016-04-01 13:04:45 -06:00
|
|
|
func (r *referrersPackageResult) PrintPlain(printf printfFunc) {
|
|
|
|
r.foreachRef(func(id *ast.Ident, text string) {
|
|
|
|
printf(id, "%s", text)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r *referrersPackageResult) JSON(fset *token.FileSet) []byte {
|
|
|
|
refs := serial.ReferrersPackage{Package: r.pkg.Path()}
|
|
|
|
r.foreachRef(func(id *ast.Ident, text string) {
|
|
|
|
refs.Refs = append(refs.Refs, serial.Ref{
|
|
|
|
Pos: fset.Position(id.NamePos).String(),
|
|
|
|
Text: text,
|
|
|
|
})
|
|
|
|
})
|
|
|
|
return toJSON(refs)
|
2016-02-11 15:57:17 -07:00
|
|
|
}
|