qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 21:10:21 -07:00
Code Releases Activity
263a825b05
go/test/syntax/semi4.go

18 lines
580 B
Go
Raw Normal View History

cmd/compile/internal/syntax: match old parser errors and line numbers This makes a bunch of changes to package syntax to tweak line numbers for AST nodes. For example, short variable declaration statements are now associated with the location of the ":=" token, and function calls are associated with the location of the final ")" token. These help satisfy many unit tests that assume the old parser's behavior. Because many of these changes are questionable, they're guarded behind a new "gcCompat" const to make them easy to identify and revisit in the future. A handful of remaining tests are too difficult to make behave identically. These have been updated to execute with -newparser=0 and comments explaining why they need to be fixed. all.bash now passes with both the old and new parsers. Change-Id: Iab834b71ca8698d39269f261eb5c92a0d55a3bf4 Reviewed-on: https://go-review.googlesource.com/27199 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
2016-06-06 18:59:05 -06:00
// errorcheck -newparser=0
gc: improved syntax errors * example-based syntax errors (go.errors) * enable bison's more specific errors and translate grammar token names into tokens like ++ * test cases R=ken2, r, ken3 CC=golang-dev https://golang.org/cl/194085
2010-01-27 00:13:22 -07:00
all: make copyright headers consistent with one space after period Follows suit with https://go-review.googlesource.com/#/c/20111. Generated by running $ grep -R 'Go Authors. All' * | cut -d":" -f1 | while read F;do perl -pi -e 's/Go Authors. All/Go Authors. All/g' $F;done The code in cmd/internal/unvendor wasn't changed. Fixes #15213 Change-Id: I4f235cee0a62ec435f9e8540a1ec08ae03b1a75f Reviewed-on: https://go-review.googlesource.com/21819 Reviewed-by: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
2016-04-10 15:32:26 -06:00
// Copyright 2010 The Go Authors. All rights reserved.
gc: improved syntax errors * example-based syntax errors (go.errors) * enable bison's more specific errors and translate grammar token names into tokens like ++ * test cases R=ken2, r, ken3 CC=golang-dev https://golang.org/cl/194085
2010-01-27 00:13:22 -07:00
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
cmd/compile/internal/syntax: match old parser errors and line numbers This makes a bunch of changes to package syntax to tweak line numbers for AST nodes. For example, short variable declaration statements are now associated with the location of the ":=" token, and function calls are associated with the location of the final ")" token. These help satisfy many unit tests that assume the old parser's behavior. Because many of these changes are questionable, they're guarded behind a new "gcCompat" const to make them easy to identify and revisit in the future. A handful of remaining tests are too difficult to make behave identically. These have been updated to execute with -newparser=0 and comments explaining why they need to be fixed. all.bash now passes with both the old and new parsers. Change-Id: Iab834b71ca8698d39269f261eb5c92a0d55a3bf4 Reviewed-on: https://go-review.googlesource.com/27199 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
2016-06-06 18:59:05 -06:00
// TODO(mdempsky): Update error expectations for new parser.
// The new parser emits an extra "missing { after for clause" error.
// The old parser is supposed to emit this too, but it panics first
// due to a nil pointer dereference.
gc: improved syntax errors * example-based syntax errors (go.errors) * enable bison's more specific errors and translate grammar token names into tokens like ++ * test cases R=ken2, r, ken3 CC=golang-dev https://golang.org/cl/194085
2010-01-27 00:13:22 -07:00
package main
func main() {
Match gccgo error messages. bug121.go:12:3: error: name list not allowed in interface type bug121.go:16:2: error: expected signature or type name semi1.go:10:76: error: unexpected semicolon or newline before ‘{’ semi1.go:10:5: error: reference to undefined name ‘x’ semi1.go:10:8: error: reference to undefined name ‘y’ semi1.go:12:3: error: reference to undefined name ‘z’ semi2.go:10:79: error: unexpected semicolon or newline before ‘{’ semi2.go:10:9: error: reference to undefined name ‘x’ semi3.go:10:79: error: unexpected semicolon or newline before ‘{’ semi3.go:10:6: error: reference to undefined name ‘x’ semi3.go:10:9: error: reference to undefined name ‘y’ semi3.go:10:12: error: reference to undefined name ‘z’ semi3.go:12:3: error: reference to undefined name ‘z’ semi4.go:11:2: error: unexpected semicolon or newline before ‘{’ semi4.go:10:6: error: reference to undefined name ‘x’ semi4.go:12:3: error: reference to undefined name ‘z’ semi5.go:10:1: error: unexpected semicolon or newline before ‘{’ semi7.go:11:2: error: unexpected semicolon or newline before ‘else’ semi7.go:10:5: error: reference to undefined name ‘x’ slice.go:9:11: error: missing lower bound in slice expression slice.go:9:9: error: reference to undefined name ‘y’ slice.go:9:12: error: reference to undefined name ‘z’ R=rsc CC=golang-dev https://golang.org/cl/201061
2010-02-04 22:31:30 -07:00
for x // GCCGO_ERROR "undefined"
cmd/compile/internal/gc: recursive-descent parser This is a translation of the yacc-based parser with adjustements to make the grammar work for a recursive-descent parser followed by cleanups and simplifications. The yacc actions were mostly literally copied for correctness with better temporary names. A few of the syntax tests were adjusted for slightly different error messages (it is very difficult to match the yacc-based error messages in all cases, and sometimes the new parser could produce better errors). The new parser is enabled by default. To switch back to the yacc-based parser, set -oldparser. To hardwire the switch back, uncomment "oldparser = 1" in lex.go. - passes all.bash - ~18% reduced parse time per file on average for make.bash - ~3% reduced compile time for building cmd/compile Change-Id: Icb5651bb9d8b9f66261762d2c94a03793050d4ce Reviewed-on: https://go-review.googlesource.com/16665 Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
2015-11-04 10:21:49 -07:00
{ // ERROR "missing .*{.* after for clause|missing operand"
Match gccgo error messages. bug121.go:12:3: error: name list not allowed in interface type bug121.go:16:2: error: expected signature or type name semi1.go:10:76: error: unexpected semicolon or newline before ‘{’ semi1.go:10:5: error: reference to undefined name ‘x’ semi1.go:10:8: error: reference to undefined name ‘y’ semi1.go:12:3: error: reference to undefined name ‘z’ semi2.go:10:79: error: unexpected semicolon or newline before ‘{’ semi2.go:10:9: error: reference to undefined name ‘x’ semi3.go:10:79: error: unexpected semicolon or newline before ‘{’ semi3.go:10:6: error: reference to undefined name ‘x’ semi3.go:10:9: error: reference to undefined name ‘y’ semi3.go:10:12: error: reference to undefined name ‘z’ semi3.go:12:3: error: reference to undefined name ‘z’ semi4.go:11:2: error: unexpected semicolon or newline before ‘{’ semi4.go:10:6: error: reference to undefined name ‘x’ semi4.go:12:3: error: reference to undefined name ‘z’ semi5.go:10:1: error: unexpected semicolon or newline before ‘{’ semi7.go:11:2: error: unexpected semicolon or newline before ‘else’ semi7.go:10:5: error: reference to undefined name ‘x’ slice.go:9:11: error: missing lower bound in slice expression slice.go:9:9: error: reference to undefined name ‘y’ slice.go:9:12: error: reference to undefined name ‘z’ R=rsc CC=golang-dev https://golang.org/cl/201061
2010-02-04 22:31:30 -07:00
z // GCCGO_ERROR "undefined"
Copy Permalink