cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
// run
|
2022-11-15 22:02:14 -07:00
|
|
|
//go:build !gcflags_noopt
|
2012-09-23 11:16:14 -06:00
|
|
|
|
2016-04-10 15:32:26 -06:00
|
|
|
// Copyright 2010 The Go Authors. All rights reserved.
|
2010-05-03 18:21:49 -06:00
|
|
|
// Use of this source code is governed by a BSD-style
|
|
|
|
// license that can be found in the LICENSE file.
|
|
|
|
|
2012-02-23 17:48:19 -07:00
|
|
|
// Test that many initializations can be done at link time and
|
|
|
|
// generate no executable init functions.
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
// Also test that trivial func init are optimized away.
|
2012-02-23 17:48:19 -07:00
|
|
|
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
package main
|
2010-05-03 18:21:49 -06:00
|
|
|
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
import (
|
|
|
|
"errors"
|
|
|
|
"unsafe"
|
|
|
|
)
|
2015-06-29 10:49:25 -06:00
|
|
|
|
2010-05-03 18:21:49 -06:00
|
|
|
// All these initializations should be done at link time.
|
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
type S struct{ a, b, c int }
|
|
|
|
type SS struct{ aa, bb, cc S }
|
|
|
|
type SA struct{ a, b, c [3]int }
|
|
|
|
type SC struct{ a, b, c []int }
|
2010-05-03 18:21:49 -06:00
|
|
|
|
|
|
|
var (
|
2011-08-31 05:37:14 -06:00
|
|
|
zero = 2
|
|
|
|
one = 1
|
|
|
|
pi = 3.14
|
|
|
|
slice = []byte{1, 2, 3}
|
|
|
|
sliceInt = []int{1, 2, 3}
|
|
|
|
hello = "hello, world"
|
|
|
|
bytes = []byte("hello, world")
|
|
|
|
four, five = 4, 5
|
|
|
|
x, y = 0.1, "hello"
|
|
|
|
nilslice []byte = nil
|
|
|
|
nilmap map[string]int = nil
|
|
|
|
nilfunc func() = nil
|
|
|
|
nilchan chan int = nil
|
|
|
|
nilptr *byte = nil
|
2010-05-03 18:21:49 -06:00
|
|
|
)
|
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
var a = [3]int{1001, 1002, 1003}
|
|
|
|
var s = S{1101, 1102, 1103}
|
|
|
|
var c = []int{1201, 1202, 1203}
|
2010-05-03 18:21:49 -06:00
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
var aa = [3][3]int{[3]int{2001, 2002, 2003}, [3]int{2004, 2005, 2006}, [3]int{2007, 2008, 2009}}
|
|
|
|
var as = [3]S{S{2101, 2102, 2103}, S{2104, 2105, 2106}, S{2107, 2108, 2109}}
|
2010-05-03 18:21:49 -06:00
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
var sa = SA{[3]int{3001, 3002, 3003}, [3]int{3004, 3005, 3006}, [3]int{3007, 3008, 3009}}
|
|
|
|
var ss = SS{S{3101, 3102, 3103}, S{3104, 3105, 3106}, S{3107, 3108, 3109}}
|
2010-05-03 18:21:49 -06:00
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
var ca = [][3]int{[3]int{4001, 4002, 4003}, [3]int{4004, 4005, 4006}, [3]int{4007, 4008, 4009}}
|
|
|
|
var cs = []S{S{4101, 4102, 4103}, S{4104, 4105, 4106}, S{4107, 4108, 4109}}
|
2010-05-03 18:21:49 -06:00
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
var answers = [...]int{
|
2010-05-03 18:21:49 -06:00
|
|
|
// s
|
|
|
|
1101, 1102, 1103,
|
|
|
|
|
|
|
|
// ss
|
|
|
|
3101, 3102, 3103,
|
|
|
|
3104, 3105, 3106,
|
|
|
|
3107, 3108, 3109,
|
|
|
|
|
|
|
|
// [0]
|
|
|
|
1001, 1201, 1301,
|
|
|
|
2101, 2102, 2103,
|
|
|
|
4101, 4102, 4103,
|
|
|
|
5101, 5102, 5103,
|
|
|
|
3001, 3004, 3007,
|
|
|
|
3201, 3204, 3207,
|
|
|
|
3301, 3304, 3307,
|
|
|
|
|
|
|
|
// [0][j]
|
|
|
|
2001, 2201, 2301, 4001, 4201, 4301, 5001, 5201, 5301,
|
|
|
|
2002, 2202, 2302, 4002, 4202, 4302, 5002, 5202, 5302,
|
|
|
|
2003, 2203, 2303, 4003, 4203, 4303, 5003, 5203, 5303,
|
|
|
|
|
|
|
|
// [1]
|
|
|
|
1002, 1202, 1302,
|
|
|
|
2104, 2105, 2106,
|
|
|
|
4104, 4105, 4106,
|
|
|
|
5104, 5105, 5106,
|
|
|
|
3002, 3005, 3008,
|
|
|
|
3202, 3205, 3208,
|
|
|
|
3302, 3305, 3308,
|
|
|
|
|
|
|
|
// [1][j]
|
|
|
|
2004, 2204, 2304, 4004, 4204, 4304, 5004, 5204, 5304,
|
|
|
|
2005, 2205, 2305, 4005, 4205, 4305, 5005, 5205, 5305,
|
|
|
|
2006, 2206, 2306, 4006, 4206, 4306, 5006, 5206, 5306,
|
|
|
|
|
|
|
|
// [2]
|
|
|
|
1003, 1203, 1303,
|
|
|
|
2107, 2108, 2109,
|
|
|
|
4107, 4108, 4109,
|
|
|
|
5107, 5108, 5109,
|
|
|
|
3003, 3006, 3009,
|
|
|
|
3203, 3206, 3209,
|
|
|
|
3303, 3306, 3309,
|
|
|
|
|
|
|
|
// [2][j]
|
|
|
|
2007, 2207, 2307, 4007, 4207, 4307, 5007, 5207, 5307,
|
|
|
|
2008, 2208, 2308, 4008, 4208, 4308, 5008, 5208, 5308,
|
|
|
|
2009, 2209, 2309, 4009, 4209, 4309, 5009, 5209, 5309,
|
|
|
|
}
|
2011-08-31 05:37:14 -06:00
|
|
|
|
|
|
|
var (
|
2014-11-06 13:14:08 -07:00
|
|
|
copy_zero = zero
|
|
|
|
copy_one = one
|
|
|
|
copy_pi = pi
|
|
|
|
copy_slice = slice
|
2011-08-31 05:37:14 -06:00
|
|
|
copy_sliceInt = sliceInt
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
// copy_hello = hello // static init of copied strings defeats link -X; see #34675
|
2014-11-04 11:20:35 -07:00
|
|
|
|
|
|
|
// Could be handled without an initialization function, but
|
|
|
|
// requires special handling for "a = []byte("..."); b = a"
|
|
|
|
// which is not a likely case.
|
|
|
|
// copy_bytes = bytes
|
|
|
|
// https://codereview.appspot.com/171840043 is one approach to
|
|
|
|
// make this special case work.
|
|
|
|
|
2011-08-31 05:37:14 -06:00
|
|
|
copy_four, copy_five = four, five
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
copy_x = x
|
|
|
|
// copy_y = y // static init of copied strings defeats link -X; see #34675
|
|
|
|
copy_nilslice = nilslice
|
|
|
|
copy_nilmap = nilmap
|
|
|
|
copy_nilfunc = nilfunc
|
|
|
|
copy_nilchan = nilchan
|
|
|
|
copy_nilptr = nilptr
|
2011-08-31 05:37:14 -06:00
|
|
|
)
|
|
|
|
|
|
|
|
var copy_a = a
|
|
|
|
var copy_s = s
|
|
|
|
var copy_c = c
|
|
|
|
|
|
|
|
var copy_aa = aa
|
|
|
|
var copy_as = as
|
|
|
|
|
|
|
|
var copy_sa = sa
|
|
|
|
var copy_ss = ss
|
|
|
|
|
|
|
|
var copy_ca = ca
|
|
|
|
var copy_cs = cs
|
|
|
|
|
|
|
|
var copy_answers = answers
|
|
|
|
|
|
|
|
var bx bool
|
|
|
|
var b0 = false
|
|
|
|
var b1 = true
|
|
|
|
|
|
|
|
var fx float32
|
|
|
|
var f0 = float32(0)
|
|
|
|
var f1 = float32(1)
|
|
|
|
|
|
|
|
var gx float64
|
|
|
|
var g0 = float64(0)
|
|
|
|
var g1 = float64(1)
|
|
|
|
|
|
|
|
var ix int
|
|
|
|
var i0 = 0
|
|
|
|
var i1 = 1
|
|
|
|
|
|
|
|
var jx uint
|
|
|
|
var j0 = uint(0)
|
|
|
|
var j1 = uint(1)
|
|
|
|
|
|
|
|
var cx complex64
|
|
|
|
var c0 = complex64(0)
|
|
|
|
var c1 = complex64(1)
|
|
|
|
|
|
|
|
var dx complex128
|
|
|
|
var d0 = complex128(0)
|
|
|
|
var d1 = complex128(1)
|
|
|
|
|
|
|
|
var sx []int
|
|
|
|
var s0 = []int{0, 0, 0}
|
|
|
|
var s1 = []int{1, 2, 3}
|
|
|
|
|
2014-11-06 13:14:08 -07:00
|
|
|
func fi() int { return 1 }
|
2011-08-31 05:37:14 -06:00
|
|
|
|
|
|
|
var ax [10]int
|
|
|
|
var a0 = [10]int{0, 0, 0}
|
|
|
|
var a1 = [10]int{1, 2, 3, 4}
|
|
|
|
|
|
|
|
type T struct{ X, Y int }
|
|
|
|
|
|
|
|
var tx T
|
|
|
|
var t0 = T{}
|
|
|
|
var t0a = T{0, 0}
|
|
|
|
var t0b = T{X: 0}
|
|
|
|
var t1 = T{X: 1, Y: 2}
|
|
|
|
var t1a = T{3, 4}
|
|
|
|
|
|
|
|
var psx *[]int
|
|
|
|
var ps0 = &[]int{0, 0, 0}
|
|
|
|
var ps1 = &[]int{1, 2, 3}
|
|
|
|
|
|
|
|
var pax *[10]int
|
|
|
|
var pa0 = &[10]int{0, 0, 0}
|
|
|
|
var pa1 = &[10]int{1, 2, 3}
|
|
|
|
|
|
|
|
var ptx *T
|
|
|
|
var pt0 = &T{}
|
|
|
|
var pt0a = &T{0, 0}
|
|
|
|
var pt0b = &T{X: 0}
|
|
|
|
var pt1 = &T{X: 1, Y: 2}
|
|
|
|
var pt1a = &T{3, 4}
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// The checks similar to
|
|
|
|
// var copy_bx = bx
|
|
|
|
// are commented out. The compiler no longer statically initializes them.
|
|
|
|
// See issue 7665 and https://codereview.appspot.com/93200044.
|
|
|
|
// If https://codereview.appspot.com/169040043 is submitted, and this
|
|
|
|
// test is changed to pass -complete to the compiler, then we can
|
|
|
|
// uncomment the copy lines again.
|
|
|
|
|
|
|
|
// var copy_bx = bx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_b0 = b0
|
|
|
|
var copy_b1 = b1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_fx = fx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_f0 = f0
|
|
|
|
var copy_f1 = f1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_gx = gx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_g0 = g0
|
|
|
|
var copy_g1 = g1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_ix = ix
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_i0 = i0
|
|
|
|
var copy_i1 = i1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_jx = jx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_j0 = j0
|
|
|
|
var copy_j1 = j1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_cx = cx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_c0 = c0
|
|
|
|
var copy_c1 = c1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_dx = dx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_d0 = d0
|
|
|
|
var copy_d1 = d1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_sx = sx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_s0 = s0
|
|
|
|
var copy_s1 = s1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_ax = ax
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_a0 = a0
|
|
|
|
var copy_a1 = a1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_tx = tx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_t0 = t0
|
|
|
|
var copy_t0a = t0a
|
|
|
|
var copy_t0b = t0b
|
|
|
|
var copy_t1 = t1
|
|
|
|
var copy_t1a = t1a
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_psx = psx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_ps0 = ps0
|
|
|
|
var copy_ps1 = ps1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_pax = pax
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_pa0 = pa0
|
|
|
|
var copy_pa1 = pa1
|
|
|
|
|
2014-11-04 11:20:35 -07:00
|
|
|
// var copy_ptx = ptx
|
2011-08-31 05:37:14 -06:00
|
|
|
var copy_pt0 = pt0
|
|
|
|
var copy_pt0a = pt0a
|
|
|
|
var copy_pt0b = pt0b
|
|
|
|
var copy_pt1 = pt1
|
|
|
|
var copy_pt1a = pt1a
|
2012-12-30 10:01:53 -07:00
|
|
|
|
|
|
|
var _ interface{} = 1
|
|
|
|
|
|
|
|
type T1 int
|
|
|
|
|
|
|
|
func (t *T1) M() {}
|
|
|
|
|
2014-11-06 13:14:08 -07:00
|
|
|
type Mer interface {
|
|
|
|
M()
|
|
|
|
}
|
2012-12-30 10:01:53 -07:00
|
|
|
|
|
|
|
var _ Mer = (*T1)(nil)
|
2015-06-29 10:49:25 -06:00
|
|
|
|
|
|
|
var Byte byte
|
|
|
|
var PtrByte unsafe.Pointer = unsafe.Pointer(&Byte)
|
cmd/compile: handle simple inlined calls in staticinit
Global variable initializers like
var myErr error = &myError{"msg"}
have been converted to statically initialized data
from the earliest days of Go: there is no init-time
execution or allocation for that line of code.
But if the expression is moved into an inlinable function,
the static initialization no longer happens.
That is, this code has always executed and allocated
at init time, even after we added inlining to the compiler,
which should in theory make this code equivalent to
the original:
func NewError(s string) error { return &myError{s} }
var myErr2 = NewError("msg")
This CL makes the static initialization rewriter understand
inlined functions consisting of a single return statement,
like in this example, so that myErr2 can be implemented as
statically initialized data too, just like myErr, with no init-time
execution or allocation.
A real example of code that benefits from this rewrite is
all globally declared errors created with errors.New, like
package io
var EOF = errors.New("EOF")
Package io no longer has to allocate and initialize EOF each
time a program starts.
Another example of code that benefits is any globally declared
godebug setting (using the API from CL 449504), like
package http
var http2server = godebug.New("http2server")
These are no longer allocated and initialized at program startup either.
The list of functions that are inlined into static initializers when
compiling std and cmd (along with how many times each occurs) is:
cmd/compile/internal/ssa.StringToAux (3)
cmd/compile/internal/walk.mkmapnames (4)
errors.New (360)
go/ast.NewIdent (1)
go/constant.MakeBool (4)
go/constant.MakeInt64 (3)
image.NewUniform (4)
image/color.ModelFunc (11)
internal/godebug.New (12)
vendor/golang.org/x/text/unicode/bidi.newBidiTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfcTrie (1)
vendor/golang.org/x/text/unicode/norm.newNfkcTrie (1)
For the cmd/go binary, this CL cuts the number of init-time
allocations from about 1920 to about 1620 (a 15% reduction).
The total executable code footprint of init functions is reduced
by 24kB, from 137kB to 113kB (an 18% reduction).
The overall binary size is reduced by 45kB,
from 15.335MB to 15.290MB (a 0.3% reduction).
(The binary size savings is larger than the executable code savings
because every byte of executable code also requires corresponding
runtime tables for unwinding, source-line mapping, and so on.)
Also merge test/sinit_run.go, which had stopped testing anything
at all as of CL 161337 (Feb 2019) and initempty.go into a new test
noinit.go.
Fixes #30820.
Change-Id: I52f7275b1ac2a0a32e22c29f9095071c7b1fac20
Reviewed-on: https://go-review.googlesource.com/c/go/+/450136
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
2022-11-13 07:22:35 -07:00
|
|
|
|
|
|
|
var LitSXInit = &S{1, 2, 3}
|
|
|
|
var LitSAnyXInit any = &S{4, 5, 6}
|
|
|
|
|
|
|
|
func FS(x, y, z int) *S { return &S{x, y, z} }
|
|
|
|
func FSA(x, y, z int) any { return &S{x, y, z} }
|
|
|
|
func F3(x int) *S { return &S{x, x, x} }
|
|
|
|
|
|
|
|
var LitSCallXInit = FS(7, 8, 9)
|
|
|
|
var LitSAnyCallXInit any = FSA(10, 11, 12)
|
|
|
|
|
|
|
|
var LitSRepeat = F3(1 + 2)
|
|
|
|
|
|
|
|
func F0() *S { return &S{1, 2, 3} }
|
|
|
|
|
|
|
|
var LitSNoArgs = F0()
|
|
|
|
|
|
|
|
var myError = errors.New("mine")
|
|
|
|
|
|
|
|
func gopherize(s string) string { return "gopher gopher gopher " + s }
|
|
|
|
|
|
|
|
var animals = gopherize("badger")
|
|
|
|
|
|
|
|
// These init funcs should optimize away.
|
|
|
|
|
|
|
|
func init() {
|
|
|
|
}
|
|
|
|
|
|
|
|
func init() {
|
|
|
|
if false {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func init() {
|
|
|
|
for false {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Actual test: check for init funcs in runtime data structures.
|
|
|
|
|
|
|
|
type initTask struct {
|
|
|
|
state uintptr
|
|
|
|
ndeps uintptr
|
|
|
|
nfns uintptr
|
|
|
|
}
|
|
|
|
|
|
|
|
//go:linkname main_inittask main..inittask
|
|
|
|
var main_inittask initTask
|
|
|
|
|
|
|
|
func main() {
|
|
|
|
if nfns := main_inittask.nfns; nfns != 0 {
|
|
|
|
println(nfns)
|
|
|
|
panic("unexpected init funcs")
|
|
|
|
}
|
|
|
|
}
|